fix(Currencies): Currencies preferences.

This commit is contained in:
a.bouhuolia
2021-03-23 21:28:58 +02:00
parent 5855d3f368
commit 96f20bf51b
25 changed files with 153 additions and 292 deletions

View File

@@ -115,7 +115,7 @@ export function NormalCell({ cell: { value } }) {
export function BalanceCell({ cell }) {
const account = cell.row.original;
return account.amount ? (
return account.amount !== null ? (
<span>
<Money amount={account.amount} currency={'USD'} />
</span>

View File

@@ -45,7 +45,13 @@ function CurrencyDeleteAlert({
});
closeAlert(name);
})
.catch(() => {
.catch(({ response: { data: { errors } } }) => {
if (errors.find(e => e.type === 'CANNOT_DELETE_BASE_CURRENCY')) {
AppToaster.show({
intent: Intent.DANGER,
message: 'Cannot delete the base currency.'
});
}
closeAlert(name);
});
};

View File

@@ -1,9 +1,8 @@
import React, { useMemo, useCallback } from 'react';
import React, { useMemo } from 'react';
import { Intent } from '@blueprintjs/core';
import { Formik } from 'formik';
import { FormattedMessage as T, useIntl } from 'react-intl';
import { AppToaster } from 'components';
import { pick } from 'lodash';
import CurrencyFormContent from './CurrencyFormContent';
import { useCurrencyFormContext } from './CurrencyFormProvider';
@@ -18,6 +17,7 @@ import { compose, transformToForm } from 'utils';
const defaultInitialValues = {
currency_name: '',
currency_code: '',
currency_sign: '',
};
/**
@@ -59,7 +59,7 @@ function CurrencyForm({
const afterSubmit = () => {
closeDialog(dialogName);
};
// Handle the request success.
const onSuccess = ({ response }) => {
AppToaster.show({
message: formatMessage({
@@ -71,9 +71,14 @@ function CurrencyForm({
});
afterSubmit(response);
};
// Handle the response error.
const onError = (errors) => {
const onError = ({ response: { data: { errors } } }) => {
if (errors.find(e => e.type === 'CURRENCY_CODE_EXISTS')) {
AppToaster.show({
message: 'The given currency code is already exists.',
intent: Intent.DANGER,
});
}
setSubmitting(false);
};
if (isEditMode) {

View File

@@ -10,6 +10,7 @@ const Schema = Yup.object().shape({
.max(4)
.required()
.label(formatMessage({ id: 'currency_code_' })),
currency_sign: Yup.string().required(),
});
export const CreateCurrencyFormSchema = Schema;

View File

@@ -1,6 +1,5 @@
import React from 'react';
import { CurrencyFormProvider } from './CurrencyFormProvider';
import { pick } from 'lodash';
import CurrencyForm from './CurrencyForm';
import withCurrencyDetail from 'containers/Currencies/withCurrencyDetail';

View File

@@ -1,24 +1,47 @@
import React from 'react';
import {
Classes,
FormGroup,
InputGroup,
} from '@blueprintjs/core';
import { Classes, FormGroup, InputGroup } from '@blueprintjs/core';
import { FastField } from 'formik';
import { FormattedMessage as T } from 'react-intl';
import {
ErrorMessage,
FieldRequiredHint,
} from 'components';
import { useCurrencyFormContext } from './CurrencyFormProvider';
import { ErrorMessage, FieldRequiredHint, ListSelect } from 'components';
import { useAutofocus } from 'hooks';
import { inputIntent } from 'utils';
import { inputIntent, currenciesOptions } from 'utils';
/**
* Currency form fields.
*/
export default function CurrencyFormFields() {
const currencyNameFieldRef = useAutofocus();
const { isEditMode } = useCurrencyFormContext();
return (
<div className={Classes.DIALOG_BODY}>
<FastField name={'currency_code'}>
{({
form: { setFieldValue },
field: { value },
meta: { error, touched },
}) => (
<FormGroup label={'Currency code'}>
<ListSelect
items={currenciesOptions}
selectedItemProp={'currency_code'}
selectedItem={value}
textProp={'formatted_name'}
defaultText={'Select currency code'}
onItemSelect={(currency) => {
setFieldValue('currency_code', currency.currency_code);
setFieldValue('currency_name', currency.name);
setFieldValue('currency_sign', currency.symbol);
}}
disabled={isEditMode}
/>
</FormGroup>
)}
</FastField>
{/* ----------- Currency name ----------- */}
<FastField name={'currency_name'}>
{({ field, field: { value }, meta: { error, touched } }) => (
@@ -38,15 +61,14 @@ export default function CurrencyFormFields() {
)}
</FastField>
{/* ----------- Currency Code ----------- */}
<FastField name={'currency_code'}>
<FastField name={'currency_sign'}>
{({ field, field: { value }, meta: { error, touched } }) => (
<FormGroup
label={<T id={'currency_code'} />}
label={<T id={'currency_sign'} />}
labelInfo={<FieldRequiredHint />}
className={'form-group--currency-code'}
className={'form-group--currency-sign'}
intent={inputIntent({ error, touched })}
helperText={<ErrorMessage name="currency_code" />}
// inline={true}
helperText={<ErrorMessage name="currency_sign" />}
>
<InputGroup {...field} />
</FormGroup>

View File

@@ -1,5 +1,5 @@
import React, { createContext } from 'react';
import { useCurrencies, useEditCurrency, useCreateCurrency } from 'hooks/query';
import { useEditCurrency, useCreateCurrency } from 'hooks/query';
import { DialogContent } from 'components';
const CurrencyFormContext = createContext();
@@ -7,27 +7,22 @@ const CurrencyFormContext = createContext();
/**
* Currency Form page provider.
*/
function CurrencyFormProvider({ isEditMode, currency, dialogName, ...props }) {
// Create and edit item currency mutations.
const { mutateAsync: createCurrencyMutate } = useCreateCurrency();
const { mutateAsync: editCurrencyMutate } = useEditCurrency();
// fetch Currencies list.
const { data: currencies, isLoading: isCurrenciesLoading } = useCurrencies();
// Provider state.
const provider = {
createCurrencyMutate,
editCurrencyMutate,
dialogName,
currency,
isCurrenciesLoading,
isEditMode,
};
return (
<DialogContent isLoading={isCurrenciesLoading} name={'currency-form'}>
<DialogContent name={'currency-form'}>
<CurrencyFormContext.Provider value={provider} {...props} />
</DialogContent>
);

View File

@@ -52,6 +52,7 @@ function CurrenciesDataTable({
loading={isCurrenciesLoading}
progressBarLoading={isCurrenciesLoading}
TableLoadingRenderer={TableSkeletonRows}
ContextMenu={ActionMenuList}
noInitialFetch={true}
payload={{
onDeleteCurrency: handleDeleteCurrency,

View File

@@ -69,6 +69,7 @@ export function useCurrenciesTableColumns() {
{
Header: 'Currency sign',
width: 120,
accessor: 'currency_sign'
},
{
id: 'actions',

View File

@@ -1034,4 +1034,6 @@ export default {
'This customer cannot be deleted as it is associated with transactions.',
this_vendor_cannot_be_deleted_as_it_is_associated_with_transactions:
'This vendor cannot be deleted as it is associated with transactions.',
currency_sign: 'Currency sign',
};

View File

@@ -14,11 +14,11 @@
}
.plan-radio,
.period-radio{
background: transparent;
background: #fff;
border-color: #bbcad4;
&.is-selected{
background: #f1f3fb;
background: #fff;
border-color: #0269ff
}
}

View File

@@ -12,4 +12,10 @@
height: 170px;
}
}
.bp3-dialog-footer{
.bp3-button{
min-width: 75px;
}
}
}

View File

@@ -1,5 +1,7 @@
import moment from 'moment';
import _, { castArray } from 'lodash';
import Currencies from 'js-money/lib/currency';
import { Intent } from '@blueprintjs/core';
import Currency from 'js-money/lib/currency';
import accounting from 'accounting';
@@ -620,3 +622,17 @@ export const updateTableRow = (rowIndex, columnId, value) => (old) => {
export const transformGeneralSettings = (data) => {
return _.mapKeys(data, (value, key) => _.snakeCase(key));
};
const getCurrenciesOptions = () => {
return Object.keys(Currencies).map((currencyCode) => {
const currency = Currencies[currencyCode];
return {
...currency,
currency_code: currencyCode,
formatted_name: `${currencyCode} - ${currency.name}`,
};
})
}
export const currenciesOptions = getCurrenciesOptions();