From a913b84723b4d0ff73346f2da4191ea7605a62e1 Mon Sep 17 00:00:00 2001 From: elforjani13 <39470382+elforjani13@users.noreply.github.com> Date: Tue, 22 Mar 2022 23:58:03 +0200 Subject: [PATCH] Fix: sales. --- .../CreditNoteFormFooterLeft.js | 11 ++--- .../CreditNoteFormFooterRight.js | 5 +-- .../CreditNoteFormHeaderFields.js | 29 +++++-------- .../CreditNoteForm/CreditNoteFormPage.js | 14 +------ .../CreditNoteForm/CreditNoteFormProvider.js | 14 +------ .../CreditNoteForm/CreditNoteFormTopBar.js | 4 +- .../EstimateForm/EstimateFormFooterLeft.js | 11 +++-- .../EstimateForm/EstimateFormFooterRight.js | 6 +-- .../EstimateForm/EstimateFormHeaderFields.js | 33 ++++++--------- .../EstimateForm/EstimateFormPage.js | 10 +---- .../EstimateForm/EstimateFormProvider.js | 12 +----- .../EstimateForm/EstimtaeFormTopBar.js | 4 +- .../InvoiceForm/InvoiceFormFooterLeft.js | 11 ++--- .../InvoiceForm/InvoiceFormFooterRight.js | 8 ++-- .../InvoiceForm/InvoiceFormHeaderFields.js | 31 ++++++-------- .../Invoices/InvoiceForm/InvoiceFormPage.js | 10 +---- .../InvoiceForm/InvoiceFormProvider.js | 8 ---- .../PaymentReceiveFormFootetLeft.js | 7 ++-- .../PaymentReceiveFormFootetRight.js | 5 +-- .../PaymentReceiveFormPage.js | 14 ++----- .../PaymentReceiveFormProvider.js | 20 +-------- .../PaymentReceiveFormTopBar.js | 2 +- .../PaymentReceiveHeaderFields.js | 41 ++++++++----------- .../ReceiptForm/ReceiptFormFooterLeft.js | 16 ++++---- .../ReceiptForm/ReceiptFormFooterRight.js | 8 ++-- .../ReceiptForm/ReceiptFormHeaderFields.js | 30 +++++--------- .../Receipts/ReceiptForm/ReceiptFormPage.js | 11 +---- .../ReceiptForm/ReceiptFormProvider.js | 15 +------ .../Receipts/ReceiptForm/ReceiptFormTopbar.js | 4 +- 29 files changed, 131 insertions(+), 263 deletions(-) diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js index 093e4728b..c0c3c2391 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterLeft.js @@ -1,4 +1,5 @@ import React from 'react'; +import intl from 'react-intl-universal'; import styled from 'styled-components'; import { FFormGroup, FEditableText, FormattedMessage as T } from 'components'; @@ -13,19 +14,19 @@ export function CreditNoteFormFooterLeft() { > - } + placeholder={intl.get('credit_note.label_customer_note.placeholder')} /> {/* --------- Terms and conditions --------- */} } + label={} name={'terms_conditions'} > } + placeholder={ + + } /> diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterRight.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterRight.js index 941350ba0..48137f532 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterRight.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormFooterRight.js @@ -15,14 +15,13 @@ export function CreditNoteFormFooterRight() { return ( } + title={} value={formattedSubtotal} borderStyle={TotalLineBorderStyle.None} /> } + title={} value={formattedTotal} - // borderStyle={TotalLineBorderStyle.SingleDark} textStyle={TotalLineTextStyle.Bold} /> diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormHeaderFields.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormHeaderFields.js index 89dc8606d..7d1078a08 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormHeaderFields.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormHeaderFields.js @@ -93,19 +93,17 @@ function CreditNoteFormHeaderFields({ intent={inputIntent({ error, touched })} helperText={} > - - } - onContactSelected={(customer) => { - form.setFieldValue('customer_id', customer.id); - form.setFieldValue('currency_code', customer?.currency_code); - }} - popoverFill={true} - allowCreate={true} - /> - + } + onContactSelected={(customer) => { + form.setFieldValue('customer_id', customer.id); + form.setFieldValue('currency_code', customer?.currency_code); + }} + popoverFill={true} + allowCreate={true} + /> {value && ( @@ -210,11 +208,6 @@ export default compose( })), )(CreditNoteFormHeaderFields); -const ControlCustomerGroup = styled(ControlGroup)` - display: flex; - align-items: center; - transform: none; -`; const CustomerButtonLink = styled(CustomerDrawerLink)` font-size: 11px; margin-top: 6px; diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormPage.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormPage.js index 2d6561062..7acfc56b3 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormPage.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormPage.js @@ -5,27 +5,17 @@ import '../../../../style/pages/CreditNote/PageForm.scss'; import CreditNoteForm from './CreditNoteForm'; import { CreditNoteFormProvider } from './CreditNoteFormProvider'; -import withCurrentOrganization from 'containers/Organization/withCurrentOrganization'; -import { compose } from 'utils'; /** * Credit note form page. */ -function CreditNoteFormPage({ - // #withCurrentOrganization - organization: { base_currency }, -}) { +export default function CreditNoteFormPage() { const { id } = useParams(); const idAsInteger = parseInt(id, 10); return ( - + ); } - -export default compose(withCurrentOrganization())(CreditNoteFormPage); diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormProvider.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormProvider.js index b320f617f..6f12e7fba 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormProvider.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormProvider.js @@ -23,7 +23,7 @@ const CreditNoteFormContext = React.createContext(); /** * Credit note data provider. */ -function CreditNoteFormProvider({ creditNoteId, baseCurrency, ...props }) { +function CreditNoteFormProvider({ creditNoteId, ...props }) { const { state } = useLocation(); const invoiceId = state?.invoiceId; @@ -82,8 +82,6 @@ function CreditNoteFormProvider({ creditNoteId, baseCurrency, ...props }) { // Form submit payload. const [submitPayload, setSubmitPayload] = React.useState(); - const [selectCustomer, setSelectCustomer] = React.useState(null); - // Determines whether the form in new mode. const isNewMode = !creditNoteId; @@ -96,10 +94,6 @@ function CreditNoteFormProvider({ creditNoteId, baseCurrency, ...props }) { }) : []; - // Determines whether the foreign customer. - const isForeignCustomer = - !isEqual(selectCustomer?.currency_code, baseCurrency) && - !isUndefined(selectCustomer?.currency_code); // Provider payload. const provider = { @@ -108,13 +102,9 @@ function CreditNoteFormProvider({ creditNoteId, baseCurrency, ...props }) { creditNote, branches, warehouses, - submitPayload, - baseCurrency, - selectCustomer, - setSelectCustomer, + submitPayload, isNewMode, newCreditNote, - isForeignCustomer, isItemsLoading, isCustomersLoading, diff --git a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormTopBar.js b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormTopBar.js index 63a96f11e..9d2a07fd7 100644 --- a/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormTopBar.js +++ b/src/containers/Sales/CreditNotes/CreditNoteForm/CreditNoteFormTopBar.js @@ -94,7 +94,7 @@ function CreditFormSelectWarehouse() { function CreditNoteWarehouseSelectButton({ label }) { return (