QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-16 12:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: issues in bills and payments made

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2020-10-24 14:49:32 +02:00
parent e8aa4b5d73
commit b91c452101
6 changed files with 67 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/src/api/controllers/Purchases/Bills.ts
View File

@@ -44,7 +44,8 @@ export default class BillsController extends BaseController {
...this.specificBillValidationSchema,
],
this.validationResult,
asyncMiddleware(this.editBill.bind(this))
asyncMiddleware(this.editBill.bind(this)),
this.handleServiceError,
);
router.get(
'/:id', [
@@ -101,10 +102,10 @@ export default class BillsController extends BaseController {
*/
get billEditValidationSchema() {
return [
// check('bill_number').exists().trim().escape(),
check('bill_number').exists().trim().escape(),
check('bill_date').exists().isISO8601(),
check('due_date').optional().isISO8601(),
// check('vendor_id').exists().isNumeric().toInt(),
check('vendor_id').exists().isNumeric().toInt(),
check('note').optional().trim().escape(),
check('entries').isArray({ min: 1 }),
@@ -186,7 +187,7 @@ export default class BillsController extends BaseController {
const { id: billId } = req.params;
try {
const bill = await this.billsService.getBillWithMetadata(tenantId, billId);
const bill = await this.billsService.getBill(tenantId, billId);
return res.status(200).send({ bill });
} catch (error) {
@@ -286,6 +287,11 @@ export default class BillsController extends BaseController {
errors: [{ type: 'ITEMS.IDS.NOT.FOUND', code: 400 }],
});
}
if (error.errorType === 'BILL_ENTRIES_IDS_NOT_FOUND') {
return res.status(400).send({
errors: [{ type: 'BILL_ENTRIES_IDS_NOT_FOUND', code: 900 }],
});
}
}
next(error);
}