QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-20 23:00:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: filter ledger blank entries

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2024-12-09 00:01:42 +02:00
parent 994c441bb8
commit b9963aa241
2 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/server/src/services/Accounting/Ledger.ts
View File

@@ -238,6 +238,7 @@ export default class Ledger implements ILedger {
return { return {
credit: defaultTo(entry.credit, 0), credit: defaultTo(entry.credit, 0),
debit: defaultTo(entry.debit, 0), debit: defaultTo(entry.debit, 0),
exchangeRate: entry.exchangeRate, exchangeRate: entry.exchangeRate,
currencyCode: entry.currencyCode, currencyCode: entry.currencyCode,

17
packages/server/src/services/Accounting/LedgerEntriesStorage.ts
View File

@@ -9,15 +9,18 @@ import {
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { transformLedgerEntryToTransaction } from './utils'; import { transformLedgerEntryToTransaction } from './utils';
// Filter the blank entries.
const filterBlankEntry = (entry: ILedgerEntry) => Boolean(entry.credit || entry.debit);
@Service() @Service()
export class LedgerEntriesStorage { export class LedgerEntriesStorage {
@Inject() @Inject()
tenancy: HasTenancyService; private tenancy: HasTenancyService;
/** /**
* Saves entries of the given ledger. * Saves entries of the given ledger.
* @param {number} tenantId * @param {number} tenantId
* @param {ILedger} ledger * @param {ILedger} ledger
* @param {Knex.Transaction} knex * @param {Knex.Transaction} knex
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
public saveEntries = async ( public saveEntries = async (
@@ -26,7 +29,7 @@ export class LedgerEntriesStorage {
trx?: Knex.Transaction trx?: Knex.Transaction
) => { ) => {
const saveEntryQueue = async.queue(this.saveEntryTask, 10); const saveEntryQueue = async.queue(this.saveEntryTask, 10);
const entries = ledger.getEntries(); const entries = ledger.filter(filterBlankEntry).getEntries();
entries.forEach((entry) => { entries.forEach((entry) => {
saveEntryQueue.push({ tenantId, entry, trx }); saveEntryQueue.push({ tenantId, entry, trx });
@@ -57,8 +60,8 @@ export class LedgerEntriesStorage {
/** /**
* Saves the ledger entry to the account transactions repository. * Saves the ledger entry to the account transactions repository.
* @param {number} tenantId * @param {number} tenantId
* @param {ILedgerEntry} entry * @param {ILedgerEntry} entry
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
private saveEntry = async ( private saveEntry = async (