Merge pull request #159 from bigcapitalhq/abouhuolia/big-24-adjustment-type-options-do-not-show-up-2

fix(webapp): adjustment type options do not show up

packages/webapp/src/constants/adjustmentType.tsx

@@ -1,7 +0,0 @@
-// @ts-nocheck
-import intl from 'react-intl-universal';
-
-export default [
-  { name: intl.get('decrement'), value: 'decrement' },
-  { name: intl.get('increment'), value: 'increment' },
-]

packages/webapp/src/constants/index.tsx

@@ -4,7 +4,6 @@ export * from './tableStyle';
 export * from './features';
 export * from './cellTypes';
 export * from './classes';
-export * from './adjustmentType';
 export * from './cashflowOptions';
 
 export const Align = { Left: 'left', Right: 'right', Center: 'center' };

packages/webapp/src/containers/Dialogs/InventoryAdjustmentFormDialog/InventoryAdjustmentFormDialogFields.tsx

@@ -34,16 +34,17 @@ import {
   toSafeNumber,
 } from '@/utils';
 import { Features, CLASSES } from '@/constants';
-import adjustmentType from '@/constants/adjustmentType';
 
 import { useInventoryAdjContext } from './InventoryAdjustmentFormProvider';
+import { useFeatureCan } from '@/hooks/state';
+
+import InventoryAdjustmentQuantityFields from './InventoryAdjustmentQuantityFields';
 import {
   diffQuantity,
   useSetPrimaryBranchToForm,
   useSetPrimaryWarehouseToForm,
+  useGetAdjustmentTypeOptions,
 } from './utils';
-import { useFeatureCan } from '@/hooks/state';
-import InventoryAdjustmentQuantityFields from './InventoryAdjustmentQuantityFields';
 
 /**
  * Inventory adjustment form dialogs fields.
@@ -52,6 +53,9 @@ export default function InventoryAdjustmentFormDialogFields() {
   // Features guard.
   const { featureCan } = useFeatureCan();
 
+  // Retrieves memorized adjustment types options.
+  const adjustmentTypes = useGetAdjustmentTypeOptions();
+
   const dateFieldRef = useAutofocus();
 
   // Inventory adjustment dialog context.
@@ -149,7 +153,7 @@ export default function InventoryAdjustmentFormDialogFields() {
                 className={classNames(CLASSES.FILL, 'form-group--type')}
               >
                 <ListSelect
-                  items={adjustmentType}
+                  items={adjustmentTypes}
                   onItemSelect={(type) => {
                     const result = diffQuantity(
                       toSafeNumber(values.quantity),

packages/webapp/src/containers/Dialogs/InventoryAdjustmentFormDialog/utils.tsx

@@ -1,5 +1,6 @@
 // @ts-nocheck
-import React from 'react';
+import React, { useMemo } from 'react';
+import intl from 'react-intl-universal';
 import { useFormikContext } from 'formik';
 import { useInventoryAdjContext } from './InventoryAdjustmentFormProvider';
 import { first } from 'lodash';
@@ -48,3 +49,12 @@ export const useSetPrimaryBranchToForm = () => {
     }
   }, [isBranchesSuccess, setFieldValue, branches]);
 };
+
+export const getAdjustmentTypeOptions = () => [
+  { name: intl.get('decrement'), value: 'decrement' },
+  { name: intl.get('increment'), value: 'increment' },
+];
+
+export const useGetAdjustmentTypeOptions = () => {
+  return useMemo(() => getAdjustmentTypeOptions(), []);
+};

packages/webapp/src/store/inventoryAdjustments/inventoryAdjustment.type.tsx

@@ -1,5 +1,6 @@
 // @ts-nocheck
 
 export default {
-  INVENTORY_ADJUSTMENTS_TABLE_STATE_SET: 'INVENTORY_ADJUSTMENTS/TABLE_STATE_SET',
+  INVENTORY_ADJUSTMENTS_TABLE_STATE_SET:
-};
+    'INVENTORY_ADJUSTMENTS/TABLE_STATE_SET',
+};