WIP / FIx & no-unused-vars

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheet.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useMemo, useCallback, useState } from 'react';
+import React, { useEffect, useCallback, useState } from 'react';
 
 import { compose } from 'utils';
 import { useQuery } from 'react-query';
@@ -16,7 +16,7 @@ import withSettings from 'containers/Settings/withSettings';
 import withBalanceSheetActions from './withBalanceSheetActions';
 import withBalanceSheetDetail from './withBalanceSheetDetail';
 
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import {useIntl } from 'react-intl';
 
 
 function BalanceSheet({
@@ -54,7 +54,7 @@ function BalanceSheet({
 
   useEffect(() => {
     changePageTitle(formatMessage({ id: 'balance_sheet' }));
-  }, []);
+  }, [changePageTitle,formatMessage]);
 
   // Handle re-fetch balance sheet after filter change.
   const handleFilterSubmit = useCallback((filter) => {

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetActionsBar.js

@@ -3,24 +3,21 @@ import {
   NavbarGroup,
   Button,
   Classes,
-  NavbarHeading,
   NavbarDivider,
-  Intent,
   Popover,
   PopoverInteractionKind,
   Position,
 } from '@blueprintjs/core';
+import { FormattedMessage as T } from 'react-intl';
+
 import Icon from 'components/Icon';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
+import FilterDropdown from 'components/FilterDropdown';
 import classNames from 'classnames';
 
-import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
-export default function JournalActionsBar({
-
-}) {
+export default function JournalActionsBar() {
   const filterDropdown = FilterDropdown({
     fields: [],
     onFilterChange: (filterConditions) => {

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeader.js

@@ -6,15 +6,16 @@ import {
   FormGroup,
   MenuItem,
 } from "@blueprintjs/core";
-import SelectList from 'components/SelectList';
 import moment from 'moment';
-import Icon from 'components/Icon';
-import { useFormik } from 'formik';
 import * as Yup from 'yup';
+import { useFormik } from 'formik';
+import { FormattedMessage as T, useIntl } from 'react-intl';
+
+import Icon from 'components/Icon';
+import SelectList from 'components/SelectList';
 import FinancialStatementDateRange from 'containers/FinancialStatements/FinancialStatementDateRange';
 import SelectDisplayColumnsBy from '../SelectDisplayColumnsBy';
 import RadiosAccountingBasis from '../RadiosAccountingBasis';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 export default function BalanceSheetHeader({
@@ -45,7 +46,7 @@ export default function BalanceSheetHeader({
   const onItemSelectDisplayColumns = useCallback((item) => {
     formik.setFieldValue('display_columns_type', item.type);
     formik.setFieldValue('display_columns_by', item.by);
-  }, []);
+  }, [formik]);
 
   // Handle submit filter submit button.
   const handleSubmitClick = useCallback(() => {
@@ -55,7 +56,7 @@ export default function BalanceSheetHeader({
   const filterAccountsOptions = useMemo(() => [
     { key: '', name: formatMessage({ id: 'accounts_with_zero_balance' }) },
     { key: 'all-trans', name: formatMessage({ id: 'all_transactions' }) },
-  ], []);
+  ], [formatMessage]);
 
   const filterAccountRenderer = useCallback((item, { handleClick, modifiers, query }) => {
     return (<MenuItem text={item.name} key={item.id} onClick={handleClick} />);

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetTable.js

@@ -1,5 +1,6 @@
 import React, {useMemo, useCallback } from 'react';
 import { connect } from 'react-redux';
+import { useIntl } from 'react-intl';
 
 import Money from 'components/Money';
 import FinancialSheet from 'components/FinancialSheet';
@@ -12,7 +13,6 @@ import {
 } from 'store/financialStatement/financialStatements.selectors';
 
 import { compose, defaultExpanderReducer } from 'utils';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 function BalanceSheetTable({
@@ -108,7 +108,7 @@ function BalanceSheetTable({
         width: 100,
       })))
     : [],
-  ], [balanceSheetQuery, balanceSheetColumns]);
+  ], [balanceSheetQuery, balanceSheetColumns,formatMessage]);
   
   const handleFetchData = useCallback(() => {
     onFetchData && onFetchData();

client/src/containers/FinancialStatements/FinancialStatementDateRange.js

@@ -2,7 +2,7 @@ import React, {useState, useCallback, useMemo} from 'react';
 import {Row, Col} from 'react-grid-system';
 import {momentFormatter} from 'utils';
 import {DateInput} from '@blueprintjs/datetime';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import { useIntl } from 'react-intl';
 
 import {
   HTMLSelect,

client/src/containers/FinancialStatements/GeneralLedger/GeneralLedger.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useCallback, useState, useMemo } from 'react';
+import React, { useEffect, useCallback, useState} from 'react';
 import moment from 'moment';
 import GeneralLedgerTable from 'containers/FinancialStatements/GeneralLedger/GeneralLedgerTable';
 import { useQuery } from 'react-query';
@@ -43,7 +43,7 @@ function GeneralLedger({
   // Change page title of the dashboard.
   useEffect(() => {
     changePageTitle(formatMessage({id:'general_ledger'}));
-  }, []);
+  }, [changePageTitle,formatMessage]);
 
   const fetchAccounts = useQuery(['accounts-list'],
     () => requestFetchAccounts());

client/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerActionsBar.js

@@ -3,25 +3,21 @@ import {
   NavbarGroup,
   Button,
   Classes,
-  NavbarHeading,
   NavbarDivider,
-  Intent,
   Popover,
   PopoverInteractionKind,
   Position,
 } from '@blueprintjs/core';
+import { FormattedMessage as T } from 'react-intl';
 import Icon from 'components/Icon';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
 import classNames from 'classnames';
 import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 /**
  * General ledger actions bar.
  */
-export default function GeneralLedgerActionsBar({
-
-}) {
+export default function GeneralLedgerActionsBar() {
   const filterDropdown = FilterDropdown({
     fields: [],
     onFilterChange: (filterConditions) => {

client/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerHeader.js

@@ -1,31 +1,29 @@
-import React, {useState, useMemo, useEffect, useCallback} from 'react';
-import FinancialStatementHeader from 'containers/FinancialStatements/FinancialStatementHeader';
-import { FormattedMessage as T, useIntl } from 'react-intl';
-
+import React, { useCallback} from 'react';
 import {
   Button,
   FormGroup,
   Classes,
 } from '@blueprintjs/core';
 import {Row, Col} from 'react-grid-system';
-import {
-  compose,
-} from 'utils';
 import moment from 'moment';
+import * as Yup from 'yup';
+import {useFormik} from 'formik';
+import { FormattedMessage as T } from 'react-intl';
+
+import AccountsMultiSelect from 'components/AccountsMultiSelect';
+import FinancialStatementHeader from 'containers/FinancialStatements/FinancialStatementHeader';
 import AccountsConnect from 'connectors/Accounts.connector'
 import classNames from 'classnames';
-import AccountsMultiSelect from 'components/AccountsMultiSelect';
-import {useFormik} from 'formik';
 import FinancialStatementDateRange from 'containers/FinancialStatements/FinancialStatementDateRange';
-import * as Yup from 'yup';
 import RadiosAccountingBasis from '../RadiosAccountingBasis';
+import {compose} from 'utils';
+
 
 function GeneralLedgerHeader({
   onSubmitFilter,
   pageFilter,
   accounts,
 }) {
-  const {formatMessage} = useIntl();
 
   const formik = useFormik({
     enableReinitialize: true,

client/src/containers/FinancialStatements/GeneralLedger/GeneralLedgerTable.js

@@ -1,11 +1,11 @@
-import React, {useEffect, useState, useCallback, useMemo} from 'react';
+import React, {useCallback, useMemo} from 'react';
 import moment from 'moment';
 import { connect } from 'react-redux';
 import {
   defaultExpanderReducer,
   compose
 } from 'utils';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import { useIntl } from 'react-intl';
 
 import FinancialSheet from 'components/FinancialSheet';
 import DataTable from 'components/DataTable';

client/src/containers/FinancialStatements/Journal/Journal.js

@@ -37,7 +37,7 @@ function Journal({
 
   useEffect(() => {
     changePageTitle(formatMessage({id:'journal_sheet'}));
-  }, []);
+  }, [changePageTitle,formatMessage]);
 
   const fetchHook = useQuery(['journal', filter],
     (key, query) => { requestFetchJournalSheet(query); },

client/src/containers/FinancialStatements/Journal/JournalActionsBar.js

@@ -3,22 +3,18 @@ import {
   NavbarGroup,
   Button,
   Classes,
-  NavbarHeading,
   NavbarDivider,
-  Intent,
   Popover,
   PopoverInteractionKind,
   Position,
 } from '@blueprintjs/core';
+import { FormattedMessage as T } from 'react-intl';
 import Icon from 'components/Icon';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
-import classNames from 'classnames';
 import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import classNames from 'classnames';
 
-export default function JournalActionsBar({
-
-}) {
+export default function JournalActionsBar() {
   const filterDropdown = FilterDropdown({
     fields: [],
     onFilterChange: (filterConditions) => {

client/src/containers/FinancialStatements/Journal/JournalHeader.js

@@ -2,11 +2,10 @@ import React, { useCallback } from 'react';
 import { Row, Col } from 'react-grid-system';
 import {
   Button,
-  Intent,
 } from '@blueprintjs/core';
 import moment from 'moment';
 import { useFormik } from 'formik';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import { FormattedMessage as T } from 'react-intl';
 import * as Yup from 'yup';
 
 import FinancialStatementDateRange from 'containers/FinancialStatements/FinancialStatementDateRange';
@@ -17,7 +16,7 @@ export default function JournalHeader({
   pageFilter,
   onSubmitFilter,
 }) {
-  const { formatMessage } = useIntl();
+ 
   const formik = useFormik({
     enableReinitialize: true,
     initialValues: {

client/src/containers/FinancialStatements/Journal/JournalTable.js

@@ -1,6 +1,7 @@
 import React, { useCallback, useMemo } from 'react';
 import {connect} from 'react-redux';
 import moment from 'moment';
+import {  useIntl } from 'react-intl';
 
 import FinancialSheet from 'components/FinancialSheet';
 import DataTable from 'components/DataTable';
@@ -12,7 +13,6 @@ import {
 } from 'store/financialStatement/financialStatements.selectors';
 
 import withJournal from './withJournal';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 function JournalSheetTable({
@@ -77,7 +77,7 @@ const {formatMessage} =useIntl();
       accessor: r => exceptRowTypes(
         r.rowType, (<Money amount={r.debit} currency={'USD'} />), ['space_entry']),
     },
-  ], []);
+  ], [formatMessage]);
 
   const handleFetchData = useCallback((...args) => {
     onFetchData && onFetchData(...args)

client/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossActionsBar.js

@@ -5,21 +5,19 @@ import {
   Classes,
   NavbarDivider,
 } from '@blueprintjs/core';
+import { FormattedMessage as T } from 'react-intl';
 import Icon from 'components/Icon';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
 import classNames from 'classnames';
-import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+// import FilterDropdown from 'components/FilterDropdown';
 
-export default function ProfitLossActionsBar({
-
-}) {
-  const filterDropdown = FilterDropdown({
-    fields: [],
-    onFilterChange: (filterConditions) => {
+export default function ProfitLossActionsBar() {
+  // const filterDropdown = FilterDropdown({
+  //   fields: [],
+  //   onFilterChange: (filterConditions) => {
       
-    },
-  });
+  //   },
+  // });
 
   return (
     <DashboardActionsBar>

client/src/containers/FinancialStatements/ProfitLossSheet/ProfitLossSheetTable.js

@@ -1,5 +1,7 @@
 import React, { useMemo, useCallback } from 'react';
 import { connect } from 'react-redux';
+import { FormattedMessage as T, useIntl } from 'react-intl';
+
 import FinancialSheet from 'components/FinancialSheet';
 import DataTable from 'components/DataTable';
 import Money from 'components/Money';
@@ -9,7 +11,6 @@ import {
   getFinancialSheetIndexByQuery,
 } from 'store/financialStatement/financialStatements.selectors';
 import withProfitLossDetail from './withProfitLoss';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 function ProfitLossSheetTable({
@@ -103,7 +104,7 @@ function ProfitLossSheetTable({
         width: 100,
       })))
     : [],
-  ], [profitLossQuery.display_columns_type, profitLossColumns]);
+  ], [profitLossQuery.display_columns_type, profitLossColumns,formatMessage]);
 
   // Handle data table fetch data.
   const handleFetchData = useCallback((...args) => {

client/src/containers/FinancialStatements/SelectDisplayColumnsBy.js

@@ -6,7 +6,7 @@ import {
   FormGroup,
   MenuItem,
 } from '@blueprintjs/core';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import { FormattedMessage as T } from 'react-intl';
 
 export default function SelectsListColumnsBy(props) {
   const { onItemSelect, formGroupProps, selectListProps } = props;
@@ -19,7 +19,7 @@ export default function SelectsListColumnsBy(props) {
     {key: 'week', name: 'Date/Week', type: 'date_periods', by: 'month'},
     {key: 'day', name: 'Date/Day', type: 'date_periods', by: 'day'},
     {key: 'quarter', name: 'Date/Quarter', type: 'date_periods', by: 'quarter'},
-  ]);
+  ],[]);
 
   const itemRenderer = useCallback((item, { handleClick, modifiers, query }) => {
     return (<MenuItem text={item.name} key={item.id} onClick={handleClick} />);

client/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceActionsBar.js

@@ -3,28 +3,22 @@ import {
   NavbarGroup,
   Button,
   Classes,
-  NavbarHeading,
   NavbarDivider,
-  Intent,
-  Popover,
-  PopoverInteractionKind,
-  Position,
 } from '@blueprintjs/core';
 import Icon from 'components/Icon';
+import { FormattedMessage as T } from 'react-intl';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
 import classNames from 'classnames';
-import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
+// import FilterDropdown from 'components/FilterDropdown';
 
-export default function GeneralLedgerActionsBar({
-
-}) {
-  const filterDropdown = FilterDropdown({
-    fields: [],
-    onFilterChange: (filterConditions) => {
+export default function GeneralLedgerActionsBar() {
+  
+  // const filterDropdown = FilterDropdown({
+  //   fields: [],
+  //   onFilterChange: (filterConditions) => {
       
-    },
-  });
+  //   },
+  // });
 
   return (
     <DashboardActionsBar>

client/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheet.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useCallback, useState, useMemo } from 'react';
+import React, { useEffect, useCallback, useState } from 'react';
 import { useQuery } from 'react-query';
 import moment from 'moment';
 import { useIntl } from 'react-intl';
@@ -52,7 +52,7 @@ function TrialBalanceSheet({
   // Change page title of the dashboard.
   useEffect(() => {
     changePageTitle(formatMessage({id:'trial_balance_sheet'}));
-  }, []);
+  }, [changePageTitle,formatMessage]);
 
   const handleFilterSubmit = useCallback((filter) => {
     const parsedFilter = {

client/src/containers/FinancialStatements/TrialBalanceSheet/TrialBalanceSheetTable.js

@@ -94,7 +94,7 @@ function TrialBalanceSheetTable({
       className: 'balance',
       width: 120,
     }
-  ], []);
+  ], [formatMessage]);
 
   const handleFetchData = useCallback(() => {
     onFetchData && onFetchData();