WIP / FIx & no-unused-vars

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheet.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useMemo, useCallback, useState } from 'react';
+import React, { useEffect, useCallback, useState } from 'react';
 
 import { compose } from 'utils';
 import { useQuery } from 'react-query';
@@ -16,7 +16,7 @@ import withSettings from 'containers/Settings/withSettings';
 import withBalanceSheetActions from './withBalanceSheetActions';
 import withBalanceSheetDetail from './withBalanceSheetDetail';
 
-import { FormattedMessage as T, useIntl } from 'react-intl';
+import {useIntl } from 'react-intl';
 
 
 function BalanceSheet({
@@ -54,7 +54,7 @@ function BalanceSheet({
 
   useEffect(() => {
     changePageTitle(formatMessage({ id: 'balance_sheet' }));
-  }, []);
+  }, [changePageTitle,formatMessage]);
 
   // Handle re-fetch balance sheet after filter change.
   const handleFilterSubmit = useCallback((filter) => {

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetActionsBar.js

@@ -3,24 +3,21 @@ import {
   NavbarGroup,
   Button,
   Classes,
-  NavbarHeading,
   NavbarDivider,
-  Intent,
   Popover,
   PopoverInteractionKind,
   Position,
 } from '@blueprintjs/core';
+import { FormattedMessage as T } from 'react-intl';
+
 import Icon from 'components/Icon';
 import DashboardActionsBar from 'components/Dashboard/DashboardActionsBar'
+import FilterDropdown from 'components/FilterDropdown';
 import classNames from 'classnames';
 
-import FilterDropdown from 'components/FilterDropdown';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
-export default function JournalActionsBar({
-
-}) {
+export default function JournalActionsBar() {
   const filterDropdown = FilterDropdown({
     fields: [],
     onFilterChange: (filterConditions) => {

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetHeader.js

@@ -6,15 +6,16 @@ import {
   FormGroup,
   MenuItem,
 } from "@blueprintjs/core";
-import SelectList from 'components/SelectList';
 import moment from 'moment';
-import Icon from 'components/Icon';
-import { useFormik } from 'formik';
 import * as Yup from 'yup';
+import { useFormik } from 'formik';
+import { FormattedMessage as T, useIntl } from 'react-intl';
+
+import Icon from 'components/Icon';
+import SelectList from 'components/SelectList';
 import FinancialStatementDateRange from 'containers/FinancialStatements/FinancialStatementDateRange';
 import SelectDisplayColumnsBy from '../SelectDisplayColumnsBy';
 import RadiosAccountingBasis from '../RadiosAccountingBasis';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 export default function BalanceSheetHeader({
@@ -45,7 +46,7 @@ export default function BalanceSheetHeader({
   const onItemSelectDisplayColumns = useCallback((item) => {
     formik.setFieldValue('display_columns_type', item.type);
     formik.setFieldValue('display_columns_by', item.by);
-  }, []);
+  }, [formik]);
 
   // Handle submit filter submit button.
   const handleSubmitClick = useCallback(() => {
@@ -55,7 +56,7 @@ export default function BalanceSheetHeader({
   const filterAccountsOptions = useMemo(() => [
     { key: '', name: formatMessage({ id: 'accounts_with_zero_balance' }) },
     { key: 'all-trans', name: formatMessage({ id: 'all_transactions' }) },
-  ], []);
+  ], [formatMessage]);
 
   const filterAccountRenderer = useCallback((item, { handleClick, modifiers, query }) => {
     return (<MenuItem text={item.name} key={item.id} onClick={handleClick} />);

client/src/containers/FinancialStatements/BalanceSheet/BalanceSheetTable.js

@@ -1,5 +1,6 @@
 import React, {useMemo, useCallback } from 'react';
 import { connect } from 'react-redux';
+import { useIntl } from 'react-intl';
 
 import Money from 'components/Money';
 import FinancialSheet from 'components/FinancialSheet';
@@ -12,7 +13,6 @@ import {
 } from 'store/financialStatement/financialStatements.selectors';
 
 import { compose, defaultExpanderReducer } from 'utils';
-import { FormattedMessage as T, useIntl } from 'react-intl';
 
 
 function BalanceSheetTable({
@@ -108,7 +108,7 @@ function BalanceSheetTable({
         width: 100,
       })))
     : [],
-  ], [balanceSheetQuery, balanceSheetColumns]);
+  ], [balanceSheetQuery, balanceSheetColumns,formatMessage]);
   
   const handleFetchData = useCallback(() => {
     onFetchData && onFetchData();