Fix: Styling Item Categories Table

client/src/containers/Items/ItemCategoriesList.js

@@ -9,6 +9,7 @@ import {
 } from 'react-intl';
 
 import AppToaster from 'components/AppToaster';
+import DashboardPageContent from 'components/Dashboard/DashboardPageContent';
 import DashboardInsider from 'components/Dashboard/DashboardInsider';
 import ItemCategoriesDataTable from 'containers/Items/ItemCategoriesTable';
 import ItemsCategoryActionsBar from 'containers/Items/ItemsCategoryActionsBar';
@@ -156,7 +157,7 @@ const ItemCategoryList = ({
 
   return (
     <DashboardInsider
-      loading={fetchResourceFields.isFetching}
+      loading={fetchResourceFields.isFetching || fetchCategories.isFetching}
       name={'item-category-list'}
     >
       <ItemsCategoryActionsBar
@@ -164,50 +165,50 @@ const ItemCategoryList = ({
         onFilterChanged={handleFilterChanged}
         onBulkDelete={handleBulkDelete}
       />
+      <DashboardPageContent>
+        <ItemCategoriesDataTable
+          onEditCategory={handleEditCategory}
+          onFetchData={handleFetchData}
+          onSelectedRowsChange={handleSelectedRowsChange}
+          onDeleteCategory={handleDeleteCategory}
+        />
 
-      <ItemCategoriesDataTable
-        onEditCategory={handleEditCategory}
-        onFetchData={handleFetchData}
-        onSelectedRowsChange={handleSelectedRowsChange}
-        onDeleteCategory={handleDeleteCategory}
-        loading={fetchCategories.isFetching}
-      />
+        <Alert
+          cancelButtonText={<T id={'cancel'} />}
+          confirmButtonText={<T id={'delete'} />}
+          icon="trash"
+          intent={Intent.DANGER}
+          isOpen={deleteCategory}
+          onCancel={handleCancelItemDelete}
+          onConfirm={handleConfirmItemDelete}
+        >
+          <p>
+            <FormattedHTMLMessage
+              id={'once_delete_this_item_category_you_will_able_to_restore_it'}
+            />
+          </p>
+        </Alert>
 
-      <Alert
-        cancelButtonText={<T id={'cancel'} />}
-        confirmButtonText={<T id={'delete'} />}
-        icon="trash"
-        intent={Intent.DANGER}
-        isOpen={deleteCategory}
-        onCancel={handleCancelItemDelete}
-        onConfirm={handleConfirmItemDelete}
-      >
-        <p>
-          <FormattedHTMLMessage
-            id={'once_delete_this_item_category_you_will_able_to_restore_it'}
-          />
-        </p>
-      </Alert>
-
-      <Alert
-        cancelButtonText={<T id={'cancel'} />}
-        confirmButtonText={`${formatMessage({
-          id: 'delete',
-        })} (${selectedRowsCount})`}
-        icon="trash"
-        intent={Intent.DANGER}
-        isOpen={bulkDelete}
-        onCancel={handleCancelBulkDelete}
-        onConfirm={handleConfirmBulkDelete}
-      >
-        <p>
-          <FormattedHTMLMessage
-            id={
-              'once_delete_these_item_categories_you_will_not_able_restore_them'
-            }
-          />
-        </p>
-      </Alert>
+        <Alert
+          cancelButtonText={<T id={'cancel'} />}
+          confirmButtonText={`${formatMessage({
+            id: 'delete',
+          })} (${selectedRowsCount})`}
+          icon="trash"
+          intent={Intent.DANGER}
+          isOpen={bulkDelete}
+          onCancel={handleCancelBulkDelete}
+          onConfirm={handleConfirmBulkDelete}
+        >
+          <p>
+            <FormattedHTMLMessage
+              id={
+                'once_delete_these_item_categories_you_will_not_able_restore_them'
+              }
+            />
+          </p>
+        </Alert>
+      </DashboardPageContent>
     </DashboardInsider>
   );
 };

client/src/containers/Items/ItemCategoriesTable.js

@@ -21,6 +21,7 @@ import withDialogActions from 'containers/Dialog/withDialogActions';
 const ItemsCategoryList = ({
   // #withItemCategories
   categoriesList,
+  categoriesTableLoading,
 
   // #withDialogActions.
   openDialog,
@@ -72,21 +73,21 @@ const ItemsCategoryList = ({
         id: 'name',
         Header: formatMessage({ id: 'category_name' }),
         accessor: 'name',
-        width: 150,
+        width: 220,
       },
       {
         id: 'description',
         Header: formatMessage({ id: 'description' }),
         accessor: 'description',
         className: 'description',
-        width: 150,
+        width: 220,
       },
       {
         id: 'count',
         Header: formatMessage({ id: 'count' }),
         accessor: 'count',
         className: 'count',
-        width: 50,
+        width: 180,
       },
       {
         id: 'actions',
@@ -94,14 +95,13 @@ const ItemsCategoryList = ({
         Cell: ({ cell }) => (
           <Popover
             content={actionMenuList(cell.row.original)}
-            position={Position.RIGHT_BOTTOM}
+            position={Position.RIGHT_TOP}
           >
             <Button icon={<Icon icon="more-h-16" iconSize={16} />} />
           </Popover>
         ),
         className: 'actions',
         width: 50,
-        disableResizing: false,
       },
     ],
     [actionMenuList, formatMessage],
@@ -148,9 +148,9 @@ const ItemsCategoryList = ({
         manualSortBy={true}
         selectionColumn={selectionColumn}
         expandable={true}
+        sticky={true}
         onSelectedRowsChange={handleSelectedRowsChange}
-        treeGraph={true}
-        spinnerProps={{ size: 30 }}
+        loading={categoriesTableLoading}
         rowContextMenu={handleRowContextMenu}
       />
     </LoadingIndicator>
@@ -158,8 +158,9 @@ const ItemsCategoryList = ({
 };
 
 export default compose(
-  withItemCategories(({ categoriesList }) => ({
+  withItemCategories(({ categoriesList, categoriesTableLoading }) => ({
     categoriesList,
+    categoriesTableLoading,
   })),
   withDialogActions,
 )(ItemsCategoryList);