QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-21 07:10:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactors backend validator for credit-debit equals

Browse Source
This commit is contained in:
Nana Kofi Larbi Mantey
2024-10-20 17:44:39 +00:00
parent ccbb399685
commit d79f26f1b5
1 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/server/src/services/ManualJournals/CommandManualJournalValidators.ts
View File

@@ -23,23 +23,20 @@ export class CommandManualJournalValidators {
* @param {IManualJournalDTO} manualJournalDTO * @param {IManualJournalDTO} manualJournalDTO
*/ */
public valdiateCreditDebitTotalEquals(manualJournalDTO: IManualJournalDTO) { public valdiateCreditDebitTotalEquals(manualJournalDTO: IManualJournalDTO) {
let totalCredit = 0; const totalCredit = this.roundToTwoDecimals(
let totalDebit = 0; manualJournalDTO.entries.reduce((sum, entry) => sum + (entry.credit || 0), 0)
);
const totalDebit = this.roundToTwoDecimals(
manualJournalDTO.entries.reduce((sum, entry) => sum + (entry.debit || 0), 0)
);
manualJournalDTO.entries.forEach((entry) => {
if (entry.credit > 0) {
totalCredit += entry.credit;
}
if (entry.debit > 0) {
totalDebit += entry.debit;
}
});
if (totalCredit <= 0 || totalDebit <= 0) { if (totalCredit <= 0 || totalDebit <= 0) {
throw new ServiceError(ERRORS.CREDIT_DEBIT_NOT_EQUAL_ZERO); throw new ServiceError(ERRORS.CREDIT_DEBIT_NOT_EQUAL_ZERO);
} }
if (totalCredit !== totalDebit) { }
throw new ServiceError(ERRORS.CREDIT_DEBIT_NOT_EQUAL);
} private roundToTwoDecimals(value: number): number {
return Math.round(value * 100) / 100;
} }
/** /**
@@ -308,3 +305,4 @@ export class CommandManualJournalValidators {
} }
}; };
} }