fix item categories API.

This commit is contained in:
Ahmed Bouhuolia
2020-03-31 14:28:13 +02:00
parent d9e10fd6b4
commit da05239e84
4 changed files with 181 additions and 92 deletions

View File

@@ -1,24 +1,47 @@
import { request, expect, create } from '~/testInit';
import {
request,
expect,
create,
login,
} from '~/testInit';
import knex from '@/database/knex';
describe('routes: /item_categories/', () => {
describe('POST `/items_categories``', async () => {
it('Should not create a item category if the user was not authorized.', () => {
let loginRes;
describe.only('routes: /item_categories/', () => {
beforeEach(async () => {
loginRes = await login();
});
afterEach(() => {
loginRes = null;
});
describe('POST `/items_categories``', async () => {
it('Should not create a item category if the user was not authorized.', async () => {
const res = await request().post('/api/item_categories').send();
expect(res.status).equals(401);
expect(res.body.message).equals('unauthorized');
});
it('Should `name` be required.', async () => {
const res = await request().post('/api/item_categories').send();
const res = await request()
.post('/api/item_categories')
.set('x-access-token', loginRes.body.token)
.send();
expect(res.status).equals(422);
expect(res.body.code).equals('validation_error');
});
it('Should `parent_category_id` be exist in the storage.', async () => {
const res = await request().posjt('/api/item_categories').send({
name: 'Clothes',
parent_category_id: 10,
});
const res = await request()
.post('/api/item_categories')
.set('x-access-token', loginRes.body.token)
.send({
name: 'Clothes',
parent_category_id: 10,
});
expect(res.status).equals(404);
expect(res.body.errors).include.something.that.deep.equals({
@@ -27,55 +50,76 @@ describe('routes: /item_categories/', () => {
});
it('Should response success with correct form data.', async () => {
const res = await request().post('/api/item_categories').send({
name: 'Clothes',
description: 'Here is description',
});
const res = await request()
.post('/api/item_categories')
.set('x-access-token', loginRes.body.token)
.send({
name: 'Clothes',
description: 'Here is description',
});
// eslint-disable-next-line no-unused-expressions
expect(res.body.id).to.exist;
expect(res.status).equals(200);
expect(res.body.category).to.be.a('object');
expect(res.body.category.id).to.be.a('number');
expect(res.body.category.name).to.be.a('string');
expect(res.body.category.description).to.be.a('string');
});
it('Should item category data be saved to the storage.', async () => {
const category = await create('item_category');
const res = await request().post('/api/item_categories').send({
name: 'Clothes',
description: 'Here is description',
parent_category_id: category.id,
});
const res = await request()
.post('/api/item_categories')
.set('x-access-token', loginRes.body.token)
.send({
name: 'Clothes',
description: 'Here is description',
parent_category_id: category.id,
});
// eslint-disable-next-line no-unused-expressions
expect(res.body.id).to.exist;
expect(res.status).equals(200);
const storedCategory = await knex('items_categories').where('id', res.body.id).first();
const storedCategory = await knex('items_categories')
.where('id', res.body.category.id).first();
expect(storedCategory.label).equals('Clothes');
expect(storedCategory.name).equals('Clothes');
expect(storedCategory.description).equals('Here is description');
expect(storedCategory.parent_category_id).equals(category.id);
expect(storedCategory.parentCategoryId).equals(category.id);
expect(storedCategory.userId).to.be.a('number');
});
});
describe('POST `/items_category/{id}`', () => {
it('Should not update a item category if the user was not authorized.', () => {
it('Should not update a item category if the user was not authorized.', async () => {
const category = await create('item_category');
const res = await request()
.post(`/api/item_categories/${category.id}`)
.send();
expect(res.status).equals(401);
expect(res.body.message).equals('unauthorized');
});
it('Should `name` be required.', async () => {
const category = await create('item_category');
const res = await request().post(`/api/item_categories/${category.id}`).send({
name: '',
});
const res = await request()
.post(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send({
name: '',
});
expect(res.status).equals(422);
expect(res.body.code).equals('validation_error');
});
it('Should `parent_category_id` be exist in the storage.', async () => {
const category = await create('item_category');
const res = await request().post(`/api/item_categories/${category.id}`).send({
name: 'Name',
parent_category_id: 10,
});
const res = await request()
.post(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send({
name: 'Name',
parent_category_id: 10,
});
expect(res.status).equals(404);
expect(res.body.errors).include.something.that.deep.equals({
@@ -87,11 +131,14 @@ describe('routes: /item_categories/', () => {
const category = await create('item_category');
const anotherCategory = await create('item_category');
const res = await request().post(`/api/item_categories/${category.id}`).send({
name: 'Name',
parent_category_id: anotherCategory.id,
description: 'updated description',
});
const res = await request()
.post(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send({
name: 'Name',
parent_category_id: anotherCategory.id,
description: 'updated description',
});
expect(res.status).equals(200);
});
@@ -100,42 +147,61 @@ describe('routes: /item_categories/', () => {
const category = await create('item_category');
const anotherCategory = await create('item_category');
const res = await request().post(`/api/item_categories/${category.id}`).send({
name: 'Name',
parent_category_id: anotherCategory.id,
description: 'updated description',
});
const res = await request()
.post(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send({
name: 'Name',
parent_category_id: anotherCategory.id,
description: 'updated description',
});
const storedCategory = await knex('items_categories').where('id', res.body.id).first();
const storedCategory = await knex('items_categories')
.where('id', res.body.id).first();
expect(storedCategory.label).equals('Name');
expect(storedCategory.name).equals('Name');
expect(storedCategory.description).equals('updated description');
expect(storedCategory.parent_category_id).equals(anotherCategory.id);
expect(storedCategory.parentCategoryId).equals(anotherCategory.id);
});
});
describe('DELETE: `/items_categories`', async () => {
it('Should not delete the give item category if the user was not authorized.', () => {
it('Should not delete the give item category if the user was not authorized.', async () => {
const category = await create('item_category');
const res = await request()
.delete(`/api/item_categories/${category.id}`)
.send();
expect(res.status).equals(401);
expect(res.body.message).equals('unauthorized');
});
it('Should not delete if the item category was not found.', async () => {
const res = await request().delete('/api/item_categories/10');
const res = await request()
.delete('/api/item_categories/10')
.set('x-access-token', loginRes.body.token)
.send();
expect(res.status).equals(404);
});
it('Should response success after delete the given item category.', async () => {
const category = await create('item_category');
const res = await request().delete(`/api/item_categories/${category.id}`);
const res = await request()
.delete(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send();
expect(res.status).equals(200);
});
it('Should delete the give item category from the storage.', async () => {
const category = await create('item_category');
await request().delete(`/api/item_categories/${category.id}`);
const res = await request()
.delete(`/api/item_categories/${category.id}`)
.set('x-access-token', loginRes.body.token)
.send();
const categories = await knex('items_categories').where('id', category.id);
@@ -143,6 +209,28 @@ describe('routes: /item_categories/', () => {
});
});
describe('GET: `/item_categories`', () => {
it('Should retrieve list of item categories.', async () => {
const category1 = await create('item_category');
const category2 = await create('item_category', { parent_category_id: category1.id });
const res = await request()
.get('/api/item_categories')
.set('x-access-token', loginRes.body.token)
.send();
expect(res.body.categories).to.be.a('array');
expect(res.body.categories.length).equals(2);
expect(res.body.categories[0].id).to.be.a('number');
expect(res.body.categories[0].name).to.be.a('string');
expect(res.body.categories[0].parent_category_id).to.be.a('null');
expect(res.body.categories[0].description).to.be.a('string');
expect(res.body.categories[1].parent_category_id).to.be.a('number');
});
});
describe('GET `/items_category/{id}', () => {
it('Should response not found with incorrect item category ID.', () => {