QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-16 04:40:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(server): remove the phone number from users service

Browse Source
This commit is contained in:
a.bouhuolia
2023-04-06 03:08:06 +02:00
parent 85b24c7a4f
commit e4a647376c
6 changed files with 31 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
packages/server/src/services/Users/UsersService.ts
View File

@@ -17,20 +17,17 @@ import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
@Service()
export default class UsersService {
@Inject('logger')
logger: any;
@Inject('repositories')
repositories: any;
private repositories: any;
@Inject()
rolesService: RolesService;
private rolesService: RolesService;
@Inject()
tenancy: HasTenancyService;
private tenancy: HasTenancyService;
@Inject()
eventPublisher: EventPublisher;
private eventPublisher: EventPublisher;
/**
* Creates a new user.
@@ -46,7 +43,7 @@ export default class UsersService {
authorizedUser: ISystemUser
): Promise<any> {
const { User } = this.tenancy.models(tenantId);
const { email, phoneNumber } = editUserDTO;
const { email } = editUserDTO;
// Retrieve the tenant user or throw not found service error.
const oldTenantUser = await this.getTenantUserOrThrowError(
@@ -62,9 +59,6 @@ export default class UsersService {
// Validate user email should be unique.
await this.validateUserEmailUniquiness(tenantId, email, userId);
// Validate user phone number should be unique.
await this.validateUserPhoneNumberUniqiness(tenantId, phoneNumber, userId);
// Retrieve the given role or throw not found service error.
const role = await this.rolesService.getRoleOrThrowError(
tenantId,
@@ -295,27 +289,6 @@ export default class UsersService {
}
};
/**
* Validate user phone number should be unique.
* @param {string} phoneNumber -
* @param {number} userId -
*/
private validateUserPhoneNumberUniqiness = async (
tenantId: number,
phoneNumber: string,
userId: number
) => {
const { User } = this.tenancy.models(tenantId);
const userByPhoneNumber = await User.query()
.findOne('phone_number', phoneNumber)
.whereNot('id', userId);
if (userByPhoneNumber) {
throw new ServiceError(ERRORS.PHONE_NUMBER_ALREADY_EXIST);
}
};
/**
* Validate the authorized user cannot mutate its role.
* @param {ITenantUser} oldTenantUser