QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-20 14:50:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Delete bank account with uncategorized transactions

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2024-08-18 14:20:23 +02:00
parent 4ba1c0aa22
commit fb8118bea8
8 changed files with 131 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/server/src/services/Banking/Rules/DeleteBankRule.ts
View File

@@ -26,7 +26,7 @@ export class DeleteBankRuleSerivce {
* @param {number} ruleId
* @returns {Promise<void>}
*/
public async deleteBankRule(tenantId: number, ruleId: number): Promise<void> {
public async deleteBankRule(tenantId: number, ruleId: number, trx?: Knex.Transaction): Promise<void> {
const { BankRule, BankRuleCondition } = this.tenancy.models(tenantId);
const oldBankRule = await BankRule.query()
@@ -51,6 +51,6 @@ export class DeleteBankRuleSerivce {
ruleId,
trx,
} as IBankRuleEventDeletedPayload);
});
}, trx);
}
}

26
packages/server/src/services/Banking/Rules/DeleteBankRules.ts Normal file
View File

@@ -0,0 +1,26 @@
import { Knex } from 'knex';
import { Inject, Service } from "typedi";
import PromisePool from "@supercharge/promise-pool";
import { castArray, uniq } from "lodash";
import { DeleteBankRuleSerivce } from "./DeleteBankRule";
@Service()
export class DeleteBankRulesService {
@Inject()
private deleteBankRuleService: DeleteBankRuleSerivce;
/**
* Delete bank rules.
* @param {number} tenantId
* @param {number | Array<number>} bankRuleId
*/
async deleteBankRules(tenantId: number, bankRuleId: number | Array<number>, trx?: Knex.Transaction) {
const bankRulesIds = uniq(castArray(bankRuleId));
await PromisePool.withConcurrency(1)
.for(bankRulesIds)
.process(async (bankRuleId: number) => {
await this.deleteBankRuleService.deleteBankRule(tenantId, bankRuleId, trx);
});
}
}