Compare commits

..

2 Commits

Author SHA1 Message Date
Ahmed Bouhuolia
c7871c6ed0 fix(webapp): use all drawers name from common enum object 2023-06-14 19:48:57 +02:00
Ahmed Bouhuolia
7ad1d3677c fix(webapp): Payment made details drawer does not show up 2023-06-14 13:13:32 +02:00
3 changed files with 5 additions and 8 deletions

View File

@@ -9,6 +9,7 @@ import events from '@/subscribers/events';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import { CommandExpenseValidator } from './CommandExpenseValidator'; import { CommandExpenseValidator } from './CommandExpenseValidator';
import { ExpenseCategory } from 'models';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
@Service() @Service()
@@ -36,7 +37,7 @@ export class DeleteExpense {
expenseId: number, expenseId: number,
authorizedUser: ISystemUser authorizedUser: ISystemUser
): Promise<void> => { ): Promise<void> => {
const { Expense, ExpenseCategory } = this.tenancy.models(tenantId); const { Expense } = this.tenancy.models(tenantId);
// Retrieves the expense transaction with associated entries or // Retrieves the expense transaction with associated entries or
// throw not found error. // throw not found error.
@@ -59,7 +60,7 @@ export class DeleteExpense {
} as IExpenseDeletingPayload); } as IExpenseDeletingPayload);
// Deletes expense associated entries. // Deletes expense associated entries.
await ExpenseCategory.query(trx).where('expenseId', expenseId).delete(); await ExpenseCategory.query(trx).findById(expenseId).delete();
// Deletes expense transactions. // Deletes expense transactions.
await Expense.query(trx).findById(expenseId).delete(); await Expense.query(trx).findById(expenseId).delete();

View File

@@ -46,7 +46,7 @@ export class ExpenseGLEntries {
...commonEntry, ...commonEntry,
credit: expense.localAmount, credit: expense.localAmount,
accountId: expense.paymentAccountId, accountId: expense.paymentAccountId,
accountNormal: AccountNormal.DEBIT, accountNormal: AccountNormal.CREDIT,
index: 1, index: 1,
}; };
}; };

View File

@@ -13,9 +13,9 @@ import {
import PaymentMadesEmptyStatus from './PaymentMadesEmptyStatus'; import PaymentMadesEmptyStatus from './PaymentMadesEmptyStatus';
import withPaymentMade from './withPaymentMade';
import withPaymentMadeActions from './withPaymentMadeActions'; import withPaymentMadeActions from './withPaymentMadeActions';
import withCurrentOrganization from '@/containers/Organization/withCurrentOrganization'; import withCurrentOrganization from '@/containers/Organization/withCurrentOrganization';
import withAlertsActions from '@/containers/Alert/withAlertActions'; import withAlertsActions from '@/containers/Alert/withAlertActions';
import withDrawerActions from '@/containers/Drawer/withDrawerActions'; import withDrawerActions from '@/containers/Drawer/withDrawerActions';
import withSettings from '@/containers/Settings/withSettings'; import withSettings from '@/containers/Settings/withSettings';
@@ -32,9 +32,6 @@ function PaymentMadesTable({
// #withPaymentMadeActions // #withPaymentMadeActions
setPaymentMadesTableState, setPaymentMadesTableState,
// #withPaymentMade
paymentMadesTableState,
// #withAlerts // #withAlerts
openAlert, openAlert,
@@ -134,7 +131,6 @@ function PaymentMadesTable({
export default compose( export default compose(
withPaymentMadeActions, withPaymentMadeActions,
withPaymentMade(({ paymentMadesTableState }) => ({ paymentMadesTableState })),
withAlertsActions, withAlertsActions,
withDrawerActions, withDrawerActions,
withCurrentOrganization(), withCurrentOrganization(),