chore: remove /data directory from git ignored dirs

fix(server): date format of filtering transactions by date range

.gitignore

@@ -1,4 +1,9 @@
 node_modules/
-data
+
+# Docker volumes data directory
+/data
+
+# Production env file 
 .env
+
 test-results/

CHANGELOG.md

@@ -2,6 +2,20 @@
 
 All notable changes to Bigcapital server-side will be in this file.
 
+# [0.9.12] - 29-08-2023
+
+* Refactor: split the services to multiple service classes. (by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/202)
+* Fix: create quick customer/vendor by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/206
+* Fix: typo in bill success message without bill number by @KalliopiPliogka in https://github.com/bigcapitalhq/bigcapital/pull/219
+* Fix: AP/AR aging summary issue by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/229
+* Fix: shouldn't write GL entries when save transaction as draft. by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/221
+* Fix: Transaction type of credit note and vendor credit are not defined on account transactions by @abouolia in 
+* Fix: date format of filtering transactions by date range by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/231
+* Fix: change the default from/date date value of reports by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/230
+* Fix: typos in words start with `A` letter by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/227
+* Fix: filter by customers, vendors and items in reports do not work by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/224
+https://github.com/bigcapitalhq/bigcapital/pull/225
+
 # [0.9.11] - 23-07-2023
 
 * added: Restart policy to docker compose files. by @suhaibaffan in https://github.com/bigcapitalhq/bigcapital/pull/198

packages/server/src/data/TransactionTypes.ts

@@ -0,0 +1,28 @@
+export const TransactionTypes = {
+  SaleInvoice: 'Sale invoice',
+  SaleReceipt: 'Sale receipt',
+  PaymentReceive: 'Payment receive',
+  Bill: 'Bill',
+  BillPayment: 'Payment made',
+  VendorOpeningBalance: 'Vendor opening balance',
+  CustomerOpeningBalance: 'Customer opening balance',
+  InventoryAdjustment: 'Inventory adjustment',
+  ManualJournal: 'Manual journal',
+  Journal: 'Manual journal',
+  Expense: 'Expense',
+  OwnerContribution: 'Owner contribution',
+  TransferToAccount: 'Transfer to account',
+  TransferFromAccount: 'Transfer from account',
+  OtherIncome: 'Other income',
+  OtherExpense: 'Other expense',
+  OwnerDrawing: 'Owner drawing',
+  InvoiceWriteOff: 'Invoice write-off',
+
+  CreditNote: 'transaction_type.credit_note',
+  VendorCredit: 'transaction_type.vendor_credit',
+
+  RefundCreditNote: 'transaction_type.refund_credit_note',
+  RefundVendorCredit: 'transaction_type.refund_vendor_credit',
+
+  LandedCost: 'transaction_type.landed_cost',
+};

packages/server/src/models/AccountTransaction.ts

@@ -59,15 +59,9 @@ export default class AccountTransaction extends TenantModel {
         }
       },
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
+        const dateFormat = 'YYYY-MM-DD';
-        const fromDate = moment(startDate)
+        const fromDate = moment(startDate).startOf(type).format(dateFormat);
-          .utcOffset(0)
+        const toDate = moment(endDate).endOf(type).format(dateFormat);
-          .startOf(type)
-          .format(dateFormat);
-        const toDate = moment(endDate)
-          .utcOffset(0)
-          .endOf(type)
-          .format(dateFormat);
 
         if (startDate) {
           query.where('date', '>=', fromDate);
@@ -111,7 +105,6 @@ export default class AccountTransaction extends TenantModel {
         query.modify('filterDateRange', null, toDate);
         query.modify('sumationCreditDebit');
       },
-
       contactsOpeningBalance(
         query,
         openingDate,

packages/server/src/models/InventoryCostLotTracker.ts

@@ -33,7 +33,7 @@ export default class InventoryCostLotTracker extends TenantModel {
         query.groupBy('item_id');
       },
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
+        const dateFormat = 'YYYY-MM-DD';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/models/InventoryTransaction.ts

@@ -36,7 +36,7 @@ export default class InventoryTransaction extends TenantModel {
   static get modifiers() {
     return {
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
+        const dateFormat = 'YYYY-MM-DD';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/models/SaleInvoice.ts

@@ -176,7 +176,7 @@ export default class SaleInvoice extends mixin(TenantModel, [
        * Filters the invoices between the given date range.
        */
       filterDateRange(query, startDate, endDate, type = 'day') {
-        const dateFormat = 'YYYY-MM-DD HH:mm:ss';
+        const dateFormat = 'YYYY-MM-DD';
         const fromDate = moment(startDate).startOf(type).format(dateFormat);
         const toDate = moment(endDate).endOf(type).format(dateFormat);
 

packages/server/src/services/Cashflow/CommandCasflowValidator.ts

@@ -1,17 +1,12 @@
-import { Service, Inject } from 'typedi';
+import { Service } from 'typedi';
-import { includes, difference, camelCase, upperFirst } from 'lodash';
+import { includes, camelCase, upperFirst } from 'lodash';
-import { ACCOUNT_TYPE } from '@/data/AccountTypes';
+import { IAccount } from '@/interfaces';
-import { IAccount, ICashflowTransactionLine } from '@/interfaces';
 import { getCashflowTransactionType } from './utils';
 import { ServiceError } from '@/exceptions';
 import { CASHFLOW_TRANSACTION_TYPE, ERRORS } from './constants';
-import HasTenancyService from '@/services/Tenancy/TenancyService';
 
 @Service()
 export class CommandCashflowValidator {
-  @Inject()
-  private tenancy: HasTenancyService;
-
   /**
    * Validates the lines accounts type should be cash or bank account.
    * @param {IAccount} accounts -

packages/server/src/services/Cashflow/CommandCashflowTransaction.ts

@@ -1,14 +0,0 @@
-import { difference, includes } from 'lodash';
-import { ICashflowTransactionLine } from '@/interfaces';
-import { ServiceError } from '@/exceptions';
-import { Inject, Service } from 'typedi';
-import { CASHFLOW_TRANSACTION_TYPE, ERRORS } from './constants';
-import { IAccount } from '@/interfaces';
-import HasTenancyService from '@/services/Tenancy/TenancyService';
-
-@Service()
-export default class CommandCashflowTransaction {
-  @Inject()
-  private tenancy: HasTenancyService;
-
-}

packages/server/src/services/Items/DeleteItem.ts

@@ -9,13 +9,9 @@ import HasTenancyService from '@/services/Tenancy/TenancyService';
 import UnitOfWork from '@/services/UnitOfWork';
 import events from '@/subscribers/events';
 import { ERRORS } from './constants';
-import { ItemsValidators } from './ItemValidators';
 
 @Service()
 export class DeleteItem {
-  @Inject()
-  private validators: ItemsValidators;
-
   @Inject()
   private tenancy: HasTenancyService;
 

packages/server/src/services/Items/ItemsCostService.ts

@@ -1,5 +0,0 @@
-
-
-export default class ItemsCostService {
-  
-}