Compare commits

...

158 Commits

Author SHA1 Message Date
Ahmed Bouhuolia
d5bf56e333 Merge pull request #923 from bigcapitalhq/20260201-165255-f063
fix(server): copy .js migration files
2026-02-01 16:56:49 +02:00
Ahmed Bouhuolia
e3182c15b3 fix(server): copy .js migration files 2026-02-01 16:53:21 +02:00
Ahmed Bouhuolia
dfa63ece21 Merge pull request #921 from bigcapitalhq/20260131-145158-fd0c
fix(scripts): db migration dockerfile
2026-01-31 15:32:07 +02:00
Ahmed Bouhuolia
6e95bd7da1 fix(scripts): db migration dockerfile 2026-01-31 15:31:17 +02:00
Ahmed Bouhuolia
f51fffa5c7 Merge pull request #918 from bigcapitalhq/20260129-203653-75b0
feat(server): add bull ui board
2026-01-29 20:39:05 +02:00
Ahmed Bouhuolia
6193358cc3 feat(server): add bull ui board 2026-01-29 20:37:04 +02:00
Ahmed Bouhuolia
518abcd30d Merge pull request #917 from bigcapitalhq/20260128-195652-2287
fix: dockerfile build script
2026-01-28 23:42:24 +02:00
Ahmed Bouhuolia
7874b9f765 fix(ci): dockerfile build script 2026-01-28 23:40:32 +02:00
Ahmed Bouhuolia
02cc7e0c96 Merge pull request #916 from bigcapitalhq/20260128-181425-8b6a
fix(webapp): blueprintjs datetime version
2026-01-28 18:17:29 +02:00
Ahmed Bouhuolia
57cc513873 fix(webapp): blueprintjs datetime version 2026-01-28 18:14:44 +02:00
Ahmed Bouhuolia
f5bfdede30 Merge pull request #915 from bigcapitalhq/fix-vendor-customer-edit-opening-balance
fix(webapp): vendor/customer edit opening balance
2026-01-27 22:09:00 +02:00
Ahmed Bouhuolia
488556bb59 fix(webapp): vendor/customer edit opening balance 2026-01-27 22:06:57 +02:00
Ahmed Bouhuolia
0fc5a66e95 Merge pull request #914 from bigcapitalhq/fix-costable-inventory-transactions
fix(server): costable attr of inventory gl entries
2026-01-26 15:02:35 +02:00
Ahmed Bouhuolia
d9ae51027e fix(server): costable attr of inventory gl entries 2026-01-26 15:00:17 +02:00
Ahmed Bouhuolia
a92d6112d9 Merge pull request #913 from bigcapitalhq/feature/20260125222025
fix(server): sale receipt cost gl entries
2026-01-25 22:22:08 +02:00
Ahmed Bouhuolia
889b0cec4b fix(server): sale receipt cost gl entries 2026-01-25 22:20:28 +02:00
Ahmed Bouhuolia
1c4c41ebba Merge pull request #912 from bigcapitalhq/feature/20260125215941
fix(server): mark compute inventory cost flag
2026-01-25 22:02:13 +02:00
Ahmed Bouhuolia
421f0c26a7 fix(server): mark compute inventory cost flag 2026-01-25 21:59:44 +02:00
Ahmed Bouhuolia
f461cc221b Merge pull request #911 from bigcapitalhq/feature/20260125001703
fix(server): landed cost gl transactions
2026-01-25 00:19:07 +02:00
Ahmed Bouhuolia
acae75a912 fix(server): landed cost gl transactions 2026-01-25 00:17:14 +02:00
Ahmed Bouhuolia
b5a69971a9 Merge pull request #910 from bigcapitalhq/feature/20260123174320
fix(server): customer/vendor opening balance
2026-01-24 14:02:17 +02:00
Ahmed Bouhuolia
04d065b969 wip 2026-01-24 13:59:43 +02:00
Ahmed Bouhuolia
ca910ee489 fix(server): customer/vendor opening balance: 2026-01-23 17:43:22 +02:00
Ahmed Bouhuolia
e3cf6bf099 Merge pull request #908 from bigcapitalhq/feature/20260121133953
fix: bill response with entries
2026-01-21 13:40:53 +02:00
Ahmed Bouhuolia
6da7e8185c fix: bill response with entries 2026-01-21 13:39:56 +02:00
Ahmed Bouhuolia
785c49f2e6 Merge pull request #907 from bigcapitalhq/feature/20260121130702
hotbug(server): interceptors order
2026-01-21 13:08:18 +02:00
Ahmed Bouhuolia
d7331554ad hotbug(server): interceptors order 2026-01-21 13:07:03 +02:00
Ahmed Bouhuolia
78b1e9136a Merge pull request #897 from bigcapitalhq/more-e2e-test-cases
feat(server): more e2e test cases
2026-01-18 22:46:12 +02:00
Ahmed Bouhuolia
fea9bb5caa Merge remote-tracking branch 'refs/remotes/origin/more-e2e-test-cases' into more-e2e-test-cases 2026-01-18 22:44:17 +02:00
Ahmed Bouhuolia
db5caa138a wip 2026-01-18 22:43:54 +02:00
Ahmed Bouhuolia
bf821885c0 Merge branch 'develop' into more-e2e-test-cases 2026-01-18 15:01:49 +02:00
Ahmed Bouhuolia
5ce5d8b899 Merge pull request #906 from bigcapitalhq/move-app-filters
fix(server): move global filters, pipes, and interceptors to AppModule
2026-01-18 15:00:58 +02:00
Ahmed Bouhuolia
458093fca2 fix(server): move global filters, pipes, and interceptors to AppModule 2026-01-18 14:59:20 +02:00
Ahmed Bouhuolia
97e17848f8 Merge pull request #905 from bigcapitalhq/pagination-darkmode
fix(webapp): pagination darkmode
2026-01-17 23:35:36 +02:00
Ahmed Bouhuolia
3dfe884413 fix(webapp): pagination darkmode 2026-01-17 23:33:10 +02:00
Ahmed Bouhuolia
f26a59f0fb Merge pull request #904 from bigcapitalhq/fix-landed-cost-dialog
fix: landed cost dialog
2026-01-17 21:45:23 +02:00
Ahmed Bouhuolia
7ee161733f fix: landed cost dialog 2026-01-17 21:42:27 +02:00
Ahmed Bouhuolia
4efc0b3eb4 Merge pull request #903 from bigcapitalhq/fix-cancel-invoice-written-off
fix(webapp): cancel the written-off invoice
2026-01-16 19:10:26 +02:00
Ahmed Bouhuolia
532aa07e7f fix(webapp): cancel the written-off invoice 2026-01-16 19:08:07 +02:00
Ahmed Bouhuolia
abacb543c7 Merge pull request #902 from bigcapitalhq/fix-bank-transactions-unexclude2
fix(webapp): unexclude bank transactions
2026-01-16 18:54:36 +02:00
Ahmed Bouhuolia
769eaebc76 fix(webapp): unexclude bank transactions 2026-01-16 18:52:12 +02:00
Ahmed Bouhuolia
e0fb345a48 fix: improve banking transaction exclude/unexclude logic 2026-01-16 18:49:27 +02:00
Ahmed Bouhuolia
c21301061f wip 2026-01-16 00:23:16 +02:00
Ahmed Bouhuolia
2bbc154f18 wip 2026-01-15 22:04:51 +02:00
Ahmed Bouhuolia
3c1273becb wip 2026-01-12 01:04:28 +02:00
Ahmed Bouhuolia
16f1d57279 feat(server): more e2e test cases 2026-01-10 01:01:41 +02:00
Ahmed Bouhuolia
8726b4b3b0 Merge pull request #896 from bigcapitalhq/fix-server-build
fix(server): Dockerfile
2026-01-09 23:40:19 +02:00
Ahmed Bouhuolia
5ace03ea99 fix(server): Dockerfile 2026-01-09 23:38:52 +02:00
Ahmed Bouhuolia
5b6c473780 Merge pull request #895 from bigcapitalhq/fix-bank-accounts-filter
fix(server): bank accounts filter
2026-01-09 20:02:36 +02:00
Ahmed Bouhuolia
2186828516 fix(server): bank accounts filter 2026-01-09 20:00:44 +02:00
Ahmed Bouhuolia
3f2ab6e8f0 feat(webapp): add socket to vite server proxy 2026-01-08 22:43:42 +02:00
Ahmed Bouhuolia
f0fae7d148 Merge pull request #894 from bigcapitalhq/fix-refund-credit-notes
fix(server): refund credit note gl entries
2026-01-08 00:29:47 +02:00
Ahmed Bouhuolia
e063597a80 fix(server): refund credit note gl entries 2026-01-08 00:27:43 +02:00
Ahmed Bouhuolia
9b3f6b22d1 Merge pull request #893 from bigcapitalhq/bugs-bashing-3
fix: bugs bashing
2026-01-04 01:27:19 +02:00
Ahmed Bouhuolia
0475ce136a fix: bugs bashing
- Added English translations for customer types in `customer.json`.
- Updated `Model.ts` to improve deletion logic by filtering dependent relations.
- Introduced `BillPaymentBillSyncSubscriber` to handle bill payment events.
- Enhanced `CreateBillPaymentService` and `EditBillPaymentService` to fetch entries after insertion/updating.
- Updated `SaleInvoiceCostGLEntries` to include item entry details in GL entries.
- Refactored various components in the webapp for consistency in naming conventions.
2026-01-04 01:24:10 +02:00
Ahmed Bouhuolia
987ad992a4 Merge pull request #892 from bigcapitalhq/darkmode-ui-bugs
fix: darkmode ui bugs
2026-01-03 18:26:21 +02:00
Ahmed Bouhuolia
ee92c2815b fix: darkmode ui bugs 2026-01-03 18:24:33 +02:00
Ahmed Bouhuolia
5767f1f603 Merge pull request #890 from bigcapitalhq/named-imports-hocs
fix: account transactions don't show up
2026-01-01 22:16:02 +02:00
Ahmed Bouhuolia
885d8014c2 fix: account transactions don't show up 2026-01-01 22:13:47 +02:00
Ahmed Bouhuolia
3ffab896ed Merge pull request #889 from bigcapitalhq/revert-888-named-imports-hocs
Revert "fix: account transactions don't show up"
2026-01-01 22:13:31 +02:00
Ahmed Bouhuolia
92a5086f1f Revert "fix: account transactions don't show up" 2026-01-01 22:13:08 +02:00
Ahmed Bouhuolia
1bf9038ddc Merge pull request #888 from bigcapitalhq/named-imports-hocs
fix: account transactions don't show up
2026-01-01 22:11:56 +02:00
Ahmed Bouhuolia
2736b76ced fix: account transactions don't show up 2026-01-01 22:09:51 +02:00
Ahmed Bouhuolia
9e921b074f Merge pull request #887 from bigcapitalhq/named-imports-hocs
refactor: HOCs named imports
2026-01-01 22:00:58 +02:00
Ahmed Bouhuolia
0f377e19f3 refactor: HOCs named imports 2026-01-01 21:58:42 +02:00
Ahmed Bouhuolia
5d872798ff Merge pull request #886 from bigcapitalhq/fix-credit-note-print
fix: credit note printing
2026-01-01 17:21:36 +02:00
Ahmed Bouhuolia
0ef78a19fe fix: credit note printing 2026-01-01 17:19:06 +02:00
Ahmed Bouhuolia
70b0a4833c Merge pull request #885 from bigcapitalhq/refund-credit-notes
fix: refund credit notes
2026-01-01 17:05:36 +02:00
Ahmed Bouhuolia
ead4fc9b97 fix: refund credit notes 2026-01-01 17:03:48 +02:00
Ahmed Bouhuolia
a91a7c612f Merge pull request #882 from bigcapitalhq/bugs-bashing2
Bug fixes, refactoring, and improvements
2025-12-31 01:01:08 +02:00
Ahmed Bouhuolia
339289be9f refactor(export): move PDF table template to shared package 2025-12-29 23:54:43 +02:00
Ahmed Bouhuolia
350d229e98 feat(transactions-locking): enable settings schema and add dark mode support 2025-12-29 23:35:34 +02:00
Ahmed Bouhuolia
8152a16fd5 Merge pull request #881 from bigcapitalhq/bugs-bashing
bugs bashing
2025-12-29 22:08:56 +02:00
Ahmed Bouhuolia
00aad6e35c wip 2025-12-29 22:06:49 +02:00
Ahmed Bouhuolia
30d8fdb4c0 fix: running compute item cost processor 2025-12-28 12:30:06 +02:00
Ahmed Bouhuolia
872fc661ce bugs bashing 2025-12-28 12:01:24 +02:00
Ahmed Bouhuolia
054cd1fae4 Merge pull request #880 from bigcapitalhq/fix-dark-mode-bank-transaction-drawer
fix: darkmode bank transaction drawer
2025-12-23 20:00:50 +02:00
Ahmed Bouhuolia
7cb169bce9 fix: darkmode bank transaction drawer 2025-12-23 19:57:31 +02:00
Ahmed Bouhuolia
f2663c4af3 Merge pull request #879 from bigcapitalhq/refactor-bound-formik-fields
refactor(webapp): bound Formik fields
2025-12-22 23:28:17 +02:00
Ahmed Bouhuolia
6fea7779da refactor(webapp): bound Formik fields 2025-12-22 23:25:43 +02:00
Ahmed Bouhuolia
c00af18327 Merge pull request #878 from bigcapitalhq/fix-match-bank-transactions
fix: match uncategorized bank transactions
2025-12-22 23:06:36 +02:00
Ahmed Bouhuolia
37f0f4e227 fix: match uncategorized bank transactions 2025-12-22 23:02:08 +02:00
Ahmed Bouhuolia
8662c5899e Merge pull request #877 from bigcapitalhq/fix-import-bank-transactions
fix: import bank transactions
2025-12-22 22:52:34 +02:00
Ahmed Bouhuolia
a9a7cd8617 fix: import bank transactions 2025-12-22 22:49:58 +02:00
Ahmed Bouhuolia
e50fc3b523 Merge pull request #876 from bigcapitalhq/refactor-date-input
refactor: date input field
2025-12-21 23:39:09 +02:00
Ahmed Bouhuolia
b294a72a26 refactor: date input field 2025-12-21 23:34:11 +02:00
Ahmed Bouhuolia
62ae49941b Merge pull request #875 from bigcapitalhq/fix-accounts-suggest-field
fix: accounts suggest field
2025-12-21 16:15:39 +02:00
Ahmed Bouhuolia
31f5cbf335 fix: accounts suggest field 2025-12-21 16:11:01 +02:00
Ahmed Bouhuolia
b22328cff9 Merge pull request #874 from bigcapitalhq/feature/20251218134811
fix: import module bugs
2025-12-18 21:25:34 +02:00
Ahmed Bouhuolia
58f609353c fix: import bugs 2025-12-18 21:21:54 +02:00
Ahmed Bouhuolia
8a2a8eed3b fix: import rows aggregator 2025-12-18 20:44:05 +02:00
Ahmed Bouhuolia
636d206b0e fix: bugs sprint 2025-12-18 13:48:12 +02:00
Ahmed Bouhuolia
63922c391a fix: formatted money attributes 2025-12-14 16:51:06 +02:00
Ahmed Bouhuolia
6ecfe1ff12 fix: remove the auth body background 2025-12-14 14:30:25 +02:00
Ahmed Bouhuolia
17651e0768 Merge pull request #871 from bigcapitalhq/fix-payment-link-base-url
fix: generated payment link base url
2025-12-14 13:29:09 +02:00
Ahmed Bouhuolia
151b623771 fix: generated payment link base url 2025-12-14 13:26:34 +02:00
Ahmed Bouhuolia
2d4459c2f9 fix: payment portal page 2025-12-14 13:06:44 +02:00
Ahmed Bouhuolia
3cbdc3ec96 Merge pull request #870 from bigcapitalhq/report-pdf-template
fix: reports pdf template
2025-12-12 23:42:02 +02:00
Ahmed Bouhuolia
3cfb5cdde8 fix: reports pdf template 2025-12-12 23:38:48 +02:00
Ahmed Bouhuolia
736f2c4109 Merge pull request #869 from bigcapitalhq/fix-passing-number-format-to-reports
fix: passing number format to reports
2025-12-11 00:25:57 +02:00
Ahmed Bouhuolia
2e21437056 fix: update pnpm-lock.yaml 2025-12-11 00:23:50 +02:00
Ahmed Bouhuolia
340b78d968 fix: passing number format to reports 2025-12-11 00:19:55 +02:00
Ahmed Bouhuolia
d006362be2 fix: transaction locking handling 2025-12-05 23:47:29 +02:00
Ahmed Bouhuolia
bc21dcb37e fix(webapp): add api key button 2025-12-05 15:14:31 +02:00
Ahmed Bouhuolia
578b0deb3e fix: sending mail jobs (#868) 2025-12-05 00:09:11 +02:00
Ahmed Bouhuolia
c3dc26a1e4 fix: sending mail jobs 2025-12-05 00:07:26 +02:00
Ahmed Bouhuolia
32d74b0413 feat: onboarding pages darkmode (#867) 2025-12-03 16:04:46 +02:00
allcontributors[bot]
71b1206f8a docs: add Daniel15 as a contributor for bug, and code (#865)
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2025-12-02 01:42:54 +02:00
Ahmed Bouhuolia
cb1bcaae77 Merge pull request #864 from Daniel15/patch-3
fix: Stripe integration
2025-12-02 01:41:04 +02:00
Ahmed Bouhuolia
eb51646035 fix: stripe payment webhooks 2025-12-02 01:26:58 +02:00
Ahmed Bouhuolia
8f54754aba feat: add stripe payment webhooks controller 2025-12-01 13:24:19 +02:00
Daniel Lo Nigro
0f446f90ca Change stripe_checkout_session to POST 2025-11-30 16:01:04 -08:00
Daniel Lo Nigro
7cb67b257b Cast payment_integration_id to number 2025-11-30 15:59:29 -08:00
Daniel Lo Nigro
0a1fffb3a4 Correctly register PaymentIntegration as tenant model 2025-11-30 15:52:07 -08:00
Daniel Lo Nigro
b756f090ed Fix Stripe redirect_uri 2025-11-30 15:50:42 -08:00
Daniel Lo Nigro
f9e49727fc Fix Stripe API URLs in webapp 2025-11-30 15:35:27 -08:00
Ahmed Bouhuolia
66969753b1 fix: seeds file-system directory 2025-11-30 22:59:48 +02:00
Ahmed Bouhuolia
3648fb3ffc fix: cloud subscription flag 2025-11-30 22:38:00 +02:00
Ahmed Bouhuolia
e196d485cf fix: filter pdf templates by resource 2025-11-26 22:25:42 +02:00
Ahmed Bouhuolia
74e46364ac feat: theme preloading and dark mode 2025-11-26 21:27:42 +02:00
Ahmed Bouhuolia
8817be4813 Merge remote-tracking branch 'refs/remotes/origin/develop' into develop 2025-11-25 23:46:51 +02:00
Ahmed Bouhuolia
cd4816aa3b fix: printing sale receipts 2025-11-25 23:46:41 +02:00
Ahmed Bouhuolia
82a2c74182 Merge pull request #859 from bigcapitalhq/rate-quantity-must-be-required
fix: rate and quantity of entries must not be empty
2025-11-25 22:03:25 +02:00
Ahmed Bouhuolia
e231efb9de fix: rate and quantity of entries must not be empty 2025-11-25 22:02:09 +02:00
Ahmed Bouhuolia
65ffc31ec0 Merge pull request #858 from bigcapitalhq/migrate-from-cra-to-vite
feat: migrate from CRA to Vite for speed
2025-11-25 21:36:28 +02:00
Ahmed Bouhuolia
dc6cf13a3e fix: wdyr error with vite 2025-11-25 21:34:17 +02:00
Ahmed Bouhuolia
adfa8852db wip 2025-11-25 21:29:32 +02:00
Ahmed Bouhuolia
ff04c4b762 wip 2025-11-24 18:58:50 +02:00
Ahmed Bouhuolia
fe4bd88f9f wip 2025-11-24 14:58:58 +02:00
Ahmed Bouhuolia
caf232d928 feat: migrate from CRA to Vite for speed 2025-11-24 14:19:05 +02:00
Ahmed Bouhuolia
234b1804b3 Merge pull request #855 from Daniel15/Daniel15-patch-1
Update commands in contributing docs
2025-11-21 11:25:29 +02:00
Daniel Lo Nigro
98b3b551c1 Update commands in contributing docs 2025-11-20 21:08:40 -08:00
Ahmed Bouhuolia
ceed9e453f feat: bulk transcations delete (#844)
* feat: bulk transcations delete
2025-11-20 23:11:06 +02:00
Ahmed Bouhuolia
43faa45dcf wip 2025-11-20 23:06:35 +02:00
Ahmed Bouhuolia
56e00d254b wip 2025-11-20 17:41:16 +02:00
Ahmed Bouhuolia
d90b6ffbe7 wip 2025-11-19 23:42:06 +02:00
Ahmed Bouhuolia
5eafd23bf8 wip 2025-11-19 22:59:30 +02:00
Ahmed Bouhuolia
2b384b2f6f wip 2025-11-19 22:59:21 +02:00
Ahmed Bouhuolia
17bcc14231 wip 2025-11-17 22:26:33 +02:00
Ahmed Bouhuolia
2c64e1b8ab wip 2025-11-17 17:04:25 +02:00
Daniel Lo Nigro
6f50138260 Improve Stripe example (#851) 2025-11-17 14:23:51 +02:00
Andres Maqueo
0a7d687f91 fix: docker/redis/Dockerfile to reduce vulnerabilities (#845)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-DEBIAN10-SYSTEMD-3339153
- https://snyk.io/vuln/SNYK-DEBIAN10-SYSTEMD-3339153
- https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-2426310
- https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-2807585
- https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-1569403

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
2025-11-17 14:22:00 +02:00
Ahmed Bouhuolia
2383091b6e wip 2025-11-12 21:34:30 +02:00
Ahmed Bouhuolia
e2f5d4c66e Merge pull request #848 from Daniel15/patch-1
[docker] Change BANKING_CONNECT to BANK_FEED_ENABLED
2025-11-12 09:31:08 +02:00
Daniel Lo Nigro
ce70234ebd [docker] Change BANKING_CONNECT to BANK_FEED_ENABLED 2025-11-11 22:57:42 -08:00
Ahmed Bouhuolia
80abd1f66f fix: edit/create account 2025-11-07 22:20:06 +02:00
Ahmed Bouhuolia
a0bc9db9a6 feat: bulk transcations delete 2025-11-03 21:40:24 +02:00
Ahmed Bouhuolia
8161439365 Merge pull request #843 from bigcapitalhq/refactor-fast-fields
feat: refactor FastField fields to binded Formik fields
2025-11-03 00:29:26 +02:00
Ahmed Bouhuolia
46871c8113 feat: refactor FastField fields to binded Formik fields 2025-11-03 00:27:32 +02:00
Ahmed Bouhuolia
a4aee58f93 Merge pull request #842 from bigcapitalhq/fix-auto-increment-transactions
fix: auto increment serial transactions
2025-11-02 21:10:04 +02:00
Ahmed Bouhuolia
f64875404a fix: auto increment serial transactions 2025-11-02 21:08:28 +02:00
Ahmed Bouhuolia
cca116f6bb Merge pull request #841 from bigcapitalhq/only-inactive-accounts-filter
fix: only inactive accounts filter
2025-11-02 20:00:14 +02:00
Ahmed Bouhuolia
fdec94a3f7 fix: only inactive accounts filter 2025-11-02 19:58:26 +02:00
Ahmed Bouhuolia
c66299aacd feat: darkmode preferences screens (#840) 2025-11-02 17:01:52 +02:00
Ahmed Bouhuolia
77dc0778a3 feat: darkmode preferences screens 2025-11-02 16:43:47 +02:00
Ahmed Bouhuolia
a76445a6eb feat: api keys ui (#839)
* feat: api keys ui
2025-11-02 12:41:16 +02:00
Ahmed Bouhuolia
41143d8bbd feat: api endpoints throttle (#837)
* feat: api endpoints throttle
2025-10-30 22:06:05 +02:00
Ahmed Bouhuolia
844a050c9a Merge pull request #836 from bigcapitalhq/auth-pages-errors-handler
fix: auth pages errors handler
2025-10-30 19:29:41 +02:00
1367 changed files with 21447 additions and 15725 deletions

View File

@@ -168,6 +168,16 @@
"contributions": [ "contributions": [
"bug" "bug"
] ]
},
{
"login": "Daniel15",
"name": "Daniel Lo Nigro",
"avatar_url": "https://avatars.githubusercontent.com/u/91933?v=4",
"profile": "https://d.sb/",
"contributions": [
"bug",
"code"
]
} }
], ],
"contributorsPerLine": 7, "contributorsPerLine": 7,

93
.dockerignore Normal file
View File

@@ -0,0 +1,93 @@
# Dependencies
node_modules/
**/node_modules/
.pnpm-store/
# Build outputs
dist/
build/
**/dist/
**/build/
*.tsbuildinfo
# Development files
.git/
.gitignore
.vscode/
.idea/
*.swp
*.swo
*~
# Test files
test/
**/test/
**/*.spec.ts
**/*.test.ts
**/*.e2e-spec.ts
coverage/
.nyc_output/
test-results/
playwright-report/
# Documentation
*.md
!README.md
docs/
CHANGELOG.md
CONTRIBUTING.md
DISCLAIMER
LICENSE
# CI/CD
.github/
.gitpod.yml
# Environment files
.env
.env.*
!.env.example
# Logs
*.log
logs/
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
# OS files
.DS_Store
Thumbs.db
*.pid
*.seed
*.pid.lock
# Docker files (don't copy Dockerfiles into themselves)
docker-compose*.yml
Dockerfile*
.dockerignore
# Misc
.cache/
.temp/
tmp/
*.tmp
.qodo/
e2e/
playwright.config.ts
# Source maps (not needed in production)
*.map
# TypeScript configs (not needed at runtime)
tsconfig*.json
!tsconfig.json
# Linting/formatting
.eslintrc*
.prettierrc*
.eslintcache
# Package manager locks (we copy them explicitly)
# pnpm-lock.yaml

View File

@@ -35,17 +35,10 @@ TENANT_DB_NAME_PERFIX=bigcapital_tenant_
BASE_URL=http://example.com BASE_URL=http://example.com
JWT_SECRET=b0JDZW56RnV6aEthb0RGPXVEcUI JWT_SECRET=b0JDZW56RnV6aEthb0RGPXVEcUI
# Jobs MongoDB
MONGODB_DATABASE_URL=mongodb://localhost/bigcapital
# App proxy # App proxy
PUBLIC_PROXY_PORT=80 PUBLIC_PROXY_PORT=80
PUBLIC_PROXY_SSL_PORT=443 PUBLIC_PROXY_SSL_PORT=443
# Agendash
AGENDASH_AUTH_USER=agendash
AGENDASH_AUTH_PASSWORD=123123
# Sign-up restrictions # Sign-up restrictions
SIGNUP_DISABLED=false SIGNUP_DISABLED=false
SIGNUP_ALLOWED_DOMAINS= SIGNUP_ALLOWED_DOMAINS=
@@ -98,8 +91,18 @@ POSTHOG_API_KEY=
POSTHOG_HOST= POSTHOG_HOST=
# Stripe Payment # Stripe Payment
# Get the keys from the Stripe dashboard
# Starts with "sk_"
STRIPE_PAYMENT_SECRET_KEY= STRIPE_PAYMENT_SECRET_KEY=
# Starts with "pk_"
STRIPE_PAYMENT_PUBLISHABLE_KEY= STRIPE_PAYMENT_PUBLISHABLE_KEY=
# Get the client ID from https://dashboard.stripe.com/settings/connect/onboarding-options/oauth
# Starts with "ca_"
STRIPE_PAYMENT_CLIENT_ID= STRIPE_PAYMENT_CLIENT_ID=
# Configure the webhook here: https://dashboard.stripe.com/workbench/webhooks/
# Endpoint URL is https://example.com/api/webhooks/stripe (replace "example.com" with the correct domain)
# Select the "checkout.session.completed" and "account.updated" events
# Starts with "whsec_"
STRIPE_PAYMENT_WEBHOOKS_SECRET= STRIPE_PAYMENT_WEBHOOKS_SECRET=
STRIPE_PAYMENT_REDIRECT_URL= # Replace example.com with the correct domain
STRIPE_PAYMENT_REDIRECT_URL=https://example.com/preferences/payment-methods/stripe/callback

View File

@@ -54,7 +54,7 @@ pnpm install
- Run all required docker containers in the development, we already configured all containers under `docker-compose.yml`. - Run all required docker containers in the development, we already configured all containers under `docker-compose.yml`.
``` ```
docker-compose up -d docker compose up -d
``` ```
Wait some seconds, and hit `docker-compose ps` and you should see the same result below. Wait some seconds, and hit `docker-compose ps` and you should see the same result below.
@@ -75,7 +75,7 @@ pnpm run build:server
- Run the database migration for system database. - Run the database migration for system database.
``` ```
node packages/server/build/commands.js system:migrate:latest pnpm run system:migrate:latest
``` ```
And you should get something like that. And you should get something like that.
@@ -84,10 +84,10 @@ And you should get something like that.
Batch 1 run: 6 migrations Batch 1 run: 6 migrations
``` ```
- Next, start the webapp application. - Next, start the server.
``` ```
pnpm run dev:server pnpm run server:start
``` ```
**[`^top^`](#)** **[`^top^`](#)**
@@ -96,12 +96,6 @@ pnpm run dev:server
## Contribute to Frontend ## Contribute to Frontend
- Clone the `bigcapital` repository and cd into `bigcapital` directory.
```
git clone https://github.com/bigcapital/bigcapital.git && cd bigcaptial
```
- Install all npm dependencies of the monorepo, you don't have to change directory to the `frontend` package. just hit that command and will install all packages across all application. - Install all npm dependencies of the monorepo, you don't have to change directory to the `frontend` package. just hit that command and will install all packages across all application.
``` ```
@@ -138,4 +132,4 @@ There are many other ways to get involved with the community and to participate
Again, Feel free to ping us on [`#contributing`](https://discord.com/invite/c8nPBJafeb) on our Discord community if you need any help on this :) Again, Feel free to ping us on [`#contributing`](https://discord.com/invite/c8nPBJafeb) on our Discord community if you need any help on this :)
Thank You! Thank You!

View File

@@ -135,6 +135,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="https://myself.vercel.app/"><img src="https://avatars.githubusercontent.com/u/42431274?v=4?s=100" width="100px;" alt="Sachin Mittal"/><br /><sub><b>Sachin Mittal</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Amittalsam98" title="Bug reports">🐛</a></td> <td align="center" valign="top" width="14.28%"><a href="https://myself.vercel.app/"><img src="https://avatars.githubusercontent.com/u/42431274?v=4?s=100" width="100px;" alt="Sachin Mittal"/><br /><sub><b>Sachin Mittal</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Amittalsam98" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.camilooviedo.com/"><img src="https://avatars.githubusercontent.com/u/64604272?v=4?s=100" width="100px;" alt="Camilo Oviedo"/><br /><sub><b>Camilo Oviedo</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=Champetaman" title="Code">💻</a></td> <td align="center" valign="top" width="14.28%"><a href="https://www.camilooviedo.com/"><img src="https://avatars.githubusercontent.com/u/64604272?v=4?s=100" width="100px;" alt="Camilo Oviedo"/><br /><sub><b>Camilo Oviedo</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=Champetaman" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://nklmantey.com/"><img src="https://avatars.githubusercontent.com/u/90279429?v=4?s=100" width="100px;" alt="Mantey"/><br /><sub><b>Mantey</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Anklmantey" title="Bug reports">🐛</a></td> <td align="center" valign="top" width="14.28%"><a href="https://nklmantey.com/"><img src="https://avatars.githubusercontent.com/u/90279429?v=4?s=100" width="100px;" alt="Mantey"/><br /><sub><b>Mantey</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Anklmantey" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://d.sb/"><img src="https://avatars.githubusercontent.com/u/91933?v=4?s=100" width="100px;" alt="Daniel Lo Nigro"/><br /><sub><b>Daniel Lo Nigro</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3ADaniel15" title="Bug reports">🐛</a> <a href="https://github.com/bigcapitalhq/bigcapital/commits?author=Daniel15" title="Code">💻</a></td>
</tr> </tr>
</tbody> </tbody>
</table> </table>

View File

@@ -32,11 +32,9 @@ services:
- '3000' - '3000'
links: links:
- mysql - mysql
- mongo
- redis - redis
depends_on: depends_on:
- mysql - mysql
- mongo
- redis - redis
restart: on-failure restart: on-failure
networks: networks:
@@ -60,22 +58,21 @@ services:
# System database # System database
- SYSTEM_DB_NAME=${SYSTEM_DB_NAME} - SYSTEM_DB_NAME=${SYSTEM_DB_NAME}
# Redis
- REDIS_HOST=redis
- REDIS_PORT=6379
- QUEUE_HOST=redis
- QUEUE_PORT=6379
# Tenants databases # Tenants databases
- TENANT_DB_NAME_PERFIX=${TENANT_DB_NAME_PERFIX} - TENANT_DB_NAME_PERFIX=${TENANT_DB_NAME_PERFIX}
# Authentication # Authentication
- JWT_SECRET=${JWT_SECRET} - JWT_SECRET=${JWT_SECRET}
# MongoDB
- MONGODB_DATABASE_URL=mongodb://mongo/bigcapital
# Application # Application
- BASE_URL=${BASE_URL} - BASE_URL=${BASE_URL}
# Agendash
- AGENDASH_AUTH_USER=${AGENDASH_AUTH_USER}
- AGENDASH_AUTH_PASSWORD=${AGENDASH_AUTH_PASSWORD}
# Sign-up restrictions # Sign-up restrictions
- SIGNUP_DISABLED=${SIGNUP_DISABLED} - SIGNUP_DISABLED=${SIGNUP_DISABLED}
- SIGNUP_ALLOWED_DOMAINS=${SIGNUP_ALLOWED_DOMAINS} - SIGNUP_ALLOWED_DOMAINS=${SIGNUP_ALLOWED_DOMAINS}
@@ -93,7 +90,7 @@ services:
- OPEN_EXCHANGE_RATE_APP_ID-${OPEN_EXCHANGE_RATE_APP_ID} - OPEN_EXCHANGE_RATE_APP_ID-${OPEN_EXCHANGE_RATE_APP_ID}
# Bank Sync # Bank Sync
- BANKING_CONNECT=${BANKING_CONNECT} - BANK_FEED_ENABLED=${BANK_FEED_ENABLED}
# Plaid # Plaid
- PLAID_ENV=${PLAID_ENV} - PLAID_ENV=${PLAID_ENV}
@@ -123,6 +120,13 @@ services:
- S3_ENDPOINT=${S3_ENDPOINT} - S3_ENDPOINT=${S3_ENDPOINT}
- S3_BUCKET=${S3_BUCKET} - S3_BUCKET=${S3_BUCKET}
# Stripe
- STRIPE_PAYMENT_SECRET_KEY=${STRIPE_PAYMENT_SECRET_KEY}
- STRIPE_PAYMENT_PUBLISHABLE_KEY=${STRIPE_PAYMENT_PUBLISHABLE_KEY}
- STRIPE_PAYMENT_CLIENT_ID=${STRIPE_PAYMENT_CLIENT_ID}
- STRIPE_PAYMENT_WEBHOOKS_SECRET=${STRIPE_PAYMENT_WEBHOOKS_SECRET}
- STRIPE_PAYMENT_REDIRECT_URL=${STRIPE_PAYMENT_REDIRECT_URL}
database_migration: database_migration:
container_name: bigcapital-database-migration container_name: bigcapital-database-migration
build: build:
@@ -159,17 +163,6 @@ services:
networks: networks:
- bigcapital_network - bigcapital_network
mongo:
container_name: bigcapital-mongo
restart: on-failure
build: ./docker/mongo
expose:
- '27017'
volumes:
- mongo:/var/lib/mongodb
networks:
- bigcapital_network
redis: redis:
container_name: bigcapital-redis container_name: bigcapital-redis
restart: on-failure restart: on-failure
@@ -195,10 +188,6 @@ volumes:
name: bigcapital_prod_mysql name: bigcapital_prod_mysql
driver: local driver: local
mongo:
name: bigcapital_prod_mongo
driver: local
redis: redis:
name: bigcapital_prod_redis name: bigcapital_prod_redis
driver: local driver: local

View File

@@ -24,25 +24,13 @@ services:
restart_policy: restart_policy:
condition: unless-stopped condition: unless-stopped
mongo:
build: ./docker/mongo
expose:
- '27017'
volumes:
- mongo:/var/lib/mongodb
ports:
- '27017:27017'
deploy:
restart_policy:
condition: unless-stopped
redis: redis:
build: build:
context: ./docker/redis context: ./docker/redis
expose: expose:
- "6379" - '6379'
ports: ports:
- "6379:6379" - '6379:6379'
volumes: volumes:
- redis:/data - redis:/data
deploy: deploy:
@@ -52,7 +40,7 @@ services:
gotenberg: gotenberg:
image: gotenberg/gotenberg:7 image: gotenberg/gotenberg:7
ports: ports:
- "9000:3000" - '9000:3000'
# Volumes # Volumes
volumes: volumes:
@@ -60,10 +48,6 @@ volumes:
name: bigcapital_dev_mysql name: bigcapital_dev_mysql
driver: local driver: local
mongo:
name: bigcapital_dev_mongo
driver: local
redis: redis:
name: bigcapital_dev_redis name: bigcapital_dev_redis
driver: local driver: local

View File

@@ -35,4 +35,4 @@ WORKDIR /app/packages/server
RUN git clone https://github.com/vishnubob/wait-for-it.git RUN git clone https://github.com/vishnubob/wait-for-it.git
# Once we listen the mysql port run the migration task. # Once we listen the mysql port run the migration task.
CMD ./wait-for-it/wait-for-it.sh mysql:3306 -- sh -c "node ./build/commands.js system:migrate:latest && node ./build/commands.js tenants:migrate:latest" CMD ./wait-for-it/wait-for-it.sh mysql:3306 -- sh -c "node dist/cli.js system:migrate:latest && node dist/cli.js tenants:migrate:latest"

View File

@@ -1 +0,0 @@
FROM mongo:5.0

View File

@@ -1,4 +1,4 @@
FROM redis:6.2.0 FROM redis:6.2.21
COPY redis.conf /usr/local/etc/redis/redis.conf COPY redis.conf /usr/local/etc/redis/redis.conf

View File

@@ -35,17 +35,10 @@ TENANT_DB_NAME_PERFIX=bigcapital_tenant_
BASE_URL=http://example.com BASE_URL=http://example.com
JWT_SECRET=b0JDZW56RnV6aEthb0RGPXVEcUI JWT_SECRET=b0JDZW56RnV6aEthb0RGPXVEcUI
# Jobs MongoDB
MONGODB_DATABASE_URL=mongodb://localhost/bigcapital
# App proxy # App proxy
PUBLIC_PROXY_PORT=80 PUBLIC_PROXY_PORT=80
PUBLIC_PROXY_SSL_PORT=443 PUBLIC_PROXY_SSL_PORT=443
# Agendash
AGENDASH_AUTH_USER=agendash
AGENDASH_AUTH_PASSWORD=123123
# Sign-up restrictions # Sign-up restrictions
SIGNUP_DISABLED=false SIGNUP_DISABLED=false
SIGNUP_ALLOWED_DOMAINS= SIGNUP_ALLOWED_DOMAINS=

102
packages/server/Dockerfile Normal file
View File

@@ -0,0 +1,102 @@
# Stage 1: Build
FROM node:18.16.0-alpine AS builder
WORKDIR /app
# Install pnpm
RUN npm install -g pnpm@8.10.2
# Install build dependencies
RUN apk add --no-cache python3 build-base chromium
# Set Python environment
ENV PYTHON=/usr/bin/python3
# Copy package files for dependency installation
COPY --chown=node:node package.json pnpm-lock.yaml pnpm-workspace.yaml lerna.json ./
COPY --chown=node:node packages/server/package.json ./packages/server/
COPY --chown=node:node shared/bigcapital-utils/package.json ./shared/bigcapital-utils/
COPY --chown=node:node shared/pdf-templates/package.json ./shared/pdf-templates/
COPY --chown=node:node shared/email-components/package.json ./shared/email-components/
# Install all dependencies (including devDependencies for build)
RUN pnpm install --frozen-lockfile
# Copy source code
COPY --chown=node:node ./packages/server ./packages/server
COPY --chown=node:node ./shared/bigcapital-utils ./shared/bigcapital-utils
COPY --chown=node:node ./shared/pdf-templates ./shared/pdf-templates
COPY --chown=node:node ./shared/email-components ./shared/email-components
# Build NestJS application
RUN pnpm run build:server --skip-nx-cache
# Stage 2: Production
FROM node:18.16.0-alpine AS production
WORKDIR /app
# Install pnpm for production
RUN npm install -g pnpm@8.10.2
# Create non-root user
RUN addgroup -g 1001 -S nodejs && \
adduser -S nodejs -u 1001
# Install build dependencies for native modules (bcrypt, etc.)
RUN apk add --no-cache python3 build-base
# Set Python environment
ENV PYTHON=/usr/bin/python3
# Copy package files for production dependency installation
COPY --chown=nodejs:nodejs package.json pnpm-lock.yaml pnpm-workspace.yaml ./
COPY --chown=nodejs:nodejs packages/server/package.json ./packages/server/
COPY --chown=nodejs:nodejs shared/bigcapital-utils/package.json ./shared/bigcapital-utils/
COPY --chown=nodejs:nodejs shared/pdf-templates/package.json ./shared/pdf-templates/
COPY --chown=nodejs:nodejs shared/email-components/package.json ./shared/email-components/
# Copy .husky directory (needed for husky install command)
COPY --chown=nodejs:nodejs .husky ./.husky
# Install only production dependencies
# Install husky temporarily so prepare script can run, then remove it
RUN pnpm add -D -w husky && \
pnpm install --prod --frozen-lockfile && \
pnpm remove -w husky && \
# Remove build dependencies to reduce image size
apk del python3 build-base
# Copy built application from builder stage
COPY --from=builder --chown=nodejs:nodejs /app/packages/server/dist ./packages/server/dist
# Copy static assets (i18n, public, static directories)
COPY --from=builder --chown=nodejs:nodejs /app/packages/server/src/i18n ./packages/server/dist/i18n
COPY --from=builder --chown=nodejs:nodejs /app/packages/server/public ./packages/server/public
COPY --from=builder --chown=nodejs:nodejs /app/packages/server/static ./packages/server/static
# Copy database migration files (needed for running migrations)
COPY --from=builder --chown=nodejs:nodejs /app/packages/server/src/database ./packages/server/src/database
# Copy built shared packages (dist folders and package.json for module resolution)
COPY --from=builder --chown=nodejs:nodejs /app/shared/bigcapital-utils/dist ./shared/bigcapital-utils/dist
COPY --from=builder --chown=nodejs:nodejs /app/shared/pdf-templates/dist ./shared/pdf-templates/dist
COPY --from=builder --chown=nodejs:nodejs /app/shared/email-components/dist ./shared/email-components/dist
# Set runtime environment variables (these should be provided at runtime via docker-compose or k8s)
ENV NODE_ENV=production
ENV NEW_RELIC_NO_CONFIG_FILE=true
ENV PORT=3000
# Switch to non-root user
USER nodejs
# Expose port
EXPOSE 3000
# Health check - uses /api/system_db ping endpoint
HEALTHCHECK --interval=30s --timeout=3s --start-period=40s --retries=3 \
CMD node -e "require('http').get('http://localhost:3000/api/system_db', (r) => {process.exit(r.statusCode >= 200 && r.statusCode < 300 ? 0 : 1)}).on('error', () => process.exit(1))"
# Start the application
CMD [ "node", "packages/server/dist/main.js" ]

View File

@@ -2,10 +2,23 @@
"$schema": "https://json.schemastore.org/nest-cli", "$schema": "https://json.schemastore.org/nest-cli",
"collection": "@nestjs/schematics", "collection": "@nestjs/schematics",
"sourceRoot": "src", "sourceRoot": "src",
"entryFile": "main",
"compilerOptions": { "compilerOptions": {
"deleteOutDir": true, "deleteOutDir": true,
"assets": [ "assets": [
{ "include": "i18n/**/*", "watchAssets": true } { "include": "i18n/**/*", "watchAssets": true },
{ "include": "database/**/*", "exclude": "**/*.ts", "watchAssets": true }
] ]
},
"projects": {
"cli": {
"type": "application",
"root": "src",
"entryFile": "cli",
"sourceRoot": "src",
"compilerOptions": {
"tsConfigPath": "tsconfig.json"
}
}
} }
} }

View File

@@ -39,6 +39,10 @@
"@casl/ability": "^5.4.3", "@casl/ability": "^5.4.3",
"@lemonsqueezy/lemonsqueezy.js": "^2.2.0", "@lemonsqueezy/lemonsqueezy.js": "^2.2.0",
"@liaoliaots/nestjs-redis": "^10.0.0", "@liaoliaots/nestjs-redis": "^10.0.0",
"@nest-lab/throttler-storage-redis": "^1.1.0",
"@bull-board/api": "^5.22.0",
"@bull-board/express": "^5.22.0",
"@bull-board/nestjs": "^5.22.0",
"@nestjs/bull": "^10.2.1", "@nestjs/bull": "^10.2.1",
"@nestjs/bullmq": "^10.2.2", "@nestjs/bullmq": "^10.2.2",
"@nestjs/cache-manager": "^2.2.2", "@nestjs/cache-manager": "^2.2.2",
@@ -166,6 +170,9 @@
"**/*.(t|j)s" "**/*.(t|j)s"
], ],
"coverageDirectory": "../coverage", "coverageDirectory": "../coverage",
"testEnvironment": "node" "testEnvironment": "node",
"moduleNameMapper": {
"^@/(.*)$": "<rootDir>/$1"
}
} }
} }

View File

@@ -0,0 +1,5 @@
import { registerAs } from '@nestjs/config';
export default registerAs('app', () => ({
baseUrl: process.env.BASE_URL,
}));

View File

@@ -0,0 +1,8 @@
import { registerAs } from '@nestjs/config';
import { parseBoolean } from '@/utils/parse-boolean';
export default registerAs('bullBoard', () => ({
enabled: parseBoolean<boolean>(process.env.BULL_BOARD_ENABLED, false),
username: process.env.BULL_BOARD_USERNAME,
password: process.env.BULL_BOARD_PASSWORD,
}));

View File

@@ -0,0 +1,5 @@
import { registerAs } from '@nestjs/config';
export default registerAs('cloud', () => ({
hostedOnCloud: process.env.HOSTED_ON_BIGCAPITAL_CLOUD === 'true',
}));

View File

@@ -1,3 +1,4 @@
import app from './app';
import systemDatabase from './system-database'; import systemDatabase from './system-database';
import tenantDatabase from './tenant-database'; import tenantDatabase from './tenant-database';
import signup from './signup'; import signup from './signup';
@@ -14,9 +15,16 @@ import jwt from './jwt';
import mail from './mail'; import mail from './mail';
import loops from './loops'; import loops from './loops';
import bankfeed from './bankfeed'; import bankfeed from './bankfeed';
import throttle from './throttle';
import cloud from './cloud';
import redis from './redis';
import queue from './queue';
import bullBoard from './bull-board';
export const config = [ export const config = [
app,
systemDatabase, systemDatabase,
cloud,
tenantDatabase, tenantDatabase,
signup, signup,
gotenberg, gotenberg,
@@ -32,4 +40,8 @@ export const config = [
mail, mail,
loops, loops,
bankfeed, bankfeed,
throttle,
redis,
queue,
bullBoard,
]; ];

View File

@@ -0,0 +1,6 @@
import { registerAs } from '@nestjs/config';
export default registerAs('queue', () => ({
host: process.env.QUEUE_HOST || 'localhost',
port: parseInt(process.env.QUEUE_PORT, 10) || 6379,
}));

View File

@@ -0,0 +1,14 @@
import { registerAs } from '@nestjs/config';
export default registerAs('throttle', () => ({
global: {
ttl: parseInt(process.env.THROTTLE_GLOBAL_TTL ?? '60000', 10),
limit: parseInt(process.env.THROTTLE_GLOBAL_LIMIT ?? '100', 10),
},
auth: {
ttl: parseInt(process.env.THROTTLE_AUTH_TTL ?? '60000', 10),
limit: parseInt(process.env.THROTTLE_AUTH_LIMIT ?? '10', 10),
},
}));

View File

@@ -0,0 +1,55 @@
import { IsArray, IsInt, ArrayNotEmpty, IsBoolean, IsOptional } from 'class-validator';
import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
import { Transform } from 'class-transformer';
import { parseBoolean } from '@/utils/parse-boolean';
export class BulkDeleteDto {
@IsArray()
@ArrayNotEmpty()
@IsInt({ each: true })
@ApiProperty({
description: 'Array of IDs to delete',
type: [Number],
example: [1, 2, 3],
})
ids: number[];
@IsOptional()
@IsBoolean()
@Transform(({ value, obj }) => parseBoolean(value ?? obj?.skip_undeletable, false))
@ApiPropertyOptional({
description: 'When true, undeletable items will be skipped and only deletable ones will be removed.',
type: Boolean,
default: false,
})
skipUndeletable?: boolean;
}
export class ValidateBulkDeleteResponseDto {
@ApiProperty({
description: 'Number of items that can be deleted',
example: 2,
})
deletableCount: number;
@ApiProperty({
description: 'Number of items that cannot be deleted',
example: 1,
})
nonDeletableCount: number;
@ApiProperty({
description: 'IDs of items that can be deleted',
type: [Number],
example: [1, 2],
})
deletableIds: number[];
@ApiProperty({
description: 'IDs of items that cannot be deleted',
type: [Number],
example: [3],
})
nonDeletableIds: number[];
}

View File

@@ -7,53 +7,46 @@ import {
} from '@nestjs/common'; } from '@nestjs/common';
import { type Observable } from 'rxjs'; import { type Observable } from 'rxjs';
import { map } from 'rxjs/operators'; import { map } from 'rxjs/operators';
import { mapKeysDeep } from '@/utils/deepdash';
export function camelToSnake<T = any>(value: T) { export function camelToSnake<T = any>(value: T): T {
if (value === null || value === undefined) { if (value === null || value === undefined) {
return value; return value;
} }
if (Array.isArray(value)) { return mapKeysDeep(
return value.map(camelToSnake); value,
} (_value: string, key: any, parent: any, context: any) => {
if (typeof value === 'object' && !(value instanceof Date)) { if (Array.isArray(parent)) {
return Object.fromEntries( // tell mapKeysDeep to skip mapping inside this branch
Object.entries(value).map(([key, value]) => [ context.skipChildren = true;
key return key;
.split(/(?=[A-Z])/) }
.join('_') return key
.toLowerCase(), .split(/(?=[A-Z])/)
camelToSnake(value), .join('_')
]), .toLowerCase();
); },
} ) as T;
return value;
} }
export function snakeToCamel<T = any>(value: T) { export function snakeToCamel<T = any>(value: T): T {
if (value === null || value === undefined) { if (value === null || value === undefined) {
return value; return value;
} }
return mapKeysDeep(
if (Array.isArray(value)) { value,
return value.map(snakeToCamel); (_value: string, key: any, parent: any, context: any) => {
} if (Array.isArray(parent)) {
// tell mapKeysDeep to skip mapping inside this branch
const impl = (str: string) => { context.skipChildren = true;
const converted = str.replace(/([-_]\w)/g, (group) => return key;
group[1].toUpperCase(), }
); const converted = key.replace(/([-_]\w)/g, (group) =>
return converted[0].toLowerCase() + converted.slice(1); group[1].toUpperCase(),
}; );
return converted[0].toLowerCase() + converted.slice(1);
if (typeof value === 'object' && !(value instanceof Date)) { },
return Object.fromEntries( ) as T;
Object.entries(value).map(([key, value]) => [
impl(key),
snakeToCamel(value),
]),
);
}
return value;
} }
export const DEFAULT_STRATEGY = { export const DEFAULT_STRATEGY = {
@@ -63,7 +56,7 @@ export const DEFAULT_STRATEGY = {
@Injectable() @Injectable()
export class SerializeInterceptor implements NestInterceptor<any, any> { export class SerializeInterceptor implements NestInterceptor<any, any> {
constructor(@Optional() readonly strategy = DEFAULT_STRATEGY) {} constructor(@Optional() readonly strategy = DEFAULT_STRATEGY) { }
intercept( intercept(
context: ExecutionContext, context: ExecutionContext,

View File

@@ -5,15 +5,18 @@ import {
NestInterceptor, NestInterceptor,
} from '@nestjs/common'; } from '@nestjs/common';
import { Observable, map } from 'rxjs'; import { Observable, map } from 'rxjs';
import { mapValues, mapValuesDeep } from '@/utils/deepdash'; import { mapValuesDeep } from '@/utils/deepdash';
@Injectable() @Injectable()
export class ToJsonInterceptor implements NestInterceptor { export class ToJsonInterceptor implements NestInterceptor {
intercept(context: ExecutionContext, next: CallHandler): Observable<any> { intercept(context: ExecutionContext, next: CallHandler): Observable<any> {
return next.handle().pipe( return next.handle().pipe(
map((data) => { map((data) => {
if (data === null || data === undefined) {
return data;
}
return mapValuesDeep(data, (value) => { return mapValuesDeep(data, (value) => {
if (value && typeof value.toJSON === 'function') { if (value !== null && value !== undefined && typeof value.toJSON === 'function') {
return value.toJSON(); return value.toJSON();
} }
return value; return value;

View File

@@ -1,4 +1,27 @@
// import { getTransactionsLockingSettingsSchema } from '@/api/controllers/TransactionsLocking/utils'; import { chain, mapKeys } from 'lodash';
const getTransactionsLockingSettingsSchema = (modules: string[]) => {
const moduleSchema = {
active: { type: 'boolean' },
lock_to_date: { type: 'date' },
unlock_from_date: { type: 'date' },
unlock_to_date: { type: 'date' },
lock_reason: { type: 'string' },
unlock_reason: { type: 'string' },
};
return chain(modules)
.map((module: string) => {
return mapKeys(moduleSchema, (value, key: string) => `${module}.${key}`);
})
.flattenDeep()
.reduce((result, value) => {
return {
...result,
...value,
};
}, {})
.value();
};
export const SettingsOptions = { export const SettingsOptions = {
organization: { organization: {
@@ -223,12 +246,12 @@ export const SettingsOptions = {
'locking-type': { 'locking-type': {
type: 'string', type: 'string',
}, },
// ...getTransactionsLockingSettingsSchema([ ...getTransactionsLockingSettingsSchema([
// 'all', 'all',
// 'sales', 'sales',
// 'purchases', 'purchases',
// 'financial', 'financial',
// ]), ]),
}, },
features: { features: {
'multi-warehouses': { 'multi-warehouses': {

View File

@@ -0,0 +1,36 @@
/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.up = function (knex) {
return knex.schema.createTable('api_keys', (table) => {
table.increments();
table.string('key').notNullable().unique().index();
table.string('name');
table
.integer('user_id')
.unsigned()
.notNullable()
.index()
.references('id')
.inTable('users');
table
.bigInteger('tenant_id')
.unsigned()
.notNullable()
.index()
.references('id')
.inTable('tenants');
table.dateTime('expires_at').nullable().index();
table.dateTime('revoked_at').nullable().index();
table.timestamps();
});
};
/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.down = function (knex) {
return knex.schema.dropTableIfExists('api_keys');
};

View File

@@ -3,6 +3,7 @@
"field.description": "Description", "field.description": "Description",
"field.slug": "Account slug", "field.slug": "Account slug",
"field.code": "Account code", "field.code": "Account code",
"field.code_hint": "Unique number to identify the account.",
"field.root_type": "Root type", "field.root_type": "Root type",
"field.normal": "Account normal", "field.normal": "Account normal",
"field.normal.credit": "Credit", "field.normal.credit": "Credit",
@@ -13,5 +14,6 @@
"field.balance": "Balance", "field.balance": "Balance",
"field.bank_balance": "Bank Balance", "field.bank_balance": "Bank Balance",
"field.parent_account": "Parent Account", "field.parent_account": "Parent Account",
"field.created_at": "Created at" "field.created_at": "Created at",
"field.account_hint": "Matches the account name or code."
} }

View File

@@ -0,0 +1,30 @@
{
"field.vendor": "Vendor",
"field.bill_number": "Bill No.",
"field.bill_date": "Date",
"field.due_date": "Due Date",
"field.reference_no": "Reference No.",
"field.exchange_rate": "Exchange Rate",
"field.note": "Note",
"field.open": "Open",
"field.entries": "Entries",
"field.item": "Item",
"field.item_hint": "Matches the item name or code.",
"field.rate": "Rate",
"field.quantity": "Quantity",
"field.description": "Line Description",
"field.amount": "Amount",
"field.payment_amount": "Payment Amount",
"field.status": "Status",
"field.status.paid": "Paid",
"field.status.partially-paid": "Partially Paid",
"field.status.overdue": "Overdue",
"field.status.unpaid": "Unpaid",
"field.status.opened": "Opened",
"field.status.draft": "Draft",
"field.created_at": "Created At",
"allocation_method": "Allocation Method",
"allocation_method.quantity": "Quantity",
"allocation_method.value": "Valuation"
}

View File

@@ -0,0 +1,15 @@
{
"field.vendor": "Vendor",
"field.payment_date": "Payment Date",
"field.payment_number": "Payment No.",
"field.payment_account": "Payment Account",
"field.exchange_rate": "Exchange Rate",
"field.note": "Note",
"field.reference": "Reference",
"field.entries": "Entries",
"field.entries.bill": "Bill",
"field.entries.payment_amount": "Payment Amount",
"field.payment_number_hint": "The payment number should be unique.",
"field.bill_hint": "Matches the bill number."
}

View File

@@ -0,0 +1,16 @@
{
"field.customer": "Customer",
"field.exchange_rate": "Exchange Rate",
"field.credit_note_date": "Credit Note Date",
"field.reference_no": "Reference No.",
"field.note": "Note",
"field.terms_conditions": "Terms & Conditions",
"field.credit_note_number": "Credit Note Number",
"field.open": "Open",
"field.entries": "Entries",
"field.item": "Item",
"field.rate": "Rate",
"field.quantity": "Quantity",
"field.description": "Description"
}

View File

@@ -0,0 +1,5 @@
{
"type.business": "Business",
"type.individual": "Individual"
}

View File

@@ -0,0 +1,21 @@
{
"field.customer": "Customer",
"field.estimate_date": "Estimate Date",
"field.expiration_date": "Expiration Date",
"field.estimate_number": "Estimate No.",
"field.reference_no": "Reference No.",
"field.exchange_rate": "Exchange Rate",
"field.currency": "Currency",
"field.note": "Note",
"field.terms_conditions": "Terms & Conditions",
"field.delivered": "Delivered",
"field.entries": "Entries",
"field.amount": "Amount",
"field.status": "Status",
"field.status.draft": "Draft",
"field.status.delivered": "Delivered",
"field.status.rejected": "Rejected",
"field.status.approved": "Approved",
"field.created_at": "Created At"
}

View File

@@ -26,6 +26,7 @@
"field.due_amount": "Due amount", "field.due_amount": "Due amount",
"field.delivered": "Delivered", "field.delivered": "Delivered",
"field.item_name": "Item Name", "field.item_name": "Item Name",
"field.item_hint": "Matches the item name or code.",
"field.rate": "Rate", "field.rate": "Rate",
"field.quantity": "Quantity", "field.quantity": "Quantity",
"field.description": "Description", "field.description": "Description",
@@ -38,5 +39,7 @@
"field.status.draft": "Draft", "field.status.draft": "Draft",
"field.created_at": "Created at", "field.created_at": "Created at",
"field.currency": "Currency", "field.currency": "Currency",
"field.entries": "Entries" "field.entries": "Entries",
"field.branch": "Branch",
"field.warehouse": "Warehouse"
} }

View File

@@ -17,6 +17,7 @@
"field.quantity_on_hand": "Quantity on Hand", "field.quantity_on_hand": "Quantity on Hand",
"field.note": "Note", "field.note": "Note",
"field.category": "Category", "field.category": "Category",
"field.category_hint": "Matches the category name.",
"field.active": "Active", "field.active": "Active",
"field.created_at": "Created At" "field.created_at": "Created At"
} }

View File

@@ -0,0 +1,17 @@
{
"field.customer": "Customer",
"field.payment_date": "Payment Date",
"field.amount": "Amount",
"field.reference_no": "Reference No.",
"field.deposit_account": "Deposit Account",
"field.payment_receive_no": "Payment No.",
"field.statement": "Statement",
"field.entries": "Entries",
"field.exchange_rate": "Exchange Rate",
"field.invoice": "Invoice",
"field.entries.payment_amount": "Payment Amount",
"field.created_at": "Created At",
"field.payment_no_hint": "The payment number should be unique.",
"field.invoice_hint": "Matches the invoice number."
}

View File

@@ -10,5 +10,21 @@
"paper.receipt_amount": "Receipt amount", "paper.receipt_amount": "Receipt amount",
"paper.total": "Total", "paper.total": "Total",
"paper.balance_due": "Balance Due", "paper.balance_due": "Balance Due",
"paper.payment_amount": "Payment Amount" "paper.payment_amount": "Payment Amount",
"field.receipt_date": "Receipt Date",
"field.customer": "Customer",
"field.deposit_account": "Deposit Account",
"field.exchange_rate": "Exchange Rate",
"field.receipt_number": "Receipt Number",
"field.reference_no": "Reference No.",
"field.closed": "Closed",
"field.entries": "Entries",
"field.statement": "Statement",
"field.receipt_message": "Receipt Message",
"field.amount": "Amount",
"field.status": "Status",
"field.status.draft": "Draft",
"field.status.closed": "Closed",
"field.created_at": "Created At"
} }

View File

@@ -2,5 +2,18 @@
"view.draft": "Draft", "view.draft": "Draft",
"view.published": "Published", "view.published": "Published",
"view.open": "Open", "view.open": "Open",
"view.closed": "Closed" "view.closed": "Closed",
"field.vendor": "Vendor",
"field.vendor_credit_number": "Vendor Credit No.",
"field.vendor_credit_date": "Vendor Credit Date",
"field.reference_no": "Reference No.",
"field.exchange_rate": "Exchange Rate",
"field.note": "Note",
"field.open": "Open",
"field.entries": "Entries",
"field.item": "Item",
"field.rate": "Rate",
"field.quantity": "Quantity",
"field.description": "Description"
} }

View File

@@ -11,6 +11,7 @@ class FsMigrations {
private sortDirsSeparately: boolean; private sortDirsSeparately: boolean;
private migrationsPaths: string[]; private migrationsPaths: string[];
private loadExtensions: string[]; private loadExtensions: string[];
private seedsDirectory: string;
/** /**
* Constructor method. * Constructor method.
@@ -30,6 +31,8 @@ class FsMigrations {
} }
this.migrationsPaths = migrationDirectories; this.migrationsPaths = migrationDirectories;
this.loadExtensions = loadExtensions || DEFAULT_LOAD_EXTENSIONS; this.loadExtensions = loadExtensions || DEFAULT_LOAD_EXTENSIONS;
// Store the seeds directory (first path is the seeds directory)
this.seedsDirectory = migrationDirectories[0] || '';
} }
/** /**
@@ -93,7 +96,10 @@ class FsMigrations {
* @returns {string} * @returns {string}
*/ */
public getMigration(migration: MigrateItem): string { public getMigration(migration: MigrateItem): string {
return importWebpackSeedModule(migration.file.replace('.ts', '')); return importWebpackSeedModule(
migration.file.replace('.ts', ''),
this.seedsDirectory,
);
} }
} }

View File

@@ -1,5 +1,6 @@
// @ts-nocheck // @ts-nocheck
import * as fs from 'fs'; import * as fs from 'fs';
import * as path from 'path';
/** /**
* Detarmines the module type of the given file path. * Detarmines the module type of the given file path.
@@ -35,8 +36,32 @@ export async function importFile(filepath: string): any {
/** /**
* *
* @param {string} moduleName * @param {string} moduleName
* @param {string} seedsDirectory - The seeds directory path from config
* @returns * @returns
*/ */
export async function importWebpackSeedModule(moduleName: string): any { export async function importWebpackSeedModule(
return import(`../../database/seeds/core/${moduleName}`); moduleName: string,
seedsDirectory: string,
): any {
// Convert the seeds directory to a relative path from this file's location
const utilsDir = __dirname;
const seedsDirAbsolute = path.isAbsolute(seedsDirectory)
? seedsDirectory
: path.resolve(process.cwd(), seedsDirectory);
// Get relative path from Utils.js location to seeds directory
const relativePath = path.relative(utilsDir, seedsDirAbsolute);
// Convert to forward slashes for import (works on all platforms)
const importPath = relativePath.split(path.sep).join('/');
// Construct the import path (add ./ prefix if not already present, or handle empty/current dir)
let finalPath = importPath;
if (!finalPath || finalPath === '.') {
finalPath = './';
} else if (!finalPath.startsWith('.')) {
finalPath = `./${finalPath}`;
}
return import(`${finalPath}/${moduleName}`);
} }

View File

@@ -4,10 +4,7 @@ import { ClsMiddleware } from 'nestjs-cls';
import * as path from 'path'; import * as path from 'path';
import './utils/moment-mysql'; import './utils/moment-mysql';
import { AppModule } from './modules/App/App.module'; import { AppModule } from './modules/App/App.module';
import { ServiceErrorFilter } from './common/filters/service-error.filter'; import { NestExpressApplication } from '@nestjs/platform-express';
import { ModelHasRelationsFilter } from './common/filters/model-has-relations.filter';
import { ValidationPipe } from './common/pipes/ClassValidation.pipe';
import { ToJsonInterceptor } from './common/interceptors/to-json.interceptor';
global.__public_dirname = path.join(__dirname, '..', 'public'); global.__public_dirname = path.join(__dirname, '..', 'public');
global.__static_dirname = path.join(__dirname, '../static'); global.__static_dirname = path.join(__dirname, '../static');
@@ -15,17 +12,15 @@ global.__views_dirname = path.join(global.__static_dirname, '/views');
global.__images_dirname = path.join(global.__static_dirname, '/images'); global.__images_dirname = path.join(global.__static_dirname, '/images');
async function bootstrap() { async function bootstrap() {
const app = await NestFactory.create(AppModule); const app = await NestFactory.create<NestExpressApplication>(AppModule, {
rawBody: true,
});
app.set('query parser', 'extended');
app.setGlobalPrefix('/api'); app.setGlobalPrefix('/api');
// create and mount the middleware manually here // create and mount the middleware manually here
app.use(new ClsMiddleware({}).use); app.use(new ClsMiddleware({}).use);
app.useGlobalInterceptors(new ToJsonInterceptor());
// use the validation pipe globally
app.useGlobalPipes(new ValidationPipe());
const config = new DocumentBuilder() const config = new DocumentBuilder()
.setTitle('Bigcapital') .setTitle('Bigcapital')
.setDescription('Financial accounting software') .setDescription('Financial accounting software')
@@ -35,9 +30,6 @@ async function bootstrap() {
const documentFactory = () => SwaggerModule.createDocument(app, config); const documentFactory = () => SwaggerModule.createDocument(app, config);
SwaggerModule.setup('swagger', app, documentFactory); SwaggerModule.setup('swagger', app, documentFactory);
app.useGlobalFilters(new ServiceErrorFilter());
app.useGlobalFilters(new ModelHasRelationsFilter());
await app.listen(process.env.PORT ?? 3000); await app.listen(process.env.PORT ?? 3000);
} }
bootstrap(); bootstrap();

View File

@@ -0,0 +1,59 @@
import { Request, Response, NextFunction } from 'express';
/**
* Creates Express middleware for the Bull Board UI:
* - When disabled: responds with 404.
* - When enabled and username/password are set: enforces HTTP Basic Auth (401 if invalid).
* - When enabled and credentials are not set: allows access (no auth).
*/
export function createBullBoardAuthMiddleware(
enabled: boolean,
username: string | undefined,
password: string | undefined,
): (req: Request, res: Response, next: NextFunction) => void {
return (req: Request, res: Response, next: NextFunction) => {
if (!enabled) {
res.status(404).send('Not Found');
return;
}
if (!username || !password) {
return next();
}
const authHeader = req.headers.authorization;
if (!authHeader || !authHeader.startsWith('Basic ')) {
res.setHeader('WWW-Authenticate', 'Basic realm="Bull Board"');
res.status(401).send('Authentication required');
return;
}
const base64Credentials = authHeader.slice(6);
let decoded: string;
try {
decoded = Buffer.from(base64Credentials, 'base64').toString('utf8');
} catch {
res.setHeader('WWW-Authenticate', 'Basic realm="Bull Board"');
res.status(401).send('Invalid credentials');
return;
}
const colonIndex = decoded.indexOf(':');
if (colonIndex === -1) {
res.setHeader('WWW-Authenticate', 'Basic realm="Bull Board"');
res.status(401).send('Invalid credentials');
return;
}
const reqUsername = decoded.slice(0, colonIndex);
const reqPassword = decoded.slice(colonIndex + 1);
if (reqUsername !== username || reqPassword !== password) {
res.setHeader('WWW-Authenticate', 'Basic realm="Bull Board"');
res.status(401).send('Invalid credentials');
return;
}
next();
};
}

View File

@@ -48,14 +48,30 @@ export class PaginationQueryBuilder<
// No relations defined // No relations defined
return this.delete(); return this.delete();
} }
// Only check HasManyRelation and ManyToManyRelation relations, as BelongsToOneRelation are just
// foreign key references and shouldn't prevent deletion. Only dependent records should block deletion.
const dependentRelationNames = relationNames.filter((name) => {
const relation = relationMappings[name];
return relation && (
relation.relation === Model.HasManyRelation ||
relation.relation === Model.ManyToManyRelation
);
});
if (dependentRelationNames.length === 0) {
// No dependent relations defined, safe to delete
return this.delete();
}
const recordQuery = this.clone(); const recordQuery = this.clone();
relationNames.forEach((relationName: string) => { dependentRelationNames.forEach((relationName: string) => {
recordQuery.withGraphFetched(relationName); recordQuery.withGraphFetched(relationName);
}); });
const record = await recordQuery; const record = await recordQuery;
const hasRelations = relationNames.some((name) => { const hasRelations = dependentRelationNames.some((name) => {
const val = record[name]; const val = record[name];
return Array.isArray(val) ? val.length > 0 : val != null; return Array.isArray(val) ? val.length > 0 : val != null;
}); });

View File

@@ -7,15 +7,17 @@ import {
Get, Get,
Query, Query,
ParseIntPipe, ParseIntPipe,
Put,
HttpCode,
} from '@nestjs/common'; } from '@nestjs/common';
import { AccountsApplication } from './AccountsApplication.service'; import { AccountsApplication } from './AccountsApplication.service';
import { CreateAccountDTO } from './CreateAccount.dto'; import { CreateAccountDTO } from './CreateAccount.dto';
import { EditAccountDTO } from './EditAccount.dto'; import { EditAccountDTO } from './EditAccount.dto';
import { IAccountsFilter } from './Accounts.types';
import { import {
ApiExtraModels, ApiExtraModels,
ApiOperation, ApiOperation,
ApiParam, ApiParam,
ApiQuery,
ApiResponse, ApiResponse,
ApiTags, ApiTags,
getSchemaPath, getSchemaPath,
@@ -24,16 +26,59 @@ import { AccountResponseDto } from './dtos/AccountResponse.dto';
import { AccountTypeResponseDto } from './dtos/AccountTypeResponse.dto'; import { AccountTypeResponseDto } from './dtos/AccountTypeResponse.dto';
import { GetAccountTransactionResponseDto } from './dtos/GetAccountTransactionResponse.dto'; import { GetAccountTransactionResponseDto } from './dtos/GetAccountTransactionResponse.dto';
import { GetAccountTransactionsQueryDto } from './dtos/GetAccountTransactionsQuery.dto'; import { GetAccountTransactionsQueryDto } from './dtos/GetAccountTransactionsQuery.dto';
import { GetAccountsQueryDto } from './dtos/GetAccountsQuery.dto';
import { ApiCommonHeaders } from '@/common/decorators/ApiCommonHeaders'; import { ApiCommonHeaders } from '@/common/decorators/ApiCommonHeaders';
import {
BulkDeleteDto,
ValidateBulkDeleteResponseDto,
} from '@/common/dtos/BulkDelete.dto';
@Controller('accounts') @Controller('accounts')
@ApiTags('Accounts') @ApiTags('Accounts')
@ApiExtraModels(AccountResponseDto) @ApiExtraModels(AccountResponseDto)
@ApiExtraModels(AccountTypeResponseDto) @ApiExtraModels(AccountTypeResponseDto)
@ApiExtraModels(GetAccountTransactionResponseDto) @ApiExtraModels(GetAccountTransactionResponseDto)
@ApiExtraModels(ValidateBulkDeleteResponseDto)
@ApiCommonHeaders() @ApiCommonHeaders()
export class AccountsController { export class AccountsController {
constructor(private readonly accountsApplication: AccountsApplication) {} constructor(private readonly accountsApplication: AccountsApplication) { }
@Post('validate-bulk-delete')
@HttpCode(200)
@ApiOperation({
summary:
'Validates which accounts can be deleted and returns counts of deletable and non-deletable accounts.',
})
@ApiResponse({
status: 200,
description:
'Validation completed. Returns counts and IDs of deletable and non-deletable accounts.',
schema: {
$ref: getSchemaPath(ValidateBulkDeleteResponseDto),
},
})
async validateBulkDeleteAccounts(
@Body() bulkDeleteDto: BulkDeleteDto,
): Promise<ValidateBulkDeleteResponseDto> {
return this.accountsApplication.validateBulkDeleteAccounts(
bulkDeleteDto.ids,
);
}
@Post('bulk-delete')
@HttpCode(200)
@ApiOperation({ summary: 'Deletes multiple accounts in bulk.' })
@ApiResponse({
status: 200,
description: 'The accounts have been successfully deleted.',
})
async bulkDeleteAccounts(
@Body() bulkDeleteDto: BulkDeleteDto,
): Promise<void> {
return this.accountsApplication.bulkDeleteAccounts(bulkDeleteDto.ids, {
skipUndeletable: bulkDeleteDto.skipUndeletable ?? false,
});
}
@Post() @Post()
@ApiOperation({ summary: 'Create an account' }) @ApiOperation({ summary: 'Create an account' })
@@ -45,7 +90,7 @@ export class AccountsController {
return this.accountsApplication.createAccount(accountDTO); return this.accountsApplication.createAccount(accountDTO);
} }
@Post(':id') @Put(':id')
@ApiOperation({ summary: 'Edit the given account.' }) @ApiOperation({ summary: 'Edit the given account.' })
@ApiResponse({ @ApiResponse({
status: 200, status: 200,
@@ -83,6 +128,7 @@ export class AccountsController {
} }
@Post(':id/activate') @Post(':id/activate')
@HttpCode(200)
@ApiOperation({ summary: 'Activate the given account.' }) @ApiOperation({ summary: 'Activate the given account.' })
@ApiResponse({ @ApiResponse({
status: 200, status: 200,
@@ -100,6 +146,7 @@ export class AccountsController {
} }
@Post(':id/inactivate') @Post(':id/inactivate')
@HttpCode(200)
@ApiOperation({ summary: 'Inactivate the given account.' }) @ApiOperation({ summary: 'Inactivate the given account.' })
@ApiResponse({ @ApiResponse({
status: 200, status: 200,
@@ -178,7 +225,19 @@ export class AccountsController {
items: { $ref: getSchemaPath(AccountResponseDto) }, items: { $ref: getSchemaPath(AccountResponseDto) },
}, },
}) })
async getAccounts(@Query() filter: Partial<IAccountsFilter>) { @ApiQuery({
name: 'onlyInactive',
required: false,
type: Boolean,
description: 'Filter to show only inactive accounts',
})
@ApiQuery({
name: 'structure',
required: false,
type: String,
description: 'Structure type for the accounts list',
})
async getAccounts(@Query() filter: GetAccountsQueryDto) {
return this.accountsApplication.getAccounts(filter); return this.accountsApplication.getAccounts(filter);
} }
} }

View File

@@ -19,6 +19,8 @@ import { GetAccountsService } from './GetAccounts.service';
import { DynamicListModule } from '../DynamicListing/DynamicList.module'; import { DynamicListModule } from '../DynamicListing/DynamicList.module';
import { AccountsExportable } from './AccountsExportable.service'; import { AccountsExportable } from './AccountsExportable.service';
import { AccountsImportable } from './AccountsImportable.service'; import { AccountsImportable } from './AccountsImportable.service';
import { BulkDeleteAccountsService } from './BulkDeleteAccounts.service';
import { ValidateBulkDeleteAccountsService } from './ValidateBulkDeleteAccounts.service';
const models = [RegisterTenancyModel(BankAccount)]; const models = [RegisterTenancyModel(BankAccount)];
@@ -40,7 +42,9 @@ const models = [RegisterTenancyModel(BankAccount)];
GetAccountTransactionsService, GetAccountTransactionsService,
GetAccountsService, GetAccountsService,
AccountsExportable, AccountsExportable,
AccountsImportable AccountsImportable,
BulkDeleteAccountsService,
ValidateBulkDeleteAccountsService,
], ],
exports: [ exports: [
AccountRepository, AccountRepository,

View File

@@ -10,10 +10,14 @@ import { GetAccount } from './GetAccount.service';
import { ActivateAccount } from './ActivateAccount.service'; import { ActivateAccount } from './ActivateAccount.service';
import { GetAccountTypesService } from './GetAccountTypes.service'; import { GetAccountTypesService } from './GetAccountTypes.service';
import { GetAccountTransactionsService } from './GetAccountTransactions.service'; import { GetAccountTransactionsService } from './GetAccountTransactions.service';
import { IAccountsFilter, IAccountsTransactionsFilter } from './Accounts.types'; import { IAccountsTransactionsFilter } from './Accounts.types';
import { GetAccountsService } from './GetAccounts.service'; import { GetAccountsService } from './GetAccounts.service';
import { IFilterMeta } from '@/interfaces/Model'; import { IFilterMeta } from '@/interfaces/Model';
import { GetAccountTransactionResponseDto } from './dtos/GetAccountTransactionResponse.dto'; import { GetAccountTransactionResponseDto } from './dtos/GetAccountTransactionResponse.dto';
import { GetAccountsQueryDto } from './dtos/GetAccountsQuery.dto';
import { BulkDeleteAccountsService } from './BulkDeleteAccounts.service';
import { ValidateBulkDeleteAccountsService } from './ValidateBulkDeleteAccounts.service';
import { ValidateBulkDeleteResponseDto } from '@/common/dtos/BulkDelete.dto';
@Injectable() @Injectable()
export class AccountsApplication { export class AccountsApplication {
@@ -36,7 +40,9 @@ export class AccountsApplication {
private readonly getAccountService: GetAccount, private readonly getAccountService: GetAccount,
private readonly getAccountTransactionsService: GetAccountTransactionsService, private readonly getAccountTransactionsService: GetAccountTransactionsService,
private readonly getAccountsService: GetAccountsService, private readonly getAccountsService: GetAccountsService,
) {} private readonly bulkDeleteAccountsService: BulkDeleteAccountsService,
private readonly validateBulkDeleteAccountsService: ValidateBulkDeleteAccountsService,
) { }
/** /**
* Creates a new account. * Creates a new account.
@@ -108,11 +114,11 @@ export class AccountsApplication {
/** /**
* Retrieves the accounts list. * Retrieves the accounts list.
* @param {IAccountsFilter} filterDTO - Filter DTO. * @param {GetAccountsQueryDto} filterDTO - Filter DTO.
* @returns {Promise<{ accounts: IAccountResponse[]; filterMeta: IFilterMeta }>} * @returns {Promise<{ accounts: IAccountResponse[]; filterMeta: IFilterMeta }>}
*/ */
public getAccounts = ( public getAccounts = (
filterDTO: Partial<IAccountsFilter>, filterDTO: GetAccountsQueryDto,
): Promise<{ accounts: Account[]; filterMeta: IFilterMeta }> => { ): Promise<{ accounts: Account[]; filterMeta: IFilterMeta }> => {
return this.getAccountsService.getAccountsList(filterDTO); return this.getAccountsService.getAccountsList(filterDTO);
}; };
@@ -127,4 +133,28 @@ export class AccountsApplication {
): Promise<Array<GetAccountTransactionResponseDto>> => { ): Promise<Array<GetAccountTransactionResponseDto>> => {
return this.getAccountTransactionsService.getAccountsTransactions(filter); return this.getAccountTransactionsService.getAccountsTransactions(filter);
}; };
/**
* Validates which accounts can be deleted in bulk.
*/
public validateBulkDeleteAccounts = (
accountIds: number[],
): Promise<ValidateBulkDeleteResponseDto> => {
return this.validateBulkDeleteAccountsService.validateBulkDeleteAccounts(
accountIds,
);
};
/**
* Deletes multiple accounts in bulk.
*/
public bulkDeleteAccounts = (
accountIds: number[],
options?: { skipUndeletable?: boolean },
): Promise<void> => {
return this.bulkDeleteAccountsService.bulkDeleteAccounts(
accountIds,
options,
);
};
} }

View File

@@ -0,0 +1,41 @@
import { Injectable } from '@nestjs/common';
import { Knex } from 'knex';
import { PromisePool } from '@supercharge/promise-pool';
import { castArray, uniq } from 'lodash';
import { DeleteAccount } from './DeleteAccount.service';
@Injectable()
export class BulkDeleteAccountsService {
constructor(private readonly deleteAccountService: DeleteAccount) { }
/**
* Deletes multiple accounts.
* @param {number | Array<number>} accountIds - The account id or ids.
* @param {Knex.Transaction} trx - The transaction.
*/
async bulkDeleteAccounts(
accountIds: number | Array<number>,
options?: { skipUndeletable?: boolean },
trx?: Knex.Transaction,
): Promise<void> {
const { skipUndeletable = false } = options ?? {};
const accountsIds = uniq(castArray(accountIds));
const results = await PromisePool.withConcurrency(1)
.for(accountsIds)
.process(async (accountId: number) => {
try {
await this.deleteAccountService.deleteAccount(accountId);
} catch (error) {
if (!skipUndeletable) {
throw error;
}
}
});
if (!skipUndeletable && results.errors && results.errors.length > 0) {
throw results.errors[0].raw;
}
}
}

View File

@@ -17,7 +17,7 @@ export class CommandAccountValidators {
@Inject(Account.name) @Inject(Account.name)
private readonly accountModel: TenantModelProxy<typeof Account>, private readonly accountModel: TenantModelProxy<typeof Account>,
private readonly accountRepository: AccountRepository, private readonly accountRepository: AccountRepository,
) {} ) { }
/** /**
* Throws error if the account was prefined. * Throws error if the account was prefined.
@@ -115,7 +115,7 @@ export class CommandAccountValidators {
accountName: string, accountName: string,
notAccountId?: number, notAccountId?: number,
) { ) {
const foundAccount = await this.accountModel const foundAccount = await this.accountModel()
.query() .query()
.findOne('name', accountName) .findOne('name', accountName)
.onBuild((query) => { .onBuild((query) => {

View File

@@ -1,7 +1,7 @@
import { IsOptional, ToNumber } from '@/common/decorators/Validators';
import { ApiProperty } from '@nestjs/swagger'; import { ApiProperty } from '@nestjs/swagger';
import { import {
IsString, IsString,
IsOptional,
IsInt, IsInt,
MinLength, MinLength,
MaxLength, MaxLength,
@@ -65,7 +65,7 @@ export class CreateAccountDTO {
description?: string; description?: string;
@IsOptional() @IsOptional()
@IsInt() @ToNumber()
@ApiProperty({ @ApiProperty({
description: 'ID of the parent account', description: 'ID of the parent account',
example: 1, example: 1,

View File

@@ -18,7 +18,7 @@ export class DeleteAccount {
private eventEmitter: EventEmitter2, private eventEmitter: EventEmitter2,
private uow: UnitOfWork, private uow: UnitOfWork,
private validator: CommandAccountValidators, private validator: CommandAccountValidators,
) {} ) { }
/** /**
* Authorize account delete. * Authorize account delete.
@@ -50,10 +50,17 @@ export class DeleteAccount {
/** /**
* Deletes the account from the storage. * Deletes the account from the storage.
* @param {number} accountId * @param {number} accountId
* @param {Knex.Transaction} trx - Database transaction instance.
*/ */
public deleteAccount = async (accountId: number): Promise<void> => { public deleteAccount = async (
accountId: number,
trx?: Knex.Transaction,
): Promise<void> => {
// Retrieve account or not found service error. // Retrieve account or not found service error.
const oldAccount = await this.accountModel().query().findById(accountId); const oldAccount = await this.accountModel()
.query()
.findById(accountId)
.throwIfNotFound();
// Authorize before delete account. // Authorize before delete account.
await this.authorize(accountId, oldAccount); await this.authorize(accountId, oldAccount);
@@ -82,6 +89,6 @@ export class DeleteAccount {
oldAccount, oldAccount,
trx, trx,
} as IAccountEventDeletedPayload); } as IAccountEventDeletedPayload);
}); }, trx);
}; };
} }

View File

@@ -1,11 +1,6 @@
import { IsString, MinLength, MaxLength } from 'class-validator';
import { ApiProperty } from '@nestjs/swagger'; import { ApiProperty } from '@nestjs/swagger';
import { import { IsOptional, ToNumber } from '@/common/decorators/Validators';
IsString,
IsOptional,
IsInt,
MinLength,
MaxLength,
} from 'class-validator';
export class EditAccountDTO { export class EditAccountDTO {
@IsString() @IsString()
@@ -45,7 +40,7 @@ export class EditAccountDTO {
description?: string; description?: string;
@IsOptional() @IsOptional()
@IsInt() @ToNumber()
@ApiProperty({ @ApiProperty({
description: 'The parent account ID of the account', description: 'The parent account ID of the account',
example: 1, example: 1,

View File

@@ -17,7 +17,7 @@ export class EditAccount {
@Inject(Account.name) @Inject(Account.name)
private readonly accountModel: TenantModelProxy<typeof Account>, private readonly accountModel: TenantModelProxy<typeof Account>,
) {} ) { }
/** /**
* Authorize the account editing. * Authorize the account editing.
@@ -85,8 +85,7 @@ export class EditAccount {
// Update the account on the storage. // Update the account on the storage.
const account = await this.accountModel() const account = await this.accountModel()
.query(trx) .query(trx)
.findById(accountId) .updateAndFetchById(accountId, { ...accountDTO });
.updateAndFetch({ ...accountDTO });
// Triggers `onAccountEdited` event. // Triggers `onAccountEdited` event.
// await this.eventEmitter.emitAsync(events.accounts.onEdited, { // await this.eventEmitter.emitAsync(events.accounts.onEdited, {

View File

@@ -8,6 +8,7 @@ import { Account } from './models/Account.model';
import { AccountRepository } from './repositories/Account.repository'; import { AccountRepository } from './repositories/Account.repository';
import { IFilterMeta } from '@/interfaces/Model'; import { IFilterMeta } from '@/interfaces/Model';
import { TenantModelProxy } from '../System/models/TenantBaseModel'; import { TenantModelProxy } from '../System/models/TenantBaseModel';
import { GetAccountsQueryDto } from './dtos/GetAccountsQuery.dto';
@Injectable() @Injectable()
export class GetAccountsService { export class GetAccountsService {
@@ -18,7 +19,7 @@ export class GetAccountsService {
@Inject(Account.name) @Inject(Account.name)
private readonly accountModel: TenantModelProxy<typeof Account>, private readonly accountModel: TenantModelProxy<typeof Account>,
) {} ) { }
/** /**
* Retrieve accounts datatable list. * Retrieve accounts datatable list.
@@ -26,12 +27,12 @@ export class GetAccountsService {
* @returns {Promise<{ accounts: IAccountResponse[]; filterMeta: IFilterMeta }>} * @returns {Promise<{ accounts: IAccountResponse[]; filterMeta: IFilterMeta }>}
*/ */
public async getAccountsList( public async getAccountsList(
filterDto: Partial<IAccountsFilter>, filterDto: Partial<GetAccountsQueryDto>,
): Promise<{ accounts: Account[]; filterMeta: IFilterMeta }> { ): Promise<{ accounts: Account[]; filterMeta: IFilterMeta }> {
const parsedFilterDto = { const parsedFilterDto = {
sortOrder: 'desc', sortOrder: 'desc',
columnSortBy: 'created_at', columnSortBy: 'created_at',
inactiveMode: false, onlyInactive: false,
structure: IAccountsStructureType.Tree, structure: IAccountsStructureType.Tree,
...filterDto, ...filterDto,
}; };
@@ -48,7 +49,7 @@ export class GetAccountsService {
.query() .query()
.onBuild((builder) => { .onBuild((builder) => {
dynamicList.buildQuery()(builder); dynamicList.buildQuery()(builder);
builder.modify('inactiveMode', filter.inactiveMode); builder.modify('inactiveMode', filterDto.onlyInactive);
}); });
const accountsGraph = await this.accountRepository.getDependencyGraph(); const accountsGraph = await this.accountRepository.getDependencyGraph();
@@ -58,7 +59,6 @@ export class GetAccountsService {
new AccountTransformer(), new AccountTransformer(),
{ accountsGraph, structure: parsedFilterDto.structure }, { accountsGraph, structure: parsedFilterDto.structure },
); );
return { return {
accounts: transformedAccounts, accounts: transformedAccounts,
filterMeta: dynamicList.getResponseMeta(), filterMeta: dynamicList.getResponseMeta(),

View File

@@ -0,0 +1,63 @@
import { Injectable, Inject } from '@nestjs/common';
import { Knex } from 'knex';
import { TENANCY_DB_CONNECTION } from '../Tenancy/TenancyDB/TenancyDB.constants';
import { DeleteAccount } from './DeleteAccount.service';
import { ModelHasRelationsError } from '@/common/exceptions/ModelHasRelations.exception';
@Injectable()
export class ValidateBulkDeleteAccountsService {
constructor(
private readonly deleteAccountService: DeleteAccount,
@Inject(TENANCY_DB_CONNECTION)
private readonly tenantKnex: () => Knex,
) {}
/**
* Validates which accounts from the provided IDs can be deleted.
* Uses the actual deleteAccount service to validate, ensuring the same validation logic.
* Uses a transaction that is always rolled back to ensure no database changes.
* @param {number[]} accountIds - Array of account IDs to validate
* @returns {Promise<{deletableCount: number, nonDeletableCount: number, deletableIds: number[], nonDeletableIds: number[]}>}
*/
public async validateBulkDeleteAccounts(accountIds: number[]): Promise<{
deletableCount: number;
nonDeletableCount: number;
deletableIds: number[];
nonDeletableIds: number[];
}> {
const trx = await this.tenantKnex().transaction({
isolationLevel: 'read uncommitted',
});
try {
const deletableIds: number[] = [];
const nonDeletableIds: number[] = [];
for (const accountId of accountIds) {
try {
await this.deleteAccountService.deleteAccount(accountId, trx);
deletableIds.push(accountId);
} catch (error) {
if (error instanceof ModelHasRelationsError) {
nonDeletableIds.push(accountId);
} else {
nonDeletableIds.push(accountId);
}
}
}
await trx.rollback();
return {
deletableCount: deletableIds.length,
nonDeletableCount: nonDeletableIds.length,
deletableIds,
nonDeletableIds,
};
} catch (error) {
await trx.rollback();
throw error;
}
}
}

View File

@@ -0,0 +1,27 @@
import { IsBoolean, IsEnum, IsOptional } from 'class-validator';
import { ApiPropertyOptional } from '@nestjs/swagger';
import { Transform } from 'class-transformer';
import { parseBoolean } from '@/utils/parse-boolean';
import { IAccountsStructureType } from '../Accounts.types';
export class GetAccountsQueryDto {
@ApiPropertyOptional({
type: Boolean,
description: 'Filter to show only inactive accounts',
default: false,
})
@IsOptional()
@IsBoolean()
@Transform(({ value }) => parseBoolean(value, false))
onlyInactive?: boolean;
@ApiPropertyOptional({
enum: IAccountsStructureType,
description: 'Structure type for the accounts list',
default: IAccountsStructureType.Tree,
})
@IsOptional()
@IsEnum(IAccountsStructureType)
structure?: IAccountsStructureType;
}

View File

@@ -156,7 +156,7 @@ export const AccountMeta = {
minLength: 3, minLength: 3,
maxLength: 6, maxLength: 6,
unique: true, unique: true,
importHint: 'Unique number to identify the account.', importHint: 'account.field.code_hint',
}, },
accountType: { accountType: {
name: 'account.field.type', name: 'account.field.type',

View File

@@ -33,6 +33,7 @@ export class AccountTransaction extends BaseModel {
public readonly userId!: number; public readonly userId!: number;
public readonly itemId!: number; public readonly itemId!: number;
public readonly projectId!: number; public readonly projectId!: number;
public readonly costable!: boolean;
public readonly account: Account; public readonly account: Account;
/** /**

View File

@@ -1,7 +1,7 @@
import { MiddlewareConsumer, Module, RequestMethod } from '@nestjs/common'; import { MiddlewareConsumer, Module, RequestMethod } from '@nestjs/common';
import { ConfigModule, ConfigService } from '@nestjs/config'; import { ConfigModule, ConfigService } from '@nestjs/config';
import { EventEmitterModule } from '@nestjs/event-emitter'; import { EventEmitterModule } from '@nestjs/event-emitter';
import { APP_INTERCEPTOR } from '@nestjs/core'; import { APP_GUARD, APP_INTERCEPTOR, APP_PIPE, APP_FILTER } from '@nestjs/core';
import { join } from 'path'; import { join } from 'path';
import { ServeStaticModule } from '@nestjs/serve-static'; import { ServeStaticModule } from '@nestjs/serve-static';
import { RedisModule } from '@liaoliaots/nestjs-redis'; import { RedisModule } from '@liaoliaots/nestjs-redis';
@@ -12,6 +12,9 @@ import {
I18nModule, I18nModule,
QueryResolver, QueryResolver,
} from 'nestjs-i18n'; } from 'nestjs-i18n';
import { BullBoardModule } from '@bull-board/nestjs';
import { ExpressAdapter } from '@bull-board/express';
import { createBullBoardAuthMiddleware } from '@/middleware/bull-board-auth.middleware';
import { BullModule } from '@nestjs/bullmq'; import { BullModule } from '@nestjs/bullmq';
import { ScheduleModule } from '@nestjs/schedule'; import { ScheduleModule } from '@nestjs/schedule';
import { PassportModule } from '@nestjs/passport'; import { PassportModule } from '@nestjs/passport';
@@ -36,6 +39,10 @@ import { PdfTemplatesModule } from '../PdfTemplate/PdfTemplates.module';
import { BranchesModule } from '../Branches/Branches.module'; import { BranchesModule } from '../Branches/Branches.module';
import { WarehousesModule } from '../Warehouses/Warehouses.module'; import { WarehousesModule } from '../Warehouses/Warehouses.module';
import { SerializeInterceptor } from '@/common/interceptors/serialize.interceptor'; import { SerializeInterceptor } from '@/common/interceptors/serialize.interceptor';
import { ToJsonInterceptor } from '@/common/interceptors/to-json.interceptor';
import { ValidationPipe } from '@/common/pipes/ClassValidation.pipe';
import { ServiceErrorFilter } from '@/common/filters/service-error.filter';
import { ModelHasRelationsFilter } from '@/common/filters/model-has-relations.filter';
import { ChromiumlyTenancyModule } from '../ChromiumlyTenancy/ChromiumlyTenancy.module'; import { ChromiumlyTenancyModule } from '../ChromiumlyTenancy/ChromiumlyTenancy.module';
import { CustomersModule } from '../Customers/Customers.module'; import { CustomersModule } from '../Customers/Customers.module';
import { VendorsModule } from '../Vendors/Vendors.module'; import { VendorsModule } from '../Vendors/Vendors.module';
@@ -95,6 +102,8 @@ import { BankingCategorizeModule } from '../BankingCategorize/BankingCategorize.
import { TenantModelsInitializeModule } from '../Tenancy/TenantModelsInitialize.module'; import { TenantModelsInitializeModule } from '../Tenancy/TenantModelsInitialize.module';
import { BillLandedCostsModule } from '../BillLandedCosts/BillLandedCosts.module'; import { BillLandedCostsModule } from '../BillLandedCosts/BillLandedCosts.module';
import { SocketModule } from '../Socket/Socket.module'; import { SocketModule } from '../Socket/Socket.module';
import { ThrottlerGuard } from '@nestjs/throttler';
import { AppThrottleModule } from './AppThrottle.module';
@Module({ @Module({
imports: [ imports: [
@@ -126,16 +135,35 @@ import { SocketModule } from '../Socket/Socket.module';
], ],
}), }),
PassportModule, PassportModule,
AppThrottleModule,
BullModule.forRootAsync({ BullModule.forRootAsync({
imports: [ConfigModule], imports: [ConfigModule],
useFactory: async (configService: ConfigService) => ({ useFactory: async (configService: ConfigService) => ({
connection: { connection: {
host: configService.get('QUEUE_HOST'), host: configService.get('queue.host'),
port: configService.get('QUEUE_PORT'), port: configService.get('queue.port'),
}, },
}), }),
inject: [ConfigService], inject: [ConfigService],
}), }),
BullBoardModule.forRootAsync({
imports: [ConfigModule],
useFactory: (configService: ConfigService) => {
const enabled = configService.get<boolean>('bullBoard.enabled');
const username = configService.get<string>('bullBoard.username');
const password = configService.get<string>('bullBoard.password');
return {
route: '/queues',
adapter: ExpressAdapter,
middleware: createBullBoardAuthMiddleware(
enabled,
username,
password,
),
};
},
inject: [ConfigService],
}),
ClsModule.forRoot({ ClsModule.forRoot({
global: true, global: true,
middleware: { middleware: {
@@ -151,8 +179,8 @@ import { SocketModule } from '../Socket/Socket.module';
imports: [ConfigModule], imports: [ConfigModule],
useFactory: (configService: ConfigService) => ({ useFactory: (configService: ConfigService) => ({
config: { config: {
host: configService.get('redis.host') || 'localhost', host: configService.get('redis.host'),
port: configService.get('redis.port') || 6379, port: configService.get('redis.port'),
}, },
}), }),
inject: [ConfigService], inject: [ConfigService],
@@ -231,10 +259,22 @@ import { SocketModule } from '../Socket/Socket.module';
], ],
controllers: [AppController], controllers: [AppController],
providers: [ providers: [
{
provide: APP_PIPE,
useClass: ValidationPipe,
},
{
provide: APP_GUARD,
useClass: ThrottlerGuard,
},
{ {
provide: APP_INTERCEPTOR, provide: APP_INTERCEPTOR,
useClass: SerializeInterceptor, useClass: SerializeInterceptor,
}, },
{
provide: APP_INTERCEPTOR,
useClass: ToJsonInterceptor,
},
{ {
provide: APP_INTERCEPTOR, provide: APP_INTERCEPTOR,
useClass: UserIpInterceptor, useClass: UserIpInterceptor,
@@ -243,6 +283,14 @@ import { SocketModule } from '../Socket/Socket.module';
provide: APP_INTERCEPTOR, provide: APP_INTERCEPTOR,
useClass: ExcludeNullInterceptor, useClass: ExcludeNullInterceptor,
}, },
{
provide: APP_FILTER,
useClass: ServiceErrorFilter,
},
{
provide: APP_FILTER,
useClass: ModelHasRelationsFilter,
},
AppService, AppService,
], ],
}) })

View File

@@ -0,0 +1,69 @@
import { Module } from '@nestjs/common';
import { ConfigModule, ConfigService } from '@nestjs/config';
import { ThrottlerModule } from '@nestjs/throttler';
import { ThrottlerStorageRedisService } from '@nest-lab/throttler-storage-redis';
@Module({
imports: [
ThrottlerModule.forRootAsync({
imports: [ConfigModule],
inject: [ConfigService],
useFactory: (configService: ConfigService) => {
// Use in-memory storage with very high limits for test environment
const isTest = process.env.NODE_ENV === 'test' || process.env.JEST_WORKER_ID !== undefined;
if (isTest) {
return {
throttlers: [
{
name: 'default',
ttl: 60000,
limit: 1000000, // Effectively disable throttling in tests
},
{
name: 'auth',
ttl: 60000,
limit: 1000000, // Effectively disable throttling in tests
},
],
// No storage specified = uses in-memory storage
};
}
const host = configService.get<string>('redis.host') || 'localhost';
const port = Number(configService.get<number>('redis.port') || 6379);
const password = configService.get<string>('redis.password');
const db = configService.get<number>('redis.db');
const globalTtl = configService.get<number>('throttle.global.ttl');
const globalLimit = configService.get<number>('throttle.global.limit');
const authTtl = configService.get<number>('throttle.auth.ttl');
const authLimit = configService.get<number>('throttle.auth.limit');
return {
throttlers: [
{
name: 'default',
ttl: globalTtl,
limit: globalLimit,
},
{
name: 'auth',
ttl: authTtl,
limit: authLimit,
},
],
storage: new ThrottlerStorageRedisService({
host,
port,
password,
db,
}),
};
},
}),
],
})
export class AppThrottleModule { }

View File

@@ -8,6 +8,7 @@ import {
Request, Request,
UseGuards, UseGuards,
} from '@nestjs/common'; } from '@nestjs/common';
import { Throttle } from '@nestjs/throttler';
import { import {
ApiTags, ApiTags,
ApiOperation, ApiOperation,
@@ -28,6 +29,7 @@ import { SystemUser } from '../System/models/SystemUser';
@ApiTags('Auth') @ApiTags('Auth')
@ApiExcludeController() @ApiExcludeController()
@PublicRoute() @PublicRoute()
@Throttle({ auth: {} })
export class AuthController { export class AuthController {
constructor( constructor(
private readonly authApp: AuthenticationApplication, private readonly authApp: AuthenticationApplication,

View File

@@ -17,6 +17,8 @@ import { PassportModule } from '@nestjs/passport';
import { APP_GUARD } from '@nestjs/core'; import { APP_GUARD } from '@nestjs/core';
import { JwtAuthGuard } from './guards/jwt.guard'; import { JwtAuthGuard } from './guards/jwt.guard';
import { AuthMailSubscriber } from './subscribers/AuthMail.subscriber'; import { AuthMailSubscriber } from './subscribers/AuthMail.subscriber';
import { BullBoardModule } from '@bull-board/nestjs';
import { BullMQAdapter } from '@bull-board/api/bullMQAdapter';
import { BullModule } from '@nestjs/bullmq'; import { BullModule } from '@nestjs/bullmq';
import { import {
SendResetPasswordMailQueue, SendResetPasswordMailQueue,
@@ -63,6 +65,14 @@ const models = [
TenancyModule, TenancyModule,
BullModule.registerQueue({ name: SendResetPasswordMailQueue }), BullModule.registerQueue({ name: SendResetPasswordMailQueue }),
BullModule.registerQueue({ name: SendSignupVerificationMailQueue }), BullModule.registerQueue({ name: SendSignupVerificationMailQueue }),
BullBoardModule.forFeature({
name: SendResetPasswordMailQueue,
adapter: BullMQAdapter,
}),
BullBoardModule.forFeature({
name: SendSignupVerificationMailQueue,
adapter: BullMQAdapter,
}),
], ],
exports: [...models], exports: [...models],
providers: [ providers: [
@@ -98,4 +108,4 @@ const models = [
AuthMailSubscriber, AuthMailSubscriber,
], ],
}) })
export class AuthModule { } export class AuthModule {}

View File

@@ -1,4 +1,4 @@
import { Controller, Post, Param, Get, Put } from '@nestjs/common'; import { Controller, Post, Param, Get, Put, Body } from '@nestjs/common';
import { GenerateApiKey } from './commands/GenerateApiKey.service'; import { GenerateApiKey } from './commands/GenerateApiKey.service';
import { GetApiKeysService } from './queries/GetApiKeys.service'; import { GetApiKeysService } from './queries/GetApiKeys.service';
import { import {
@@ -8,6 +8,8 @@ import {
ApiParam, ApiParam,
ApiExtraModels, ApiExtraModels,
getSchemaPath, getSchemaPath,
ApiBody,
ApiProperty,
} from '@nestjs/swagger'; } from '@nestjs/swagger';
import { ApiCommonHeaders } from '@/common/decorators/ApiCommonHeaders'; import { ApiCommonHeaders } from '@/common/decorators/ApiCommonHeaders';
import { import {
@@ -16,6 +18,20 @@ import {
ApiKeyListResponseDto, ApiKeyListResponseDto,
ApiKeyListItemDto, ApiKeyListItemDto,
} from './dtos/ApiKey.dto'; } from './dtos/ApiKey.dto';
import { IsString, MaxLength } from 'class-validator';
import { IsOptional } from '@/common/decorators/Validators';
class GenerateApiKeyDto {
@IsOptional()
@IsString()
@MaxLength(255)
@ApiProperty({
description: 'Optional name for the API key',
required: false,
example: 'My API Key',
})
name?: string;
}
@Controller('api-keys') @Controller('api-keys')
@ApiTags('Api keys') @ApiTags('Api keys')
@@ -29,17 +45,18 @@ export class AuthApiKeysController {
constructor( constructor(
private readonly getApiKeysService: GetApiKeysService, private readonly getApiKeysService: GetApiKeysService,
private readonly generateApiKeyService: GenerateApiKey, private readonly generateApiKeyService: GenerateApiKey,
) {} ) { }
@Post('generate') @Post('generate')
@ApiOperation({ summary: 'Generate a new API key' }) @ApiOperation({ summary: 'Generate a new API key' })
@ApiBody({ type: GenerateApiKeyDto })
@ApiResponse({ @ApiResponse({
status: 201, status: 201,
description: 'The generated API key', description: 'The generated API key',
type: ApiKeyResponseDto, type: ApiKeyResponseDto,
}) })
async generate() { async generate(@Body() body: GenerateApiKeyDto) {
return this.generateApiKeyService.generate(); return this.generateApiKeyService.generate(body.name);
} }
@Put(':id/revoke') @Put(':id/revoke')

View File

@@ -6,6 +6,7 @@ import {
} from '@nestjs/swagger'; } from '@nestjs/swagger';
import { GetAuthenticatedAccount } from './queries/GetAuthedAccount.service'; import { GetAuthenticatedAccount } from './queries/GetAuthedAccount.service';
import { Controller, Get, Post } from '@nestjs/common'; import { Controller, Get, Post } from '@nestjs/common';
import { Throttle } from '@nestjs/throttler';
import { IgnoreTenantSeededRoute } from '../Tenancy/EnsureTenantIsSeeded.guards'; import { IgnoreTenantSeededRoute } from '../Tenancy/EnsureTenantIsSeeded.guards';
import { IgnoreTenantInitializedRoute } from '../Tenancy/EnsureTenantIsInitialized.guard'; import { IgnoreTenantInitializedRoute } from '../Tenancy/EnsureTenantIsInitialized.guard';
import { AuthenticationApplication } from './AuthApplication.sevice'; import { AuthenticationApplication } from './AuthApplication.sevice';
@@ -18,11 +19,12 @@ import { IgnoreUserVerifiedRoute } from './guards/EnsureUserVerified.guard';
@IgnoreTenantSeededRoute() @IgnoreTenantSeededRoute()
@IgnoreTenantInitializedRoute() @IgnoreTenantInitializedRoute()
@IgnoreUserVerifiedRoute() @IgnoreUserVerifiedRoute()
@Throttle({ auth: {} })
export class AuthedController { export class AuthedController {
constructor( constructor(
private readonly getAuthedAccountService: GetAuthenticatedAccount, private readonly getAuthedAccountService: GetAuthenticatedAccount,
private readonly authApp: AuthenticationApplication, private readonly authApp: AuthenticationApplication,
) {} ) { }
@Post('/signup/verify/resend') @Post('/signup/verify/resend')
@ApiOperation({ summary: 'Resend the signup confirmation message' }) @ApiOperation({ summary: 'Resend the signup confirmation message' })

View File

@@ -16,6 +16,7 @@ import {
import { defaultTo } from 'ramda'; import { defaultTo } from 'ramda';
import { ERRORS } from '../Auth.constants'; import { ERRORS } from '../Auth.constants';
import { hashPassword } from '../Auth.utils'; import { hashPassword } from '../Auth.utils';
import { ClsService } from 'nestjs-cls';
@Injectable() @Injectable()
export class AuthSignupService { export class AuthSignupService {
@@ -29,6 +30,7 @@ export class AuthSignupService {
private readonly configService: ConfigService, private readonly configService: ConfigService,
private readonly eventEmitter: EventEmitter2, private readonly eventEmitter: EventEmitter2,
private readonly tenantsManager: TenantsManagerService, private readonly tenantsManager: TenantsManagerService,
private readonly clsService: ClsService,
@Inject(SystemUser.name) @Inject(SystemUser.name)
private readonly systemUserModel: typeof SystemUser, private readonly systemUserModel: typeof SystemUser,
@@ -70,6 +72,11 @@ export class AuthSignupService {
tenantId: tenant.id, tenantId: tenant.id,
inviteAcceptedAt, inviteAcceptedAt,
}); });
// Set the user in the cls service.
this.clsService.set('tenantId', user.tenantId);
this.clsService.set('userId', user.id);
this.clsService.set('organizationId', tenant.organizationId);
// Triggers signed up event. // Triggers signed up event.
await this.eventEmitter.emitAsync(events.auth.signUp, { await this.eventEmitter.emitAsync(events.auth.signUp, {
signupDTO, signupDTO,

View File

@@ -10,14 +10,15 @@ export class GenerateApiKey {
private readonly tenancyContext: TenancyContext, private readonly tenancyContext: TenancyContext,
@Inject(ApiKeyModel.name) @Inject(ApiKeyModel.name)
private readonly apiKeyModel: typeof ApiKeyModel, private readonly apiKeyModel: typeof ApiKeyModel,
) {} ) { }
/** /**
* Generates a new secure API key for the current tenant and system user. * Generates a new secure API key for the current tenant and system user.
* The key is saved in the database and returned (only the key and id for security). * The key is saved in the database and returned (only the key and id for security).
* @param {string} name - Optional name for the API key.
* @returns {Promise<{ key: string; id: number }>} The generated API key and its database id. * @returns {Promise<{ key: string; id: number }>} The generated API key and its database id.
*/ */
async generate() { async generate(name?: string) {
const tenant = await this.tenancyContext.getTenant(); const tenant = await this.tenancyContext.getTenant();
const user = await this.tenancyContext.getSystemUser(); const user = await this.tenancyContext.getSystemUser();
@@ -26,6 +27,7 @@ export class GenerateApiKey {
// Save the API key to the database // Save the API key to the database
const apiKeyRecord = await this.apiKeyModel.query().insert({ const apiKeyRecord = await this.apiKeyModel.query().insert({
key, key,
name,
tenantId: tenant.id, tenantId: tenant.id,
userId: user.id, userId: user.id,
createdAt: new Date(), createdAt: new Date(),

View File

@@ -29,6 +29,12 @@ export class ApiKeyListItemDto {
@ApiProperty({ example: 'My API Key', description: 'API key name' }) @ApiProperty({ example: 'My API Key', description: 'API key name' })
name?: string; name?: string;
@ApiProperty({
example: 'bc_1234...',
description: 'First 8 characters of the API key token',
})
token: string;
@ApiProperty({ @ApiProperty({
example: '2024-01-01T00:00:00.000Z', example: '2024-01-01T00:00:00.000Z',
description: 'Creation date', description: 'Creation date',

View File

@@ -1,10 +1,6 @@
import { Processor, WorkerHost } from '@nestjs/bullmq'; import { Processor, WorkerHost } from '@nestjs/bullmq';
import { Scope } from '@nestjs/common'; import { Scope } from '@nestjs/common';
import { import { SendResetPasswordMailQueue } from '../Auth.constants';
SendResetPasswordMailJob,
SendResetPasswordMailQueue,
} from '../Auth.constants';
import { Process } from '@nestjs/bull';
import { Job } from 'bullmq'; import { Job } from 'bullmq';
import { AuthenticationMailMesssages } from '../AuthMailMessages.esrvice'; import { AuthenticationMailMesssages } from '../AuthMailMessages.esrvice';
import { MailTransporter } from '@/modules/Mail/MailTransporter.service'; import { MailTransporter } from '@/modules/Mail/MailTransporter.service';
@@ -23,7 +19,6 @@ export class SendResetPasswordMailProcessor extends WorkerHost {
super(); super();
} }
@Process(SendResetPasswordMailJob)
async process(job: Job<SendResetPasswordMailJobPayload>) { async process(job: Job<SendResetPasswordMailJobPayload>) {
try { try {
await this.authMailMesssages.sendResetPasswordMail( await this.authMailMesssages.sendResetPasswordMail(

View File

@@ -1,11 +1,7 @@
import { Scope } from '@nestjs/common'; import { Scope } from '@nestjs/common';
import { Job } from 'bullmq'; import { Job } from 'bullmq';
import { Process } from '@nestjs/bull';
import { Processor, WorkerHost } from '@nestjs/bullmq'; import { Processor, WorkerHost } from '@nestjs/bullmq';
import { import { SendSignupVerificationMailQueue } from '../Auth.constants';
SendSignupVerificationMailJob,
SendSignupVerificationMailQueue,
} from '../Auth.constants';
import { MailTransporter } from '@/modules/Mail/MailTransporter.service'; import { MailTransporter } from '@/modules/Mail/MailTransporter.service';
import { AuthenticationMailMesssages } from '../AuthMailMessages.esrvice'; import { AuthenticationMailMesssages } from '../AuthMailMessages.esrvice';
@@ -21,7 +17,6 @@ export class SendSignupVerificationMailProcessor extends WorkerHost {
super(); super();
} }
@Process(SendSignupVerificationMailJob)
async process(job: Job<SendSignupVerificationMailJobPayload>) { async process(job: Job<SendSignupVerificationMailJobPayload>) {
try { try {
await this.authMailMesssages.sendSignupVerificationMail( await this.authMailMesssages.sendSignupVerificationMail(

View File

@@ -1,7 +1,16 @@
import { Transformer } from '@/modules/Transformer/Transformer'; import { Transformer } from '@/modules/Transformer/Transformer';
export class GetApiKeysTransformer extends Transformer { export class GetApiKeysTransformer extends Transformer {
public includeAttributes = (): string[] => {
return ['token'];
};
public excludeAttributes = (): string[] => { public excludeAttributes = (): string[] => {
return ['tenantId']; return ['tenantId'];
}; };
public token(apiKey) {
return apiKey.key ? `${apiKey.key.substring(0, 8)}...` : '';
}
} }

View File

@@ -1,16 +1,28 @@
import { Controller, Get, Param, Post, Query } from '@nestjs/common'; import { Controller, Get, Param, Post, Query } from '@nestjs/common';
import { BankAccountsApplication } from './BankAccountsApplication.service'; import { BankAccountsApplication } from './BankAccountsApplication.service';
import { ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger'; import { ApiOperation, ApiQuery, ApiResponse, ApiTags } from '@nestjs/swagger';
import { ICashflowAccountsFilter } from './types/BankAccounts.types'; import { BankAccountsQueryDto } from './dtos/BankAccountsQuery.dto';
import { BankAccountResponseDto } from './dtos/BankAccountResponse.dto';
@Controller('banking/accounts') @Controller('banking/accounts')
@ApiTags('Bank Accounts') @ApiTags('Bank Accounts')
export class BankAccountsController { export class BankAccountsController {
constructor(private bankAccountsApplication: BankAccountsApplication) {} constructor(private bankAccountsApplication: BankAccountsApplication) { }
@Get() @Get()
@ApiOperation({ summary: 'Retrieve the bank accounts.' }) @ApiOperation({ summary: 'Retrieve the bank accounts.' })
getBankAccounts(@Query() filterDto: ICashflowAccountsFilter) { @ApiQuery({
name: 'query',
description: 'Query parameters for the bank accounts list.',
type: BankAccountsQueryDto,
required: false,
})
@ApiResponse({
status: 200,
description: 'List of bank accounts retrieved successfully.',
type: [BankAccountResponseDto],
})
getBankAccounts(@Query() filterDto: BankAccountsQueryDto) {
return this.bankAccountsApplication.getBankAccounts(filterDto); return this.bankAccountsApplication.getBankAccounts(filterDto);
} }

View File

@@ -6,6 +6,7 @@ import { PauseBankAccountFeeds } from './commands/PauseBankAccountFeeds.service'
import { GetBankAccountsService } from './queries/GetBankAccounts'; import { GetBankAccountsService } from './queries/GetBankAccounts';
import { ICashflowAccountsFilter } from './types/BankAccounts.types'; import { ICashflowAccountsFilter } from './types/BankAccounts.types';
import { GetBankAccountSummary } from './queries/GetBankAccountSummary'; import { GetBankAccountSummary } from './queries/GetBankAccountSummary';
import { BankAccountsQueryDto } from './dtos/BankAccountsQuery.dto';
@Injectable() @Injectable()
export class BankAccountsApplication { export class BankAccountsApplication {
@@ -16,13 +17,13 @@ export class BankAccountsApplication {
private readonly refreshBankAccountService: RefreshBankAccountService, private readonly refreshBankAccountService: RefreshBankAccountService,
private readonly resumeBankAccountFeedsService: ResumeBankAccountFeedsService, private readonly resumeBankAccountFeedsService: ResumeBankAccountFeedsService,
private readonly pauseBankAccountFeedsService: PauseBankAccountFeeds, private readonly pauseBankAccountFeedsService: PauseBankAccountFeeds,
) {} ) { }
/** /**
* Retrieves the bank accounts. * Retrieves the bank accounts.
* @param {ICashflowAccountsFilter} filterDto - * @param {ICashflowAccountsFilter} filterDto -
*/ */
getBankAccounts(filterDto: ICashflowAccountsFilter) { getBankAccounts(filterDto: BankAccountsQueryDto) {
return this.getBankAccountsService.getCashflowAccounts(filterDto); return this.getBankAccountsService.getCashflowAccounts(filterDto);
} }

View File

@@ -0,0 +1,166 @@
import { ApiProperty } from '@nestjs/swagger';
/**
* Bank Account Response DTO
* Based on AccountResponseDto but excludes fields that are filtered out by CashflowAccountTransformer:
* - predefined
* - index
* - accountTypeLabel
*/
export class BankAccountResponseDto {
@ApiProperty({
description: 'The unique identifier of the account',
example: 1,
})
id: number;
@ApiProperty({
description: 'The name of the account',
example: 'Cash Account',
})
name: string;
@ApiProperty({
description: 'The slug of the account',
example: 'cash-account',
})
slug: string;
@ApiProperty({
description: 'The code of the account',
example: '1001',
})
code: string;
@ApiProperty({
description: 'The type of the account',
example: 'bank',
})
accountType: string;
@ApiProperty({
description: 'The parent account ID',
example: null,
})
parentAccountId: number | null;
@ApiProperty({
description: 'The currency code of the account',
example: 'USD',
})
currencyCode: string;
@ApiProperty({
description: 'Whether the account is active',
example: true,
})
active: boolean;
@ApiProperty({
description: 'The bank balance of the account',
example: 5000.0,
})
bankBalance: number;
@ApiProperty({
description: 'The formatted bank balance',
example: '$5,000.00',
})
bankBalanceFormatted: string;
@ApiProperty({
description: 'The last feeds update timestamp',
example: '2024-03-20T10:30:00Z',
})
lastFeedsUpdatedAt: string | Date | null;
@ApiProperty({
description: 'The formatted last feeds update timestamp',
example: 'Mar 20, 2024 10:30 AM',
})
lastFeedsUpdatedAtFormatted: string;
@ApiProperty({
description: 'The last feeds updated from now (relative time)',
example: '2 hours ago',
})
lastFeedsUpdatedFromNow: string;
@ApiProperty({
description: 'The amount of the account',
example: 5000.0,
})
amount: number;
@ApiProperty({
description: 'The formatted amount',
example: '$5,000.00',
})
formattedAmount: string;
@ApiProperty({
description: 'The Plaid item ID',
example: 'plaid-item-123',
})
plaidItemId: string;
@ApiProperty({
description: 'The Plaid account ID',
example: 'plaid-account-456',
})
plaidAccountId: string | null;
@ApiProperty({
description: 'Whether the feeds are active',
example: true,
})
isFeedsActive: boolean;
@ApiProperty({
description: 'Whether the account is syncing owner',
example: true,
})
isSyncingOwner: boolean;
@ApiProperty({
description: 'Whether the feeds are paused',
example: false,
})
isFeedsPaused: boolean;
@ApiProperty({
description: 'The account normal',
example: 'debit',
})
accountNormal: string;
@ApiProperty({
description: 'The formatted account normal',
example: 'Debit',
})
accountNormalFormatted: string;
@ApiProperty({
description: 'The flatten name with all dependant accounts names',
example: 'Assets: Cash Account',
})
flattenName: string;
@ApiProperty({
description: 'The account level in the hierarchy',
example: 2,
})
accountLevel?: number;
@ApiProperty({
description: 'The creation timestamp',
example: '2024-03-20T10:00:00Z',
})
createdAt: Date;
@ApiProperty({
description: 'The update timestamp',
example: '2024-03-20T10:30:00Z',
})
updatedAt: Date;
}

View File

@@ -0,0 +1,107 @@
import { ApiPropertyOptional } from '@nestjs/swagger';
import { Transform } from 'class-transformer';
import { IsArray, IsBoolean, IsEnum, IsInt, IsOptional, IsString, Min } from 'class-validator';
import { ToNumber } from '@/common/decorators/Validators';
import { IFilterRole, ISortOrder } from '@/modules/DynamicListing/DynamicFilter/DynamicFilter.types';
import { parseBoolean } from '@/utils/parse-boolean';
export class BankAccountsQueryDto {
@ApiPropertyOptional({
description: 'Custom view ID',
type: Number,
example: 1,
})
@IsOptional()
@ToNumber()
@IsInt()
customViewId?: number;
@ApiPropertyOptional({
description: 'Filter roles array',
type: Array,
isArray: true,
})
@IsArray()
@IsOptional()
filterRoles?: IFilterRole[];
@ApiPropertyOptional({
description: 'Column to sort by',
type: String,
example: 'created_at',
})
@IsOptional()
@IsString()
columnSortBy?: string;
@ApiPropertyOptional({
description: 'Sort order',
enum: ISortOrder,
example: ISortOrder.DESC,
})
@IsOptional()
@IsEnum(ISortOrder)
sortOrder?: string;
@ApiPropertyOptional({
description: 'Stringified filter roles',
type: String,
example: '{"fieldKey":"status","value":"active"}',
})
@IsOptional()
@IsString()
stringifiedFilterRoles?: string;
@ApiPropertyOptional({
description: 'Search keyword',
type: String,
example: 'bank account',
})
@IsOptional()
@IsString()
searchKeyword?: string;
@ApiPropertyOptional({
description: 'View slug',
type: String,
example: 'active-accounts',
})
@IsOptional()
@IsString()
viewSlug?: string;
@ApiPropertyOptional({
description: 'Page number',
type: Number,
example: 1,
minimum: 1,
})
@IsOptional()
@ToNumber()
@IsInt()
@Min(1)
page?: number;
@ApiPropertyOptional({
description: 'Page size',
type: Number,
example: 25,
minimum: 1,
})
@IsOptional()
@ToNumber()
@IsInt()
@Min(1)
pageSize?: number;
@ApiPropertyOptional({
description: 'Include inactive accounts',
type: Boolean,
example: false,
default: false,
})
@IsOptional()
@Transform(({ value }) => parseBoolean(value, false))
@IsBoolean()
inactiveMode?: boolean;
}

View File

@@ -6,6 +6,8 @@ import { TenantModelProxy } from '@/modules/System/models/TenantBaseModel';
import { ICashflowAccountsFilter } from '../types/BankAccounts.types'; import { ICashflowAccountsFilter } from '../types/BankAccounts.types';
import { TransformerInjectable } from '@/modules/Transformer/TransformerInjectable.service'; import { TransformerInjectable } from '@/modules/Transformer/TransformerInjectable.service';
import { DynamicListService } from '@/modules/DynamicListing/DynamicList.service'; import { DynamicListService } from '@/modules/DynamicListing/DynamicList.service';
import { BankAccountsQueryDto } from '../dtos/BankAccountsQuery.dto';
import { IDynamicListFilter } from '@/modules/DynamicListing/DynamicFilter/DynamicFilter.types';
@Injectable() @Injectable()
export class GetBankAccountsService { export class GetBankAccountsService {
@@ -15,14 +17,14 @@ export class GetBankAccountsService {
@Inject(Account.name) @Inject(Account.name)
private readonly accountModel: TenantModelProxy<typeof Account>, private readonly accountModel: TenantModelProxy<typeof Account>,
) {} ) { }
/** /**
* Retrieve the cash flow accounts. * Retrieve the cash flow accounts.
* @param {ICashflowAccountsFilter} filterDTO - Filter DTO. * @param {ICashflowAccountsFilter} filterDTO - Filter DTO.
* @returns {ICashflowAccount[]} * @returns {ICashflowAccount[]}
*/ */
public async getCashflowAccounts(filterDTO: ICashflowAccountsFilter) { public async getCashflowAccounts(filterDTO: BankAccountsQueryDto) {
const _filterDto = { const _filterDto = {
sortOrder: 'desc', sortOrder: 'desc',
columnSortBy: 'created_at', columnSortBy: 'created_at',
@@ -30,12 +32,14 @@ export class GetBankAccountsService {
...filterDTO, ...filterDTO,
}; };
// Parsees accounts list filter DTO. // Parsees accounts list filter DTO.
const filter = this.dynamicListService.parseStringifiedFilter(_filterDto); const filter = this.dynamicListService.parseStringifiedFilter<BankAccountsQueryDto>(
_filterDto,
);
// Dynamic list service. // Dynamic list service.
const dynamicList = await this.dynamicListService.dynamicList( const dynamicList = await this.dynamicListService.dynamicList(
this.accountModel(), this.accountModel(),
filter, filter as IDynamicListFilter,
); );
// Retrieve accounts model based on the given query. // Retrieve accounts model based on the given query.
const accounts = await this.accountModel() const accounts = await this.accountModel()

View File

@@ -1,7 +1,7 @@
import { Inject, Injectable } from '@nestjs/common'; import { Inject, Injectable } from '@nestjs/common';
import { Knex } from 'knex'; import { Knex } from 'knex';
import * as yup from 'yup'; import * as yup from 'yup';
import uniqid from 'uniqid'; import * as uniqid from 'uniqid';
import { Importable } from '../../Import/Importable'; import { Importable } from '../../Import/Importable';
import { CreateUncategorizedTransactionService } from './CreateUncategorizedTransaction.service'; import { CreateUncategorizedTransactionService } from './CreateUncategorizedTransaction.service';
import { ImportableContext } from '../../Import/interfaces'; import { ImportableContext } from '../../Import/interfaces';
@@ -9,8 +9,10 @@ import { BankTransactionsSampleData } from '../../BankingTransactions/constants'
import { Account } from '@/modules/Accounts/models/Account.model'; import { Account } from '@/modules/Accounts/models/Account.model';
import { CreateUncategorizedTransactionDTO } from '../types/BankingCategorize.types'; import { CreateUncategorizedTransactionDTO } from '../types/BankingCategorize.types';
import { TenantModelProxy } from '@/modules/System/models/TenantBaseModel'; import { TenantModelProxy } from '@/modules/System/models/TenantBaseModel';
import { ImportableService } from '../../Import/decorators/Import.decorator';
import { UncategorizedBankTransaction } from '../../BankingTransactions/models/UncategorizedBankTransaction';
@Injectable() @Injectable()
@ImportableService({ name: UncategorizedBankTransaction.name })
export class UncategorizedTransactionsImportable extends Importable { export class UncategorizedTransactionsImportable extends Importable {
constructor( constructor(
private readonly createUncategorizedTransaction: CreateUncategorizedTransactionService, private readonly createUncategorizedTransaction: CreateUncategorizedTransactionService,

View File

@@ -1,5 +1,5 @@
import { ApiOperation, ApiTags } from '@nestjs/swagger'; import { ApiOperation, ApiTags } from '@nestjs/swagger';
import { Body, Controller, Get, Param, Post, Query } from '@nestjs/common'; import { Body, Controller, Get, Param, Patch, Post, Query } from '@nestjs/common';
import { BankingMatchingApplication } from './BankingMatchingApplication'; import { BankingMatchingApplication } from './BankingMatchingApplication';
import { GetMatchedTransactionsFilter } from './types'; import { GetMatchedTransactionsFilter } from './types';
import { MatchBankTransactionDto } from './dtos/MatchBankTransaction.dto'; import { MatchBankTransactionDto } from './dtos/MatchBankTransaction.dto';
@@ -34,7 +34,7 @@ export class BankingMatchingController {
); );
} }
@Post('/unmatch/:uncategorizedTransactionId') @Patch('/unmatch/:uncategorizedTransactionId')
@ApiOperation({ summary: 'Unmatch the given uncategorized transaction.' }) @ApiOperation({ summary: 'Unmatch the given uncategorized transaction.' })
async unmatchMatchedTransaction( async unmatchMatchedTransaction(
@Param('uncategorizedTransactionId') uncategorizedTransactionId: number, @Param('uncategorizedTransactionId') uncategorizedTransactionId: number,

View File

@@ -1,6 +1,6 @@
import * as moment from 'moment'; import * as moment from 'moment';
import * as R from 'ramda'; import * as R from 'ramda';
import { isEmpty, sumBy } from 'lodash'; import { isEmpty, round, sumBy } from 'lodash';
import { ERRORS, MatchedTransactionPOJO } from './types'; import { ERRORS, MatchedTransactionPOJO } from './types';
import { ServiceError } from '../Items/ServiceError'; import { ServiceError } from '../Items/ServiceError';
@@ -22,18 +22,24 @@ export const sortClosestMatchTransactions = (
}; };
export const sumMatchTranasctions = (transactions: Array<any>) => { export const sumMatchTranasctions = (transactions: Array<any>) => {
return transactions.reduce( const total = transactions.reduce(
(total, item) => (sum, item) => {
total + const amount = parseFloat(item.amount) || 0;
(item.transactionNormal === 'debit' ? 1 : -1) * parseFloat(item.amount), const multiplier = item.transactionNormal === 'debit' ? 1 : -1;
return sum + multiplier * amount;
},
0 0
); );
// Round to 2 decimal places to avoid floating-point precision issues
return round(total, 2);
}; };
export const sumUncategorizedTransactions = ( export const sumUncategorizedTransactions = (
uncategorizedTransactions: Array<any> uncategorizedTransactions: Array<any>
) => { ) => {
return sumBy(uncategorizedTransactions, 'amount'); const total = sumBy(uncategorizedTransactions, 'amount');
// Round to 2 decimal places to avoid floating-point precision issues
return round(total, 2);
}; };
export const validateUncategorizedTransactionsNotMatched = ( export const validateUncategorizedTransactionsNotMatched = (

View File

@@ -34,7 +34,7 @@ export class MatchBankTransactions {
private readonly uncategorizedBankTransactionModel: TenantModelProxy< private readonly uncategorizedBankTransactionModel: TenantModelProxy<
typeof UncategorizedBankTransaction typeof UncategorizedBankTransaction
>, >,
) {} ) { }
/** /**
* Validates the match bank transactions DTO. * Validates the match bank transactions DTO.
@@ -100,7 +100,10 @@ export class MatchBankTransactions {
); );
// Validates the total given matching transcations whether is not equal // Validates the total given matching transcations whether is not equal
// uncategorized transaction amount. // uncategorized transaction amount.
if (totalUncategorizedTransactions !== totalMatchedTranasctions) { // Use tolerance-based comparison to handle floating-point precision issues
const tolerance = 0.01; // Allow 0.01 difference for floating-point precision
const difference = Math.abs(totalUncategorizedTransactions - totalMatchedTranasctions);
if (difference > tolerance) {
throw new ServiceError(ERRORS.TOTAL_MATCHING_TRANSACTIONS_INVALID); throw new ServiceError(ERRORS.TOTAL_MATCHING_TRANSACTIONS_INVALID);
} }
} }

View File

@@ -12,24 +12,30 @@ export class MatchTransactionsTypes {
private static registry: MatchTransactionsTypesRegistry; private static registry: MatchTransactionsTypesRegistry;
/** /**
* Consttuctor method. * Constructor method.
*/ */
constructor() { constructor(
private readonly getMatchedInvoicesService: GetMatchedTransactionsByInvoices,
private readonly getMatchedBillsService: GetMatchedTransactionsByBills,
private readonly getMatchedExpensesService: GetMatchedTransactionsByExpenses,
private readonly getMatchedManualJournalsService: GetMatchedTransactionsByManualJournals,
private readonly getMatchedCashflowService: GetMatchedTransactionsByCashflow,
) {
this.boot(); this.boot();
} }
get registered() { get registered() {
return [ return [
{ type: 'SaleInvoice', service: GetMatchedTransactionsByInvoices }, { type: 'SaleInvoice', service: this.getMatchedInvoicesService },
{ type: 'Bill', service: GetMatchedTransactionsByBills }, { type: 'Bill', service: this.getMatchedBillsService },
{ type: 'Expense', service: GetMatchedTransactionsByExpenses }, { type: 'Expense', service: this.getMatchedExpensesService },
{ {
type: 'ManualJournal', type: 'ManualJournal',
service: GetMatchedTransactionsByManualJournals, service: this.getMatchedManualJournalsService,
}, },
{ {
type: 'CashflowTransaction', type: 'CashflowTransaction',
service: GetMatchedTransactionsByCashflow, service: this.getMatchedCashflowService,
}, },
]; ];
} }
@@ -50,14 +56,13 @@ export class MatchTransactionsTypes {
* Boots all the registered importables. * Boots all the registered importables.
*/ */
public boot() { public boot() {
if (!MatchTransactionsTypes.registry) { const instance = MatchTransactionsTypesRegistry.getInstance();
const instance = MatchTransactionsTypesRegistry.getInstance();
this.registered.forEach((registered) => { // Always register services to ensure they're available
// const serviceInstanace = Container.get(registered.service); this.registered.forEach((registered) => {
// instance.register(registered.type, serviceInstanace); instance.register(registered.type, registered.service);
}); });
MatchTransactionsTypes.registry = instance;
} MatchTransactionsTypes.registry = instance;
} }
} }

View File

@@ -1,3 +1,5 @@
import { BullBoardModule } from '@bull-board/nestjs';
import { BullMQAdapter } from '@bull-board/api/bullMQAdapter';
import { BullModule } from '@nestjs/bullmq'; import { BullModule } from '@nestjs/bullmq';
import { Module } from '@nestjs/common'; import { Module } from '@nestjs/common';
import { SocketModule } from '../Socket/Socket.module'; import { SocketModule } from '../Socket/Socket.module';
@@ -33,6 +35,10 @@ const models = [RegisterTenancyModel(PlaidItem)];
BankingCategorizeModule, BankingCategorizeModule,
BankingTransactionsModule, BankingTransactionsModule,
BullModule.registerQueue({ name: UpdateBankingPlaidTransitionsQueueJob }), BullModule.registerQueue({ name: UpdateBankingPlaidTransitionsQueueJob }),
BullBoardModule.forFeature({
name: UpdateBankingPlaidTransitionsQueueJob,
adapter: BullMQAdapter,
}),
...models, ...models,
], ],
providers: [ providers: [
@@ -51,4 +57,4 @@ const models = [RegisterTenancyModel(PlaidItem)];
exports: [...models], exports: [...models],
controllers: [BankingPlaidController, BankingPlaidWebhooksController], controllers: [BankingPlaidController, BankingPlaidWebhooksController],
}) })
export class BankingPlaidModule { } export class BankingPlaidModule {}

View File

@@ -1,11 +1,9 @@
import { Process } from '@nestjs/bull';
import { UseCls } from 'nestjs-cls'; import { UseCls } from 'nestjs-cls';
import { Processor, WorkerHost } from '@nestjs/bullmq'; import { Processor, WorkerHost } from '@nestjs/bullmq';
import { Scope } from '@nestjs/common'; import { Scope } from '@nestjs/common';
import { Job } from 'bullmq'; import { Job } from 'bullmq';
import { import {
PlaidFetchTransitonsEventPayload, PlaidFetchTransitonsEventPayload,
UpdateBankingPlaidTransitionsJob,
UpdateBankingPlaidTransitionsQueueJob, UpdateBankingPlaidTransitionsQueueJob,
} from '../types/BankingPlaid.types'; } from '../types/BankingPlaid.types';
import { PlaidUpdateTransactions } from '../command/PlaidUpdateTransactions'; import { PlaidUpdateTransactions } from '../command/PlaidUpdateTransactions';
@@ -28,7 +26,6 @@ export class PlaidFetchTransactionsProcessor extends WorkerHost {
/** /**
* Triggers the function. * Triggers the function.
*/ */
@Process(UpdateBankingPlaidTransitionsJob)
@UseCls() @UseCls()
async process(job: Job<PlaidFetchTransitonsEventPayload>) { async process(job: Job<PlaidFetchTransitonsEventPayload>) {
const { plaidItemId } = job.data; const { plaidItemId } = job.data;

View File

@@ -10,6 +10,8 @@ import { BankingRecognizedTransactionsController } from './BankingRecognizedTran
import { RecognizedTransactionsApplication } from './RecognizedTransactions.application'; import { RecognizedTransactionsApplication } from './RecognizedTransactions.application';
import { GetRecognizedTransactionsService } from './GetRecongizedTransactions'; import { GetRecognizedTransactionsService } from './GetRecongizedTransactions';
import { GetRecognizedTransactionService } from './queries/GetRecognizedTransaction.service'; import { GetRecognizedTransactionService } from './queries/GetRecognizedTransaction.service';
import { BullBoardModule } from '@bull-board/nestjs';
import { BullMQAdapter } from '@bull-board/api/bullMQAdapter';
import { BullModule } from '@nestjs/bullmq'; import { BullModule } from '@nestjs/bullmq';
import { RecognizeUncategorizedTransactionsQueue } from './_types'; import { RecognizeUncategorizedTransactionsQueue } from './_types';
import { RegonizeTransactionsPrcessor } from './jobs/RecognizeTransactionsJob'; import { RegonizeTransactionsPrcessor } from './jobs/RecognizeTransactionsJob';
@@ -25,6 +27,10 @@ const models = [RegisterTenancyModel(RecognizedBankTransaction)];
BullModule.registerQueue({ BullModule.registerQueue({
name: RecognizeUncategorizedTransactionsQueue, name: RecognizeUncategorizedTransactionsQueue,
}), }),
BullBoardModule.forFeature({
name: RecognizeUncategorizedTransactionsQueue,
adapter: BullMQAdapter,
}),
...models, ...models,
], ],
providers: [ providers: [

View File

@@ -7,7 +7,6 @@ import {
RecognizeUncategorizedTransactionsJobPayload, RecognizeUncategorizedTransactionsJobPayload,
RecognizeUncategorizedTransactionsQueue, RecognizeUncategorizedTransactionsQueue,
} from '../_types'; } from '../_types';
import { Process } from '@nestjs/bull';
@Processor({ @Processor({
name: RecognizeUncategorizedTransactionsQueue, name: RecognizeUncategorizedTransactionsQueue,
@@ -28,7 +27,6 @@ export class RegonizeTransactionsPrcessor extends WorkerHost {
/** /**
* Triggers sending invoice mail. * Triggers sending invoice mail.
*/ */
@Process(RecognizeUncategorizedTransactionsQueue)
@UseCls() @UseCls()
async process(job: Job<RecognizeUncategorizedTransactionsJobPayload>) { async process(job: Job<RecognizeUncategorizedTransactionsJobPayload>) {
const { ruleId, transactionsCriteria } = job.data; const { ruleId, transactionsCriteria } = job.data;

View File

@@ -83,4 +83,4 @@ const models = [
CreateBankTransactionService CreateBankTransactionService
], ],
}) })
export class BankingTransactionsModule {} export class BankingTransactionsModule { }

View File

@@ -1,4 +1,4 @@
import { Type } from 'class-transformer'; import { Transform, Type } from 'class-transformer';
import { import {
IsBoolean, IsBoolean,
IsEnum, IsEnum,
@@ -7,6 +7,7 @@ import {
IsPositive, IsPositive,
} from 'class-validator'; } from 'class-validator';
import { ApiPropertyOptional } from '@nestjs/swagger'; import { ApiPropertyOptional } from '@nestjs/swagger';
import { parseBoolean } from '@/utils/parse-boolean';
export class NumberFormatQueryDto { export class NumberFormatQueryDto {
@ApiPropertyOptional({ @ApiPropertyOptional({
@@ -24,6 +25,7 @@ export class NumberFormatQueryDto {
example: false, example: false,
}) })
@IsBoolean() @IsBoolean()
@Transform(({ value }) => parseBoolean(value, false))
@IsOptional() @IsOptional()
readonly divideOn1000: boolean; readonly divideOn1000: boolean;
@@ -32,6 +34,7 @@ export class NumberFormatQueryDto {
example: true, example: true,
}) })
@IsBoolean() @IsBoolean()
@Transform(({ value }) => parseBoolean(value, false))
@IsOptional() @IsOptional()
readonly showZero: boolean; readonly showZero: boolean;

View File

@@ -0,0 +1,72 @@
export const UncategorizedBankTransactionMeta = {
defaultFilterField: 'createdAt',
defaultSort: {
sortOrder: 'DESC',
sortField: 'created_at',
},
importable: true,
fields: {
date: {
name: 'Date',
column: 'date',
fieldType: 'date',
},
payee: {
name: 'Payee',
column: 'payee',
fieldType: 'text',
},
description: {
name: 'Description',
column: 'description',
fieldType: 'text',
},
referenceNo: {
name: 'Reference No.',
column: 'reference_no',
fieldType: 'text',
},
amount: {
name: 'Amount',
column: 'Amount',
fieldType: 'numeric',
required: true,
},
account: {
name: 'Account',
column: 'account_id',
fieldType: 'relation',
to: { model: 'Account', to: 'id' },
},
createdAt: {
name: 'Created At',
column: 'createdAt',
fieldType: 'date',
importable: false,
},
},
fields2: {
date: {
name: 'Date',
fieldType: 'date',
required: true,
},
payee: {
name: 'Payee',
fieldType: 'text',
},
description: {
name: 'Description',
fieldType: 'text',
},
referenceNo: {
name: 'Reference No.',
fieldType: 'text',
},
amount: {
name: 'Amount',
fieldType: 'number',
required: true,
},
},
};

View File

@@ -2,7 +2,10 @@
import * as moment from 'moment'; import * as moment from 'moment';
import { Model } from 'objection'; import { Model } from 'objection';
import { TenantBaseModel } from '@/modules/System/models/TenantBaseModel'; import { TenantBaseModel } from '@/modules/System/models/TenantBaseModel';
import { UncategorizedBankTransactionMeta } from './UncategorizedBankTransaction.meta';
import { InjectModelMeta } from '@/modules/Tenancy/TenancyModels/decorators/InjectModelMeta.decorator';
@InjectModelMeta(UncategorizedBankTransactionMeta)
export class UncategorizedBankTransaction extends TenantBaseModel { export class UncategorizedBankTransaction extends TenantBaseModel {
readonly amount!: number; readonly amount!: number;
readonly date!: Date | string; readonly date!: Date | string;

View File

@@ -4,8 +4,8 @@ import {
validateTransactionShouldBeExcluded, validateTransactionShouldBeExcluded,
} from './utils'; } from './utils';
import { import {
IBankTransactionExcludedEventPayload, IBankTransactionUnexcludedEventPayload,
IBankTransactionExcludingEventPayload, IBankTransactionUnexcludingEventPayload,
} from '../types/BankTransactionsExclude.types'; } from '../types/BankTransactionsExclude.types';
import { EventEmitter2 } from '@nestjs/event-emitter'; import { EventEmitter2 } from '@nestjs/event-emitter';
import { Inject, Injectable } from '@nestjs/common'; import { Inject, Injectable } from '@nestjs/common';
@@ -24,7 +24,7 @@ export class UnexcludeBankTransactionService {
private readonly uncategorizedBankTransactionModel: TenantModelProxy< private readonly uncategorizedBankTransactionModel: TenantModelProxy<
typeof UncategorizedBankTransaction typeof UncategorizedBankTransaction
>, >,
) {} ) { }
/** /**
* Marks the given bank transaction as excluded. * Marks the given bank transaction as excluded.
@@ -50,7 +50,8 @@ export class UnexcludeBankTransactionService {
return this.uow.withTransaction(async (trx: Knex.Transaction) => { return this.uow.withTransaction(async (trx: Knex.Transaction) => {
await this.eventEmitter.emitAsync(events.bankTransactions.onUnexcluding, { await this.eventEmitter.emitAsync(events.bankTransactions.onUnexcluding, {
uncategorizedTransactionId, uncategorizedTransactionId,
} as IBankTransactionExcludingEventPayload); trx,
} as IBankTransactionUnexcludingEventPayload);
await this.uncategorizedBankTransactionModel() await this.uncategorizedBankTransactionModel()
.query(trx) .query(trx)
@@ -61,7 +62,8 @@ export class UnexcludeBankTransactionService {
await this.eventEmitter.emitAsync(events.bankTransactions.onUnexcluded, { await this.eventEmitter.emitAsync(events.bankTransactions.onUnexcluded, {
uncategorizedTransactionId, uncategorizedTransactionId,
} as IBankTransactionExcludedEventPayload); trx,
} as IBankTransactionUnexcludedEventPayload);
}); });
} }
} }

View File

@@ -19,7 +19,7 @@ export class DecrementUncategorizedTransactionOnExclude {
private readonly uncategorizedBankTransaction: TenantModelProxy< private readonly uncategorizedBankTransaction: TenantModelProxy<
typeof UncategorizedBankTransaction typeof UncategorizedBankTransaction
>, >,
) {} ) { }
/** /**
* Validates the cashflow transaction whether matched with bank transaction on deleting. * Validates the cashflow transaction whether matched with bank transaction on deleting.
@@ -50,7 +50,7 @@ export class DecrementUncategorizedTransactionOnExclude {
trx, trx,
}: IBankTransactionUnexcludedEventPayload) { }: IBankTransactionUnexcludedEventPayload) {
const transaction = await this.uncategorizedBankTransaction() const transaction = await this.uncategorizedBankTransaction()
.query() .query(trx)
.findById(uncategorizedTransactionId); .findById(uncategorizedTransactionId);
// //
await this.account() await this.account()

View File

@@ -2,9 +2,11 @@ import { forwardRef, Module } from '@nestjs/common';
import { TransactionLandedCostEntriesService } from './TransactionLandedCostEntries.service'; import { TransactionLandedCostEntriesService } from './TransactionLandedCostEntries.service';
import { AllocateLandedCostService } from './commands/AllocateLandedCost.service'; import { AllocateLandedCostService } from './commands/AllocateLandedCost.service';
import { LandedCostGLEntriesSubscriber } from './commands/LandedCostGLEntries.subscriber'; import { LandedCostGLEntriesSubscriber } from './commands/LandedCostGLEntries.subscriber';
// import { LandedCostGLEntries } from './commands/LandedCostGLEntries.service'; import { LandedCostGLEntriesService } from './commands/LandedCostGLEntries.service';
import { LandedCostSyncCostTransactions } from './commands/LandedCostSyncCostTransactions.service'; import { LandedCostSyncCostTransactions } from './commands/LandedCostSyncCostTransactions.service';
import { LedgerModule } from '../Ledger/Ledger.module';
import { LandedCostSyncCostTransactionsSubscriber } from './commands/LandedCostSyncCostTransactions.subscriber'; import { LandedCostSyncCostTransactionsSubscriber } from './commands/LandedCostSyncCostTransactions.subscriber';
import { LandedCostInventoryTransactionsSubscriber } from './commands/LandedCostInventoryTransactions.subscriber';
import { BillAllocatedLandedCostTransactions } from './commands/BillAllocatedLandedCostTransactions.service'; import { BillAllocatedLandedCostTransactions } from './commands/BillAllocatedLandedCostTransactions.service';
import { BillAllocateLandedCostController } from './LandedCost.controller'; import { BillAllocateLandedCostController } from './LandedCost.controller';
import { RevertAllocatedLandedCost } from './commands/RevertAllocatedLandedCost.service'; import { RevertAllocatedLandedCost } from './commands/RevertAllocatedLandedCost.service';
@@ -16,12 +18,12 @@ import { ExpenseLandedCost } from './commands/ExpenseLandedCost.service';
import { BillLandedCost } from './commands/BillLandedCost.service'; import { BillLandedCost } from './commands/BillLandedCost.service';
@Module({ @Module({
imports: [forwardRef(() => InventoryCostModule)], imports: [forwardRef(() => InventoryCostModule), LedgerModule],
providers: [ providers: [
AllocateLandedCostService, AllocateLandedCostService,
TransactionLandedCostEntriesService, TransactionLandedCostEntriesService,
BillAllocatedLandedCostTransactions, BillAllocatedLandedCostTransactions,
LandedCostGLEntriesSubscriber, LandedCostGLEntriesService,
TransactionLandedCost, TransactionLandedCost,
BillLandedCost, BillLandedCost,
ExpenseLandedCost, ExpenseLandedCost,
@@ -29,6 +31,8 @@ import { BillLandedCost } from './commands/BillLandedCost.service';
RevertAllocatedLandedCost, RevertAllocatedLandedCost,
LandedCostInventoryTransactions, LandedCostInventoryTransactions,
LandedCostTranasctions, LandedCostTranasctions,
LandedCostGLEntriesSubscriber,
LandedCostInventoryTransactionsSubscriber,
LandedCostSyncCostTransactionsSubscriber, LandedCostSyncCostTransactionsSubscriber,
], ],
exports: [TransactionLandedCostEntriesService], exports: [TransactionLandedCostEntriesService],

View File

@@ -25,7 +25,7 @@ export class BillAllocateLandedCostController {
private billAllocatedCostTransactions: BillAllocatedLandedCostTransactions, private billAllocatedCostTransactions: BillAllocatedLandedCostTransactions,
private revertAllocatedLandedCost: RevertAllocatedLandedCost, private revertAllocatedLandedCost: RevertAllocatedLandedCost,
private landedCostTransactions: LandedCostTranasctions, private landedCostTransactions: LandedCostTranasctions,
) {} ) { }
@Get('/transactions') @Get('/transactions')
@ApiOperation({ summary: 'Get landed cost transactions' }) @ApiOperation({ summary: 'Get landed cost transactions' })

View File

@@ -23,7 +23,9 @@ export class AllocateLandedCostService extends BaseLandedCostService {
private readonly billModel: TenantModelProxy<typeof Bill>, private readonly billModel: TenantModelProxy<typeof Bill>,
@Inject(BillLandedCost.name) @Inject(BillLandedCost.name)
protected readonly billLandedCostModel: TenantModelProxy<typeof BillLandedCost> protected readonly billLandedCostModel: TenantModelProxy<
typeof BillLandedCost
>,
) { ) {
super(); super();
} }
@@ -54,7 +56,8 @@ export class AllocateLandedCostService extends BaseLandedCostService {
const amount = this.getAllocateItemsCostTotal(allocateCostDTO); const amount = this.getAllocateItemsCostTotal(allocateCostDTO);
// Retrieve the purchase invoice or throw not found error. // Retrieve the purchase invoice or throw not found error.
const bill = await this.billModel().query() const bill = await this.billModel()
.query()
.findById(billId) .findById(billId)
.withGraphFetched('entries') .withGraphFetched('entries')
.throwIfNotFound(); .throwIfNotFound();
@@ -89,8 +92,9 @@ export class AllocateLandedCostService extends BaseLandedCostService {
// unit-of-work eniverment. // unit-of-work eniverment.
return this.uow.withTransaction(async (trx: Knex.Transaction) => { return this.uow.withTransaction(async (trx: Knex.Transaction) => {
// Save the bill landed cost model. // Save the bill landed cost model.
const billLandedCost = const billLandedCost = await this.billLandedCostModel()
await BillLandedCost.query(trx).insertGraph(billLandedCostObj); .query(trx)
.insertGraph(billLandedCostObj);
// Triggers `onBillLandedCostCreated` event. // Triggers `onBillLandedCostCreated` event.
await this.eventPublisher.emitAsync(events.billLandedCost.onCreated, { await this.eventPublisher.emitAsync(events.billLandedCost.onCreated, {
bill, bill,
@@ -103,5 +107,5 @@ export class AllocateLandedCostService extends BaseLandedCostService {
return billLandedCost; return billLandedCost;
}); });
}; }
} }

View File

@@ -21,7 +21,7 @@ export class BillAllocatedLandedCostTransactions {
private readonly billLandedCostModel: TenantModelProxy< private readonly billLandedCostModel: TenantModelProxy<
typeof BillLandedCost typeof BillLandedCost
>, >,
) {} ) { }
/** /**
* Retrieve the bill associated landed cost transactions. * Retrieve the bill associated landed cost transactions.
@@ -77,6 +77,13 @@ export class BillAllocatedLandedCostTransactions {
transaction.fromTransactionType, transaction.fromTransactionType,
transaction, transaction,
); );
const allocationMethodFormattedKey = transaction.allocationMethodFormatted;
const allocationMethodFormatted = allocationMethodFormattedKey
? this.i18nService.t(allocationMethodFormattedKey, {
defaultValue: allocationMethodFormattedKey,
})
: '';
return { return {
formattedAmount: formatNumber(transaction.amount, { formattedAmount: formatNumber(transaction.amount, {
currencyCode: transaction.currencyCode, currencyCode: transaction.currencyCode,
@@ -84,12 +91,14 @@ export class BillAllocatedLandedCostTransactions {
...omit(transaction, [ ...omit(transaction, [
'allocatedFromBillEntry', 'allocatedFromBillEntry',
'allocatedFromExpenseEntry', 'allocatedFromExpenseEntry',
'allocationMethodFormatted',
]), ]),
name, name,
description, description,
formattedLocalAmount: formatNumber(transaction.localAmount, { formattedLocalAmount: formatNumber(transaction.localAmount, {
currencyCode: 'USD', currencyCode: 'USD',
}), }),
allocationMethodFormatted,
}; };
}; };

View File

@@ -1,236 +1,188 @@
// import * as R from 'ramda'; import { Knex } from 'knex';
// import { Knex } from 'knex'; import { Inject, Injectable } from '@nestjs/common';
// import { Inject, Injectable } from '@nestjs/common'; import * as moment from 'moment';
// import { BaseLandedCostService } from '../BaseLandedCost.service'; import { BaseLandedCostService } from '../BaseLandedCost.service';
// import { BillLandedCost } from '../models/BillLandedCost'; import { BillLandedCost } from '../models/BillLandedCost';
// import { TenantModelProxy } from '@/modules/System/models/TenantBaseModel'; import { Bill } from '@/modules/Bills/models/Bill';
// import { Bill } from '@/modules/Bills/models/Bill'; import { BillLandedCostEntry } from '../models/BillLandedCostEntry';
// import { BillLandedCostEntry } from '../models/BillLandedCostEntry'; import { ILedgerEntry } from '@/modules/Ledger/types/Ledger.types';
// import { ILedger, ILedgerEntry } from '@/modules/Ledger/types/Ledger.types'; import { Ledger } from '@/modules/Ledger/Ledger';
// import { Ledger } from '@/modules/Ledger/Ledger'; import { LedgerStorageService } from '@/modules/Ledger/LedgerStorage.service';
// import { AccountNormal } from '@/interfaces/Account'; import { AccountNormal } from '@/modules/Accounts/Accounts.types';
// import { ILandedCostTransactionEntry } from '../types/BillLandedCosts.types'; import { TenantModelProxy } from '@/modules/System/models/TenantBaseModel';
// @Injectable() @Injectable()
// export class LandedCostGLEntries extends BaseLandedCostService { export class LandedCostGLEntriesService extends BaseLandedCostService {
// constructor( constructor(
// private readonly journalService: JournalPosterService, private readonly ledgerStorage: LedgerStorageService,
// private readonly ledgerRepository: LedgerRepository,
// @Inject(BillLandedCost.name) @Inject(BillLandedCost.name)
// private readonly billLandedCostModel: TenantModelProxy<typeof BillLandedCost>, protected readonly billLandedCostModel: TenantModelProxy<
// ) { typeof BillLandedCost
// super(); >,
// } ) {
super();
}
// /** /**
// * Retrieves the landed cost GL common entry. * Retrieves the landed cost GL common entry.
// * @param {IBill} bill */
// * @param {IBillLandedCost} allocatedLandedCost private getLandedCostGLCommonEntry(
// * @returns bill: Bill,
// */ allocatedLandedCost: BillLandedCost,
// private getLandedCostGLCommonEntry = ( ) {
// bill: Bill, return {
// allocatedLandedCost: BillLandedCost date: moment(bill.billDate).format('YYYY-MM-DD'),
// ) => { currencyCode: allocatedLandedCost.currencyCode,
// return { exchangeRate: allocatedLandedCost.exchangeRate,
// date: bill.billDate,
// currencyCode: allocatedLandedCost.currencyCode,
// exchangeRate: allocatedLandedCost.exchangeRate,
// transactionType: 'LandedCost', transactionType: 'LandedCost',
// transactionId: allocatedLandedCost.id, transactionId: allocatedLandedCost.id,
// transactionNumber: bill.billNumber, transactionNumber: bill.billNumber,
// referenceNumber: bill.referenceNo, referenceNumber: bill.referenceNo,
// credit: 0, branchId: bill.branchId,
// debit: 0, projectId: bill.projectId,
// };
// };
// /** credit: 0,
// * Retrieves the landed cost GL inventory entry. debit: 0,
// * @param {IBill} bill };
// * @param {IBillLandedCost} allocatedLandedCost }
// * @param {IBillLandedCostEntry} allocatedEntry
// * @returns {ILedgerEntry}
// */
// private getLandedCostGLInventoryEntry = (
// bill: Bill,
// allocatedLandedCost: BillLandedCost,
// allocatedEntry: BillLandedCostEntry
// ): ILedgerEntry => {
// const commonEntry = this.getLandedCostGLCommonEntry(
// bill,
// allocatedLandedCost
// );
// return {
// ...commonEntry,
// debit: allocatedLandedCost.localAmount,
// accountId: allocatedEntry.itemEntry.item.inventoryAccountId,
// index: 1,
// accountNormal: AccountNormal.DEBIT,
// };
// };
// /** /**
// * Retrieves the landed cost GL cost entry. * Retrieves the landed cost GL inventory entry for an allocated item.
// * @param {IBill} bill */
// * @param {IBillLandedCost} allocatedLandedCost private getLandedCostGLInventoryEntry(
// * @param {ILandedCostTransactionEntry} fromTransactionEntry bill: Bill,
// * @returns {ILedgerEntry} allocatedLandedCost: BillLandedCost,
// */ allocatedEntry: BillLandedCostEntry,
// private getLandedCostGLCostEntry = ( index: number,
// bill: Bill, ): ILedgerEntry {
// allocatedLandedCost: BillLandedCost, const commonEntry = this.getLandedCostGLCommonEntry(
// fromTransactionEntry: ILandedCostTransactionEntry bill,
// ): ILedgerEntry => { allocatedLandedCost,
// const commonEntry = this.getLandedCostGLCommonEntry( );
// bill, const itemEntry = (
// allocatedLandedCost allocatedEntry as BillLandedCostEntry & {
// ); itemEntry?: {
// return { item?: { type?: string; inventoryAccountId?: number };
// ...commonEntry, costAccountId?: number;
// credit: allocatedLandedCost.localAmount, itemId?: number;
// accountId: fromTransactionEntry.costAccountId, };
// index: 2, }
// accountNormal: AccountNormal.CREDIT, ).itemEntry;
// }; const item = itemEntry?.item;
// }; const isInventory = item && ['inventory'].indexOf(item.type) !== -1;
const accountId = isInventory
? item?.inventoryAccountId
: itemEntry?.costAccountId;
// /** if (!accountId) {
// * Retrieve allocated landed cost entry GL entries. throw new Error(
// * @param {IBill} bill `Cannot determine GL account for landed cost allocate entry (entryId: ${allocatedEntry.entryId})`,
// * @param {IBillLandedCost} allocatedLandedCost );
// * @param {ILandedCostTransactionEntry} fromTransactionEntry }
// * @param {IBillLandedCostEntry} allocatedEntry
// * @returns {ILedgerEntry}
// */
// private getLandedCostGLAllocateEntry = R.curry(
// (
// bill: Bill,
// allocatedLandedCost: BillLandedCost,
// fromTransactionEntry: ILandedCostTransactionEntry,
// allocatedEntry: BillLandedCostEntry
// ): ILedgerEntry[] => {
// const inventoryEntry = this.getLandedCostGLInventoryEntry(
// bill,
// allocatedLandedCost,
// allocatedEntry
// );
// const costEntry = this.getLandedCostGLCostEntry(
// bill,
// allocatedLandedCost,
// fromTransactionEntry
// );
// return [inventoryEntry, costEntry];
// }
// );
// /** const localAmount =
// * Compose the landed cost GL entries. allocatedEntry.cost * (allocatedLandedCost.exchangeRate || 1);
// * @param {BillLandedCost} allocatedLandedCost
// * @param {Bill} bill
// * @param {ILandedCostTransactionEntry} fromTransactionEntry
// * @returns {ILedgerEntry[]}
// */
// public getLandedCostGLEntries = (
// allocatedLandedCost: BillLandedCost,
// bill: Bill,
// fromTransactionEntry: ILandedCostTransactionEntry
// ): ILedgerEntry[] => {
// const getEntry = this.getLandedCostGLAllocateEntry(
// bill,
// allocatedLandedCost,
// fromTransactionEntry
// );
// return allocatedLandedCost.allocateEntries.map(getEntry).flat();
// };
// /** return {
// * Retrieves the landed cost GL ledger. ...commonEntry,
// * @param {BillLandedCost} allocatedLandedCost debit: localAmount,
// * @param {Bill} bill accountId,
// * @param {ILandedCostTransactionEntry} fromTransactionEntry index: index + 1,
// * @returns {ILedger} indexGroup: 10,
// */ itemId: itemEntry?.itemId,
// public getLandedCostLedger = ( accountNormal: AccountNormal.DEBIT,
// allocatedLandedCost: BillLandedCost, };
// bill: Bill, }
// fromTransactionEntry: ILandedCostTransactionEntry
// ): ILedger => {
// const entries = this.getLandedCostGLEntries(
// allocatedLandedCost,
// bill,
// fromTransactionEntry
// );
// return new Ledger(entries);
// };
// /** /**
// * Writes landed cost GL entries to the storage layer. * Retrieves the landed cost GL cost entry (credit to cost account).
// * @param {number} tenantId - */
// */ private getLandedCostGLCostEntry(
// public writeLandedCostGLEntries = async ( bill: Bill,
// allocatedLandedCost: BillLandedCost, allocatedLandedCost: BillLandedCost,
// bill: Bill, ): ILedgerEntry {
// fromTransactionEntry: ILandedCostTransactionEntry, const commonEntry = this.getLandedCostGLCommonEntry(
// trx?: Knex.Transaction bill,
// ) => { allocatedLandedCost,
// const ledgerEntries = this.getLandedCostGLEntries( );
// allocatedLandedCost,
// bill,
// fromTransactionEntry
// );
// await this.ledgerRepository.saveLedgerEntries(ledgerEntries, trx);
// };
// /** return {
// * Generates and writes GL entries of the given landed cost. ...commonEntry,
// * @param {number} billLandedCostId credit: allocatedLandedCost.localAmount,
// * @param {Knex.Transaction} trx accountId: allocatedLandedCost.costAccountId,
// */ index: 1,
// public createLandedCostGLEntries = async ( indexGroup: 20,
// billLandedCostId: number, accountNormal: AccountNormal.CREDIT,
// trx?: Knex.Transaction };
// ) => { }
// // Retrieve the bill landed cost transacion with associated
// // allocated entries and items.
// const allocatedLandedCost = await this.billLandedCostModel().query(trx)
// .findById(billLandedCostId)
// .withGraphFetched('bill')
// .withGraphFetched('allocateEntries.itemEntry.item');
// // Retrieve the allocated from transactione entry. /**
// const transactionEntry = await this.getLandedCostEntry( * Composes the landed cost GL entries.
// allocatedLandedCost.fromTransactionType, */
// allocatedLandedCost.fromTransactionId, public getLandedCostGLEntries(
// allocatedLandedCost.fromTransactionEntryId allocatedLandedCost: BillLandedCost,
// ); bill: Bill,
// // Writes the given landed cost GL entries to the storage layer. ): ILedgerEntry[] {
// await this.writeLandedCostGLEntries( const inventoryEntries = allocatedLandedCost.allocateEntries.map(
// allocatedLandedCost, (allocatedEntry, index) =>
// allocatedLandedCost.bill, this.getLandedCostGLInventoryEntry(
// transactionEntry, bill,
// trx allocatedLandedCost,
// ); allocatedEntry,
// }; index,
),
);
const costEntry = this.getLandedCostGLCostEntry(bill, allocatedLandedCost);
// /** return [...inventoryEntries, costEntry];
// * Reverts GL entries of the given allocated landed cost transaction. }
// * @param {number} tenantId
// * @param {number} landedCostId /**
// * @param {Knex.Transaction} trx * Retrieves the landed cost GL ledger.
// */ */
// public revertLandedCostGLEntries = async ( public getLandedCostLedger(
// landedCostId: number, allocatedLandedCost: BillLandedCost,
// trx: Knex.Transaction bill: Bill,
// ) => { ): Ledger {
// await this.journalService.revertJournalTransactions( const entries = this.getLandedCostGLEntries(allocatedLandedCost, bill);
// landedCostId, return new Ledger(entries);
// 'LandedCost', }
// trx
// ); /**
// }; * Generates and writes GL entries of the given landed cost.
// } */
public createLandedCostGLEntries = async (
billLandedCostId: number,
trx?: Knex.Transaction,
) => {
const allocatedLandedCost = await this.billLandedCostModel()
.query(trx)
.findById(billLandedCostId)
.withGraphFetched('bill')
.withGraphFetched('allocateEntries.itemEntry.item');
if (!allocatedLandedCost?.bill) {
throw new Error('BillLandedCost or associated Bill not found');
}
const ledger = this.getLandedCostLedger(
allocatedLandedCost,
allocatedLandedCost.bill,
);
await this.ledgerStorage.commit(ledger, trx);
};
/**
* Reverts GL entries of the given allocated landed cost transaction.
*/
public revertLandedCostGLEntries = async (
landedCostId: number,
trx?: Knex.Transaction,
) => {
await this.ledgerStorage.deleteByReference(landedCostId, 'LandedCost', trx);
};
}

View File

@@ -3,14 +3,15 @@ import {
IAllocatedLandedCostDeletedPayload, IAllocatedLandedCostDeletedPayload,
} from '../types/BillLandedCosts.types'; } from '../types/BillLandedCosts.types';
import { OnEvent } from '@nestjs/event-emitter'; import { OnEvent } from '@nestjs/event-emitter';
// import { LandedCostGLEntries } from './LandedCostGLEntries.service';
import { Injectable } from '@nestjs/common'; import { Injectable } from '@nestjs/common';
import { events } from '@/common/events/events'; import { events } from '@/common/events/events';
import { LandedCostGLEntriesService } from './LandedCostGLEntries.service';
@Injectable() @Injectable()
export class LandedCostGLEntriesSubscriber { export class LandedCostGLEntriesSubscriber {
constructor() // private readonly billLandedCostGLEntries: LandedCostGLEntries, constructor(
{} private readonly landedCostGLEntries: LandedCostGLEntriesService,
) {}
/** /**
* Writes GL entries once landed cost transaction created. * Writes GL entries once landed cost transaction created.
@@ -21,10 +22,10 @@ export class LandedCostGLEntriesSubscriber {
billLandedCost, billLandedCost,
trx, trx,
}: IAllocatedLandedCostCreatedPayload) { }: IAllocatedLandedCostCreatedPayload) {
// await this.billLandedCostGLEntries.createLandedCostGLEntries( await this.landedCostGLEntries.createLandedCostGLEntries(
// billLandedCost.id, billLandedCost.id,
// trx trx,
// ); );
} }
/** /**
@@ -32,13 +33,13 @@ export class LandedCostGLEntriesSubscriber {
* @param {IAllocatedLandedCostDeletedPayload} payload - * @param {IAllocatedLandedCostDeletedPayload} payload -
*/ */
@OnEvent(events.billLandedCost.onDeleted) @OnEvent(events.billLandedCost.onDeleted)
async revertGLEnteriesOnceLandedCostDeleted({ async revertGLEntriesOnceLandedCostDeleted({
oldBillLandedCost, oldBillLandedCost,
trx, trx,
}: IAllocatedLandedCostDeletedPayload) { }: IAllocatedLandedCostDeletedPayload) {
// await this.billLandedCostGLEntries.revertLandedCostGLEntries( await this.landedCostGLEntries.revertLandedCostGLEntries(
// oldBillLandedCost.id, oldBillLandedCost.id,
// trx trx,
// ); );
} }
} }

View File

@@ -14,7 +14,7 @@ import { LandedCostTransactionsQueryDto } from '../dtos/LandedCostTransactionsQu
@Injectable() @Injectable()
export class LandedCostTranasctions { export class LandedCostTranasctions {
constructor(private readonly transactionLandedCost: TransactionLandedCost) {} constructor(private readonly transactionLandedCost: TransactionLandedCost) { }
/** /**
* Retrieve the landed costs based on the given query. * Retrieve the landed costs based on the given query.
@@ -45,8 +45,8 @@ export class LandedCostTranasctions {
)(transactionType); )(transactionType);
return pipe( return pipe(
this.transformLandedCostTransactions,
R.map(transformLandedCost), R.map(transformLandedCost),
this.transformLandedCostTransactions,
)(transactions); )(transactions);
}; };
@@ -90,7 +90,7 @@ export class LandedCostTranasctions {
const entries = R.map< const entries = R.map<
ILandedCostTransactionEntry, ILandedCostTransactionEntry,
ILandedCostTransactionEntryDOJO ILandedCostTransactionEntryDOJO
>(transformLandedCostEntry)(transaction.entries); >(transformLandedCostEntry)(transaction.entries ?? []);
return { return {
...transaction, ...transaction,

View File

@@ -4,7 +4,6 @@ import {
IsOptional, IsOptional,
IsArray, IsArray,
ValidateNested, ValidateNested,
IsDecimal,
IsString, IsString,
IsNumber, IsNumber,
} from 'class-validator'; } from 'class-validator';
@@ -17,8 +16,9 @@ export class AllocateBillLandedCostItemDto {
@ToNumber() @ToNumber()
entryId: number; entryId: number;
@IsDecimal() @IsNumber()
cost: string; // Use string for IsDecimal, or use @IsNumber() if you want a number @ToNumber()
cost: number;
} }
export class AllocateBillLandedCostDto { export class AllocateBillLandedCostDto {

View File

@@ -60,8 +60,8 @@ export class BillLandedCost extends BaseModel {
const allocationMethod = lowerCase(this.allocationMethod); const allocationMethod = lowerCase(this.allocationMethod);
const keyLabelsPairs = { const keyLabelsPairs = {
value: 'allocation_method.value.label', value: 'bill.allocation_method.value',
quantity: 'allocation_method.quantity.label', quantity: 'bill.allocation_method.quantity',
}; };
return keyLabelsPairs[allocationMethod] || ''; return keyLabelsPairs[allocationMethod] || '';
} }

View File

@@ -14,6 +14,7 @@ import { BranchesSettingsService } from '../Branches/BranchesSettings';
import { BillPaymentsController } from './BillPayments.controller'; import { BillPaymentsController } from './BillPayments.controller';
import { BillPaymentGLEntries } from './commands/BillPaymentGLEntries'; import { BillPaymentGLEntries } from './commands/BillPaymentGLEntries';
import { BillPaymentGLEntriesSubscriber } from './subscribers/BillPaymentGLEntriesSubscriber'; import { BillPaymentGLEntriesSubscriber } from './subscribers/BillPaymentGLEntriesSubscriber';
import { BillPaymentBillSyncSubscriber } from './subscribers/BillPaymentBillSyncSubscriber';
import { LedgerModule } from '../Ledger/Ledger.module'; import { LedgerModule } from '../Ledger/Ledger.module';
import { AccountsModule } from '../Accounts/Accounts.module'; import { AccountsModule } from '../Accounts/Accounts.module';
import { BillPaymentsExportable } from './queries/BillPaymentsExportable'; import { BillPaymentsExportable } from './queries/BillPaymentsExportable';
@@ -39,6 +40,7 @@ import { BillPaymentsPages } from './commands/BillPaymentsPages.service';
TenancyContext, TenancyContext,
BillPaymentGLEntries, BillPaymentGLEntries,
BillPaymentGLEntriesSubscriber, BillPaymentGLEntriesSubscriber,
BillPaymentBillSyncSubscriber,
BillPaymentsExportable, BillPaymentsExportable,
BillPaymentsImportable, BillPaymentsImportable,
GetBillPaymentsService, GetBillPaymentsService,
@@ -52,4 +54,4 @@ import { BillPaymentsPages } from './commands/BillPaymentsPages.service';
], ],
controllers: [BillPaymentsController], controllers: [BillPaymentsController],
}) })
export class BillPaymentsModule {} export class BillPaymentsModule { }

View File

@@ -38,7 +38,7 @@ export class CreateBillPaymentService {
@Inject(BillPayment.name) @Inject(BillPayment.name)
private readonly billPaymentModel: TenantModelProxy<typeof BillPayment>, private readonly billPaymentModel: TenantModelProxy<typeof BillPayment>,
) {} ) { }
/** /**
* Creates a new bill payment transcations and store it to the storage * Creates a new bill payment transcations and store it to the storage
@@ -103,11 +103,19 @@ export class CreateBillPaymentService {
} as IBillPaymentCreatingPayload); } as IBillPaymentCreatingPayload);
// Writes the bill payment graph to the storage. // Writes the bill payment graph to the storage.
const billPayment = await this.billPaymentModel() const insertedBillPayment = await this.billPaymentModel()
.query(trx) .query(trx)
.insertGraphAndFetch({ .insertGraphAndFetch({
...billPaymentObj, ...billPaymentObj,
}); });
// Fetch the bill payment with entries to ensure they're loaded for the subscriber.
const billPayment = await this.billPaymentModel()
.query(trx)
.withGraphFetched('entries')
.findById(insertedBillPayment.id)
.throwIfNotFound();
// Triggers `onBillPaymentCreated` event. // Triggers `onBillPaymentCreated` event.
await this.eventPublisher.emitAsync(events.billPayment.onCreated, { await this.eventPublisher.emitAsync(events.billPayment.onCreated, {
billPayment, billPayment,

View File

@@ -29,7 +29,7 @@ export class EditBillPayment {
@Inject(Vendor.name) @Inject(Vendor.name)
private readonly vendorModel: TenantModelProxy<typeof Vendor>, private readonly vendorModel: TenantModelProxy<typeof Vendor>,
) {} ) { }
/** /**
* Edits the details of the given bill payment. * Edits the details of the given bill payment.
@@ -116,12 +116,20 @@ export class EditBillPayment {
} as IBillPaymentEditingPayload); } as IBillPaymentEditingPayload);
// Edits the bill payment transaction graph on the storage. // Edits the bill payment transaction graph on the storage.
const billPayment = await this.billPaymentModel() await this.billPaymentModel()
.query(trx) .query(trx)
.upsertGraphAndFetch({ .upsertGraph({
id: billPaymentId, id: billPaymentId,
...billPaymentObj, ...billPaymentObj,
}); });
// Fetch the bill payment with entries to ensure they're loaded for the subscriber.
const billPayment = await this.billPaymentModel()
.query(trx)
.withGraphFetched('entries')
.findById(billPaymentId)
.throwIfNotFound();
// Triggers `onBillPaymentEdited` event. // Triggers `onBillPaymentEdited` event.
await this.eventPublisher.emitAsync(events.billPayment.onEdited, { await this.eventPublisher.emitAsync(events.billPayment.onEdited, {
billPaymentId, billPaymentId,

View File

@@ -104,6 +104,12 @@ export class BillPaymentResponseDto {
@ApiProperty({ description: 'The formatted amount', example: '100.00 USD' }) @ApiProperty({ description: 'The formatted amount', example: '100.00 USD' })
formattedAmount: string; formattedAmount: string;
@ApiProperty({ description: 'The formatted total', example: '100.00 USD' })
formattedTotal: string;
@ApiProperty({ description: 'The formatted subtotal', example: '100.00 USD' })
formattedSubtotal: string;
@ApiProperty({ @ApiProperty({
description: 'The date when the payment was created', description: 'The date when the payment was created',
example: '2024-01-01T12:00:00Z', example: '2024-01-01T12:00:00Z',

Some files were not shown because too many files have changed in this diff Show More