Compare commits

..

69 Commits

Author SHA1 Message Date
Ahmed Bouhuolia
b768f18294 chore: change subscription prices 2024-08-19 13:08:09 +02:00
Ahmed Bouhuolia
25297bc191 chore: dump CHANGELOG 2024-08-18 20:56:10 +02:00
Ahmed Bouhuolia
1989887b25 Merge pull request #615 from bigcapitalhq/activate-account-from-drawer
feat: activate/inactivate account from drawer details
2024-08-18 20:24:07 +02:00
Ahmed Bouhuolia
e4fb126d39 feat: activate/inactivate account from drawer details 2024-08-18 20:23:47 +02:00
Ahmed Bouhuolia
5fcb2d9cc9 Merge pull request #614 from bigcapitalhq/delete-bank-account-with-uncategorized-transactions
fix: Delete bank account with uncategorized transactions
2024-08-18 19:55:15 +02:00
Ahmed Bouhuolia
06ea631732 fix: making pagination more readable 2024-08-18 19:38:15 +02:00
Ahmed Bouhuolia
2f21107a43 feat: delete uncategorized transactions before deleting bank account 2024-08-18 19:30:09 +02:00
Ahmed Bouhuolia
fb8118bea8 fix: Delete bank account with uncategorized transactions 2024-08-18 14:20:23 +02:00
Ahmed Bouhuolia
4ba1c0aa22 Merge pull request #612 from Champetaman/fix-manual-journal-date-expense-drawer
Fix: Correctly display Date, Published At, and Created At in ExpenseDrawerHeader
2024-08-18 11:20:25 +02:00
Ahmed Bouhuolia
169f115fa0 fix: remove the default value from date and createdAt because always required 2024-08-18 11:19:06 +02:00
Ahmed Bouhuolia
61ab2b78d9 Merge pull request #613 from bigcapitalhq/language-typos
fix: Language typos
2024-08-18 11:12:49 +02:00
Ahmed Bouhuolia
93732430fc fix: Language typos 2024-08-18 11:11:17 +02:00
Camilo Oviedo
0215206220 add: Created attribute formattedPublishedAt to display on Expense Drawer 2024-08-17 10:11:05 +10:00
Camilo Oviedo
3c8956fedf fix: Correctly display Date, Published At, and Created At fields 2024-08-17 10:09:44 +10:00
Ahmed Bouhuolia
4477ada1ad Merge pull request #611 from bigcapitalhq/fix-connection-lost
fix: Database connection lost error
2024-08-15 23:48:28 +02:00
Ahmed Bouhuolia
fde9ccc5ca fix: Database connection lost error 2024-08-15 23:47:21 +02:00
Ahmed Bouhuolia
bbbd96f159 Merge pull request #604 from bigcapitalhq/inconsistance-pagination-page-size
fix: inconsistance page size of paginated data tables
2024-08-14 22:14:03 +02:00
Ahmed Bouhuolia
9f4de8115f fix: initial page size to the data tables from store state 2024-08-14 22:12:21 +02:00
Ahmed Bouhuolia
d9f241a2f8 Merge branch 'develop' into inconsistance-pagination-page-size 2024-08-14 22:01:04 +02:00
Ahmed Bouhuolia
ee96dc68cc fix: Change Dropzone title and subtitle (#607) 2024-08-14 20:13:45 +02:00
Ahmed Bouhuolia
b12f090d13 fix: matching bank transactions should create associate payment transactions for bills and invoicese. (#606) 2024-08-14 19:23:15 +02:00
allcontributors[bot]
f6ce761a27 docs: add Champetaman as a contributor for code (#605)
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-08-14 16:20:50 +02:00
Ahmed Bouhuolia
8c89e04f54 Merge pull request #603 from Champetaman/fix-import-drag-area-colors-blue
Fix: Enhance Dropzone visual feedback for dropzone
2024-08-14 16:17:44 +02:00
Ahmed Bouhuolia
f97b127a69 fix: style tweaks in dropzoen accept/reject modes 2024-08-14 16:12:13 +02:00
Ahmed Bouhuolia
5c1fa8f5cd fix: inconsistance page size of paginated data tables 2024-08-14 15:23:14 +02:00
Ahmed Bouhuolia
64c4d7b5a4 Merge pull request #599 from bigcapitalhq/rename-payment-receives-to-payment-received
fix: Typo payment receive messages
2024-08-14 14:54:54 +02:00
Ahmed Bouhuolia
ea2fad648b Merge branch 'develop' into rename-payment-receives-to-payment-received 2024-08-14 14:54:48 +02:00
Camilo Oviedo
9b8b51cb91 fix: Enhance visual feedback on file drag-and-drop 2024-08-14 16:29:38 +10:00
Camilo Oviedo
09b7e74d65 fix: Enhance visual feedback on file drag-and-drop 2024-08-14 16:21:48 +10:00
Ahmed Bouhuolia
7137e06d99 Merge pull request #602 from bigcapitalhq/remove-views-tabs-from-receipts-list
fix: Remove views tabs from receipts list
2024-08-14 00:06:14 +02:00
Ahmed Bouhuolia
fc29b765f7 fix: remove views tabs from receipts list 2024-08-14 00:04:11 +02:00
Ahmed Bouhuolia
2946475f89 Merge pull request #601 from bigcapitalhq/autofill-quick-customer-vendor
fix: Autofill the quick created customer/vendor
2024-08-13 23:59:26 +02:00
Ahmed Bouhuolia
d2193fdac0 fix: autofill the quick created customer/vendor 2024-08-13 23:55:53 +02:00
Ahmed Bouhuolia
ec2b7e332e Merge pull request #600 from bigcapitalhq/fix-typo-categories-list
fix: Typo categories list
2024-08-13 19:39:17 +02:00
Ahmed Bouhuolia
a3704df6dd fix: Typo categories list 2024-08-13 19:38:07 +02:00
Ahmed Bouhuolia
c3c784e52c Merge pull request #598 from bigcapitalhq/move-payment-mades-to-payments-made
fix: Typo payments made
2024-08-13 19:33:02 +02:00
Ahmed Bouhuolia
bbcf695a6c fix: Typo payments made 2024-08-13 19:10:09 +02:00
Ahmed Bouhuolia
038d4dd5a7 chore: renmame payment receive term to payment received 2024-08-13 15:15:07 +02:00
Ahmed Bouhuolia
961e4b99e8 fix: rename interfaces to PaymentReceived 2024-08-13 14:17:37 +02:00
Ahmed Bouhuolia
9991eebaaf fix(server): rename term to 2024-08-13 13:41:09 +02:00
Ahmed Bouhuolia
cd90fede54 Merge pull request #597 from bigcapitalhq/refresh-acccounts-bank-transactions
fix: Refresh accounts and account transactions.
2024-08-13 11:39:11 +02:00
Ahmed Bouhuolia
a2d28648bd fix: refresh accounts and account transactions. 2024-08-13 11:37:59 +02:00
Ahmed Bouhuolia
3097d05eda Merge pull request #596 from bigcapitalhq/transaction-type-description-general-ledger
fix: Transaction type and description do not show in general ledger.
2024-08-12 21:11:02 +02:00
Ahmed Bouhuolia
ff94d8d9b2 fix: Transaction type and description do not show in general ledger. 2024-08-12 21:08:02 +02:00
Ahmed Bouhuolia
79cc09fad9 Merge pull request #595 from bigcapitalhq/add-comparators-to-amount-bank-rule
feat: Add amount comparators to amount bank rule field
2024-08-12 20:17:20 +02:00
Ahmed Bouhuolia
c1b29c3f23 fix: add equal condition to number fields on bank rule 2024-08-12 20:16:18 +02:00
Ahmed Bouhuolia
cf4bb3007e feat: run re-recognizing bank transactions on edit bank rule 2024-08-12 20:07:01 +02:00
Ahmed Bouhuolia
193a86cf30 feat: add amount comparators to amount bank rule field 2024-08-12 17:53:57 +02:00
Ahmed Bouhuolia
7a81f14eb2 Merge pull request #594 from bigcapitalhq/multi-lines-transactions-statements
fix: Multi-lines transactions statements
2024-08-12 16:33:01 +02:00
Ahmed Bouhuolia
14d1f0bd1d fix: Multi-lines transactions statements 2024-08-12 16:31:36 +02:00
Ahmed Bouhuolia
82f8648c59 Merge pull request #593 from bigcapitalhq/fix-round-pending-matching
fix: Rounding the total amount the pending and matched transactions
2024-08-12 13:01:27 +02:00
Ahmed Bouhuolia
c928940d32 fix: rounding the total amount the pending and matched transactions 2024-08-12 13:01:00 +02:00
Ahmed Bouhuolia
0a78d56015 Merge pull request #592 from bigcapitalhq/matching-reconcile-branches
fix: Should not load branches on reconcile matching form if the branches not enabled
2024-08-12 11:29:48 +02:00
Ahmed Bouhuolia
1a5716873e fix: should not load branches on reconcile matching form if the branches not enabled 2024-08-12 11:28:34 +02:00
Ahmed Bouhuolia
01b7c86ab9 Merge pull request #588 from Champetaman/fix-dev-variable-setting-error
Update `dev` Script in `package.json` to Use `cross-env`
2024-08-12 10:55:45 +02:00
Ahmed Bouhuolia
0ca209b195 Merge pull request #589 from bigcapitalhq/bank-pending-transactions
feat: Pending bank transactions
2024-08-12 10:54:32 +02:00
Ahmed Bouhuolia
be6f6e3c73 fix: function description 2024-08-12 10:54:16 +02:00
Ahmed Bouhuolia
cb016be78c fix: avoid decrement/increment for pending bank transactions 2024-08-12 10:48:36 +02:00
Ahmed Bouhuolia
fc085f2328 Merge pull request #587 from bigcapitalhq/big-244-uncategorize-bank-transactions-in-bulk
feat: Uncategorize bank transactions in bulk
2024-08-12 10:11:55 +02:00
Ahmed Bouhuolia
9a34f3e283 fix: invalidate account cache on bulk uncategorizing 2024-08-12 10:11:40 +02:00
Ahmed Bouhuolia
7054e862d5 feat: pending transactions table 2024-08-11 22:51:58 +02:00
Ahmed Bouhuolia
faa81abee4 feat(banking): uncategorize bank transactions in bulk 2024-08-11 21:26:02 +02:00
Ahmed Bouhuolia
6d01f2a323 Merge pull request #591 from bigcapitalhq/import-export-tax-rates
feat: import and export tax rates
2024-08-11 19:51:50 +02:00
Ahmed Bouhuolia
72678bb936 feat: import and export tax rates 2024-08-11 19:51:16 +02:00
Ahmed Bouhuolia
9ae5644af9 feat: Pending bank transactions 2024-08-11 16:14:13 +02:00
Camilo Oviedo
e8830c5911 Fix dev variable setting causing error on windows for craco start command 2024-08-11 22:14:54 +10:00
Camilo Oviedo
7699889bd6 Fix dev variable setting causing error on windows for craco start command 2024-08-11 21:57:50 +10:00
Ahmed Bouhuolia
35a061d188 feat: Uncategorize bank transactions in bulk 2024-08-11 13:02:38 +02:00
Ahmed Bouhuolia
c7c021c969 fix(banking): detarmine if Plaid item is disabled (#585) 2024-08-11 12:10:15 +02:00
311 changed files with 3113 additions and 1396 deletions

View File

@@ -150,6 +150,15 @@
"contributions": [ "contributions": [
"bug" "bug"
] ]
},
{
"login": "Champetaman",
"name": "Camilo Oviedo",
"avatar_url": "https://avatars.githubusercontent.com/u/64604272?v=4",
"profile": "https://www.camilooviedo.com/",
"contributions": [
"code"
]
} }
], ],
"contributorsPerLine": 7, "contributorsPerLine": 7,

View File

@@ -2,6 +2,27 @@
All notable changes to Bigcapital server-side will be in this file. All notable changes to Bigcapital server-side will be in this file.
## [0.19.4] - 18-08-2024
* fix: Allow multi-lines to statements transactions by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/594
* feat: Add amount comparators to amount bank rule field by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/595
* fix: Transaction type and description do not show in general ledger. by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/596
* fix: Refresh accounts and account transactions. by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/597
* fix: Typo payments made by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/598
* fix: Typo categories list by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/600
* fix: Autofill the quick created customer/vendor by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/601
* fix: Remove views tabs from receipts list by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/602
* fix: Typo payment receive messages by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/599
* fix: Enhance Dropzone visual of accept and reject modes by @Champetaman in https://github.com/bigcapitalhq/bigcapital/pull/603
* fix: Matching bank transactions should create associate payment transactions by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/606
* fix: Change Dropzone title and subtitle by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/607
* fix: Inconsistance page size of paginated data tables by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/604
* fix: Database connection lost error by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/611
* fix: Language typos by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/613
* Fix: Correctly display Date, Published At, and Created At in ExpenseDrawerHeader by @Champetaman in https://github.com/bigcapitalhq/bigcapital/pull/612
* fix: Delete bank account with uncategorized transactions by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/614
* feat: activate/inactivate account from drawer details by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/615
## [v0.18.0] - 10-08-2024 ## [v0.18.0] - 10-08-2024
* feat: Bank rules for automated categorization by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/511 * feat: Bank rules for automated categorization by @abouolia in https://github.com/bigcapitalhq/bigcapital/pull/511

View File

@@ -129,6 +129,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<tr> <tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/oleynikd"><img src="https://avatars.githubusercontent.com/u/3976868?v=4?s=100" width="100px;" alt="Denis"/><br /><sub><b>Denis</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Aoleynikd" title="Bug reports">🐛</a></td> <td align="center" valign="top" width="14.28%"><a href="https://github.com/oleynikd"><img src="https://avatars.githubusercontent.com/u/3976868?v=4?s=100" width="100px;" alt="Denis"/><br /><sub><b>Denis</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Aoleynikd" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://myself.vercel.app/"><img src="https://avatars.githubusercontent.com/u/42431274?v=4?s=100" width="100px;" alt="Sachin Mittal"/><br /><sub><b>Sachin Mittal</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Amittalsam98" title="Bug reports">🐛</a></td> <td align="center" valign="top" width="14.28%"><a href="https://myself.vercel.app/"><img src="https://avatars.githubusercontent.com/u/42431274?v=4?s=100" width="100px;" alt="Sachin Mittal"/><br /><sub><b>Sachin Mittal</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/issues?q=author%3Amittalsam98" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.camilooviedo.com/"><img src="https://avatars.githubusercontent.com/u/64604272?v=4?s=100" width="100px;" alt="Camilo Oviedo"/><br /><sub><b>Camilo Oviedo</b></sub></a><br /><a href="https://github.com/bigcapitalhq/bigcapital/commits?author=Champetaman" title="Code">💻</a></td>
</tr> </tr>
</tbody> </tbody>
</table> </table>

View File

@@ -69,9 +69,8 @@
"is-my-json-valid": "^2.20.5", "is-my-json-valid": "^2.20.5",
"js-money": "^0.6.3", "js-money": "^0.6.3",
"jsonwebtoken": "^8.5.1", "jsonwebtoken": "^8.5.1",
"knex": "^0.95.15", "knex": "^3.1.0",
"knex-cleaner": "^1.3.0", "knex-cleaner": "^1.3.0",
"knex-db-manager": "^0.6.1",
"libphonenumber-js": "^1.9.6", "libphonenumber-js": "^1.9.6",
"lodash": "^4.17.15", "lodash": "^4.17.15",
"lru-cache": "^6.0.0", "lru-cache": "^6.0.0",

View File

@@ -1,9 +1,10 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { NextFunction, Request, Response, Router } from 'express'; import { NextFunction, Request, Response, Router } from 'express';
import { param, query } from 'express-validator';
import BaseController from '@/api/controllers/BaseController'; import BaseController from '@/api/controllers/BaseController';
import { GetBankAccountSummary } from '@/services/Banking/BankAccounts/GetBankAccountSummary'; import { GetBankAccountSummary } from '@/services/Banking/BankAccounts/GetBankAccountSummary';
import { BankAccountsApplication } from '@/services/Banking/BankAccounts/BankAccountsApplication'; import { BankAccountsApplication } from '@/services/Banking/BankAccounts/BankAccountsApplication';
import { param } from 'express-validator'; import { GetPendingBankAccountTransactions } from '@/services/Cashflow/GetPendingBankAccountTransaction';
@Service() @Service()
export class BankAccountsController extends BaseController { export class BankAccountsController extends BaseController {
@@ -13,6 +14,9 @@ export class BankAccountsController extends BaseController {
@Inject() @Inject()
private bankAccountsApp: BankAccountsApplication; private bankAccountsApp: BankAccountsApplication;
@Inject()
private getPendingTransactionsService: GetPendingBankAccountTransactions;
/** /**
* Router constructor. * Router constructor.
*/ */
@@ -20,6 +24,16 @@ export class BankAccountsController extends BaseController {
const router = Router(); const router = Router();
router.get('/:bankAccountId/meta', this.getBankAccountSummary.bind(this)); router.get('/:bankAccountId/meta', this.getBankAccountSummary.bind(this));
router.get(
'/pending_transactions',
[
query('account_id').optional().isNumeric().toInt(),
query('page').optional().isNumeric().toInt(),
query('page_size').optional().isNumeric().toInt(),
],
this.validationResult,
this.getBankAccountsPendingTransactions.bind(this)
);
router.post( router.post(
'/:bankAccountId/disconnect', '/:bankAccountId/disconnect',
this.disconnectBankAccount.bind(this) this.disconnectBankAccount.bind(this)
@@ -27,17 +41,13 @@ export class BankAccountsController extends BaseController {
router.post('/:bankAccountId/update', this.refreshBankAccount.bind(this)); router.post('/:bankAccountId/update', this.refreshBankAccount.bind(this));
router.post( router.post(
'/:bankAccountId/pause_feeds', '/:bankAccountId/pause_feeds',
[ [param('bankAccountId').exists().isNumeric().toInt()],
param('bankAccountId').exists().isNumeric().toInt(),
],
this.validationResult, this.validationResult,
this.pauseBankAccountFeeds.bind(this) this.pauseBankAccountFeeds.bind(this)
); );
router.post( router.post(
'/:bankAccountId/resume_feeds', '/:bankAccountId/resume_feeds',
[ [param('bankAccountId').exists().isNumeric().toInt()],
param('bankAccountId').exists().isNumeric().toInt(),
],
this.validationResult, this.validationResult,
this.resumeBankAccountFeeds.bind(this) this.resumeBankAccountFeeds.bind(this)
); );
@@ -72,6 +82,32 @@ export class BankAccountsController extends BaseController {
} }
} }
/**
* Retrieves the bank account pending transactions.
* @param {Request} req
* @param {Response} res
* @param {NextFunction} next
*/
async getBankAccountsPendingTransactions(
req: Request,
res: Response,
next: NextFunction
) {
const { tenantId } = req;
const query = this.matchedQueryData(req);
try {
const data =
await this.getPendingTransactionsService.getPendingTransactions(
tenantId,
query
);
return res.status(200).send(data);
} catch (error) {
next(error);
}
}
/** /**
* Disonnect the given bank account. * Disonnect the given bank account.
* @param {Request} req * @param {Request} req

View File

@@ -33,7 +33,16 @@ export class BankingRulesController extends BaseController {
body('conditions.*.field').exists().isIn(['description', 'amount']), body('conditions.*.field').exists().isIn(['description', 'amount']),
body('conditions.*.comparator') body('conditions.*.comparator')
.exists() .exists()
.isIn(['equals', 'contains', 'not_contain']) .isIn([
'equals',
'equal',
'contains',
'not_contain',
'bigger',
'bigger_or_equal',
'smaller',
'smaller_or_equal',
])
.default('contain') .default('contain')
.trim(), .trim(),
body('conditions.*.value').exists().trim(), body('conditions.*.value').exists().trim(),

View File

@@ -1,5 +1,5 @@
import { Service, Inject } from 'typedi'; import { Service, Inject } from 'typedi';
import { ValidationChain, check, param, query } from 'express-validator'; import { ValidationChain, body, check, param, query } from 'express-validator';
import { Router, Request, Response, NextFunction } from 'express'; import { Router, Request, Response, NextFunction } from 'express';
import { omit } from 'lodash'; import { omit } from 'lodash';
import BaseController from '../BaseController'; import BaseController from '../BaseController';
@@ -43,6 +43,16 @@ export default class NewCashflowTransactionController extends BaseController {
this.asyncMiddleware(this.newCashflowTransaction), this.asyncMiddleware(this.newCashflowTransaction),
this.catchServiceErrors this.catchServiceErrors
); );
router.post(
'/transactions/uncategorize/bulk',
[
body('ids').isArray({ min: 1 }),
body('ids.*').exists().isNumeric().toInt(),
],
this.validationResult,
this.uncategorizeBulkTransactions.bind(this),
this.catchServiceErrors
);
router.post( router.post(
'/transactions/:id/uncategorize', '/transactions/:id/uncategorize',
this.revertCategorizedCashflowTransaction, this.revertCategorizedCashflowTransaction,
@@ -184,6 +194,34 @@ export default class NewCashflowTransactionController extends BaseController {
} }
}; };
/**
* Uncategorize the given transactions in bulk.
* @param {Request<{}>} req
* @param {Response} res
* @param {NextFunction} next
* @returns {Promise<Response | null>}
*/
private uncategorizeBulkTransactions = async (
req: Request<{}>,
res: Response,
next: NextFunction
) => {
const { tenantId } = req;
const { ids: uncategorizedTransactionIds } = this.matchedBodyData(req);
try {
await this.cashflowApplication.uncategorizeTransactions(
tenantId,
uncategorizedTransactionIds
);
return res.status(200).send({
message: 'The given transactions have been uncategorized successfully.',
});
} catch (error) {
next(error);
}
};
/** /**
* Categorize the cashflow transaction. * Categorize the cashflow transaction.
* @param {Request} req * @param {Request} req

View File

@@ -9,9 +9,9 @@ import {
} from '@/interfaces'; } from '@/interfaces';
import BaseController from '@/api/controllers/BaseController'; import BaseController from '@/api/controllers/BaseController';
import asyncMiddleware from '@/api/middleware/asyncMiddleware'; import asyncMiddleware from '@/api/middleware/asyncMiddleware';
import PaymentReceivesPages from '@/services/Sales/PaymentReceives/PaymentReceivesPages'; import PaymentsReceivedPages from '@/services/Sales/PaymentReceived/PaymentsReceivedPages';
import { PaymentReceivesApplication } from '@/services/Sales/PaymentReceived/PaymentReceivedApplication';
import DynamicListingService from '@/services/DynamicListing/DynamicListService'; import DynamicListingService from '@/services/DynamicListing/DynamicListService';
import { PaymentReceivesApplication } from '@/services/Sales/PaymentReceives/PaymentReceivesApplication';
import CheckPolicies from '@/api/middleware/CheckPolicies'; import CheckPolicies from '@/api/middleware/CheckPolicies';
import { ServiceError } from '@/exceptions'; import { ServiceError } from '@/exceptions';
import { ACCEPT_TYPE } from '@/interfaces/Http'; import { ACCEPT_TYPE } from '@/interfaces/Http';
@@ -22,7 +22,7 @@ export default class PaymentReceivesController extends BaseController {
private paymentReceiveApplication: PaymentReceivesApplication; private paymentReceiveApplication: PaymentReceivesApplication;
@Inject() @Inject()
private PaymentReceivesPages: PaymentReceivesPages; private PaymentsReceivedPages: PaymentsReceivedPages;
@Inject() @Inject()
private dynamicListService: DynamicListingService; private dynamicListService: DynamicListingService;
@@ -229,7 +229,7 @@ export default class PaymentReceivesController extends BaseController {
try { try {
const storedPaymentReceive = const storedPaymentReceive =
await this.paymentReceiveApplication.createPaymentReceive( await this.paymentReceiveApplication.createPaymentReceived(
tenantId, tenantId,
paymentReceive, paymentReceive,
user user
@@ -376,7 +376,7 @@ export default class PaymentReceivesController extends BaseController {
const { customerId } = this.matchedQueryData(req); const { customerId } = this.matchedQueryData(req);
try { try {
const entries = await this.PaymentReceivesPages.getNewPageEntries( const entries = await this.PaymentsReceivedPages.getNewPageEntries(
tenantId, tenantId,
customerId customerId
); );
@@ -404,7 +404,7 @@ export default class PaymentReceivesController extends BaseController {
try { try {
const { paymentReceive, entries } = const { paymentReceive, entries } =
await this.PaymentReceivesPages.getPaymentReceiveEditPage( await this.PaymentsReceivedPages.getPaymentReceiveEditPage(
tenantId, tenantId,
paymentReceiveId, paymentReceiveId,
user user

View File

@@ -32,7 +32,7 @@ module.exports = {
*/ */
tenant: { tenant: {
db_client: process.env.TENANT_DB_CLIENT || process.env.DB_CLIENT || 'mysql', db_client: process.env.TENANT_DB_CLIENT || process.env.DB_CLIENT || 'mysql',
db_name_prefix: process.env.TENANT_DB_NAME_PERFIX, db_name_prefix: process.env.TENANT_DB_NAME_PERFIX || 'bigcapital_tenant_',
db_host: process.env.TENANT_DB_HOST || process.env.DB_HOST, db_host: process.env.TENANT_DB_HOST || process.env.DB_HOST,
db_user: process.env.TENANT_DB_USER || process.env.DB_USER, db_user: process.env.TENANT_DB_USER || process.env.DB_USER,
db_password: process.env.TENANT_DB_PASSWORD || process.env.DB_PASSWORD, db_password: process.env.TENANT_DB_PASSWORD || process.env.DB_PASSWORD,

View File

@@ -0,0 +1,13 @@
exports.up = function (knex) {
return knex.schema.table('uncategorized_cashflow_transactions', (table) => {
table.boolean('pending').defaultTo(false);
table.string('pending_plaid_transaction_id').nullable();
});
};
exports.down = function (knex) {
return knex.schema.table('uncategorized_cashflow_transactions', (table) => {
table.dropColumn('pending');
table.dropColumn('pending_plaid_transaction_id');
});
};

View File

@@ -268,6 +268,8 @@ export interface CreateUncategorizedTransactionDTO {
description?: string; description?: string;
referenceNo?: string | null; referenceNo?: string | null;
plaidTransactionId?: string | null; plaidTransactionId?: string | null;
pending?: boolean;
pendingPlaidTransactionId?: string | null;
batch?: string; batch?: string;
} }
@@ -283,3 +285,17 @@ export interface IUncategorizedTransactionCreatedEventPayload {
createUncategorizedTransactionDTO: CreateUncategorizedTransactionDTO; createUncategorizedTransactionDTO: CreateUncategorizedTransactionDTO;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPendingTransactionRemovingEventPayload {
tenantId: number;
uncategorizedTransactionId: number;
pendingTransaction: IUncategorizedCashflowTransaction;
trx?: Knex.Transaction;
}
export interface IPendingTransactionRemovedEventPayload {
tenantId: number;
uncategorizedTransactionId: number;
pendingTransaction: IUncategorizedCashflowTransaction;
trx?: Knex.Transaction;
}

View File

@@ -30,7 +30,7 @@ export interface IGeneralLedgerSheetAccountTransaction {
currencyCode: string; currencyCode: string;
note?: string; note?: string;
transactionType?: string; transactionTypeFormatted: string;
transactionNumber: string; transactionNumber: string;
referenceId?: number; referenceId?: number;

View File

@@ -8,7 +8,7 @@ import { ILedgerEntry } from './Ledger';
import { ISaleInvoice } from './SaleInvoice'; import { ISaleInvoice } from './SaleInvoice';
import { AttachmentLinkDTO } from './Attachments'; import { AttachmentLinkDTO } from './Attachments';
export interface IPaymentReceive { export interface IPaymentReceived {
id?: number; id?: number;
customerId: number; customerId: number;
paymentDate: Date; paymentDate: Date;
@@ -19,14 +19,14 @@ export interface IPaymentReceive {
depositAccountId: number; depositAccountId: number;
paymentReceiveNo: string; paymentReceiveNo: string;
statement: string; statement: string;
entries: IPaymentReceiveEntry[]; entries: IPaymentReceivedEntry[];
userId: number; userId: number;
createdAt: Date; createdAt: Date;
updatedAt: Date; updatedAt: Date;
localAmount?: number; localAmount?: number;
branchId?: number; branchId?: number;
} }
export interface IPaymentReceiveCreateDTO { export interface IPaymentReceivedCreateDTO {
customerId: number; customerId: number;
paymentDate: Date; paymentDate: Date;
amount: number; amount: number;
@@ -35,13 +35,13 @@ export interface IPaymentReceiveCreateDTO {
depositAccountId: number; depositAccountId: number;
paymentReceiveNo?: string; paymentReceiveNo?: string;
statement: string; statement: string;
entries: IPaymentReceiveEntryDTO[]; entries: IPaymentReceivedEntryDTO[];
branchId?: number; branchId?: number;
attachments?: AttachmentLinkDTO[]; attachments?: AttachmentLinkDTO[];
} }
export interface IPaymentReceiveEditDTO { export interface IPaymentReceivedEditDTO {
customerId: number; customerId: number;
paymentDate: Date; paymentDate: Date;
amount: number; amount: number;
@@ -50,12 +50,12 @@ export interface IPaymentReceiveEditDTO {
depositAccountId: number; depositAccountId: number;
paymentReceiveNo?: string; paymentReceiveNo?: string;
statement: string; statement: string;
entries: IPaymentReceiveEntryDTO[]; entries: IPaymentReceivedEntryDTO[];
branchId?: number; branchId?: number;
attachments?: AttachmentLinkDTO[]; attachments?: AttachmentLinkDTO[];
} }
export interface IPaymentReceiveEntry { export interface IPaymentReceivedEntry {
id?: number; id?: number;
paymentReceiveId: number; paymentReceiveId: number;
invoiceId: number; invoiceId: number;
@@ -64,15 +64,15 @@ export interface IPaymentReceiveEntry {
invoice?: ISaleInvoice; invoice?: ISaleInvoice;
} }
export interface IPaymentReceiveEntryDTO { export interface IPaymentReceivedEntryDTO {
id?: number; id?: number;
index: number; index: number;
paymentReceiveId: number; paymentReceiveId?: number;
invoiceId: number; invoiceId: number;
paymentAmount: number; paymentAmount: number;
} }
export interface IPaymentReceivesFilter extends IDynamicListFilterDTO { export interface IPaymentsReceivedFilter extends IDynamicListFilterDTO {
stringifiedFilterRoles?: string; stringifiedFilterRoles?: string;
} }
@@ -88,65 +88,65 @@ export interface IPaymentReceivePageEntry {
date: Date | string; date: Date | string;
} }
export interface IPaymentReceiveEditPage { export interface IPaymentReceivedEditPage {
paymentReceive: IPaymentReceive; paymentReceive: IPaymentReceived;
entries: IPaymentReceivePageEntry[]; entries: IPaymentReceivePageEntry[];
} }
export interface IPaymentsReceiveService { export interface IPaymentsReceivedService {
validateCustomerHasNoPayments( validateCustomerHasNoPayments(
tenantId: number, tenantId: number,
customerId: number customerId: number
): Promise<void>; ): Promise<void>;
} }
export interface IPaymentReceiveSmsDetails { export interface IPaymentReceivedSmsDetails {
customerName: string; customerName: string;
customerPhoneNumber: string; customerPhoneNumber: string;
smsMessage: string; smsMessage: string;
} }
export interface IPaymentReceiveCreatingPayload { export interface IPaymentReceivedCreatingPayload {
tenantId: number; tenantId: number;
paymentReceiveDTO: IPaymentReceiveCreateDTO; paymentReceiveDTO: IPaymentReceivedCreateDTO;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPaymentReceiveCreatedPayload { export interface IPaymentReceivedCreatedPayload {
tenantId: number; tenantId: number;
paymentReceive: IPaymentReceive; paymentReceive: IPaymentReceived;
paymentReceiveId: number; paymentReceiveId: number;
authorizedUser: ISystemUser; authorizedUser: ISystemUser;
paymentReceiveDTO: IPaymentReceiveCreateDTO; paymentReceiveDTO: IPaymentReceivedCreateDTO;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPaymentReceiveEditedPayload { export interface IPaymentReceivedEditedPayload {
tenantId: number; tenantId: number;
paymentReceiveId: number; paymentReceiveId: number;
paymentReceive: IPaymentReceive; paymentReceive: IPaymentReceived;
oldPaymentReceive: IPaymentReceive; oldPaymentReceive: IPaymentReceived;
paymentReceiveDTO: IPaymentReceiveEditDTO; paymentReceiveDTO: IPaymentReceivedEditDTO;
authorizedUser: ISystemUser; authorizedUser: ISystemUser;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPaymentReceiveEditingPayload { export interface IPaymentReceivedEditingPayload {
tenantId: number; tenantId: number;
oldPaymentReceive: IPaymentReceive; oldPaymentReceive: IPaymentReceived;
paymentReceiveDTO: IPaymentReceiveEditDTO; paymentReceiveDTO: IPaymentReceivedEditDTO;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPaymentReceiveDeletingPayload { export interface IPaymentReceivedDeletingPayload {
tenantId: number; tenantId: number;
oldPaymentReceive: IPaymentReceive; oldPaymentReceive: IPaymentReceived;
trx: Knex.Transaction; trx: Knex.Transaction;
} }
export interface IPaymentReceiveDeletedPayload { export interface IPaymentReceivedDeletedPayload {
tenantId: number; tenantId: number;
paymentReceiveId: number; paymentReceiveId: number;
oldPaymentReceive: IPaymentReceive; oldPaymentReceive: IPaymentReceived;
authorizedUser: ISystemUser; authorizedUser: ISystemUser;
trx: Knex.Transaction; trx: Knex.Transaction;
} }

View File

@@ -51,5 +51,4 @@ export interface ISystemService {
cache(); cache();
repositories(); repositories();
knex(); knex();
dbManager();
} }

View File

@@ -21,7 +21,7 @@ export default class ComputeItemCostJob {
agenda.define( agenda.define(
'compute-item-cost', 'compute-item-cost',
{ priority: 'high', concurrency: 1 }, { priority: 'high', concurrency: 20 },
this.handler.bind(this) this.handler.bind(this)
); );
this.agenda.on('start:compute-item-cost', this.onJobStart.bind(this)); this.agenda.on('start:compute-item-cost', this.onJobStart.bind(this));

View File

@@ -8,7 +8,7 @@ export default class OrganizationSetupJob {
constructor(agenda) { constructor(agenda) {
agenda.define( agenda.define(
'organization-setup', 'organization-setup',
{ priority: 'high', concurrency: 1 }, { priority: 'high', concurrency: 20 },
this.handler this.handler
); );
} }

View File

@@ -15,7 +15,7 @@ export default class WriteInvoicesJournalEntries {
agenda.define( agenda.define(
eventName, eventName,
{ priority: 'normal', concurrency: 1 }, { priority: 'normal', concurrency: 20 },
this.handler.bind(this) this.handler.bind(this)
); );
agenda.on(`complete:${eventName}`, this.onJobCompleted.bind(this)); agenda.on(`complete:${eventName}`, this.onJobCompleted.bind(this));

View File

@@ -1,7 +0,0 @@
import knexManager from 'knex-db-manager';
import { systemKnexConfig, systemDbManager } from 'config/knexConfig';
export default () => knexManager.databaseManagerFactory({
knex: systemKnexConfig,
dbManager: systemDbManager,
});

View File

@@ -3,7 +3,6 @@ import LoggerInstance from '@/loaders/logger';
import agendaFactory from '@/loaders/agenda'; import agendaFactory from '@/loaders/agenda';
import SmsClientLoader from '@/loaders/smsClient'; import SmsClientLoader from '@/loaders/smsClient';
import mailInstance from '@/loaders/mail'; import mailInstance from '@/loaders/mail';
import dbManagerFactory from '@/loaders/dbManager';
import i18n from '@/loaders/i18n'; import i18n from '@/loaders/i18n';
import repositoriesLoader from '@/loaders/systemRepositories'; import repositoriesLoader from '@/loaders/systemRepositories';
import Cache from '@/services/Cache'; import Cache from '@/services/Cache';
@@ -16,7 +15,6 @@ export default ({ mongoConnection, knex }) => {
try { try {
const agendaInstance = agendaFactory({ mongoConnection }); const agendaInstance = agendaFactory({ mongoConnection });
const smsClientInstance = SmsClientLoader(config.easySMSGateway.api_key); const smsClientInstance = SmsClientLoader(config.easySMSGateway.api_key);
const dbManager = dbManagerFactory(knex);
const cacheInstance = new Cache(); const cacheInstance = new Cache();
Container.set('logger', LoggerInstance); Container.set('logger', LoggerInstance);
@@ -24,7 +22,6 @@ export default ({ mongoConnection, knex }) => {
Container.set('SMSClient', smsClientInstance); Container.set('SMSClient', smsClientInstance);
Container.set('mail', mailInstance); Container.set('mail', mailInstance);
Container.set('dbManager', dbManager);
LoggerInstance.info( LoggerInstance.info(
'[DI] Database manager has been injected into container.' '[DI] Database manager has been injected into container.'
); );

View File

@@ -115,6 +115,7 @@ import { DecrementUncategorizedTransactionOnExclude } from '@/services/Banking/E
import { DecrementUncategorizedTransactionOnCategorize } from '@/services/Cashflow/subscribers/DecrementUncategorizedTransactionOnCategorize'; import { DecrementUncategorizedTransactionOnCategorize } from '@/services/Cashflow/subscribers/DecrementUncategorizedTransactionOnCategorize';
import { DisconnectPlaidItemOnAccountDeleted } from '@/services/Banking/BankAccounts/events/DisconnectPlaidItemOnAccountDeleted'; import { DisconnectPlaidItemOnAccountDeleted } from '@/services/Banking/BankAccounts/events/DisconnectPlaidItemOnAccountDeleted';
import { LoopsEventsSubscriber } from '@/services/Loops/LoopsEventsSubscriber'; import { LoopsEventsSubscriber } from '@/services/Loops/LoopsEventsSubscriber';
import { DeleteUncategorizedTransactionsOnAccountDeleting } from '@/services/Banking/BankAccounts/events/DeleteUncategorizedTransactionsOnAccountDeleting';
export default () => { export default () => {
return new EventPublisher(); return new EventPublisher();
@@ -277,6 +278,7 @@ export const susbcribers = () => {
// Plaid // Plaid
RecognizeSyncedBankTranasctions, RecognizeSyncedBankTranasctions,
DisconnectPlaidItemOnAccountDeleted, DisconnectPlaidItemOnAccountDeleted,
DeleteUncategorizedTransactionsOnAccountDeleting,
// Loops // Loops
LoopsEventsSubscriber LoopsEventsSubscriber

View File

@@ -34,4 +34,4 @@
// import 'services/Sales/SaleInvoiceWriteoffSubscriber'; // import 'services/Sales/SaleInvoiceWriteoffSubscriber';
// import 'subscribers/SaleInvoices/SendSmsNotificationToCustomer'; // import 'subscribers/SaleInvoices/SendSmsNotificationToCustomer';
// import 'subscribers/SaleReceipt/SendNotificationToCustomer'; // import 'subscribers/SaleReceipt/SendNotificationToCustomer';
// import 'services/Sales/PaymentReceives/PaymentReceiveSmsSubscriber'; // import 'services/Sales/PaymentReceived/PaymentReceiveSmsSubscriber';

View File

@@ -9,7 +9,7 @@ import { SendSaleInvoiceMailJob } from '@/services/Sales/Invoices/SendSaleInvoic
import { SendSaleInvoiceReminderMailJob } from '@/services/Sales/Invoices/SendSaleInvoiceMailReminderJob'; import { SendSaleInvoiceReminderMailJob } from '@/services/Sales/Invoices/SendSaleInvoiceMailReminderJob';
import { SendSaleEstimateMailJob } from '@/services/Sales/Estimates/SendSaleEstimateMailJob'; import { SendSaleEstimateMailJob } from '@/services/Sales/Estimates/SendSaleEstimateMailJob';
import { SaleReceiptMailNotificationJob } from '@/services/Sales/Receipts/SaleReceiptMailNotificationJob'; import { SaleReceiptMailNotificationJob } from '@/services/Sales/Receipts/SaleReceiptMailNotificationJob';
import { PaymentReceiveMailNotificationJob } from '@/services/Sales/PaymentReceives/PaymentReceiveMailNotificationJob'; import { PaymentReceivedMailNotificationJob } from '@/services/Sales/PaymentReceived/PaymentReceivedMailNotificationJob';
import { PlaidFetchTransactionsJob } from '@/services/Banking/Plaid/PlaidFetchTransactionsJob'; import { PlaidFetchTransactionsJob } from '@/services/Banking/Plaid/PlaidFetchTransactionsJob';
import { ImportDeleteExpiredFilesJobs } from '@/services/Import/jobs/ImportDeleteExpiredFilesJob'; import { ImportDeleteExpiredFilesJobs } from '@/services/Import/jobs/ImportDeleteExpiredFilesJob';
import { SendVerifyMailJob } from '@/services/Authentication/jobs/SendVerifyMailJob'; import { SendVerifyMailJob } from '@/services/Authentication/jobs/SendVerifyMailJob';
@@ -28,7 +28,7 @@ export default ({ agenda }: { agenda: Agenda }) => {
new SendSaleInvoiceReminderMailJob(agenda); new SendSaleInvoiceReminderMailJob(agenda);
new SendSaleEstimateMailJob(agenda); new SendSaleEstimateMailJob(agenda);
new SaleReceiptMailNotificationJob(agenda); new SaleReceiptMailNotificationJob(agenda);
new PaymentReceiveMailNotificationJob(agenda); new PaymentReceivedMailNotificationJob(agenda);
new PlaidFetchTransactionsJob(agenda); new PlaidFetchTransactionsJob(agenda);
new ImportDeleteExpiredFilesJobs(agenda); new ImportDeleteExpiredFilesJobs(agenda);
new SendVerifyMailJob(agenda); new SendVerifyMailJob(agenda);

View File

@@ -3,7 +3,7 @@ import TenantModel from 'models/TenantModel';
import ModelSetting from './ModelSetting'; import ModelSetting from './ModelSetting';
import BillPaymentSettings from './BillPayment.Settings'; import BillPaymentSettings from './BillPayment.Settings';
import CustomViewBaseModel from './CustomViewBaseModel'; import CustomViewBaseModel from './CustomViewBaseModel';
import { DEFAULT_VIEWS } from '@/services/Sales/PaymentReceives/constants'; import { DEFAULT_VIEWS } from '@/services/Sales/PaymentReceived/constants';
import ModelSearchable from './ModelSearchable'; import ModelSearchable from './ModelSearchable';
export default class BillPayment extends mixin(TenantModel, [ export default class BillPayment extends mixin(TenantModel, [

View File

@@ -1,4 +1,5 @@
import { Model } from 'objection'; import { Model } from 'objection';
import { castArray, omit, pick } from 'lodash';
import { isEmpty } from 'lodash'; import { isEmpty } from 'lodash';
import { ServiceError } from '@/exceptions'; import { ServiceError } from '@/exceptions';
@@ -16,7 +17,15 @@ export default class PaginationQueryBuilder extends Model.QueryBuilder {
}); });
} }
queryAndThrowIfHasRelations = ({ type, message }) => { queryAndThrowIfHasRelations = ({
type,
message,
excludeRelations = [],
includedRelations = [],
}) => {
const _excludeRelations = castArray(excludeRelations);
const _includedRelations = castArray(includedRelations);
const model = this.modelClass(); const model = this.modelClass();
const modelRelations = Object.keys(model.relationMappings).filter( const modelRelations = Object.keys(model.relationMappings).filter(
(relation) => (relation) =>
@@ -25,9 +34,20 @@ export default class PaginationQueryBuilder extends Model.QueryBuilder {
) !== -1 ) !== -1
); );
const relations = model.secureDeleteRelations || modelRelations; const relations = model.secureDeleteRelations || modelRelations;
const filteredByIncluded = relations.filter((r) =>
_includedRelations.includes(r)
);
const filteredByExcluded = relations.filter(
(r) => !excludeRelations.includes(r)
);
const filteredRelations = !isEmpty(_includedRelations)
? filteredByIncluded
: !isEmpty(_excludeRelations)
? filteredByExcluded
: relations;
this.runAfter((model, query) => { this.runAfter((model, query) => {
const nonEmptyRelations = relations.filter( const nonEmptyRelations = filteredRelations.filter(
(relation) => !isEmpty(model[relation]) (relation) => !isEmpty(model[relation])
); );
if (nonEmptyRelations.length > 0) { if (nonEmptyRelations.length > 0) {
@@ -36,7 +56,7 @@ export default class PaginationQueryBuilder extends Model.QueryBuilder {
return model; return model;
}); });
return this.onBuild((query) => { return this.onBuild((query) => {
relations.forEach((relation) => { filteredRelations.forEach((relation) => {
query.withGraphFetched(`${relation}(selectId)`).modifiers({ query.withGraphFetched(`${relation}(selectId)`).modifiers({
selectId(builder) { selectId(builder) {
builder.select('id'); builder.select('id');

View File

@@ -3,7 +3,7 @@ import TenantModel from 'models/TenantModel';
import ModelSetting from './ModelSetting'; import ModelSetting from './ModelSetting';
import PaymentReceiveSettings from './PaymentReceive.Settings'; import PaymentReceiveSettings from './PaymentReceive.Settings';
import CustomViewBaseModel from './CustomViewBaseModel'; import CustomViewBaseModel from './CustomViewBaseModel';
import { DEFAULT_VIEWS } from '@/services/Sales/PaymentReceives/constants'; import { DEFAULT_VIEWS } from '@/services/Sales/PaymentReceived/constants';
import ModelSearchable from './ModelSearchable'; import ModelSearchable from './ModelSearchable';
export default class PaymentReceive extends mixin(TenantModel, [ export default class PaymentReceive extends mixin(TenantModel, [

View File

@@ -0,0 +1,69 @@
export default {
defaultSort: {
sortOrder: 'DESC',
sortField: 'created_at',
},
exportable: true,
importable: true,
print: {
pageTitle: 'Tax Rates',
},
columns: {
name: {
name: 'Tax Rate Name',
type: 'text',
accessor: 'name',
},
code: {
name: 'Code',
type: 'text',
accessor: 'code',
},
rate: {
name: 'Rate',
type: 'text',
},
description: {
name: 'Description',
type: 'text',
},
isNonRecoverable: {
name: 'Is Non Recoverable',
type: 'boolean',
},
active: {
name: 'Active',
type: 'boolean',
},
},
field: {},
fields2: {
name: {
name: 'Tax name',
fieldType: 'name',
required: true,
},
code: {
name: 'Code',
fieldType: 'code',
required: true,
},
rate: {
name: 'Rate',
fieldType: 'number',
required: true,
},
description: {
name: 'Description',
fieldType: 'text',
},
isNonRecoverable: {
name: 'Is Non Recoverable',
fieldType: 'boolean',
},
active: {
name: 'Active',
fieldType: 'boolean',
},
},
};

View File

@@ -2,8 +2,13 @@ import { mixin, Model, raw } from 'objection';
import TenantModel from 'models/TenantModel'; import TenantModel from 'models/TenantModel';
import ModelSearchable from './ModelSearchable'; import ModelSearchable from './ModelSearchable';
import SoftDeleteQueryBuilder from '@/collection/SoftDeleteQueryBuilder'; import SoftDeleteQueryBuilder from '@/collection/SoftDeleteQueryBuilder';
import TaxRateMeta from './TaxRate.settings';
import ModelSetting from './ModelSetting';
export default class TaxRate extends mixin(TenantModel, [ModelSearchable]) { export default class TaxRate extends mixin(TenantModel, [
ModelSetting,
ModelSearchable,
]) {
/** /**
* Table name * Table name
*/ */
@@ -25,6 +30,13 @@ export default class TaxRate extends mixin(TenantModel, [ModelSearchable]) {
return ['createdAt', 'updatedAt']; return ['createdAt', 'updatedAt'];
} }
/**
* Retrieves the tax rate meta.
*/
static get meta() {
return TaxRateMeta;
}
/** /**
* Virtual attributes. * Virtual attributes.
*/ */

View File

@@ -1,6 +1,5 @@
/* eslint-disable global-require */ /* eslint-disable global-require */
import * as R from 'ramda'; import { Model, mixin } from 'objection';
import { Model, ModelOptions, QueryContext, mixin } from 'objection';
import TenantModel from 'models/TenantModel'; import TenantModel from 'models/TenantModel';
import ModelSettings from './ModelSetting'; import ModelSettings from './ModelSetting';
import Account from './Account'; import Account from './Account';
@@ -21,6 +20,7 @@ export default class UncategorizedCashflowTransaction extends mixin(
plaidTransactionId!: string; plaidTransactionId!: string;
recognizedTransactionId!: number; recognizedTransactionId!: number;
excludedAt: Date; excludedAt: Date;
pending: boolean;
/** /**
* Table name. * Table name.
@@ -46,7 +46,8 @@ export default class UncategorizedCashflowTransaction extends mixin(
'isDepositTransaction', 'isDepositTransaction',
'isWithdrawalTransaction', 'isWithdrawalTransaction',
'isRecognized', 'isRecognized',
'isExcluded' 'isExcluded',
'isPending',
]; ];
} }
@@ -99,6 +100,14 @@ export default class UncategorizedCashflowTransaction extends mixin(
return !!this.excludedAt; return !!this.excludedAt;
} }
/**
* Detarmines whether the transaction is pending.
* @returns {boolean}
*/
public get isPending(): boolean {
return !!this.pending;
}
/** /**
* Model modifiers. * Model modifiers.
*/ */
@@ -143,6 +152,20 @@ export default class UncategorizedCashflowTransaction extends mixin(
query.whereNull('categorizeRefType'); query.whereNull('categorizeRefType');
query.whereNull('categorizeRefId'); query.whereNull('categorizeRefId');
}, },
/**
* Filters the not pending transactions.
*/
notPending(query) {
query.where('pending', false);
},
/**
* Filters the pending transactions.
*/
pending(query) {
query.where('pending', true);
},
}; };
} }

View File

@@ -249,6 +249,7 @@ export default class Ledger implements ILedger {
transactionId: entry.referenceId, transactionId: entry.referenceId,
transactionType: entry.referenceType, transactionType: entry.referenceType,
transactionSubType: entry.transactionType,
transactionNumber: entry.transactionNumber, transactionNumber: entry.transactionNumber,
referenceNumber: entry.referenceNumber, referenceNumber: entry.referenceNumber,
@@ -262,6 +263,8 @@ export default class Ledger implements ILedger {
taxRateId: entry.taxRateId, taxRateId: entry.taxRateId,
taxRate: entry.taxRate, taxRate: entry.taxRate,
note: entry.note,
}; };
} }

View File

@@ -43,8 +43,8 @@ export class AccountsApplication {
/** /**
* Creates a new account. * Creates a new account.
* @param {number} tenantId * @param {number} tenantId
* @param {IAccountCreateDTO} accountDTO * @param {IAccountCreateDTO} accountDTO
* @returns {Promise<IAccount>} * @returns {Promise<IAccount>}
*/ */
public createAccount = ( public createAccount = (
@@ -108,8 +108,8 @@ export class AccountsApplication {
/** /**
* Retrieves the account details. * Retrieves the account details.
* @param {number} tenantId * @param {number} tenantId
* @param {number} accountId * @param {number} accountId
* @returns {Promise<IAccount>} * @returns {Promise<IAccount>}
*/ */
public getAccount = (tenantId: number, accountId: number) => { public getAccount = (tenantId: number, accountId: number) => {

View File

@@ -73,6 +73,7 @@ export class DeleteAccount {
.throwIfNotFound() .throwIfNotFound()
.queryAndThrowIfHasRelations({ .queryAndThrowIfHasRelations({
type: ERRORS.ACCOUNT_HAS_ASSOCIATED_TRANSACTIONS, type: ERRORS.ACCOUNT_HAS_ASSOCIATED_TRANSACTIONS,
excludeRelations: ['uncategorizedTransactions', 'plaidItem']
}); });
// Authorize before delete account. // Authorize before delete account.
await this.authorize(tenantId, accountId, oldAccount); await this.authorize(tenantId, accountId, oldAccount);

View File

@@ -1,10 +1,10 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { isEmpty } from 'lodash'; import { isEmpty } from 'lodash';
import { import {
IPaymentReceiveCreatedPayload, IPaymentReceivedCreatedPayload,
IPaymentReceiveCreatingPayload, IPaymentReceivedCreatingPayload,
IPaymentReceiveDeletingPayload, IPaymentReceivedDeletingPayload,
IPaymentReceiveEditedPayload, IPaymentReceivedEditedPayload,
} from '@/interfaces'; } from '@/interfaces';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { LinkAttachment } from '../LinkAttachment'; import { LinkAttachment } from '../LinkAttachment';
@@ -50,13 +50,13 @@ export class AttachmentsOnPaymentsReceived {
/** /**
* Validates the attachment keys on creating payment. * Validates the attachment keys on creating payment.
* @param {IPaymentReceiveCreatingPayload} * @param {IPaymentReceivedCreatingPayload}
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
private async validateAttachmentsOnPaymentCreate({ private async validateAttachmentsOnPaymentCreate({
paymentReceiveDTO, paymentReceiveDTO,
tenantId, tenantId,
}: IPaymentReceiveCreatingPayload): Promise<void> { }: IPaymentReceivedCreatingPayload): Promise<void> {
if (isEmpty(paymentReceiveDTO.attachments)) { if (isEmpty(paymentReceiveDTO.attachments)) {
return; return;
} }
@@ -67,7 +67,7 @@ export class AttachmentsOnPaymentsReceived {
/** /**
* Handles linking the attachments of the created payment. * Handles linking the attachments of the created payment.
* @param {IPaymentReceiveCreatedPayload} * @param {IPaymentReceivedCreatedPayload}
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
private async handleAttachmentsOnPaymentCreated({ private async handleAttachmentsOnPaymentCreated({
@@ -75,7 +75,7 @@ export class AttachmentsOnPaymentsReceived {
paymentReceiveDTO, paymentReceiveDTO,
paymentReceive, paymentReceive,
trx, trx,
}: IPaymentReceiveCreatedPayload): Promise<void> { }: IPaymentReceivedCreatedPayload): Promise<void> {
if (isEmpty(paymentReceiveDTO.attachments)) return; if (isEmpty(paymentReceiveDTO.attachments)) return;
const keys = paymentReceiveDTO.attachments?.map( const keys = paymentReceiveDTO.attachments?.map(
@@ -92,14 +92,14 @@ export class AttachmentsOnPaymentsReceived {
/** /**
* Handles unlinking all the unpresented keys of the edited payment. * Handles unlinking all the unpresented keys of the edited payment.
* @param {IPaymentReceiveEditedPayload} * @param {IPaymentReceivedEditedPayload}
*/ */
private async handleUnlinkUnpresentedKeysOnPaymentEdited({ private async handleUnlinkUnpresentedKeysOnPaymentEdited({
tenantId, tenantId,
paymentReceiveDTO, paymentReceiveDTO,
oldPaymentReceive, oldPaymentReceive,
trx, trx,
}: IPaymentReceiveEditedPayload) { }: IPaymentReceivedEditedPayload) {
const keys = paymentReceiveDTO.attachments?.map( const keys = paymentReceiveDTO.attachments?.map(
(attachment) => attachment.key (attachment) => attachment.key
); );
@@ -114,7 +114,7 @@ export class AttachmentsOnPaymentsReceived {
/** /**
* Handles linking all the presented keys of the edited payment. * Handles linking all the presented keys of the edited payment.
* @param {IPaymentReceiveEditedPayload} * @param {IPaymentReceivedEditedPayload}
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
private async handleLinkPresentedKeysOnPaymentEdited({ private async handleLinkPresentedKeysOnPaymentEdited({
@@ -122,7 +122,7 @@ export class AttachmentsOnPaymentsReceived {
paymentReceiveDTO, paymentReceiveDTO,
oldPaymentReceive, oldPaymentReceive,
trx, trx,
}: IPaymentReceiveEditedPayload) { }: IPaymentReceivedEditedPayload) {
if (isEmpty(paymentReceiveDTO.attachments)) return; if (isEmpty(paymentReceiveDTO.attachments)) return;
const keys = paymentReceiveDTO.attachments?.map( const keys = paymentReceiveDTO.attachments?.map(
@@ -146,7 +146,7 @@ export class AttachmentsOnPaymentsReceived {
tenantId, tenantId,
oldPaymentReceive, oldPaymentReceive,
trx, trx,
}: IPaymentReceiveDeletingPayload) { }: IPaymentReceivedDeletingPayload) {
await this.unlinkAttachmentService.unlinkAllModelKeys( await this.unlinkAttachmentService.unlinkAllModelKeys(
tenantId, tenantId,
'PaymentReceive', 'PaymentReceive',

View File

@@ -52,6 +52,9 @@ export class GetBankAccountSummary {
q.withGraphJoined('matchedBankTransactions'); q.withGraphJoined('matchedBankTransactions');
q.whereNull('matchedBankTransactions.id'); q.whereNull('matchedBankTransactions.id');
// Exclude the pending transactions.
q.modify('notPending');
// Count the results. // Count the results.
q.count('uncategorized_cashflow_transactions.id as total'); q.count('uncategorized_cashflow_transactions.id as total');
q.first(); q.first();
@@ -65,16 +68,32 @@ export class GetBankAccountSummary {
q.withGraphJoined('recognizedTransaction'); q.withGraphJoined('recognizedTransaction');
q.whereNotNull('recognizedTransaction.id'); q.whereNotNull('recognizedTransaction.id');
// Exclude the pending transactions.
q.modify('notPending');
// Count the results. // Count the results.
q.count('uncategorized_cashflow_transactions.id as total'); q.count('uncategorized_cashflow_transactions.id as total');
q.first(); q.first();
}); });
// Retrieves excluded transactions count.
const excludedTransactionsCount = const excludedTransactionsCount =
await UncategorizedCashflowTransaction.query().onBuild((q) => { await UncategorizedCashflowTransaction.query().onBuild((q) => {
q.where('accountId', bankAccountId); q.where('accountId', bankAccountId);
q.modify('excluded'); q.modify('excluded');
// Exclude the pending transactions.
q.modify('notPending');
// Count the results.
q.count('uncategorized_cashflow_transactions.id as total');
q.first();
});
// Retrieves the pending transactions count.
const pendingTransactionsCount =
await UncategorizedCashflowTransaction.query().onBuild((q) => {
q.where('accountId', bankAccountId);
q.modify('pending');
// Count the results. // Count the results.
q.count('uncategorized_cashflow_transactions.id as total'); q.count('uncategorized_cashflow_transactions.id as total');
q.first(); q.first();
@@ -83,14 +102,15 @@ export class GetBankAccountSummary {
const totalUncategorizedTransactions = const totalUncategorizedTransactions =
uncategorizedTranasctionsCount?.total || 0; uncategorizedTranasctionsCount?.total || 0;
const totalRecognizedTransactions = recognizedTransactionsCount?.total || 0; const totalRecognizedTransactions = recognizedTransactionsCount?.total || 0;
const totalExcludedTransactions = excludedTransactionsCount?.total || 0; const totalExcludedTransactions = excludedTransactionsCount?.total || 0;
const totalPendingTransactions = pendingTransactionsCount?.total || 0;
return { return {
name: bankAccount.name, name: bankAccount.name,
totalUncategorizedTransactions, totalUncategorizedTransactions,
totalRecognizedTransactions, totalRecognizedTransactions,
totalExcludedTransactions, totalExcludedTransactions,
totalPendingTransactions,
}; };
} }
} }

View File

@@ -0,0 +1,78 @@
import { Inject, Service } from 'typedi';
import { initialize } from 'objection';
import HasTenancyService from '@/services/Tenancy/TenancyService';
import events from '@/subscribers/events';
import { IAccountEventDeletePayload } from '@/interfaces';
import { DeleteBankRulesService } from '../../Rules/DeleteBankRules';
import { RevertRecognizedTransactions } from '../../RegonizeTranasctions/RevertRecognizedTransactions';
@Service()
export class DeleteUncategorizedTransactionsOnAccountDeleting {
@Inject()
private tenancy: HasTenancyService;
@Inject()
private deleteBankRules: DeleteBankRulesService;
@Inject()
private revertRecognizedTransactins: RevertRecognizedTransactions;
/**
* Constructor method.
*/
public attach(bus) {
bus.subscribe(
events.accounts.onDelete,
this.handleDeleteBankRulesOnAccountDeleting.bind(this)
);
}
/**
* Handles revert the recognized transactions and delete all the bank rules
* associated to the deleted bank account.
* @param {IAccountEventDeletePayload}
*/
private async handleDeleteBankRulesOnAccountDeleting({
tenantId,
oldAccount,
trx,
}: IAccountEventDeletePayload) {
const knex = this.tenancy.knex(tenantId);
const {
BankRule,
UncategorizedCashflowTransaction,
MatchedBankTransaction,
RecognizedBankTransaction,
} = this.tenancy.models(tenantId);
const foundAssociatedRules = await BankRule.query(trx).where(
'applyIfAccountId',
oldAccount.id
);
const foundAssociatedRulesIds = foundAssociatedRules.map((rule) => rule.id);
await initialize(knex, [
UncategorizedCashflowTransaction,
RecognizedBankTransaction,
MatchedBankTransaction,
]);
// Revert the recognized transactions of the given bank rules.
await this.revertRecognizedTransactins.revertRecognizedTransactions(
tenantId,
foundAssociatedRulesIds,
null,
trx
);
// Delete the associated uncategorized transactions.
await UncategorizedCashflowTransaction.query(trx)
.where('accountId', oldAccount.id)
.delete();
// Delete the given bank rules.
await this.deleteBankRules.deleteBankRules(
tenantId,
foundAssociatedRulesIds,
trx
);
}
}

View File

@@ -51,6 +51,7 @@ export class DisconnectPlaidItemOnAccountDeleted {
.findOne('plaidItemId', oldAccount.plaidItemId) .findOne('plaidItemId', oldAccount.plaidItemId)
.delete(); .delete();
// Remove Plaid item once the transaction resolve.
if (oldPlaidItem) { if (oldPlaidItem) {
const plaidInstance = PlaidClientWrapper.getClient(); const plaidInstance = PlaidClientWrapper.getClient();

View File

@@ -64,7 +64,7 @@ export class GetMatchedTransactions {
.whereIn('id', uncategorizedTransactionIds) .whereIn('id', uncategorizedTransactionIds)
.throwIfNotFound(); .throwIfNotFound();
const totalPending = Math.abs(sumBy(uncategorizedTransactions, 'amount')); const totalPending = sumBy(uncategorizedTransactions, 'amount');
const filtered = filter.transactionType const filtered = filter.transactionType
? this.registered.filter((item) => item.type === filter.transactionType) ? this.registered.filter((item) => item.type === filter.transactionType)

View File

@@ -1,18 +1,25 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { initialize } from 'objection'; import { initialize } from 'objection';
import { Knex } from 'knex';
import { first } from 'lodash';
import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable'; import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable';
import { GetMatchedTransactionBillsTransformer } from './GetMatchedTransactionBillsTransformer'; import { GetMatchedTransactionBillsTransformer } from './GetMatchedTransactionBillsTransformer';
import { GetMatchedTransactionsFilter, MatchedTransactionPOJO } from './types'; import {
import HasTenancyService from '@/services/Tenancy/TenancyService'; GetMatchedTransactionsFilter,
IMatchTransactionDTO,
MatchedTransactionPOJO,
} from './types';
import { GetMatchedTransactionsByType } from './GetMatchedTransactionsByType'; import { GetMatchedTransactionsByType } from './GetMatchedTransactionsByType';
import { CreateBillPayment } from '@/services/Purchases/BillPayments/CreateBillPayment';
import { IBillPaymentDTO } from '@/interfaces';
@Service() @Service()
export class GetMatchedTransactionsByBills extends GetMatchedTransactionsByType { export class GetMatchedTransactionsByBills extends GetMatchedTransactionsByType {
@Inject() @Inject()
private tenancy: HasTenancyService; private transformer: TransformerInjectable;
@Inject() @Inject()
private transformer: TransformerInjectable; private createPaymentMadeService: CreateBillPayment;
/** /**
* Retrieves the matched transactions. * Retrieves the matched transactions.
@@ -71,4 +78,62 @@ export class GetMatchedTransactionsByBills extends GetMatchedTransactionsByType
new GetMatchedTransactionBillsTransformer() new GetMatchedTransactionBillsTransformer()
); );
} }
/**
* Creates the common matched transaction.
* @param {number} tenantId
* @param {Array<number>} uncategorizedTransactionIds
* @param {IMatchTransactionDTO} matchTransactionDTO
* @param {Knex.Transaction} trx
*/
public async createMatchedTransaction(
tenantId: number,
uncategorizedTransactionIds: Array<number>,
matchTransactionDTO: IMatchTransactionDTO,
trx?: Knex.Transaction
): Promise<void> {
await super.createMatchedTransaction(
tenantId,
uncategorizedTransactionIds,
matchTransactionDTO,
trx
);
const { Bill, UncategorizedCashflowTransaction, MatchedBankTransaction } =
this.tenancy.models(tenantId);
const uncategorizedTransactionId = first(uncategorizedTransactionIds);
const uncategorizedTransaction =
await UncategorizedCashflowTransaction.query(trx)
.findById(uncategorizedTransactionId)
.throwIfNotFound();
const bill = await Bill.query(trx)
.findById(matchTransactionDTO.referenceId)
.throwIfNotFound();
const createPaymentMadeDTO: IBillPaymentDTO = {
vendorId: bill.vendorId,
paymentAccountId: uncategorizedTransaction.accountId,
paymentDate: uncategorizedTransaction.date,
exchangeRate: 1,
entries: [
{
paymentAmount: bill.dueAmount,
billId: bill.id,
},
],
branchId: bill.branchId,
};
// Create a new bill payment associated to the matched bill.
const billPayment = await this.createPaymentMadeService.createBillPayment(
tenantId,
createPaymentMadeDTO,
trx
);
// Link the create bill payment with matched transaction.
await super.createMatchedTransaction(tenantId, uncategorizedTransactionIds, {
referenceType: 'BillPayment',
referenceId: billPayment.id,
}, trx);
}
} }

View File

@@ -1,22 +1,26 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { initialize } from 'objection'; import { initialize } from 'objection';
import { Knex } from 'knex';
import { first } from 'lodash';
import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable'; import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable';
import { GetMatchedTransactionInvoicesTransformer } from './GetMatchedTransactionInvoicesTransformer'; import { GetMatchedTransactionInvoicesTransformer } from './GetMatchedTransactionInvoicesTransformer';
import { import {
GetMatchedTransactionsFilter, GetMatchedTransactionsFilter,
IMatchTransactionDTO,
MatchedTransactionPOJO, MatchedTransactionPOJO,
MatchedTransactionsPOJO, MatchedTransactionsPOJO,
} from './types'; } from './types';
import HasTenancyService from '@/services/Tenancy/TenancyService';
import { GetMatchedTransactionsByType } from './GetMatchedTransactionsByType'; import { GetMatchedTransactionsByType } from './GetMatchedTransactionsByType';
import { CreatePaymentReceived } from '@/services/Sales/PaymentReceived/CreatePaymentReceived';
import { IPaymentReceivedCreateDTO } from '@/interfaces';
@Service() @Service()
export class GetMatchedTransactionsByInvoices extends GetMatchedTransactionsByType { export class GetMatchedTransactionsByInvoices extends GetMatchedTransactionsByType {
@Inject() @Inject()
protected tenancy: HasTenancyService; protected transformer: TransformerInjectable;
@Inject() @Inject()
protected transformer: TransformerInjectable; protected createPaymentReceivedService: CreatePaymentReceived;
/** /**
* Retrieves the matched transactions. * Retrieves the matched transactions.
@@ -78,4 +82,64 @@ export class GetMatchedTransactionsByInvoices extends GetMatchedTransactionsByTy
new GetMatchedTransactionInvoicesTransformer() new GetMatchedTransactionInvoicesTransformer()
); );
} }
/**
* Creates the common matched transaction.
* @param {number} tenantId
* @param {Array<number>} uncategorizedTransactionIds
* @param {IMatchTransactionDTO} matchTransactionDTO
* @param {Knex.Transaction} trx
*/
public async createMatchedTransaction(
tenantId: number,
uncategorizedTransactionIds: Array<number>,
matchTransactionDTO: IMatchTransactionDTO,
trx?: Knex.Transaction
) {
await super.createMatchedTransaction(
tenantId,
uncategorizedTransactionIds,
matchTransactionDTO,
trx
);
const { SaleInvoice, UncategorizedCashflowTransaction, MatchedBankTransaction } =
this.tenancy.models(tenantId);
const uncategorizedTransactionId = first(uncategorizedTransactionIds);
const uncategorizedTransaction =
await UncategorizedCashflowTransaction.query(trx)
.findById(uncategorizedTransactionId)
.throwIfNotFound();
const invoice = await SaleInvoice.query(trx)
.findById(matchTransactionDTO.referenceId)
.throwIfNotFound();
const createPaymentReceivedDTO: IPaymentReceivedCreateDTO = {
customerId: invoice.customerId,
paymentDate: uncategorizedTransaction.date,
amount: invoice.dueAmount,
depositAccountId: uncategorizedTransaction.accountId,
entries: [
{
index: 1,
invoiceId: invoice.id,
paymentAmount: invoice.dueAmount,
},
],
branchId: invoice.branchId,
};
// Create a payment received associated to the matched invoice.
const paymentReceived = await this.createPaymentReceivedService.createPaymentReceived(
tenantId,
createPaymentReceivedDTO,
{},
trx
);
// Link the create payment received with matched invoice transaction.
await super.createMatchedTransaction(tenantId, uncategorizedTransactionIds, {
referenceType: 'PaymentReceive',
referenceId: paymentReceived.id,
}, trx)
}
} }

View File

@@ -1,7 +1,7 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { import {
IBillPaymentEventDeletedPayload, IBillPaymentEventDeletedPayload,
IPaymentReceiveDeletedPayload, IPaymentReceivedDeletedPayload,
} from '@/interfaces'; } from '@/interfaces';
import { ValidateTransactionMatched } from '../ValidateTransactionsMatched'; import { ValidateTransactionMatched } from '../ValidateTransactionsMatched';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
@@ -23,7 +23,7 @@ export class ValidateMatchingOnPaymentMadeDelete {
/** /**
* Validates the payment made transaction whether matched with bank transaction on deleting. * Validates the payment made transaction whether matched with bank transaction on deleting.
* @param {IPaymentReceiveDeletedPayload} * @param {IPaymentReceivedDeletedPayload}
*/ */
public async validateMatchingOnPaymentMadeDeleting({ public async validateMatchingOnPaymentMadeDeleting({
tenantId, tenantId,

View File

@@ -1,5 +1,5 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { IPaymentReceiveDeletedPayload } from '@/interfaces'; import { IPaymentReceivedDeletedPayload } from '@/interfaces';
import { ValidateTransactionMatched } from '../ValidateTransactionsMatched'; import { ValidateTransactionMatched } from '../ValidateTransactionsMatched';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
@@ -20,13 +20,13 @@ export class ValidateMatchingOnPaymentReceivedDelete {
/** /**
* Validates the payment received transaction whether matched with bank transaction on deleting. * Validates the payment received transaction whether matched with bank transaction on deleting.
* @param {IPaymentReceiveDeletedPayload} * @param {IPaymentReceivedDeletedPayload}
*/ */
public async validateMatchingOnPaymentReceivedDeleting({ public async validateMatchingOnPaymentReceivedDeleting({
tenantId, tenantId,
oldPaymentReceive, oldPaymentReceive,
trx, trx,
}: IPaymentReceiveDeletedPayload) { }: IPaymentReceivedDeletedPayload) {
await this.validateNoMatchingLinkedService.validateTransactionNoMatchLinking( await this.validateNoMatchingLinkedService.validateTransactionNoMatchLinking(
tenantId, tenantId,
'PaymentReceive', 'PaymentReceive',

View File

@@ -25,6 +25,7 @@ import { Knex } from 'knex';
import uniqid from 'uniqid'; import uniqid from 'uniqid';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { RemovePendingUncategorizedTransaction } from '@/services/Cashflow/RemovePendingUncategorizedTransaction';
const CONCURRENCY_ASYNC = 10; const CONCURRENCY_ASYNC = 10;
@@ -40,7 +41,7 @@ export class PlaidSyncDb {
private cashflowApp: CashflowApplication; private cashflowApp: CashflowApplication;
@Inject() @Inject()
private deleteCashflowTransactionService: DeleteCashflowTransaction; private removePendingTransaction: RemovePendingUncategorizedTransaction;
@Inject() @Inject()
private eventPublisher: EventPublisher; private eventPublisher: EventPublisher;
@@ -185,21 +186,22 @@ export class PlaidSyncDb {
plaidTransactionsIds: string[], plaidTransactionsIds: string[],
trx?: Knex.Transaction trx?: Knex.Transaction
) { ) {
const { CashflowTransaction } = this.tenancy.models(tenantId); const { UncategorizedCashflowTransaction } = this.tenancy.models(tenantId);
const cashflowTransactions = await CashflowTransaction.query(trx).whereIn( const uncategorizedTransactions =
'plaidTransactionId', await UncategorizedCashflowTransaction.query(trx).whereIn(
plaidTransactionsIds 'plaidTransactionId',
); plaidTransactionsIds
const cashflowTransactionsIds = cashflowTransactions.map( );
const uncategorizedTransactionsIds = uncategorizedTransactions.map(
(trans) => trans.id (trans) => trans.id
); );
await bluebird.map( await bluebird.map(
cashflowTransactionsIds, uncategorizedTransactionsIds,
(transactionId: number) => (uncategorizedTransactionId: number) =>
this.deleteCashflowTransactionService.deleteCashflowTransaction( this.removePendingTransaction.removePendingTransaction(
tenantId, tenantId,
transactionId, uncategorizedTransactionId,
trx trx
), ),
{ concurrency: CONCURRENCY_ASYNC } { concurrency: CONCURRENCY_ASYNC }

View File

@@ -1,10 +1,10 @@
import HasTenancyService from '@/services/Tenancy/TenancyService'; import { Knex } from 'knex';
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import HasTenancyService from '@/services/Tenancy/TenancyService';
import { PlaidClientWrapper } from '@/lib/Plaid/Plaid'; import { PlaidClientWrapper } from '@/lib/Plaid/Plaid';
import { PlaidSyncDb } from './PlaidSyncDB'; import { PlaidSyncDb } from './PlaidSyncDB';
import { PlaidFetchedTransactionsUpdates } from '@/interfaces'; import { PlaidFetchedTransactionsUpdates } from '@/interfaces';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
import { Knex } from 'knex';
@Service() @Service()
export class PlaidUpdateTransactions { export class PlaidUpdateTransactions {
@@ -19,9 +19,9 @@ export class PlaidUpdateTransactions {
/** /**
* Handles sync the Plaid item to Bigcaptial under UOW. * Handles sync the Plaid item to Bigcaptial under UOW.
* @param {number} tenantId * @param {number} tenantId - Tenant id.
* @param {number} plaidItemId * @param {number} plaidItemId - Plaid item id.
* @returns {Promise<{ addedCount: number; modifiedCount: number; removedCount: number; }>} * @returns {Promise<{ addedCount: number; modifiedCount: number; removedCount: number; }>}
*/ */
public async updateTransactions(tenantId: number, plaidItemId: string) { public async updateTransactions(tenantId: number, plaidItemId: string) {
return this.uow.withTransaction(tenantId, (trx: Knex.Transaction) => { return this.uow.withTransaction(tenantId, (trx: Knex.Transaction) => {
@@ -73,6 +73,12 @@ export class PlaidUpdateTransactions {
item, item,
trx trx
); );
// Sync removed transactions.
await this.plaidSync.syncRemoveTransactions(
tenantId,
removed?.map((r) => r.transaction_id),
trx
);
// Sync bank account transactions. // Sync bank account transactions.
await this.plaidSync.syncAccountsTransactions( await this.plaidSync.syncAccountsTransactions(
tenantId, tenantId,

View File

@@ -83,8 +83,9 @@ export class PlaidWebooks {
webhookCode: string webhookCode: string
): Promise<void> { ): Promise<void> {
const { PlaidItem } = this.tenancy.models(tenantId); const { PlaidItem } = this.tenancy.models(tenantId);
const plaidItem = await PlaidItem.query() const plaidItem = await PlaidItem.query()
.findById(plaidItemId) .findOne({ plaidItemId })
.throwIfNotFound(); .throwIfNotFound();
switch (webhookCode) { switch (webhookCode) {

View File

@@ -3,11 +3,11 @@ import {
Item as PlaidItem, Item as PlaidItem,
Institution as PlaidInstitution, Institution as PlaidInstitution,
AccountBase as PlaidAccount, AccountBase as PlaidAccount,
TransactionBase as PlaidTransactionBase,
} from 'plaid'; } from 'plaid';
import { import {
CreateUncategorizedTransactionDTO, CreateUncategorizedTransactionDTO,
IAccountCreateDTO, IAccountCreateDTO,
PlaidTransaction,
} from '@/interfaces'; } from '@/interfaces';
/** /**
@@ -48,7 +48,7 @@ export const transformPlaidAccountToCreateAccount = R.curry(
export const transformPlaidTrxsToCashflowCreate = R.curry( export const transformPlaidTrxsToCashflowCreate = R.curry(
( (
cashflowAccountId: number, cashflowAccountId: number,
plaidTranasction: PlaidTransaction plaidTranasction: PlaidTransactionBase
): CreateUncategorizedTransactionDTO => { ): CreateUncategorizedTransactionDTO => {
return { return {
date: plaidTranasction.date, date: plaidTranasction.date,
@@ -64,6 +64,8 @@ export const transformPlaidTrxsToCashflowCreate = R.curry(
accountId: cashflowAccountId, accountId: cashflowAccountId,
referenceNo: plaidTranasction.payment_meta?.reference_number, referenceNo: plaidTranasction.payment_meta?.reference_number,
plaidTransactionId: plaidTranasction.transaction_id, plaidTransactionId: plaidTranasction.transaction_id,
pending: plaidTranasction.pending,
pendingPlaidTransactionId: plaidTranasction.pending_transaction_id,
}; };
} }
); );

View File

@@ -33,17 +33,29 @@ const matchNumberCondition = (
transaction: UncategorizedCashflowTransaction, transaction: UncategorizedCashflowTransaction,
condition: IBankRuleCondition condition: IBankRuleCondition
) => { ) => {
const conditionValue = parseFloat(condition.value);
const transactionAmount =
condition.field === 'amount'
? Math.abs(transaction[condition.field])
: (transaction[condition.field] as unknown as number);
switch (condition.comparator) { switch (condition.comparator) {
case BankRuleConditionComparator.Equals: case BankRuleConditionComparator.Equals:
return transaction[condition.field] === condition.value; case BankRuleConditionComparator.Equal:
case BankRuleConditionComparator.Contains: return transactionAmount === conditionValue;
return transaction[condition.field]
?.toString() case BankRuleConditionComparator.BiggerOrEqual:
.includes(condition.value.toString()); return transactionAmount >= conditionValue;
case BankRuleConditionComparator.NotContain:
return !transaction[condition.field] case BankRuleConditionComparator.Bigger:
?.toString() return transactionAmount > conditionValue;
.includes(condition.value.toString());
case BankRuleConditionComparator.Smaller:
return transactionAmount < conditionValue;
case BankRuleConditionComparator.SmallerOrEqual:
return transactionAmount <= conditionValue;
default: default:
return false; return false;
} }
@@ -53,18 +65,19 @@ const matchTextCondition = (
transaction: UncategorizedCashflowTransaction, transaction: UncategorizedCashflowTransaction,
condition: IBankRuleCondition condition: IBankRuleCondition
): boolean => { ): boolean => {
const transactionValue = transaction[condition.field] as string;
switch (condition.comparator) { switch (condition.comparator) {
case BankRuleConditionComparator.Equals: case BankRuleConditionComparator.Equals:
return transaction[condition.field] === condition.value; case BankRuleConditionComparator.Equal:
return transactionValue === condition.value;
case BankRuleConditionComparator.Contains: case BankRuleConditionComparator.Contains:
const fieldValue = lowerCase(transaction[condition.field]); const fieldValue = lowerCase(transactionValue);
const conditionValue = lowerCase(condition.value); const conditionValue = lowerCase(condition.value);
return fieldValue.includes(conditionValue); return fieldValue.includes(conditionValue);
case BankRuleConditionComparator.NotContain: case BankRuleConditionComparator.NotContain:
return !transaction[condition.field]?.includes( return !transactionValue?.includes(condition.value.toString());
condition.value.toString()
);
default: default:
return false; return false;
} }
@@ -101,8 +114,8 @@ const determineFieldType = (field: string): string => {
case 'amount': case 'amount':
return 'number'; return 'number';
case 'description': case 'description':
return 'text'; case 'payee':
default: default:
return 'unknown'; return 'text';
} }
}; };

View File

@@ -1,4 +1,5 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { isEqual, omit } from 'lodash';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { import {
IBankRuleEventCreatedPayload, IBankRuleEventCreatedPayload,
@@ -55,10 +56,22 @@ export class TriggerRecognizedTransactions {
private async recognizedTransactionsOnRuleEdited({ private async recognizedTransactionsOnRuleEdited({
tenantId, tenantId,
editRuleDTO, editRuleDTO,
oldBankRule,
bankRule,
ruleId, ruleId,
}: IBankRuleEventEditedPayload) { }: IBankRuleEventEditedPayload) {
const payload = { tenantId, ruleId }; const payload = { tenantId, ruleId };
// Cannot continue if the new and old bank rule values are the same,
// after excluding `createdAt` and `updatedAt` dates.
if (
isEqual(
omit(bankRule, ['createdAt', 'updatedAt']),
omit(oldBankRule, ['createdAt', 'updatedAt'])
)
) {
return;
}
await this.agenda.now( await this.agenda.now(
'rerecognize-uncategorized-transactions-job', 'rerecognize-uncategorized-transactions-job',
payload payload

View File

@@ -26,31 +26,39 @@ export class DeleteBankRuleSerivce {
* @param {number} ruleId * @param {number} ruleId
* @returns {Promise<void>} * @returns {Promise<void>}
*/ */
public async deleteBankRule(tenantId: number, ruleId: number): Promise<void> { public async deleteBankRule(
tenantId: number,
ruleId: number,
trx?: Knex.Transaction
): Promise<void> {
const { BankRule, BankRuleCondition } = this.tenancy.models(tenantId); const { BankRule, BankRuleCondition } = this.tenancy.models(tenantId);
const oldBankRule = await BankRule.query() const oldBankRule = await BankRule.query()
.findById(ruleId) .findById(ruleId)
.throwIfNotFound(); .throwIfNotFound();
return this.uow.withTransaction(tenantId, async (trx: Knex.Transaction) => { return this.uow.withTransaction(
// Triggers `onBankRuleDeleting` event. tenantId,
await this.eventPublisher.emitAsync(events.bankRules.onDeleting, { async (trx: Knex.Transaction) => {
tenantId, // Triggers `onBankRuleDeleting` event.
oldBankRule, await this.eventPublisher.emitAsync(events.bankRules.onDeleting, {
ruleId, tenantId,
trx, oldBankRule,
} as IBankRuleEventDeletingPayload); ruleId,
trx,
} as IBankRuleEventDeletingPayload);
await BankRuleCondition.query(trx).where('ruleId', ruleId).delete(); await BankRuleCondition.query(trx).where('ruleId', ruleId).delete()
await BankRule.query(trx).findById(ruleId).delete(); await BankRule.query(trx).findById(ruleId).delete();
// Triggers `onBankRuleDeleted` event. // Triggers `onBankRuleDeleted` event.
await await this.eventPublisher.emitAsync(events.bankRules.onDeleted, { await await this.eventPublisher.emitAsync(events.bankRules.onDeleted, {
tenantId, tenantId,
ruleId, ruleId,
trx, trx,
} as IBankRuleEventDeletedPayload); } as IBankRuleEventDeletedPayload);
}); },
trx
);
} }
} }

View File

@@ -0,0 +1,34 @@
import { Knex } from 'knex';
import { Inject, Service } from 'typedi';
import PromisePool from '@supercharge/promise-pool';
import { castArray, uniq } from 'lodash';
import { DeleteBankRuleSerivce } from './DeleteBankRule';
@Service()
export class DeleteBankRulesService {
@Inject()
private deleteBankRuleService: DeleteBankRuleSerivce;
/**
* Delete bank rules.
* @param {number} tenantId
* @param {number | Array<number>} bankRuleId
*/
async deleteBankRules(
tenantId: number,
bankRuleId: number | Array<number>,
trx?: Knex.Transaction
) {
const bankRulesIds = uniq(castArray(bankRuleId));
const results = await PromisePool.withConcurrency(1)
.for(bankRulesIds)
.process(async (bankRuleId: number) => {
await this.deleteBankRuleService.deleteBankRule(
tenantId,
bankRuleId,
trx
);
});
}
}

View File

@@ -47,6 +47,7 @@ export class EditBankRuleService {
const oldBankRule = await BankRule.query() const oldBankRule = await BankRule.query()
.findById(ruleId) .findById(ruleId)
.withGraphFetched('conditions')
.throwIfNotFound(); .throwIfNotFound();
const tranformDTO = this.transformDTO(editRuleDTO); const tranformDTO = this.transformDTO(editRuleDTO);
@@ -64,15 +65,15 @@ export class EditBankRuleService {
} as IBankRuleEventEditingPayload); } as IBankRuleEventEditingPayload);
// Updates the given bank rule. // Updates the given bank rule.
await BankRule.query(trx).upsertGraphAndFetch({ const bankRule = await BankRule.query(trx).upsertGraphAndFetch({
...tranformDTO, ...tranformDTO,
id: ruleId, id: ruleId,
}); });
// Triggers `onBankRuleEdited` event. // Triggers `onBankRuleEdited` event.
await this.eventPublisher.emitAsync(events.bankRules.onEdited, { await this.eventPublisher.emitAsync(events.bankRules.onEdited, {
tenantId, tenantId,
oldBankRule, oldBankRule,
bankRule,
ruleId, ruleId,
editRuleDTO, editRuleDTO,
trx, trx,

View File

@@ -1,15 +1,20 @@
import { Knex } from 'knex'; import { Knex } from 'knex';
export enum BankRuleConditionField { export enum BankRuleConditionField {
Amount = 'Amount', Amount = 'amount',
Description = 'Description', Description = 'description',
Payee = 'Payee', Payee = 'payee',
} }
export enum BankRuleConditionComparator { export enum BankRuleConditionComparator {
Contains = 'contains', Contains = 'contains',
Equals = 'equals', Equals = 'equals',
Equal = 'equal',
NotContain = 'not_contain', NotContain = 'not_contain',
Bigger = 'bigger',
BiggerOrEqual = 'bigger_or_equal',
Smaller = 'smaller',
SmallerOrEqual = 'smaller_or_equal',
} }
export interface IBankRuleCondition { export interface IBankRuleCondition {
@@ -56,7 +61,15 @@ export enum BankRuleAssignCategory {
export interface IBankRuleConditionDTO { export interface IBankRuleConditionDTO {
id?: number; id?: number;
field: string; field: string;
comparator: string; comparator:
| 'contains'
| 'equals'
| 'not_contains'
| 'equal'
| 'bigger'
| 'bigger_or_equal'
| 'smaller'
| 'smaller_or_equal';
value: number; value: number;
} }
@@ -99,6 +112,8 @@ export interface IBankRuleEventEditingPayload {
export interface IBankRuleEventEditedPayload { export interface IBankRuleEventEditedPayload {
tenantId: number; tenantId: number;
ruleId: number; ruleId: number;
oldBankRule: IBankRule;
bankRule: IBankRule;
editRuleDTO: IEditBankRuleDTO; editRuleDTO: IEditBankRuleDTO;
trx?: Knex.Transaction; trx?: Knex.Transaction;
} }

View File

@@ -1,8 +1,8 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { import {
IPaymentReceiveCreatingPayload, IPaymentReceivedCreatingPayload,
IPaymentReceiveEditingPayload, IPaymentReceivedEditingPayload,
} from '@/interfaces'; } from '@/interfaces';
import { ValidateBranchExistance } from '../../Integrations/ValidateBranchExistance'; import { ValidateBranchExistance } from '../../Integrations/ValidateBranchExistance';
@@ -28,12 +28,12 @@ export class PaymentReceiveBranchValidateSubscriber {
/** /**
* Validate branch existance on estimate creating. * Validate branch existance on estimate creating.
* @param {IPaymentReceiveCreatingPayload} payload * @param {IPaymentReceivedCreatingPayload} payload
*/ */
private validateBranchExistanceOnPaymentCreating = async ({ private validateBranchExistanceOnPaymentCreating = async ({
tenantId, tenantId,
paymentReceiveDTO, paymentReceiveDTO,
}: IPaymentReceiveCreatingPayload) => { }: IPaymentReceivedCreatingPayload) => {
await this.validateBranchExistance.validateTransactionBranchWhenActive( await this.validateBranchExistance.validateTransactionBranchWhenActive(
tenantId, tenantId,
paymentReceiveDTO.branchId paymentReceiveDTO.branchId
@@ -42,12 +42,12 @@ export class PaymentReceiveBranchValidateSubscriber {
/** /**
* Validate branch existance once estimate editing. * Validate branch existance once estimate editing.
* @param {IPaymentReceiveEditingPayload} payload * @param {IPaymentReceivedEditingPayload} payload
*/ */
private validateBranchExistanceOnPaymentEditing = async ({ private validateBranchExistanceOnPaymentEditing = async ({
paymentReceiveDTO, paymentReceiveDTO,
tenantId, tenantId,
}: IPaymentReceiveEditingPayload) => { }: IPaymentReceivedEditingPayload) => {
await this.validateBranchExistance.validateTransactionBranchWhenActive( await this.validateBranchExistance.validateTransactionBranchWhenActive(
tenantId, tenantId,
paymentReceiveDTO.branchId paymentReceiveDTO.branchId

View File

@@ -21,6 +21,7 @@ import GetCashflowAccountsService from './GetCashflowAccountsService';
import { GetCashflowTransactionService } from './GetCashflowTransactionsService'; import { GetCashflowTransactionService } from './GetCashflowTransactionsService';
import { GetRecognizedTransactionsService } from './GetRecongizedTransactions'; import { GetRecognizedTransactionsService } from './GetRecongizedTransactions';
import { GetRecognizedTransactionService } from './GetRecognizedTransaction'; import { GetRecognizedTransactionService } from './GetRecognizedTransaction';
import { UncategorizeCashflowTransactionsBulk } from './UncategorizeCashflowTransactionsBulk';
@Service() @Service()
export class CashflowApplication { export class CashflowApplication {
@@ -39,6 +40,9 @@ export class CashflowApplication {
@Inject() @Inject()
private uncategorizeTransactionService: UncategorizeCashflowTransaction; private uncategorizeTransactionService: UncategorizeCashflowTransaction;
@Inject()
private uncategorizeTransasctionsService: UncategorizeCashflowTransactionsBulk;
@Inject() @Inject()
private categorizeTransactionService: CategorizeCashflowTransaction; private categorizeTransactionService: CategorizeCashflowTransaction;
@@ -155,6 +159,22 @@ export class CashflowApplication {
); );
} }
/**
* Uncategorize the given transactions in bulk.
* @param {number} tenantId
* @param {number | Array<number>} transactionId
* @returns
*/
public uncategorizeTransactions(
tenantId: number,
transactionId: number | Array<number>
) {
return this.uncategorizeTransasctionsService.uncategorizeBulk(
tenantId,
transactionId
);
}
/** /**
* Categorize the given cashflow transaction. * Categorize the given cashflow transaction.
* @param {number} tenantId * @param {number} tenantId

View File

@@ -0,0 +1,53 @@
import { Inject } from 'typedi';
import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable';
import HasTenancyService from '../Tenancy/TenancyService';
import { GetPendingBankAccountTransactionTransformer } from './GetPendingBankAccountTransactionTransformer';
export class GetPendingBankAccountTransactions {
@Inject()
private tenancy: HasTenancyService;
@Inject()
private transformer: TransformerInjectable;
/**
* Retrieves the given bank accounts pending transaction.
* @param {number} tenantId - Tenant id.
* @param {GetPendingTransactionsQuery} filter - Pending transactions query.
*/
async getPendingTransactions(
tenantId: number,
filter?: GetPendingTransactionsQuery
) {
const { UncategorizedCashflowTransaction } = this.tenancy.models(tenantId);
const _filter = {
page: 1,
pageSize: 20,
...filter,
};
const { results, pagination } =
await UncategorizedCashflowTransaction.query()
.onBuild((q) => {
q.modify('pending');
if (_filter?.accountId) {
q.where('accountId', _filter.accountId);
}
})
.pagination(_filter.page - 1, _filter.pageSize);
const data = await this.transformer.transform(
tenantId,
results,
new GetPendingBankAccountTransactionTransformer()
);
return { data, pagination };
}
}
interface GetPendingTransactionsQuery {
page?: number;
pageSize?: number;
accountId?: number;
}

View File

@@ -0,0 +1,73 @@
import { Transformer } from '@/lib/Transformer/Transformer';
import { formatNumber } from '@/utils';
export class GetPendingBankAccountTransactionTransformer extends Transformer {
/**
* Include these attributes to sale invoice object.
* @returns {string[]}
*/
public includeAttributes = (): string[] => {
return [
'formattedAmount',
'formattedDate',
'formattedDepositAmount',
'formattedWithdrawalAmount',
];
};
/**
* Exclude all attributes.
* @returns {Array<string>}
*/
public excludeAttributes = (): string[] => {
return [];
};
/**
* Formattes the transaction date.
* @param transaction
* @returns {string}
*/
public formattedDate(transaction) {
return this.formatDate(transaction.date);
}
/**
* Formatted amount.
* @param transaction
* @returns {string}
*/
public formattedAmount(transaction) {
return formatNumber(transaction.amount, {
currencyCode: transaction.currencyCode,
});
}
/**
* Formatted deposit amount.
* @param transaction
* @returns {string}
*/
protected formattedDepositAmount(transaction) {
if (transaction.isDepositTransaction) {
return formatNumber(transaction.deposit, {
currencyCode: transaction.currencyCode,
});
}
return '';
}
/**
* Formatted withdrawal amount.
* @param transaction
* @returns {string}
*/
protected formattedWithdrawalAmount(transaction) {
if (transaction.isWithdrawalTransaction) {
return formatNumber(transaction.withdrawal, {
currencyCode: transaction.currencyCode,
});
}
return '';
}
}

View File

@@ -34,8 +34,13 @@ export class GetRecognizedTransactionsService {
q.withGraphFetched('recognizedTransaction.assignAccount'); q.withGraphFetched('recognizedTransaction.assignAccount');
q.withGraphFetched('recognizedTransaction.bankRule'); q.withGraphFetched('recognizedTransaction.bankRule');
q.whereNotNull('recognizedTransactionId'); q.whereNotNull('recognizedTransactionId');
// Exclude the excluded transactions.
q.modify('notExcluded'); q.modify('notExcluded');
// Exclude the pending transactions.
q.modify('notPending');
if (_filter.accountId) { if (_filter.accountId) {
q.where('accountId', _filter.accountId); q.where('accountId', _filter.accountId);
} }

View File

@@ -51,7 +51,9 @@ export class GetUncategorizedTransactions {
.onBuild((q) => { .onBuild((q) => {
q.where('accountId', accountId); q.where('accountId', accountId);
q.where('categorized', false); q.where('categorized', false);
q.modify('notExcluded'); q.modify('notExcluded');
q.modify('notPending');
q.withGraphFetched('account'); q.withGraphFetched('account');
q.withGraphFetched('recognizedTransaction.assignAccount'); q.withGraphFetched('recognizedTransaction.assignAccount');

View File

@@ -0,0 +1,72 @@
import { Knex } from 'knex';
import { Inject, Service } from 'typedi';
import HasTenancyService from '../Tenancy/TenancyService';
import UnitOfWork from '../UnitOfWork';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import events from '@/subscribers/events';
import { ServiceError } from '@/exceptions';
import { ERRORS } from './constants';
import {
IPendingTransactionRemovedEventPayload,
IPendingTransactionRemovingEventPayload,
} from '@/interfaces';
@Service()
export class RemovePendingUncategorizedTransaction {
@Inject()
private tenancy: HasTenancyService;
@Inject()
private uow: UnitOfWork;
@Inject()
private eventPublisher: EventPublisher;
/**
* REmoves the pending uncategorized transaction.
* @param {number} tenantId -
* @param {number} uncategorizedTransactionId -
* @param {Knex.Transaction} trx -
* @returns {Promise<void>}
*/
public async removePendingTransaction(
tenantId: number,
uncategorizedTransactionId: number,
trx?: Knex.Transaction
): Promise<void> {
const { UncategorizedCashflowTransaction } = this.tenancy.models(tenantId);
const pendingTransaction = await UncategorizedCashflowTransaction.query(trx)
.findById(uncategorizedTransactionId)
.throwIfNotFound();
if (!pendingTransaction.isPending) {
throw new ServiceError(ERRORS.TRANSACTION_NOT_PENDING);
}
return this.uow.withTransaction(tenantId, async (trx: Knex.Transaction) => {
await this.eventPublisher.emitAsync(
events.bankTransactions.onPendingRemoving,
{
tenantId,
uncategorizedTransactionId,
pendingTransaction,
trx,
} as IPendingTransactionRemovingEventPayload
);
// Removes the pending uncategorized transaction.
await UncategorizedCashflowTransaction.query(trx)
.findById(uncategorizedTransactionId)
.delete();
await this.eventPublisher.emitAsync(
events.bankTransactions.onPendingRemoved,
{
tenantId,
uncategorizedTransactionId,
pendingTransaction,
trx,
} as IPendingTransactionRemovedEventPayload
);
});
}
}

View File

@@ -0,0 +1,37 @@
import PromisePool from '@supercharge/promise-pool';
import { castArray } from 'lodash';
import { Service, Inject } from 'typedi';
import HasTenancyService from '../Tenancy/TenancyService';
import { UncategorizeCashflowTransaction } from './UncategorizeCashflowTransaction';
@Service()
export class UncategorizeCashflowTransactionsBulk {
@Inject()
private tenancy: HasTenancyService;
@Inject()
private uncategorizeTransaction: UncategorizeCashflowTransaction;
/**
* Uncategorize the given bank transactions in bulk.
* @param {number} tenantId
* @param {number} uncategorizedTransactionId
*/
public async uncategorizeBulk(
tenantId: number,
uncategorizedTransactionId: number | Array<number>
) {
const uncategorizedTransactionIds = castArray(uncategorizedTransactionId);
const result = await PromisePool.withConcurrency(MIGRATION_CONCURRENCY)
.for(uncategorizedTransactionIds)
.process(async (_uncategorizedTransactionId: number, index, pool) => {
await this.uncategorizeTransaction.uncategorize(
tenantId,
_uncategorizedTransactionId
);
});
}
}
const MIGRATION_CONCURRENCY = 1;

View File

@@ -15,10 +15,10 @@ export const ERRORS = {
'UNCATEGORIZED_TRANSACTION_TYPE_INVALID', 'UNCATEGORIZED_TRANSACTION_TYPE_INVALID',
CANNOT_DELETE_TRANSACTION_CONVERTED_FROM_UNCATEGORIZED: CANNOT_DELETE_TRANSACTION_CONVERTED_FROM_UNCATEGORIZED:
'CANNOT_DELETE_TRANSACTION_CONVERTED_FROM_UNCATEGORIZED', 'CANNOT_DELETE_TRANSACTION_CONVERTED_FROM_UNCATEGORIZED',
CANNOT_CATEGORIZE_EXCLUDED_TRANSACTION:
CANNOT_CATEGORIZE_EXCLUDED_TRANSACTION: 'CANNOT_CATEGORIZE_EXCLUDED_TRANSACTION', 'CANNOT_CATEGORIZE_EXCLUDED_TRANSACTION',
TRANSACTION_NOT_CATEGORIZED: 'TRANSACTION_NOT_CATEGORIZED' TRANSACTION_NOT_CATEGORIZED: 'TRANSACTION_NOT_CATEGORIZED',
TRANSACTION_NOT_PENDING: 'TRANSACTION_NOT_PENDING',
}; };
export enum CASHFLOW_DIRECTION { export enum CASHFLOW_DIRECTION {

View File

@@ -1,11 +1,11 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import PromisePool from '@supercharge/promise-pool';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { import {
ICashflowTransactionCategorizedPayload, ICashflowTransactionCategorizedPayload,
ICashflowTransactionUncategorizedPayload, ICashflowTransactionUncategorizedPayload,
} from '@/interfaces'; } from '@/interfaces';
import PromisePool from '@supercharge/promise-pool';
@Service() @Service()
export class DecrementUncategorizedTransactionOnCategorize { export class DecrementUncategorizedTransactionOnCategorize {
@@ -36,13 +36,17 @@ export class DecrementUncategorizedTransactionOnCategorize {
public async decrementUnCategorizedTransactionsOnCategorized({ public async decrementUnCategorizedTransactionsOnCategorized({
tenantId, tenantId,
uncategorizedTransactions, uncategorizedTransactions,
trx trx,
}: ICashflowTransactionCategorizedPayload) { }: ICashflowTransactionCategorizedPayload) {
const { Account } = this.tenancy.models(tenantId); const { Account } = this.tenancy.models(tenantId);
await PromisePool.withConcurrency(1) await PromisePool.withConcurrency(1)
.for(uncategorizedTransactions) .for(uncategorizedTransactions)
.process(async (uncategorizedTransaction) => { .process(async (uncategorizedTransaction) => {
// Cannot continue if the transaction is still pending.
if (uncategorizedTransaction.isPending) {
return;
}
await Account.query(trx) await Account.query(trx)
.findById(uncategorizedTransaction.accountId) .findById(uncategorizedTransaction.accountId)
.decrement('uncategorizedTransactions', 1); .decrement('uncategorizedTransactions', 1);
@@ -56,13 +60,17 @@ export class DecrementUncategorizedTransactionOnCategorize {
public async incrementUnCategorizedTransactionsOnUncategorized({ public async incrementUnCategorizedTransactionsOnUncategorized({
tenantId, tenantId,
uncategorizedTransactions, uncategorizedTransactions,
trx trx,
}: ICashflowTransactionUncategorizedPayload) { }: ICashflowTransactionUncategorizedPayload) {
const { Account } = this.tenancy.models(tenantId); const { Account } = this.tenancy.models(tenantId);
await PromisePool.withConcurrency(1) await PromisePool.withConcurrency(1)
.for(uncategorizedTransactions) .for(uncategorizedTransactions)
.process(async (uncategorizedTransaction) => { .process(async (uncategorizedTransaction) => {
// Cannot continue if the transaction is still pending.
if (uncategorizedTransaction.isPending) {
return;
}
await Account.query(trx) await Account.query(trx)
.findById(uncategorizedTransaction.accountId) .findById(uncategorizedTransaction.accountId)
.increment('uncategorizedTransactions', 1); .increment('uncategorizedTransactions', 1);
@@ -82,6 +90,9 @@ export class DecrementUncategorizedTransactionOnCategorize {
if (!uncategorizedTransaction.accountId) return; if (!uncategorizedTransaction.accountId) return;
// Cannot continue if the transaction is still pending.
if (uncategorizedTransaction.isPending) return;
await Account.query(trx) await Account.query(trx)
.findById(uncategorizedTransaction.accountId) .findById(uncategorizedTransaction.accountId)
.increment('uncategorizedTransactions', 1); .increment('uncategorizedTransactions', 1);

View File

@@ -9,7 +9,7 @@ import {
} from '@/interfaces'; } from '@/interfaces';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
import { PaymentReceiveValidators } from '../Sales/PaymentReceives/PaymentReceiveValidators'; import { PaymentReceivedValidators } from '../Sales/PaymentReceived/PaymentReceivedValidators';
import BaseCreditNotes from './CreditNotes'; import BaseCreditNotes from './CreditNotes';
import { import {
IApplyCreditToInvoicesDTO, IApplyCreditToInvoicesDTO,
@@ -26,7 +26,7 @@ export default class CreditNoteApplyToInvoices extends BaseCreditNotes {
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@Inject() @Inject()
private paymentReceiveValidators: PaymentReceiveValidators; private paymentReceiveValidators: PaymentReceivedValidators;
@Inject() @Inject()
private uow: UnitOfWork; private uow: UnitOfWork;

View File

@@ -16,6 +16,7 @@ export class ExpenseTransfromer extends Transformer {
'formattedAllocatedCostAmount', 'formattedAllocatedCostAmount',
'formattedDate', 'formattedDate',
'formattedCreatedAt', 'formattedCreatedAt',
'formattedPublishedAt',
'categories', 'categories',
'attachments', 'attachments',
]; ];
@@ -91,4 +92,13 @@ export class ExpenseTransfromer extends Transformer {
protected attachments = (expense: IExpense) => { protected attachments = (expense: IExpense) => {
return this.item(expense.attachments, new AttachmentTransformer()); return this.item(expense.attachments, new AttachmentTransformer());
}; };
/**
* Retrieve formatted published at date.
* @param {IExpense} expense
* @returns {string}
*/
protected formattedPublishedAt = (expense: IExpense): string => {
return this.formatDate(expense.publishedAt);
}
} }

View File

@@ -9,12 +9,13 @@ import { SaleInvoicesExportable } from '../Sales/Invoices/SaleInvoicesExportable
import { SaleEstimatesExportable } from '../Sales/Estimates/SaleEstimatesExportable'; import { SaleEstimatesExportable } from '../Sales/Estimates/SaleEstimatesExportable';
import { SaleReceiptsExportable } from '../Sales/Receipts/SaleReceiptsExportable'; import { SaleReceiptsExportable } from '../Sales/Receipts/SaleReceiptsExportable';
import { BillsExportable } from '../Purchases/Bills/BillsExportable'; import { BillsExportable } from '../Purchases/Bills/BillsExportable';
import { PaymentsReceivedExportable } from '../Sales/PaymentReceives/PaymentsReceivedExportable'; import { PaymentsReceivedExportable } from '../Sales/PaymentReceived/PaymentsReceivedExportable';
import { BillPaymentExportable } from '../Purchases/BillPayments/BillPaymentExportable'; import { BillPaymentExportable } from '../Purchases/BillPayments/BillPaymentExportable';
import { ManualJournalsExportable } from '../ManualJournals/ManualJournalExportable'; import { ManualJournalsExportable } from '../ManualJournals/ManualJournalExportable';
import { CreditNotesExportable } from '../CreditNotes/CreditNotesExportable'; import { CreditNotesExportable } from '../CreditNotes/CreditNotesExportable';
import { VendorCreditsExportable } from '../Purchases/VendorCredits/VendorCreditsExportable'; import { VendorCreditsExportable } from '../Purchases/VendorCredits/VendorCreditsExportable';
import { ItemCategoriesExportable } from '../ItemCategories/ItemCategoriesExportable'; import { ItemCategoriesExportable } from '../ItemCategories/ItemCategoriesExportable';
import { TaxRatesExportable } from '../TaxRates/TaxRatesExportable';
@Service() @Service()
export class ExportableResources { export class ExportableResources {
@@ -46,6 +47,7 @@ export class ExportableResources {
{ resource: 'ManualJournal', exportable: ManualJournalsExportable }, { resource: 'ManualJournal', exportable: ManualJournalsExportable },
{ resource: 'CreditNote', exportable: CreditNotesExportable }, { resource: 'CreditNote', exportable: CreditNotesExportable },
{ resource: 'VendorCredit', exportable: VendorCreditsExportable }, { resource: 'VendorCredit', exportable: VendorCreditsExportable },
{ resource: 'TaxRate', exportable: TaxRatesExportable },
]; ];
/** /**

View File

@@ -15,6 +15,7 @@ import { FinancialSheetStructure } from '../FinancialSheetStructure';
import { flatToNestedArray } from '@/utils'; import { flatToNestedArray } from '@/utils';
import Ledger from '@/services/Accounting/Ledger'; import Ledger from '@/services/Accounting/Ledger';
import { calculateRunningBalance } from './_utils'; import { calculateRunningBalance } from './_utils';
import { getTransactionTypeLabel } from '@/utils/transactions-types';
/** /**
* General ledger sheet. * General ledger sheet.
@@ -90,11 +91,13 @@ export default class GeneralLedgerSheet extends R.compose(
date: entry.date, date: entry.date,
dateFormatted: moment(entry.date).format('YYYY MMM DD'), dateFormatted: moment(entry.date).format('YYYY MMM DD'),
transactionNumber: entry.transactionNumber, referenceType: entry.transactionType,
referenceType: entry.referenceType, referenceId: entry.transactionId,
referenceId: entry.referenceId,
referenceTypeFormatted: this.i18n.__(entry.referenceTypeFormatted),
transactionNumber: entry.transactionNumber,
transactionTypeFormatted: this.i18n.__(
getTransactionTypeLabel(entry.transactionType, entry.transactionSubType)
),
contactName: get(contact, 'displayName'), contactName: get(contact, 'displayName'),
contactType: get(contact, 'contactService'), contactType: get(contact, 'contactService'),

View File

@@ -67,7 +67,7 @@ export class GeneralLedgerTable extends R.compose(
return [ return [
{ key: 'date', accessor: 'dateFormatted' }, { key: 'date', accessor: 'dateFormatted' },
{ key: 'account_name', accessor: 'account.name' }, { key: 'account_name', accessor: 'account.name' },
{ key: 'reference_type', accessor: 'referenceTypeFormatted' }, { key: 'reference_type', accessor: 'transactionTypeFormatted' },
{ key: 'reference_number', accessor: 'transactionNumber' }, { key: 'reference_number', accessor: 'transactionNumber' },
{ key: 'description', accessor: 'note' }, { key: 'description', accessor: 'note' },
{ key: 'credit', accessor: 'formattedCredit' }, { key: 'credit', accessor: 'formattedCredit' },

View File

@@ -13,9 +13,10 @@ import { SaleInvoicesImportable } from '../Sales/Invoices/SaleInvoicesImportable
import { SaleEstimatesImportable } from '../Sales/Estimates/SaleEstimatesImportable'; import { SaleEstimatesImportable } from '../Sales/Estimates/SaleEstimatesImportable';
import { BillPaymentsImportable } from '../Purchases/BillPayments/BillPaymentsImportable'; import { BillPaymentsImportable } from '../Purchases/BillPayments/BillPaymentsImportable';
import { VendorCreditsImportable } from '../Purchases/VendorCredits/VendorCreditsImportable'; import { VendorCreditsImportable } from '../Purchases/VendorCredits/VendorCreditsImportable';
import { PaymentReceivesImportable } from '../Sales/PaymentReceives/PaymentReceivesImportable'; import { PaymentsReceivedImportable } from '../Sales/PaymentReceived/PaymentsReceivedImportable';
import { CreditNotesImportable } from '../CreditNotes/CreditNotesImportable'; import { CreditNotesImportable } from '../CreditNotes/CreditNotesImportable';
import { SaleReceiptsImportable } from '../Sales/Receipts/SaleReceiptsImportable'; import { SaleReceiptsImportable } from '../Sales/Receipts/SaleReceiptsImportable';
import { TaxRatesImportable } from '../TaxRates/TaxRatesImportable';
@Service() @Service()
export class ImportableResources { export class ImportableResources {
@@ -44,10 +45,11 @@ export class ImportableResources {
{ resource: 'SaleInvoice', importable: SaleInvoicesImportable }, { resource: 'SaleInvoice', importable: SaleInvoicesImportable },
{ resource: 'SaleEstimate', importable: SaleEstimatesImportable }, { resource: 'SaleEstimate', importable: SaleEstimatesImportable },
{ resource: 'BillPayment', importable: BillPaymentsImportable }, { resource: 'BillPayment', importable: BillPaymentsImportable },
{ resource: 'PaymentReceive', importable: PaymentReceivesImportable }, { resource: 'PaymentReceive', importable: PaymentsReceivedImportable },
{ resource: 'VendorCredit', importable: VendorCreditsImportable }, { resource: 'VendorCredit', importable: VendorCreditsImportable },
{ resource: 'CreditNote', importable: CreditNotesImportable }, { resource: 'CreditNote', importable: CreditNotesImportable },
{ resource: 'SaleReceipt', importable: SaleReceiptsImportable } { resource: 'SaleReceipt', importable: SaleReceiptsImportable },
{ resource: 'TaxRate', importable: TaxRatesImportable },
]; ];
public get registry() { public get registry() {

View File

@@ -6,7 +6,7 @@ import SaleNotifyBySms from '../SaleNotifyBySms';
import SmsNotificationsSettingsService from '@/services/Settings/SmsNotificationsSettings'; import SmsNotificationsSettingsService from '@/services/Settings/SmsNotificationsSettings';
import { import {
ICustomer, ICustomer,
IPaymentReceiveSmsDetails, IPaymentReceivedSmsDetails,
ISaleEstimate, ISaleEstimate,
SMS_NOTIFICATION_KEY, SMS_NOTIFICATION_KEY,
} from '@/interfaces'; } from '@/interfaces';
@@ -173,12 +173,12 @@ export class SaleEstimateNotifyBySms {
* Retrieve the SMS details of the given payment receive transaction. * Retrieve the SMS details of the given payment receive transaction.
* @param {number} tenantId * @param {number} tenantId
* @param {number} saleEstimateId * @param {number} saleEstimateId
* @returns {Promise<IPaymentReceiveSmsDetails>} * @returns {Promise<IPaymentReceivedSmsDetails>}
*/ */
public smsDetails = async ( public smsDetails = async (
tenantId: number, tenantId: number,
saleEstimateId: number saleEstimateId: number
): Promise<IPaymentReceiveSmsDetails> => { ): Promise<IPaymentReceivedSmsDetails> => {
const { SaleEstimate } = this.tenancy.models(tenantId); const { SaleEstimate } = this.tenancy.models(tenantId);
// Retrieve the sale invoice or throw not found service error. // Retrieve the sale invoice or throw not found service error.

View File

@@ -3,7 +3,7 @@ import { CreateSaleEstimate } from './CreateSaleEstimate';
import { import {
IFilterMeta, IFilterMeta,
IPaginationMeta, IPaginationMeta,
IPaymentReceiveSmsDetails, IPaymentReceivedSmsDetails,
ISaleEstimate, ISaleEstimate,
ISaleEstimateDTO, ISaleEstimateDTO,
ISalesEstimatesFilter, ISalesEstimatesFilter,
@@ -191,12 +191,12 @@ export class SaleEstimatesApplication {
* Retrieve the SMS details of the given payment receive transaction. * Retrieve the SMS details of the given payment receive transaction.
* @param {number} tenantId * @param {number} tenantId
* @param {number} saleEstimateId * @param {number} saleEstimateId
* @returns {Promise<IPaymentReceiveSmsDetails>} * @returns {Promise<IPaymentReceivedSmsDetails>}
*/ */
public getSaleEstimateSmsDetails = ( public getSaleEstimateSmsDetails = (
tenantId: number, tenantId: number,
saleEstimateId: number saleEstimateId: number
): Promise<IPaymentReceiveSmsDetails> => { ): Promise<IPaymentReceivedSmsDetails> => {
return this.saleEstimateNotifyBySmsService.smsDetails( return this.saleEstimateNotifyBySmsService.smsDetails(
tenantId, tenantId,
saleEstimateId saleEstimateId

View File

@@ -2,7 +2,7 @@ import { Knex } from 'knex';
import async from 'async'; import async from 'async';
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { PaymentReceiveGLEntries } from '../PaymentReceives/PaymentReceiveGLEntries'; import { PaymentReceivedGLEntries } from '../PaymentReceived/PaymentReceivedGLEntries';
@Service() @Service()
export class InvoicePaymentsGLEntriesRewrite { export class InvoicePaymentsGLEntriesRewrite {
@@ -10,7 +10,7 @@ export class InvoicePaymentsGLEntriesRewrite {
public tenancy: HasTenancyService; public tenancy: HasTenancyService;
@Inject() @Inject()
public paymentGLEntries: PaymentReceiveGLEntries; public paymentGLEntries: PaymentReceivedGLEntries;
/** /**
* Rewrites the payment GL entries task. * Rewrites the payment GL entries task.

View File

@@ -2,23 +2,23 @@ import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { import {
ICustomer, ICustomer,
IPaymentReceiveCreateDTO, IPaymentReceivedCreateDTO,
IPaymentReceiveCreatedPayload, IPaymentReceivedCreatedPayload,
IPaymentReceiveCreatingPayload, IPaymentReceivedCreatingPayload,
ISystemUser, ISystemUser,
} from '@/interfaces'; } from '@/interfaces';
import { PaymentReceiveValidators } from './PaymentReceiveValidators'; import { PaymentReceivedValidators } from './PaymentReceivedValidators';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
import { PaymentReceiveDTOTransformer } from './PaymentReceiveDTOTransformer'; import { PaymentReceiveDTOTransformer } from './PaymentReceivedDTOTransformer';
import { TenantMetadata } from '@/system/models'; import { TenantMetadata } from '@/system/models';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
@Service() @Service()
export class CreatePaymentReceive { export class CreatePaymentReceived {
@Inject() @Inject()
private validators: PaymentReceiveValidators; private validators: PaymentReceivedValidators;
@Inject() @Inject()
private eventPublisher: EventPublisher; private eventPublisher: EventPublisher;
@@ -37,11 +37,11 @@ export class CreatePaymentReceive {
* with associated invoices payment and journal transactions. * with associated invoices payment and journal transactions.
* @async * @async
* @param {number} tenantId - Tenant id. * @param {number} tenantId - Tenant id.
* @param {IPaymentReceive} paymentReceive * @param {IPaymentReceived} paymentReceive
*/ */
public async createPaymentReceive( public async createPaymentReceived(
tenantId: number, tenantId: number,
paymentReceiveDTO: IPaymentReceiveCreateDTO, paymentReceiveDTO: IPaymentReceivedCreateDTO,
authorizedUser: ISystemUser, authorizedUser: ISystemUser,
trx?: Knex.Transaction trx?: Knex.Transaction
) { ) {
@@ -97,7 +97,7 @@ export class CreatePaymentReceive {
trx, trx,
paymentReceiveDTO, paymentReceiveDTO,
tenantId, tenantId,
} as IPaymentReceiveCreatingPayload); } as IPaymentReceivedCreatingPayload);
// Inserts the payment receive transaction. // Inserts the payment receive transaction.
const paymentReceive = await PaymentReceive.query( const paymentReceive = await PaymentReceive.query(
@@ -113,7 +113,7 @@ export class CreatePaymentReceive {
paymentReceiveDTO, paymentReceiveDTO,
authorizedUser, authorizedUser,
trx, trx,
} as IPaymentReceiveCreatedPayload); } as IPaymentReceivedCreatedPayload);
return paymentReceive; return paymentReceive;
}, },
@@ -125,13 +125,13 @@ export class CreatePaymentReceive {
* Transform the create payment receive DTO. * Transform the create payment receive DTO.
* @param {number} tenantId * @param {number} tenantId
* @param {ICustomer} customer * @param {ICustomer} customer
* @param {IPaymentReceiveCreateDTO} paymentReceiveDTO * @param {IPaymentReceivedCreateDTO} paymentReceiveDTO
* @returns * @returns
*/ */
private transformCreateDTOToModel = async ( private transformCreateDTOToModel = async (
tenantId: number, tenantId: number,
customer: ICustomer, customer: ICustomer,
paymentReceiveDTO: IPaymentReceiveCreateDTO paymentReceiveDTO: IPaymentReceivedCreateDTO
) => { ) => {
return this.transformer.transformPaymentReceiveDTOToModel( return this.transformer.transformPaymentReceiveDTOToModel(
tenantId, tenantId,

View File

@@ -1,8 +1,8 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { import {
IPaymentReceiveDeletedPayload, IPaymentReceivedDeletedPayload,
IPaymentReceiveDeletingPayload, IPaymentReceivedDeletingPayload,
ISystemUser, ISystemUser,
} from '@/interfaces'; } from '@/interfaces';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
@@ -11,7 +11,7 @@ import events from '@/subscribers/events';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
@Service() @Service()
export class DeletePaymentReceive { export class DeletePaymentReceived {
@Inject() @Inject()
private eventPublisher: EventPublisher; private eventPublisher: EventPublisher;
@@ -33,7 +33,7 @@ export class DeletePaymentReceive {
* @async * @async
* @param {number} tenantId - Tenant id. * @param {number} tenantId - Tenant id.
* @param {Integer} paymentReceiveId - Payment receive id. * @param {Integer} paymentReceiveId - Payment receive id.
* @param {IPaymentReceive} paymentReceive - Payment receive object. * @param {IPaymentReceived} paymentReceive - Payment receive object.
*/ */
public async deletePaymentReceive( public async deletePaymentReceive(
tenantId: number, tenantId: number,
@@ -56,7 +56,7 @@ export class DeletePaymentReceive {
tenantId, tenantId,
oldPaymentReceive, oldPaymentReceive,
trx, trx,
} as IPaymentReceiveDeletingPayload); } as IPaymentReceivedDeletingPayload);
// Deletes the payment receive associated entries. // Deletes the payment receive associated entries.
await PaymentReceiveEntry.query(trx) await PaymentReceiveEntry.query(trx)
@@ -73,7 +73,7 @@ export class DeletePaymentReceive {
oldPaymentReceive, oldPaymentReceive,
authorizedUser, authorizedUser,
trx, trx,
} as IPaymentReceiveDeletedPayload); } as IPaymentReceivedDeletedPayload);
}); });
} }
} }

View File

@@ -2,14 +2,14 @@ import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { import {
ICustomer, ICustomer,
IPaymentReceive, IPaymentReceived,
IPaymentReceiveEditDTO, IPaymentReceivedEditDTO,
IPaymentReceiveEditedPayload, IPaymentReceivedEditedPayload,
IPaymentReceiveEditingPayload, IPaymentReceivedEditingPayload,
ISystemUser, ISystemUser,
} from '@/interfaces'; } from '@/interfaces';
import { PaymentReceiveDTOTransformer } from './PaymentReceiveDTOTransformer'; import { PaymentReceiveDTOTransformer } from './PaymentReceivedDTOTransformer';
import { PaymentReceiveValidators } from './PaymentReceiveValidators'; import { PaymentReceivedValidators } from './PaymentReceivedValidators';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import UnitOfWork from '@/services/UnitOfWork'; import UnitOfWork from '@/services/UnitOfWork';
@@ -17,12 +17,12 @@ import HasTenancyService from '@/services/Tenancy/TenancyService';
import { TenantMetadata } from '@/system/models'; import { TenantMetadata } from '@/system/models';
@Service() @Service()
export class EditPaymentReceive { export class EditPaymentReceived {
@Inject() @Inject()
private transformer: PaymentReceiveDTOTransformer; private transformer: PaymentReceiveDTOTransformer;
@Inject() @Inject()
private validators: PaymentReceiveValidators; private validators: PaymentReceivedValidators;
@Inject() @Inject()
private eventPublisher: EventPublisher; private eventPublisher: EventPublisher;
@@ -46,12 +46,12 @@ export class EditPaymentReceive {
* @async * @async
* @param {number} tenantId - * @param {number} tenantId -
* @param {Integer} paymentReceiveId - * @param {Integer} paymentReceiveId -
* @param {IPaymentReceive} paymentReceive - * @param {IPaymentReceived} paymentReceive -
*/ */
public async editPaymentReceive( public async editPaymentReceive(
tenantId: number, tenantId: number,
paymentReceiveId: number, paymentReceiveId: number,
paymentReceiveDTO: IPaymentReceiveEditDTO, paymentReceiveDTO: IPaymentReceivedEditDTO,
authorizedUser: ISystemUser authorizedUser: ISystemUser
) { ) {
const { PaymentReceive, Contact } = this.tenancy.models(tenantId); const { PaymentReceive, Contact } = this.tenancy.models(tenantId);
@@ -131,7 +131,7 @@ export class EditPaymentReceive {
tenantId, tenantId,
oldPaymentReceive, oldPaymentReceive,
paymentReceiveDTO, paymentReceiveDTO,
} as IPaymentReceiveEditingPayload); } as IPaymentReceivedEditingPayload);
// Update the payment receive transaction. // Update the payment receive transaction.
const paymentReceive = await PaymentReceive.query( const paymentReceive = await PaymentReceive.query(
@@ -149,7 +149,7 @@ export class EditPaymentReceive {
paymentReceiveDTO, paymentReceiveDTO,
authorizedUser, authorizedUser,
trx, trx,
} as IPaymentReceiveEditedPayload); } as IPaymentReceivedEditedPayload);
return paymentReceive; return paymentReceive;
}); });
@@ -159,15 +159,15 @@ export class EditPaymentReceive {
* Transform the edit payment receive DTO. * Transform the edit payment receive DTO.
* @param {number} tenantId * @param {number} tenantId
* @param {ICustomer} customer * @param {ICustomer} customer
* @param {IPaymentReceiveEditDTO} paymentReceiveDTO * @param {IPaymentReceivedEditDTO} paymentReceiveDTO
* @param {IPaymentReceive} oldPaymentReceive * @param {IPaymentReceived} oldPaymentReceive
* @returns * @returns
*/ */
private transformEditDTOToModel = async ( private transformEditDTOToModel = async (
tenantId: number, tenantId: number,
customer: ICustomer, customer: ICustomer,
paymentReceiveDTO: IPaymentReceiveEditDTO, paymentReceiveDTO: IPaymentReceivedEditDTO,
oldPaymentReceive: IPaymentReceive oldPaymentReceive: IPaymentReceived
) => { ) => {
return this.transformer.transformPaymentReceiveDTOToModel( return this.transformer.transformPaymentReceiveDTOToModel(
tenantId, tenantId,

View File

@@ -1,13 +1,13 @@
import { ServiceError } from '@/exceptions'; import { ServiceError } from '@/exceptions';
import { IPaymentReceive } from '@/interfaces'; import { IPaymentReceived } from '@/interfaces';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { ERRORS } from './constants'; import { ERRORS } from './constants';
import { PaymentReceiveTransfromer } from './PaymentReceiveTransformer'; import { PaymentReceiveTransfromer } from './PaymentReceivedTransformer';
import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable'; import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable';
@Service() @Service()
export class GetPaymentReceive { export class GetPaymentReceived {
@Inject() @Inject()
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@@ -18,12 +18,12 @@ export class GetPaymentReceive {
* Retrieve payment receive details. * Retrieve payment receive details.
* @param {number} tenantId - Tenant id. * @param {number} tenantId - Tenant id.
* @param {number} paymentReceiveId - Payment receive id. * @param {number} paymentReceiveId - Payment receive id.
* @return {Promise<IPaymentReceive>} * @return {Promise<IPaymentReceived>}
*/ */
public async getPaymentReceive( public async getPaymentReceive(
tenantId: number, tenantId: number,
paymentReceiveId: number paymentReceiveId: number
): Promise<IPaymentReceive> { ): Promise<IPaymentReceived> {
const { PaymentReceive } = this.tenancy.models(tenantId); const { PaymentReceive } = this.tenancy.models(tenantId);
const paymentReceive = await PaymentReceive.query() const paymentReceive = await PaymentReceive.query()

View File

@@ -1,14 +1,14 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { PaymentReceiveValidators } from './PaymentReceiveValidators'; import { PaymentReceivedValidators } from './PaymentReceivedValidators';
@Service() @Service()
export class GetPaymentReceiveInvoices { export class GetPaymentReceivedInvoices {
@Inject() @Inject()
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@Inject() @Inject()
private validators: PaymentReceiveValidators; private validators: PaymentReceivedValidators;
/** /**
* Retrieve sale invoices that assocaited to the given payment receive. * Retrieve sale invoices that assocaited to the given payment receive.

View File

@@ -1,10 +1,10 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { ChromiumlyTenancy } from '@/services/ChromiumlyTenancy/ChromiumlyTenancy'; import { ChromiumlyTenancy } from '@/services/ChromiumlyTenancy/ChromiumlyTenancy';
import { TemplateInjectable } from '@/services/TemplateInjectable/TemplateInjectable'; import { TemplateInjectable } from '@/services/TemplateInjectable/TemplateInjectable';
import { GetPaymentReceive } from './GetPaymentReceive'; import { GetPaymentReceived } from './GetPaymentReceived';
@Service() @Service()
export default class GetPaymentReceivePdf { export default class GetPaymentReceivedPdf {
@Inject() @Inject()
private chromiumlyTenancy: ChromiumlyTenancy; private chromiumlyTenancy: ChromiumlyTenancy;
@@ -12,12 +12,12 @@ export default class GetPaymentReceivePdf {
private templateInjectable: TemplateInjectable; private templateInjectable: TemplateInjectable;
@Inject() @Inject()
private getPaymentService: GetPaymentReceive; private getPaymentService: GetPaymentReceived;
/** /**
* Retrieve sale invoice pdf content. * Retrieve sale invoice pdf content.
* @param {number} tenantId - * @param {number} tenantId -
* @param {IPaymentReceive} paymentReceive - * @param {IPaymentReceived} paymentReceive -
* @returns {Promise<Buffer>} * @returns {Promise<Buffer>}
*/ */
async getPaymentReceivePdf( async getPaymentReceivePdf(

View File

@@ -3,10 +3,10 @@ import * as R from 'ramda';
import { import {
IFilterMeta, IFilterMeta,
IPaginationMeta, IPaginationMeta,
IPaymentReceive, IPaymentReceived,
IPaymentReceivesFilter, IPaymentsReceivedFilter,
} from '@/interfaces'; } from '@/interfaces';
import { PaymentReceiveTransfromer } from './PaymentReceiveTransformer'; import { PaymentReceiveTransfromer } from './PaymentReceivedTransformer';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable'; import { TransformerInjectable } from '@/lib/Transformer/TransformerInjectable';
import DynamicListingService from '@/services/DynamicListing/DynamicListService'; import DynamicListingService from '@/services/DynamicListing/DynamicListService';
@@ -25,13 +25,13 @@ export class GetPaymentReceives {
/** /**
* Retrieve payment receives paginated and filterable list. * Retrieve payment receives paginated and filterable list.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceivesFilter} paymentReceivesFilter * @param {IPaymentsReceivedFilter} paymentReceivesFilter
*/ */
public async getPaymentReceives( public async getPaymentReceives(
tenantId: number, tenantId: number,
filterDTO: IPaymentReceivesFilter filterDTO: IPaymentsReceivedFilter
): Promise<{ ): Promise<{
paymentReceives: IPaymentReceive[]; paymentReceives: IPaymentReceived[];
pagination: IPaginationMeta; pagination: IPaginationMeta;
filterMeta: IFilterMeta; filterMeta: IFilterMeta;
}> { }> {

View File

@@ -1,44 +1,44 @@
import { import {
IFilterMeta, IFilterMeta,
IPaginationMeta, IPaginationMeta,
IPaymentReceive, IPaymentReceived,
IPaymentReceiveCreateDTO, IPaymentReceivedCreateDTO,
IPaymentReceiveEditDTO, IPaymentReceivedEditDTO,
IPaymentReceiveSmsDetails, IPaymentReceivedSmsDetails,
IPaymentReceivesFilter, IPaymentsReceivedFilter,
ISystemUser, ISystemUser,
PaymentReceiveMailOptsDTO, PaymentReceiveMailOptsDTO,
} from '@/interfaces'; } from '@/interfaces';
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { CreatePaymentReceive } from './CreatePaymentReceive'; import { CreatePaymentReceived } from './CreatePaymentReceived';
import { EditPaymentReceive } from './EditPaymentReceive'; import { EditPaymentReceived } from './EditPaymentReceived';
import { DeletePaymentReceive } from './DeletePaymentReceive'; import { DeletePaymentReceived } from './DeletePaymentReceived';
import { GetPaymentReceives } from './GetPaymentReceives'; import { GetPaymentReceives } from './GetPaymentsReceived';
import { GetPaymentReceive } from './GetPaymentReceive'; import { GetPaymentReceived } from './GetPaymentReceived';
import { GetPaymentReceiveInvoices } from './GetPaymentReceiveInvoices'; import { GetPaymentReceivedInvoices } from './GetPaymentReceivedInvoices';
import { PaymentReceiveNotifyBySms } from './PaymentReceiveSmsNotify'; import { PaymentReceiveNotifyBySms } from './PaymentReceivedSmsNotify';
import GetPaymentReceivePdf from './GetPaymentReeceivePdf'; import GetPaymentReceivedPdf from './GetPaymentReceivedPdf';
import { SendPaymentReceiveMailNotification } from './PaymentReceiveMailNotification'; import { SendPaymentReceiveMailNotification } from './PaymentReceivedMailNotification';
@Service() @Service()
export class PaymentReceivesApplication { export class PaymentReceivesApplication {
@Inject() @Inject()
private createPaymentReceiveService: CreatePaymentReceive; private createPaymentReceivedService: CreatePaymentReceived;
@Inject() @Inject()
private editPaymentReceiveService: EditPaymentReceive; private editPaymentReceivedService: EditPaymentReceived;
@Inject() @Inject()
private deletePaymentReceiveService: DeletePaymentReceive; private deletePaymentReceivedService: DeletePaymentReceived;
@Inject() @Inject()
private getPaymentReceivesService: GetPaymentReceives; private getPaymentsReceivedService: GetPaymentReceives;
@Inject() @Inject()
private getPaymentReceiveService: GetPaymentReceive; private getPaymentReceivedService: GetPaymentReceived;
@Inject() @Inject()
private getPaymentReceiveInvoicesService: GetPaymentReceiveInvoices; private getPaymentReceiveInvoicesService: GetPaymentReceivedInvoices;
@Inject() @Inject()
private paymentSmsNotify: PaymentReceiveNotifyBySms; private paymentSmsNotify: PaymentReceiveNotifyBySms;
@@ -47,21 +47,21 @@ export class PaymentReceivesApplication {
private paymentMailNotify: SendPaymentReceiveMailNotification; private paymentMailNotify: SendPaymentReceiveMailNotification;
@Inject() @Inject()
private getPaymentReceivePdfService: GetPaymentReceivePdf; private getPaymentReceivePdfService: GetPaymentReceivedPdf;
/** /**
* Creates a new payment receive. * Creates a new payment receive.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceiveCreateDTO} paymentReceiveDTO * @param {IPaymentReceivedCreateDTO} paymentReceiveDTO
* @param {ISystemUser} authorizedUser * @param {ISystemUser} authorizedUser
* @returns * @returns
*/ */
public createPaymentReceive( public createPaymentReceived(
tenantId: number, tenantId: number,
paymentReceiveDTO: IPaymentReceiveCreateDTO, paymentReceiveDTO: IPaymentReceivedCreateDTO,
authorizedUser: ISystemUser authorizedUser: ISystemUser
) { ) {
return this.createPaymentReceiveService.createPaymentReceive( return this.createPaymentReceivedService.createPaymentReceived(
tenantId, tenantId,
paymentReceiveDTO, paymentReceiveDTO,
authorizedUser authorizedUser
@@ -72,17 +72,17 @@ export class PaymentReceivesApplication {
* Edit details the given payment receive with associated entries. * Edit details the given payment receive with associated entries.
* @param {number} tenantId * @param {number} tenantId
* @param {number} paymentReceiveId * @param {number} paymentReceiveId
* @param {IPaymentReceiveEditDTO} paymentReceiveDTO * @param {IPaymentReceivedEditDTO} paymentReceiveDTO
* @param {ISystemUser} authorizedUser * @param {ISystemUser} authorizedUser
* @returns * @returns
*/ */
public editPaymentReceive( public editPaymentReceive(
tenantId: number, tenantId: number,
paymentReceiveId: number, paymentReceiveId: number,
paymentReceiveDTO: IPaymentReceiveEditDTO, paymentReceiveDTO: IPaymentReceivedEditDTO,
authorizedUser: ISystemUser authorizedUser: ISystemUser
) { ) {
return this.editPaymentReceiveService.editPaymentReceive( return this.editPaymentReceivedService.editPaymentReceive(
tenantId, tenantId,
paymentReceiveId, paymentReceiveId,
paymentReceiveDTO, paymentReceiveDTO,
@@ -102,7 +102,7 @@ export class PaymentReceivesApplication {
paymentReceiveId: number, paymentReceiveId: number,
authorizedUser: ISystemUser authorizedUser: ISystemUser
) { ) {
return this.deletePaymentReceiveService.deletePaymentReceive( return this.deletePaymentReceivedService.deletePaymentReceive(
tenantId, tenantId,
paymentReceiveId, paymentReceiveId,
authorizedUser authorizedUser
@@ -112,18 +112,18 @@ export class PaymentReceivesApplication {
/** /**
* Retrieve payment receives paginated and filterable. * Retrieve payment receives paginated and filterable.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceivesFilter} filterDTO * @param {IPaymentsReceivedFilter} filterDTO
* @returns * @returns
*/ */
public async getPaymentReceives( public async getPaymentReceives(
tenantId: number, tenantId: number,
filterDTO: IPaymentReceivesFilter filterDTO: IPaymentsReceivedFilter
): Promise<{ ): Promise<{
paymentReceives: IPaymentReceive[]; paymentReceives: IPaymentReceived[];
pagination: IPaginationMeta; pagination: IPaginationMeta;
filterMeta: IFilterMeta; filterMeta: IFilterMeta;
}> { }> {
return this.getPaymentReceivesService.getPaymentReceives( return this.getPaymentsReceivedService.getPaymentReceives(
tenantId, tenantId,
filterDTO filterDTO
); );
@@ -133,13 +133,13 @@ export class PaymentReceivesApplication {
* Retrieves the given payment receive. * Retrieves the given payment receive.
* @param {number} tenantId * @param {number} tenantId
* @param {number} paymentReceiveId * @param {number} paymentReceiveId
* @returns {Promise<IPaymentReceive>} * @returns {Promise<IPaymentReceived>}
*/ */
public async getPaymentReceive( public async getPaymentReceive(
tenantId: number, tenantId: number,
paymentReceiveId: number paymentReceiveId: number
): Promise<IPaymentReceive> { ): Promise<IPaymentReceived> {
return this.getPaymentReceiveService.getPaymentReceive( return this.getPaymentReceivedService.getPaymentReceive(
tenantId, tenantId,
paymentReceiveId paymentReceiveId
); );
@@ -175,7 +175,7 @@ export class PaymentReceivesApplication {
public getPaymentSmsDetails = async ( public getPaymentSmsDetails = async (
tenantId: number, tenantId: number,
paymentReceiveId: number paymentReceiveId: number
): Promise<IPaymentReceiveSmsDetails> => { ): Promise<IPaymentReceivedSmsDetails> => {
return this.paymentSmsNotify.smsDetails(tenantId, paymentReceiveId); return this.paymentSmsNotify.smsDetails(tenantId, paymentReceiveId);
}; };

View File

@@ -3,22 +3,22 @@ import { Inject, Service } from 'typedi';
import { omit, sumBy } from 'lodash'; import { omit, sumBy } from 'lodash';
import { import {
ICustomer, ICustomer,
IPaymentReceive, IPaymentReceived,
IPaymentReceiveCreateDTO, IPaymentReceivedCreateDTO,
IPaymentReceiveEditDTO, IPaymentReceivedEditDTO,
} from '@/interfaces'; } from '@/interfaces';
import { PaymentReceiveValidators } from './PaymentReceiveValidators'; import { PaymentReceivedValidators } from './PaymentReceivedValidators';
import { PaymentReceiveIncrement } from './PaymentReceiveIncrement'; import { PaymentReceivedIncrement } from './PaymentReceivedIncrement';
import { BranchTransactionDTOTransform } from '@/services/Branches/Integrations/BranchTransactionDTOTransform'; import { BranchTransactionDTOTransform } from '@/services/Branches/Integrations/BranchTransactionDTOTransform';
import { formatDateFields } from '@/utils'; import { formatDateFields } from '@/utils';
@Service() @Service()
export class PaymentReceiveDTOTransformer { export class PaymentReceiveDTOTransformer {
@Inject() @Inject()
private validators: PaymentReceiveValidators; private validators: PaymentReceivedValidators;
@Inject() @Inject()
private increments: PaymentReceiveIncrement; private increments: PaymentReceivedIncrement;
@Inject() @Inject()
private branchDTOTransform: BranchTransactionDTOTransform; private branchDTOTransform: BranchTransactionDTOTransform;
@@ -26,16 +26,16 @@ export class PaymentReceiveDTOTransformer {
/** /**
* Transformes the create payment receive DTO to model object. * Transformes the create payment receive DTO to model object.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceiveCreateDTO|IPaymentReceiveEditDTO} paymentReceiveDTO - Payment receive DTO. * @param {IPaymentReceivedCreateDTO|IPaymentReceivedEditDTO} paymentReceiveDTO - Payment receive DTO.
* @param {IPaymentReceive} oldPaymentReceive - * @param {IPaymentReceived} oldPaymentReceive -
* @return {IPaymentReceive} * @return {IPaymentReceived}
*/ */
public async transformPaymentReceiveDTOToModel( public async transformPaymentReceiveDTOToModel(
tenantId: number, tenantId: number,
customer: ICustomer, customer: ICustomer,
paymentReceiveDTO: IPaymentReceiveCreateDTO | IPaymentReceiveEditDTO, paymentReceiveDTO: IPaymentReceivedCreateDTO | IPaymentReceivedEditDTO,
oldPaymentReceive?: IPaymentReceive oldPaymentReceive?: IPaymentReceived
): Promise<IPaymentReceive> { ): Promise<IPaymentReceived> {
const amount = const amount =
paymentReceiveDTO.amount ?? paymentReceiveDTO.amount ??
sumBy(paymentReceiveDTO.entries, 'paymentAmount'); sumBy(paymentReceiveDTO.entries, 'paymentAmount');
@@ -65,7 +65,7 @@ export class PaymentReceiveDTOTransformer {
})), })),
}; };
return R.compose( return R.compose(
this.branchDTOTransform.transformDTO<IPaymentReceive>(tenantId) this.branchDTOTransform.transformDTO<IPaymentReceived>(tenantId)
)(initialDTO); )(initialDTO);
} }
} }

View File

@@ -2,7 +2,7 @@ import { Transformer } from '@/lib/Transformer/Transformer';
import { SaleInvoiceTransformer } from '../Invoices/SaleInvoiceTransformer'; import { SaleInvoiceTransformer } from '../Invoices/SaleInvoiceTransformer';
import { formatNumber } from '@/utils'; import { formatNumber } from '@/utils';
export class PaymentReceiveEntryTransfromer extends Transformer { export class PaymentReceivedEntryTransfromer extends Transformer {
/** /**
* Include these attributes to payment receive entry object. * Include these attributes to payment receive entry object.
* @returns {Array} * @returns {Array}

View File

@@ -4,7 +4,7 @@ import { Knex } from 'knex';
import Ledger from '@/services/Accounting/Ledger'; import Ledger from '@/services/Accounting/Ledger';
import TenancyService from '@/services/Tenancy/TenancyService'; import TenancyService from '@/services/Tenancy/TenancyService';
import { import {
IPaymentReceive, IPaymentReceived,
ILedgerEntry, ILedgerEntry,
AccountNormal, AccountNormal,
IPaymentReceiveGLCommonEntry, IPaymentReceiveGLCommonEntry,
@@ -13,7 +13,7 @@ import LedgerStorageService from '@/services/Accounting/LedgerStorageService';
import { TenantMetadata } from '@/system/models'; import { TenantMetadata } from '@/system/models';
@Service() @Service()
export class PaymentReceiveGLEntries { export class PaymentReceivedGLEntries {
@Inject() @Inject()
private tenancy: TenancyService; private tenancy: TenancyService;
@@ -93,14 +93,14 @@ export class PaymentReceiveGLEntries {
/** /**
* Retrieves the payment receive general ledger. * Retrieves the payment receive general ledger.
* @param {number} tenantId - * @param {number} tenantId -
* @param {IPaymentReceive} paymentReceive - * @param {IPaymentReceived} paymentReceive -
* @param {string} baseCurrencyCode - * @param {string} baseCurrencyCode -
* @param {Knex.Transaction} trx - * @param {Knex.Transaction} trx -
* @returns {Ledger} * @returns {Ledger}
*/ */
public getPaymentReceiveGLedger = async ( public getPaymentReceiveGLedger = async (
tenantId: number, tenantId: number,
paymentReceive: IPaymentReceive, paymentReceive: IPaymentReceived,
baseCurrencyCode: string, baseCurrencyCode: string,
trx?: Knex.Transaction trx?: Knex.Transaction
): Promise<Ledger> => { ): Promise<Ledger> => {
@@ -132,7 +132,7 @@ export class PaymentReceiveGLEntries {
* @returns {number} * @returns {number}
*/ */
private getPaymentExGainOrLoss = ( private getPaymentExGainOrLoss = (
paymentReceive: IPaymentReceive paymentReceive: IPaymentReceived
): number => { ): number => {
return sumBy(paymentReceive.entries, (entry) => { return sumBy(paymentReceive.entries, (entry) => {
const paymentLocalAmount = const paymentLocalAmount =
@@ -145,11 +145,11 @@ export class PaymentReceiveGLEntries {
/** /**
* Retrieves the common entry of payment receive. * Retrieves the common entry of payment receive.
* @param {IPaymentReceive} paymentReceive * @param {IPaymentReceived} paymentReceive
* @returns {} * @returns {}
*/ */
private getPaymentReceiveCommonEntry = ( private getPaymentReceiveCommonEntry = (
paymentReceive: IPaymentReceive paymentReceive: IPaymentReceived
): IPaymentReceiveGLCommonEntry => { ): IPaymentReceiveGLCommonEntry => {
return { return {
debit: 0, debit: 0,
@@ -174,14 +174,14 @@ export class PaymentReceiveGLEntries {
/** /**
* Retrieves the payment exchange gain/loss entry. * Retrieves the payment exchange gain/loss entry.
* @param {IPaymentReceive} paymentReceive - * @param {IPaymentReceived} paymentReceive -
* @param {number} ARAccountId - * @param {number} ARAccountId -
* @param {number} exchangeGainOrLossAccountId - * @param {number} exchangeGainOrLossAccountId -
* @param {string} baseCurrencyCode - * @param {string} baseCurrencyCode -
* @returns {ILedgerEntry[]} * @returns {ILedgerEntry[]}
*/ */
private getPaymentExchangeGainLossEntry = ( private getPaymentExchangeGainLossEntry = (
paymentReceive: IPaymentReceive, paymentReceive: IPaymentReceived,
ARAccountId: number, ARAccountId: number,
exchangeGainOrLossAccountId: number, exchangeGainOrLossAccountId: number,
baseCurrencyCode: string baseCurrencyCode: string
@@ -219,11 +219,11 @@ export class PaymentReceiveGLEntries {
/** /**
* Retrieves the payment deposit GL entry. * Retrieves the payment deposit GL entry.
* @param {IPaymentReceive} paymentReceive * @param {IPaymentReceived} paymentReceive
* @returns {ILedgerEntry} * @returns {ILedgerEntry}
*/ */
private getPaymentDepositGLEntry = ( private getPaymentDepositGLEntry = (
paymentReceive: IPaymentReceive paymentReceive: IPaymentReceived
): ILedgerEntry => { ): ILedgerEntry => {
const commonJournal = this.getPaymentReceiveCommonEntry(paymentReceive); const commonJournal = this.getPaymentReceiveCommonEntry(paymentReceive);
@@ -238,12 +238,12 @@ export class PaymentReceiveGLEntries {
/** /**
* Retrieves the payment receivable entry. * Retrieves the payment receivable entry.
* @param {IPaymentReceive} paymentReceive * @param {IPaymentReceived} paymentReceive
* @param {number} ARAccountId * @param {number} ARAccountId
* @returns {ILedgerEntry} * @returns {ILedgerEntry}
*/ */
private getPaymentReceivableEntry = ( private getPaymentReceivableEntry = (
paymentReceive: IPaymentReceive, paymentReceive: IPaymentReceived,
ARAccountId: number ARAccountId: number
): ILedgerEntry => { ): ILedgerEntry => {
const commonJournal = this.getPaymentReceiveCommonEntry(paymentReceive); const commonJournal = this.getPaymentReceiveCommonEntry(paymentReceive);
@@ -267,14 +267,14 @@ export class PaymentReceiveGLEntries {
* - Payment account [current asset] -> Credit * - Payment account [current asset] -> Credit
* *
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceive} paymentRecieve - Payment receive model. * @param {IPaymentReceived} paymentRecieve - Payment receive model.
* @param {number} ARAccountId - A/R account id. * @param {number} ARAccountId - A/R account id.
* @param {number} exGainOrLossAccountId - Exchange gain/loss account id. * @param {number} exGainOrLossAccountId - Exchange gain/loss account id.
* @param {string} baseCurrency - Base currency code. * @param {string} baseCurrency - Base currency code.
* @returns {Promise<ILedgerEntry>} * @returns {Promise<ILedgerEntry>}
*/ */
public getPaymentReceiveGLEntries = ( public getPaymentReceiveGLEntries = (
paymentReceive: IPaymentReceive, paymentReceive: IPaymentReceived,
ARAccountId: number, ARAccountId: number,
exGainOrLossAccountId: number, exGainOrLossAccountId: number,
baseCurrency: string baseCurrency: string

View File

@@ -2,7 +2,7 @@ import { Inject, Service } from 'typedi';
import AutoIncrementOrdersService from '../AutoIncrementOrdersService'; import AutoIncrementOrdersService from '../AutoIncrementOrdersService';
@Service() @Service()
export class PaymentReceiveIncrement { export class PaymentReceivedIncrement {
@Inject() @Inject()
private autoIncrementOrdersService: AutoIncrementOrdersService; private autoIncrementOrdersService: AutoIncrementOrdersService;

View File

@@ -1,11 +1,11 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { IPaymentReceiveEntryDTO } from '@/interfaces'; import { IPaymentReceivedEntryDTO } from '@/interfaces';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import { entriesAmountDiff } from '@/utils'; import { entriesAmountDiff } from '@/utils';
@Service() @Service()
export class PaymentReceiveInvoiceSync { export class PaymentReceivedInvoiceSync {
@Inject() @Inject()
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@@ -19,8 +19,8 @@ export class PaymentReceiveInvoiceSync {
*/ */
public async saveChangeInvoicePaymentAmount( public async saveChangeInvoicePaymentAmount(
tenantId: number, tenantId: number,
newPaymentReceiveEntries: IPaymentReceiveEntryDTO[], newPaymentReceiveEntries: IPaymentReceivedEntryDTO[],
oldPaymentReceiveEntries?: IPaymentReceiveEntryDTO[], oldPaymentReceiveEntries?: IPaymentReceivedEntryDTO[],
trx?: Knex.Transaction trx?: Knex.Transaction
): Promise<void> { ): Promise<void> {
const { SaleInvoice } = this.tenancy.models(tenantId); const { SaleInvoice } = this.tenancy.models(tenantId);

View File

@@ -11,7 +11,7 @@ import {
DEFAULT_PAYMENT_MAIL_CONTENT, DEFAULT_PAYMENT_MAIL_CONTENT,
DEFAULT_PAYMENT_MAIL_SUBJECT, DEFAULT_PAYMENT_MAIL_SUBJECT,
} from './constants'; } from './constants';
import { GetPaymentReceive } from './GetPaymentReceive'; import { GetPaymentReceived } from './GetPaymentReceived';
import { ContactMailNotification } from '@/services/MailNotification/ContactMailNotification'; import { ContactMailNotification } from '@/services/MailNotification/ContactMailNotification';
import { parseAndValidateMailOptions } from '@/services/MailNotification/utils'; import { parseAndValidateMailOptions } from '@/services/MailNotification/utils';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
@@ -23,7 +23,7 @@ export class SendPaymentReceiveMailNotification {
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@Inject() @Inject()
private getPaymentService: GetPaymentReceive; private getPaymentService: GetPaymentReceived;
@Inject() @Inject()
private contactMailNotification: ContactMailNotification; private contactMailNotification: ContactMailNotification;

View File

@@ -1,8 +1,8 @@
import Container, { Service } from 'typedi'; import Container, { Service } from 'typedi';
import { SendPaymentReceiveMailNotification } from './PaymentReceiveMailNotification'; import { SendPaymentReceiveMailNotification } from './PaymentReceivedMailNotification';
@Service() @Service()
export class PaymentReceiveMailNotificationJob { export class PaymentReceivedMailNotificationJob {
/** /**
* Constructor method. * Constructor method.
*/ */

View File

@@ -2,17 +2,17 @@ import { Service, Inject } from 'typedi';
import HasTenancyService from '@/services/Tenancy/TenancyService'; import HasTenancyService from '@/services/Tenancy/TenancyService';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { import {
IPaymentReceiveSmsDetails, IPaymentReceivedSmsDetails,
SMS_NOTIFICATION_KEY, SMS_NOTIFICATION_KEY,
IPaymentReceive, IPaymentReceived,
IPaymentReceiveEntry, IPaymentReceivedEntry,
} from '@/interfaces'; } from '@/interfaces';
import SmsNotificationsSettingsService from '@/services/Settings/SmsNotificationsSettings'; import SmsNotificationsSettingsService from '@/services/Settings/SmsNotificationsSettings';
import { formatNumber, formatSmsMessage } from 'utils'; import { formatNumber, formatSmsMessage } from 'utils';
import { TenantMetadata } from '@/system/models'; import { TenantMetadata } from '@/system/models';
import SaleNotifyBySms from '../SaleNotifyBySms'; import SaleNotifyBySms from '../SaleNotifyBySms';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import { PaymentReceiveValidators } from './PaymentReceiveValidators'; import { PaymentReceivedValidators } from './PaymentReceivedValidators';
@Service() @Service()
export class PaymentReceiveNotifyBySms { export class PaymentReceiveNotifyBySms {
@@ -29,7 +29,7 @@ export class PaymentReceiveNotifyBySms {
private saleSmsNotification: SaleNotifyBySms; private saleSmsNotification: SaleNotifyBySms;
@Inject() @Inject()
private validators: PaymentReceiveValidators; private validators: PaymentReceivedValidators;
/** /**
* Notify customer via sms about payment receive details. * Notify customer via sms about payment receive details.
@@ -71,12 +71,12 @@ export class PaymentReceiveNotifyBySms {
/** /**
* Sends the payment details sms notification of the given customer. * Sends the payment details sms notification of the given customer.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceive} paymentReceive * @param {IPaymentReceived} paymentReceive
* @param {ICustomer} customer * @param {ICustomer} customer
*/ */
private sendSmsNotification = async ( private sendSmsNotification = async (
tenantId: number, tenantId: number,
paymentReceive: IPaymentReceive paymentReceive: IPaymentReceived
) => { ) => {
const smsClient = this.tenancy.smsClient(tenantId); const smsClient = this.tenancy.smsClient(tenantId);
const tenantMetadata = await TenantMetadata.query().findOne({ tenantId }); const tenantMetadata = await TenantMetadata.query().findOne({ tenantId });
@@ -116,12 +116,12 @@ export class PaymentReceiveNotifyBySms {
/** /**
* Formates the payment receive details sms message. * Formates the payment receive details sms message.
* @param {number} tenantId - * @param {number} tenantId -
* @param {IPaymentReceive} payment - * @param {IPaymentReceived} payment -
* @param {ICustomer} customer - * @param {ICustomer} customer -
*/ */
private formattedPaymentDetailsMessage = ( private formattedPaymentDetailsMessage = (
tenantId: number, tenantId: number,
payment: IPaymentReceive, payment: IPaymentReceived,
tenantMetadata: TenantMetadata tenantMetadata: TenantMetadata
) => { ) => {
const notification = this.smsNotificationsSettings.getSmsNotificationMeta( const notification = this.smsNotificationsSettings.getSmsNotificationMeta(
@@ -138,14 +138,14 @@ export class PaymentReceiveNotifyBySms {
/** /**
* Formattes the payment details sms notification messafge. * Formattes the payment details sms notification messafge.
* @param {string} smsMessage * @param {string} smsMessage
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @param {ICustomer} customer * @param {ICustomer} customer
* @param {TenantMetadata} tenantMetadata * @param {TenantMetadata} tenantMetadata
* @returns {string} * @returns {string}
*/ */
private formatPaymentDetailsMessage = ( private formatPaymentDetailsMessage = (
smsMessage: string, smsMessage: string,
payment: IPaymentReceive, payment: IPaymentReceived,
tenantMetadata: any tenantMetadata: any
): string => { ): string => {
const invoiceNumbers = this.stringifyPaymentInvoicesNumber(payment); const invoiceNumbers = this.stringifyPaymentInvoicesNumber(payment);
@@ -167,12 +167,12 @@ export class PaymentReceiveNotifyBySms {
/** /**
* Stringify payment receive invoices to numbers as string. * Stringify payment receive invoices to numbers as string.
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @returns {string} * @returns {string}
*/ */
private stringifyPaymentInvoicesNumber(payment: IPaymentReceive) { private stringifyPaymentInvoicesNumber(payment: IPaymentReceived) {
const invoicesNumberes = payment.entries.map( const invoicesNumberes = payment.entries.map(
(entry: IPaymentReceiveEntry) => entry.invoice.invoiceNo (entry: IPaymentReceivedEntry) => entry.invoice.invoiceNo
); );
return invoicesNumberes.join(', '); return invoicesNumberes.join(', ');
} }
@@ -185,7 +185,7 @@ export class PaymentReceiveNotifyBySms {
public smsDetails = async ( public smsDetails = async (
tenantId: number, tenantId: number,
paymentReceiveid: number paymentReceiveid: number
): Promise<IPaymentReceiveSmsDetails> => { ): Promise<IPaymentReceivedSmsDetails> => {
const { PaymentReceive } = this.tenancy.models(tenantId); const { PaymentReceive } = this.tenancy.models(tenantId);
// Retrieve the payment receive or throw not found service error. // Retrieve the payment receive or throw not found service error.

View File

@@ -1,8 +1,7 @@
import { Container } from 'typedi'; import { Container } from 'typedi';
import { On, EventSubscriber } from 'event-dispatch'; import { On, EventSubscriber } from 'event-dispatch';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import SaleReceiptNotifyBySms from '@/services/Sales/SaleReceiptNotifyBySms'; import { PaymentReceiveNotifyBySms } from './PaymentReceivedSmsNotify';
import PaymentReceiveNotifyBySms from './PaymentReceiveSmsNotify';
@EventSubscriber() @EventSubscriber()
export default class SendSmsNotificationPaymentReceive { export default class SendSmsNotificationPaymentReceive {

View File

@@ -1,7 +1,7 @@
import { IPaymentReceive, IPaymentReceiveEntry } from '@/interfaces'; import { IPaymentReceived, IPaymentReceivedEntry } from '@/interfaces';
import { Transformer } from '@/lib/Transformer/Transformer'; import { Transformer } from '@/lib/Transformer/Transformer';
import { formatNumber } from 'utils'; import { formatNumber } from 'utils';
import { PaymentReceiveEntryTransfromer } from './PaymentReceiveEntryTransformer'; import { PaymentReceivedEntryTransfromer } from './PaymentReceivedEntryTransformer';
export class PaymentReceiveTransfromer extends Transformer { export class PaymentReceiveTransfromer extends Transformer {
/** /**
@@ -24,25 +24,25 @@ export class PaymentReceiveTransfromer extends Transformer {
* @param {ISaleInvoice} invoice * @param {ISaleInvoice} invoice
* @returns {String} * @returns {String}
*/ */
protected formattedPaymentDate = (payment: IPaymentReceive): string => { protected formattedPaymentDate = (payment: IPaymentReceived): string => {
return this.formatDate(payment.paymentDate); return this.formatDate(payment.paymentDate);
}; };
/** /**
* Retrieves the formatted created at date. * Retrieves the formatted created at date.
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @returns {string} * @returns {string}
*/ */
protected formattedCreatedAt = (payment: IPaymentReceive): string => { protected formattedCreatedAt = (payment: IPaymentReceived): string => {
return this.formatDate(payment.createdAt); return this.formatDate(payment.createdAt);
}; };
/** /**
* Retrieve the formatted payment subtotal. * Retrieve the formatted payment subtotal.
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @returns {string} * @returns {string}
*/ */
protected subtotalFormatted = (payment: IPaymentReceive): string => { protected subtotalFormatted = (payment: IPaymentReceived): string => {
return formatNumber(payment.amount, { return formatNumber(payment.amount, {
currencyCode: payment.currencyCode, currencyCode: payment.currencyCode,
money: false, money: false,
@@ -54,25 +54,25 @@ export class PaymentReceiveTransfromer extends Transformer {
* @param {ISaleInvoice} invoice * @param {ISaleInvoice} invoice
* @returns {string} * @returns {string}
*/ */
protected formattedAmount = (payment: IPaymentReceive): string => { protected formattedAmount = (payment: IPaymentReceived): string => {
return formatNumber(payment.amount, { currencyCode: payment.currencyCode }); return formatNumber(payment.amount, { currencyCode: payment.currencyCode });
}; };
/** /**
* Retrieve the formatted exchange rate. * Retrieve the formatted exchange rate.
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @returns {string} * @returns {string}
*/ */
protected formattedExchangeRate = (payment: IPaymentReceive): string => { protected formattedExchangeRate = (payment: IPaymentReceived): string => {
return formatNumber(payment.exchangeRate, { money: false }); return formatNumber(payment.exchangeRate, { money: false });
}; };
/** /**
* Retrieves the payment entries. * Retrieves the payment entries.
* @param {IPaymentReceive} payment * @param {IPaymentReceived} payment
* @returns {IPaymentReceiveEntry[]} * @returns {IPaymentReceivedEntry[]}
*/ */
protected entries = (payment: IPaymentReceive): IPaymentReceiveEntry[] => { protected entries = (payment: IPaymentReceived): IPaymentReceivedEntry[] => {
return this.item(payment.entries, new PaymentReceiveEntryTransfromer()); return this.item(payment.entries, new PaymentReceivedEntryTransfromer());
}; };
} }

View File

@@ -2,10 +2,10 @@ import { Inject, Service } from 'typedi';
import { difference, sumBy } from 'lodash'; import { difference, sumBy } from 'lodash';
import { import {
IAccount, IAccount,
IPaymentReceive, IPaymentReceived,
IPaymentReceiveEditDTO, IPaymentReceivedEditDTO,
IPaymentReceiveEntry, IPaymentReceivedEntry,
IPaymentReceiveEntryDTO, IPaymentReceivedEntryDTO,
ISaleInvoice, ISaleInvoice,
} from '@/interfaces'; } from '@/interfaces';
import { ServiceError } from '@/exceptions'; import { ServiceError } from '@/exceptions';
@@ -15,7 +15,7 @@ import { ACCOUNT_TYPE } from '@/data/AccountTypes';
import { PaymentReceive } from '@/models'; import { PaymentReceive } from '@/models';
@Service() @Service()
export class PaymentReceiveValidators { export class PaymentReceivedValidators {
@Inject() @Inject()
private tenancy: HasTenancyService; private tenancy: HasTenancyService;
@@ -58,7 +58,7 @@ export class PaymentReceiveValidators {
* Validates the invoices IDs existance. * Validates the invoices IDs existance.
* @param {number} tenantId - * @param {number} tenantId -
* @param {number} customerId - * @param {number} customerId -
* @param {IPaymentReceiveEntryDTO[]} paymentReceiveEntries - * @param {IPaymentReceivedEntryDTO[]} paymentReceiveEntries -
*/ */
public async validateInvoicesIDsExistance( public async validateInvoicesIDsExistance(
tenantId: number, tenantId: number,
@@ -100,12 +100,12 @@ export class PaymentReceiveValidators {
*/ */
public async validateInvoicesPaymentsAmount( public async validateInvoicesPaymentsAmount(
tenantId: number, tenantId: number,
paymentReceiveEntries: IPaymentReceiveEntryDTO[], paymentReceiveEntries: IPaymentReceivedEntryDTO[],
oldPaymentEntries: IPaymentReceiveEntry[] = [] oldPaymentEntries: IPaymentReceivedEntry[] = []
) { ) {
const { SaleInvoice } = this.tenancy.models(tenantId); const { SaleInvoice } = this.tenancy.models(tenantId);
const invoicesIds = paymentReceiveEntries.map( const invoicesIds = paymentReceiveEntries.map(
(e: IPaymentReceiveEntryDTO) => e.invoiceId (e: IPaymentReceivedEntryDTO) => e.invoiceId
); );
const storedInvoices = await SaleInvoice.query().whereIn('id', invoicesIds); const storedInvoices = await SaleInvoice.query().whereIn('id', invoicesIds);
@@ -124,7 +124,7 @@ export class PaymentReceiveValidators {
const hasWrongPaymentAmount: any[] = []; const hasWrongPaymentAmount: any[] = [];
paymentReceiveEntries.forEach( paymentReceiveEntries.forEach(
(entry: IPaymentReceiveEntryDTO, index: number) => { (entry: IPaymentReceivedEntryDTO, index: number) => {
const entryInvoice = storedInvoicesMap.get(entry.invoiceId); const entryInvoice = storedInvoicesMap.get(entry.invoiceId);
const { dueAmount } = entryInvoice; const { dueAmount } = entryInvoice;
@@ -140,9 +140,9 @@ export class PaymentReceiveValidators {
/** /**
* Validate the payment receive number require. * Validate the payment receive number require.
* @param {IPaymentReceive} paymentReceiveObj * @param {IPaymentReceived} paymentReceiveObj
*/ */
public validatePaymentReceiveNoRequire(paymentReceiveObj: IPaymentReceive) { public validatePaymentReceiveNoRequire(paymentReceiveObj: IPaymentReceived) {
if (!paymentReceiveObj.paymentReceiveNo) { if (!paymentReceiveObj.paymentReceiveNo) {
throw new ServiceError(ERRORS.PAYMENT_RECEIVE_NO_IS_REQUIRED); throw new ServiceError(ERRORS.PAYMENT_RECEIVE_NO_IS_REQUIRED);
} }
@@ -152,12 +152,12 @@ export class PaymentReceiveValidators {
* Validate the payment receive entries IDs existance. * Validate the payment receive entries IDs existance.
* @param {number} tenantId * @param {number} tenantId
* @param {number} paymentReceiveId * @param {number} paymentReceiveId
* @param {IPaymentReceiveEntryDTO[]} paymentReceiveEntries * @param {IPaymentReceivedEntryDTO[]} paymentReceiveEntries
*/ */
public async validateEntriesIdsExistance( public async validateEntriesIdsExistance(
tenantId: number, tenantId: number,
paymentReceiveId: number, paymentReceiveId: number,
paymentReceiveEntries: IPaymentReceiveEntryDTO[] paymentReceiveEntries: IPaymentReceivedEntryDTO[]
) { ) {
const { PaymentReceiveEntry } = this.tenancy.models(tenantId); const { PaymentReceiveEntry } = this.tenancy.models(tenantId);
@@ -189,12 +189,12 @@ export class PaymentReceiveValidators {
/** /**
* Validate the payment customer whether modified. * Validate the payment customer whether modified.
* @param {IPaymentReceiveEditDTO} paymentReceiveDTO * @param {IPaymentReceivedEditDTO} paymentReceiveDTO
* @param {IPaymentReceive} oldPaymentReceive * @param {IPaymentReceived} oldPaymentReceive
*/ */
public validateCustomerNotModified( public validateCustomerNotModified(
paymentReceiveDTO: IPaymentReceiveEditDTO, paymentReceiveDTO: IPaymentReceivedEditDTO,
oldPaymentReceive: IPaymentReceive oldPaymentReceive: IPaymentReceived
) { ) {
if (paymentReceiveDTO.customerId !== oldPaymentReceive.customerId) { if (paymentReceiveDTO.customerId !== oldPaymentReceive.customerId) {
throw new ServiceError(ERRORS.PAYMENT_CUSTOMER_SHOULD_NOT_UPDATE); throw new ServiceError(ERRORS.PAYMENT_CUSTOMER_SHOULD_NOT_UPDATE);
@@ -230,7 +230,7 @@ export class PaymentReceiveValidators {
async getPaymentReceiveOrThrowError( async getPaymentReceiveOrThrowError(
tenantId: number, tenantId: number,
paymentReceiveId: number paymentReceiveId: number
): Promise<IPaymentReceive> { ): Promise<IPaymentReceived> {
const { PaymentReceive } = this.tenancy.models(tenantId); const { PaymentReceive } = this.tenancy.models(tenantId);
const paymentReceive = await PaymentReceive.query() const paymentReceive = await PaymentReceive.query()
.withGraphFetched('entries') .withGraphFetched('entries')

View File

@@ -1,7 +1,7 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { IAccountsStructureType, IPaymentReceivesFilter } from '@/interfaces'; import { IAccountsStructureType, IPaymentsReceivedFilter } from '@/interfaces';
import { Exportable } from '@/services/Export/Exportable'; import { Exportable } from '@/services/Export/Exportable';
import { PaymentReceivesApplication } from './PaymentReceivesApplication'; import { PaymentReceivesApplication } from './PaymentReceivedApplication';
@Service() @Service()
export class PaymentsReceivedExportable extends Exportable { export class PaymentsReceivedExportable extends Exportable {
@@ -11,17 +11,17 @@ export class PaymentsReceivedExportable extends Exportable {
/** /**
* Retrieves the accounts data to exportable sheet. * Retrieves the accounts data to exportable sheet.
* @param {number} tenantId * @param {number} tenantId
* @param {IPaymentReceivesFilter} query - * @param {IPaymentsReceivedFilter} query -
* @returns * @returns
*/ */
public exportable(tenantId: number, query: IPaymentReceivesFilter) { public exportable(tenantId: number, query: IPaymentsReceivedFilter) {
const parsedQuery = { const parsedQuery = {
sortOrder: 'desc', sortOrder: 'desc',
columnSortBy: 'created_at', columnSortBy: 'created_at',
inactiveMode: false, inactiveMode: false,
...query, ...query,
structure: IAccountsStructureType.Flat, structure: IAccountsStructureType.Flat,
} as IPaymentReceivesFilter; } as IPaymentsReceivedFilter;
return this.paymentReceivedApp return this.paymentReceivedApp
.getPaymentReceives(tenantId, parsedQuery) .getPaymentReceives(tenantId, parsedQuery)

View File

@@ -1,14 +1,14 @@
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { IPaymentReceiveCreateDTO } from '@/interfaces'; import { IPaymentReceivedCreateDTO } from '@/interfaces';
import { Importable } from '@/services/Import/Importable'; import { Importable } from '@/services/Import/Importable';
import { CreatePaymentReceive } from './CreatePaymentReceive'; import { CreatePaymentReceived } from './CreatePaymentReceived';
import { PaymentsReceiveSampleData } from './constants'; import { PaymentsReceiveSampleData } from './constants';
@Service() @Service()
export class PaymentReceivesImportable extends Importable { export class PaymentsReceivedImportable extends Importable {
@Inject() @Inject()
private createPaymentReceiveService: CreatePaymentReceive; private createPaymentReceiveService: CreatePaymentReceived;
/** /**
* Importing to account service. * Importing to account service.
@@ -18,10 +18,10 @@ export class PaymentReceivesImportable extends Importable {
*/ */
public importable( public importable(
tenantId: number, tenantId: number,
createPaymentDTO: IPaymentReceiveCreateDTO, createPaymentDTO: IPaymentReceivedCreateDTO,
trx?: Knex.Transaction trx?: Knex.Transaction
) { ) {
return this.createPaymentReceiveService.createPaymentReceive( return this.createPaymentReceiveService.createPaymentReceived(
tenantId, tenantId,
createPaymentDTO, createPaymentDTO,
{}, {},

View File

@@ -3,7 +3,7 @@ import { omit } from 'lodash';
import { import {
ISaleInvoice, ISaleInvoice,
IPaymentReceivePageEntry, IPaymentReceivePageEntry,
IPaymentReceive, IPaymentReceived,
ISystemUser, ISystemUser,
} from '@/interfaces'; } from '@/interfaces';
import TenancyService from '@/services/Tenancy/TenancyService'; import TenancyService from '@/services/Tenancy/TenancyService';
@@ -14,12 +14,9 @@ import { ERRORS } from './constants';
* Payment receives edit/new pages service. * Payment receives edit/new pages service.
*/ */
@Service() @Service()
export default class PaymentReceivesPages { export default class PaymentsReceivedPages {
@Inject() @Inject()
tenancy: TenancyService; private tenancy: TenancyService;
@Inject('logger')
logger: any;
/** /**
* Retrive page invoices entries from the given sale invoices models. * Retrive page invoices entries from the given sale invoices models.
@@ -68,7 +65,7 @@ export default class PaymentReceivesPages {
tenantId: number, tenantId: number,
paymentReceiveId: number paymentReceiveId: number
): Promise<{ ): Promise<{
paymentReceive: Omit<IPaymentReceive, 'entries'>; paymentReceive: Omit<IPaymentReceived, 'entries'>;
entries: IPaymentReceivePageEntry[]; entries: IPaymentReceivePageEntry[];
}> { }> {
const { PaymentReceive, SaleInvoice } = this.tenancy.models(tenantId); const { PaymentReceive, SaleInvoice } = this.tenancy.models(tenantId);

View File

@@ -1,9 +1,10 @@
import { ServiceError } from '@/exceptions'; import { Knex } from 'knex';
import { Inject, Service } from 'typedi'; import { Inject, Service } from 'typedi';
import { difference } from 'lodash';
import { ServiceError } from '@/exceptions';
import HasTenancyService from '../Tenancy/TenancyService'; import HasTenancyService from '../Tenancy/TenancyService';
import { IItemEntryDTO, ITaxRate } from '@/interfaces'; import { IItemEntryDTO, ITaxRate } from '@/interfaces';
import { ERRORS } from './constants'; import { ERRORS } from './constants';
import { difference } from 'lodash';
@Service() @Service()
export class CommandTaxRatesValidators { export class CommandTaxRatesValidators {
@@ -44,11 +45,16 @@ export class CommandTaxRatesValidators {
* Validates the tax code uniquiness. * Validates the tax code uniquiness.
* @param {number} tenantId * @param {number} tenantId
* @param {string} taxCode * @param {string} taxCode
* @param {Knex.Transaction} trx -
*/ */
public async validateTaxCodeUnique(tenantId: number, taxCode: string) { public async validateTaxCodeUnique(
tenantId: number,
taxCode: string,
trx?: Knex.Transaction
) {
const { TaxRate } = this.tenancy.models(tenantId); const { TaxRate } = this.tenancy.models(tenantId);
const foundTaxCode = await TaxRate.query().findOne({ code: taxCode }); const foundTaxCode = await TaxRate.query(trx).findOne({ code: taxCode });
if (foundTaxCode) { if (foundTaxCode) {
throw new ServiceError(ERRORS.TAX_CODE_NOT_UNIQUE); throw new ServiceError(ERRORS.TAX_CODE_NOT_UNIQUE);

View File

@@ -1,3 +1,4 @@
import { Inject, Service } from 'typedi';
import { Knex } from 'knex'; import { Knex } from 'knex';
import { import {
ICreateTaxRateDTO, ICreateTaxRateDTO,
@@ -7,7 +8,6 @@ import {
import UnitOfWork from '../UnitOfWork'; import UnitOfWork from '../UnitOfWork';
import { EventPublisher } from '@/lib/EventPublisher/EventPublisher'; import { EventPublisher } from '@/lib/EventPublisher/EventPublisher';
import HasTenancyService from '../Tenancy/TenancyService'; import HasTenancyService from '../Tenancy/TenancyService';
import { Inject, Service } from 'typedi';
import events from '@/subscribers/events'; import events from '@/subscribers/events';
import { CommandTaxRatesValidators } from './CommandTaxRatesValidators'; import { CommandTaxRatesValidators } from './CommandTaxRatesValidators';
@@ -32,36 +32,41 @@ export class CreateTaxRate {
*/ */
public async createTaxRate( public async createTaxRate(
tenantId: number, tenantId: number,
createTaxRateDTO: ICreateTaxRateDTO createTaxRateDTO: ICreateTaxRateDTO,
trx?: Knex.Transaction
) { ) {
const { TaxRate } = this.tenancy.models(tenantId); const { TaxRate } = this.tenancy.models(tenantId);
// Validates the tax code uniquiness. // Validates the tax code uniquiness.
await this.validators.validateTaxCodeUnique( await this.validators.validateTaxCodeUnique(
tenantId, tenantId,
createTaxRateDTO.code createTaxRateDTO.code,
trx
); );
return this.uow.withTransaction(tenantId, async (trx: Knex.Transaction) => { return this.uow.withTransaction(
// Triggers `onTaxRateCreating` event. tenantId,
await this.eventPublisher.emitAsync(events.taxRates.onCreating, { async (trx: Knex.Transaction) => {
createTaxRateDTO, // Triggers `onTaxRateCreating` event.
tenantId, await this.eventPublisher.emitAsync(events.taxRates.onCreating, {
trx, createTaxRateDTO,
} as ITaxRateCreatingPayload); tenantId,
trx,
} as ITaxRateCreatingPayload);
const taxRate = await TaxRate.query(trx).insertAndFetch({ const taxRate = await TaxRate.query(trx).insertAndFetch({
...createTaxRateDTO, ...createTaxRateDTO,
}); });
// Triggers `onTaxRateCreated` event.
await this.eventPublisher.emitAsync(events.taxRates.onCreated, {
createTaxRateDTO,
taxRate,
tenantId,
trx,
} as ITaxRateCreatedPayload);
// Triggers `onTaxRateCreated` event. return taxRate;
await this.eventPublisher.emitAsync(events.taxRates.onCreated, { },
createTaxRateDTO, trx
taxRate, );
tenantId,
trx,
} as ITaxRateCreatedPayload);
return taxRate;
});
} }
} }

View File

@@ -0,0 +1,18 @@
import { Inject, Service } from 'typedi';
import { Exportable } from '../Export/Exportable';
import { TaxRatesApplication } from './TaxRatesApplication';
@Service()
export class TaxRatesExportable extends Exportable {
@Inject()
private taxRatesApplication: TaxRatesApplication;
/**
* Retrieves the accounts data to exportable sheet.
* @param {number} tenantId
* @returns
*/
public exportable(tenantId: number) {
return this.taxRatesApplication.getTaxRates(tenantId);
}
}

View File

@@ -0,0 +1,18 @@
export const TaxRatesSampleData = [
{
'Tax Name': 'Value Added Tax',
Code: 'VAT-STD',
Rate: '20',
Description: 'Standard VAT rate applied to most goods and services.',
'Is Non Recoverable': 'F',
Active: 'T',
},
{
'Tax Name': 'Luxury Goods Tax',
Code: 'TAX-LUXURY',
Rate: '25',
Description: 'Tax imposed on the sale of luxury items.',
'Is Non Recoverable': 'T',
Active: 'T',
},
];

View File

@@ -0,0 +1,46 @@
import { Inject, Service } from 'typedi';
import { Knex } from 'knex';
import { ICreateTaxRateDTO } from '@/interfaces';
import { CreateTaxRate } from './CreateTaxRate';
import { Importable } from '../Import/Importable';
import { TaxRatesSampleData } from './TaxRatesImportable.SampleData';
@Service()
export class TaxRatesImportable extends Importable {
@Inject()
private createTaxRateService: CreateTaxRate;
/**
* Importing to tax rate creating service.
* @param {number} tenantId -
* @param {ICreateTaxRateDTO} ICreateTaxRateDTO -
* @param {Knex.Transaction} trx -
* @returns
*/
public importable(
tenantId: number,
createAccountDTO: ICreateTaxRateDTO,
trx?: Knex.Transaction
) {
return this.createTaxRateService.createTaxRate(
tenantId,
createAccountDTO,
trx
);
}
/**
* Concurrrency controlling of the importing process.
* @returns {number}
*/
public get concurrency() {
return 1;
}
/**
* Retrieves the sample data that used to download accounts sample sheet.
*/
public sampleData(): any[] {
return TaxRatesSampleData;
}
}

View File

@@ -18,8 +18,4 @@ export default class HasSystemService implements SystemService {
cache() { cache() {
return this.container('cache'); return this.container('cache');
} }
dbManager() {
return this.container('dbManager');
}
} }

View File

@@ -1,18 +1,16 @@
import { Container } from 'typedi'; import { Container } from 'typedi';
import Knex from 'knex'; import { Knex, knex } from 'knex';
import { knexSnakeCaseMappers } from 'objection'; import { knexSnakeCaseMappers } from 'objection';
import { tenantKnexConfig, tenantSeedConfig } from '@/config/knexConfig'; import { tenantKnexConfig, tenantSeedConfig } from '@/config/knexConfig';
import config from '@/config'; import config from '@/config';
import { ITenant, ITenantDBManager } from '@/interfaces'; import { ITenant, ITenantDBManager } from '@/interfaces';
import SystemService from '@/services/Tenancy/SystemService'; import SystemService from '@/services/Tenancy/SystemService';
import { TenantDBAlreadyExists } from '@/exceptions'; import { TenantDBAlreadyExists } from '@/exceptions';
import { sanitizeDatabaseName } from '@/utils/sanitizers';
export default class TenantDBManager implements ITenantDBManager { export default class TenantDBManager implements ITenantDBManager {
static knexCache: { [key: string]: Knex } = {}; static knexCache: { [key: string]: Knex } = {};
// System database manager.
dbManager: any;
// System knex instance. // System knex instance.
sysKnex: Knex; sysKnex: Knex;
@@ -23,7 +21,6 @@ export default class TenantDBManager implements ITenantDBManager {
constructor() { constructor() {
const systemService = Container.get(SystemService); const systemService = Container.get(SystemService);
this.dbManager = systemService.dbManager();
this.sysKnex = systemService.knex(); this.sysKnex = systemService.knex();
} }
@@ -32,7 +29,9 @@ export default class TenantDBManager implements ITenantDBManager {
* @return {string} * @return {string}
*/ */
private getDatabaseName(tenant: ITenant) { private getDatabaseName(tenant: ITenant) {
return `${config.tenant.db_name_prefix}${tenant.organizationId}`; return sanitizeDatabaseName(
`${config.tenant.db_name_prefix}${tenant.organizationId}`
);
} }
/** /**
@@ -59,7 +58,9 @@ export default class TenantDBManager implements ITenantDBManager {
await this.throwErrorIfTenantDBExists(tenant); await this.throwErrorIfTenantDBExists(tenant);
const databaseName = this.getDatabaseName(tenant); const databaseName = this.getDatabaseName(tenant);
await this.dbManager.createDb(databaseName); await this.sysKnex.raw(
`CREATE DATABASE ${databaseName} DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci`
);
} }
/** /**
@@ -72,7 +73,6 @@ export default class TenantDBManager implements ITenantDBManager {
if (!isExists) { if (!isExists) {
return; return;
} }
await this.dropDatabase(tenant); await this.dropDatabase(tenant);
} }
@@ -83,7 +83,7 @@ export default class TenantDBManager implements ITenantDBManager {
public async dropDatabase(tenant: ITenant) { public async dropDatabase(tenant: ITenant) {
const databaseName = this.getDatabaseName(tenant); const databaseName = this.getDatabaseName(tenant);
await this.dbManager.dropDb(databaseName); await this.sysKnex.raw(`DROP DATABASE IF EXISTS ${databaseName}`);
} }
/** /**
@@ -118,7 +118,7 @@ export default class TenantDBManager implements ITenantDBManager {
let knexInstance = TenantDBManager.knexCache[key]; let knexInstance = TenantDBManager.knexCache[key];
if (!knexInstance) { if (!knexInstance) {
knexInstance = Knex({ knexInstance = knex({
...tenantKnexConfig(tenant), ...tenantKnexConfig(tenant),
...knexSnakeCaseMappers({ upperCase: true }), ...knexSnakeCaseMappers({ upperCase: true }),
}); });

View File

@@ -5,9 +5,9 @@ import {
ISaleInvoiceCreatingPaylaod, ISaleInvoiceCreatingPaylaod,
ISaleReceiptDeletingPayload, ISaleReceiptDeletingPayload,
ICreditNoteDeletingPayload, ICreditNoteDeletingPayload,
IPaymentReceiveCreatingPayload, IPaymentReceivedCreatingPayload,
IRefundCreditNoteDeletingPayload, IRefundCreditNoteDeletingPayload,
IPaymentReceiveDeletingPayload, IPaymentReceivedDeletingPayload,
ISaleEstimateDeletingPayload, ISaleEstimateDeletingPayload,
ISaleEstimateCreatingPayload, ISaleEstimateCreatingPayload,
ISaleEstimateEditingPayload, ISaleEstimateEditingPayload,
@@ -17,7 +17,7 @@ import {
ISaleInvoiceWrittenOffCancelPayload, ISaleInvoiceWrittenOffCancelPayload,
ICreditNoteEditingPayload, ICreditNoteEditingPayload,
ISaleReceiptEditingPayload, ISaleReceiptEditingPayload,
IPaymentReceiveEditingPayload, IPaymentReceivedEditingPayload,
ISaleReceiptEventClosingPayload, ISaleReceiptEventClosingPayload,
ICreditNoteCreatingPayload, ICreditNoteCreatingPayload,
} from '@/interfaces'; } from '@/interfaces';
@@ -454,13 +454,13 @@ export default class SalesTransactionLockingGuardSubscriber {
/** /**
* Transaction locking guard on payment receive editing. * Transaction locking guard on payment receive editing.
* @param {IPaymentReceiveEditingPayload} * @param {IPaymentReceivedEditingPayload}
*/ */
private transactionLockingGuardOnPaymentEditing = async ({ private transactionLockingGuardOnPaymentEditing = async ({
tenantId, tenantId,
oldPaymentReceive, oldPaymentReceive,
paymentReceiveDTO, paymentReceiveDTO,
}: IPaymentReceiveEditingPayload) => { }: IPaymentReceivedEditingPayload) => {
// Validate the old payment date. // Validate the old payment date.
await this.salesLockingGuard.transactionLockingGuard( await this.salesLockingGuard.transactionLockingGuard(
tenantId, tenantId,
@@ -475,12 +475,12 @@ export default class SalesTransactionLockingGuardSubscriber {
/** /**
* Transaction locking guard on payment creating. * Transaction locking guard on payment creating.
* @param {IPaymentReceiveCreatingPayload} * @param {IPaymentReceivedCreatingPayload}
*/ */
private transactionLockingGuardOnPaymentCreating = async ({ private transactionLockingGuardOnPaymentCreating = async ({
tenantId, tenantId,
paymentReceiveDTO, paymentReceiveDTO,
}: IPaymentReceiveCreatingPayload) => { }: IPaymentReceivedCreatingPayload) => {
await this.salesLockingGuard.transactionLockingGuard( await this.salesLockingGuard.transactionLockingGuard(
tenantId, tenantId,
paymentReceiveDTO.paymentDate paymentReceiveDTO.paymentDate
@@ -489,12 +489,12 @@ export default class SalesTransactionLockingGuardSubscriber {
/** /**
* Transaction locking guard on payment deleting. * Transaction locking guard on payment deleting.
* @param {IPaymentReceiveDeletingPayload} payload - * @param {IPaymentReceivedDeletingPayload} payload -
*/ */
private transactionLockingGuardPaymentDeleting = async ({ private transactionLockingGuardPaymentDeleting = async ({
oldPaymentReceive, oldPaymentReceive,
tenantId, tenantId,
}: IPaymentReceiveDeletingPayload) => { }: IPaymentReceivedDeletingPayload) => {
await this.salesLockingGuard.transactionLockingGuard( await this.salesLockingGuard.transactionLockingGuard(
tenantId, tenantId,
oldPaymentReceive.paymentDate oldPaymentReceive.paymentDate

Some files were not shown because too many files have changed in this diff Show More