mirror of
https://github.com/apache/superset.git
synced 2026-05-12 19:35:17 +00:00
fix(SQL Editor): names new query tabs correctly (#18951)
* Added in code changes that now properly increment the Untitled Query SQL Lab tab names. All that is left is to add tests to make sure that the function works correctly
* Updated the code so that it adds to the untitled_query_numbers variable only if the character after the string 'Untitled Query ' is a number. This prevents any issues when trying to get the maximum value in the list.
* Refactored part of the mapping code, to make it shorter and easier to read/understand
* Fixed issues in the code that were causing some of the CI tests to fail
* Made code changes based on comments within the PR. Also added a unit test to make sure that the newQueryEditor function in the TabbedSqlEditors component works as intended
* Fixed the failing cypress test in tabs.test.js
(cherry picked from commit 5a5ff99c37)
This commit is contained in:
committed by
Ville Brofeldt
parent
ea534e2386
commit
00a53dae73
@@ -180,7 +180,7 @@ export const defaultQueryEditor = {
|
||||
latestQueryId: null,
|
||||
selectedText: null,
|
||||
sql: 'SELECT *\nFROM\nWHERE',
|
||||
title: 'Untitled Query',
|
||||
title: 'Untitled Query 1',
|
||||
schemaOptions: [
|
||||
{
|
||||
value: 'main',
|
||||
|
||||
Reference in New Issue
Block a user