fix: Popovers in Explore not attached to the fields they are triggered by (#19139)

* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
This commit is contained in:
Diego Medina
2022-03-16 22:46:52 -04:00
committed by GitHub
parent 3b427b2029
commit 0277ebc225
14 changed files with 277 additions and 35 deletions

View File

@@ -23,10 +23,10 @@ import {
isAdhocColumn,
isColumnMeta,
} from '@superset-ui/chart-controls';
import Popover from 'src/components/Popover';
import { ExplorePopoverContent } from 'src/explore/components/ExploreContentPopover';
import ColumnSelectPopover from './ColumnSelectPopover';
import { DndColumnSelectPopoverTitle } from './DndColumnSelectPopoverTitle';
import ControlPopover from '../ControlPopover/ControlPopover';
interface ColumnSelectPopoverTriggerProps {
columns: ColumnMeta[];
@@ -137,8 +137,7 @@ const ColumnSelectPopoverTrigger = ({
);
return (
<Popover
placement="right"
<ControlPopover
trigger="click"
content={overlayContent}
defaultVisible={visible}
@@ -148,7 +147,7 @@ const ColumnSelectPopoverTrigger = ({
destroyTooltipOnHide
>
{children}
</Popover>
</ControlPopover>
);
};