QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make VizTypeControl use metadata from plugin (#6235)

Browse Source 
* Render vis type item using information from registry

* adjust style

* fix unit test

* Remove large thumbnails

* Update addSlice
This commit is contained in:
Krist Wongsuphasawat
2018-11-01 11:39:24 -07:00
committed by Maxime Beauchemin
parent d1cbb0d000
commit 02f0616025
55 changed files with 104 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset/assets/spec/javascripts/explore/components/VizTypeControl_spec.jsx
View File

@@ -3,17 +3,30 @@ import sinon from 'sinon';
import { shallow } from 'enzyme';
import { Modal } from 'react-bootstrap';
import VizTypeControl from '../../../../src/explore/components/controls/VizTypeControl';
import getChartMetadataRegistry from '../../../../src/visualizations/core/registries/ChartMetadataRegistrySingleton';
import ChartMetadata from '../../../../src/visualizations/core/models/ChartMetadata';
const defaultProps = {
name: 'viz_type',
label: 'Visualization Type',
value: 'table',
value: 'vis1',
onChange: sinon.spy(),
};
describe('VizTypeControl', () => {
let wrapper;
const registry = getChartMetadataRegistry();
registry
.registerValue('vis1', new ChartMetadata({
name: 'vis1',
thumbnail: '',
}))
.registerValue('vis2', new ChartMetadata({
name: 'vis2',
thumbnail: '',
}));
beforeEach(() => {
wrapper = shallow(<VizTypeControl {...defaultProps} />);
});
@@ -28,8 +41,8 @@ describe('VizTypeControl', () => {
expect(defaultProps.onChange.called).toBe(true);
});
it('filters images based on text input', () => {
expect(wrapper.find('img').length).toBeGreaterThan(20);
wrapper.setState({ filter: 'time' });
expect(wrapper.find('img').length).toBeLessThan(10);
expect(wrapper.find('img')).toHaveLength(2);
wrapper.setState({ filter: 'vis2' });
expect(wrapper.find('img')).toHaveLength(1);
});
});