chore(metricoption): remove metricoption and columntypelable dependency (#10077)

* remove columntypeLabel and metricoptions from superset

* fix lint

* remove old test

* update pakage

* add suggestions

* fix merge conflict

superset-frontend/spec/javascripts/components/ColumnTypeLabel_spec.jsx

@@ -19,8 +19,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import { ColumnOption } from '@superset-ui/control-utils';
-import ColumnTypeLabel from 'src/components/ColumnTypeLabel';
+import { ColumnOption, ColumnTypeLabel } from '@superset-ui/control-utils';
 
 describe('ColumnOption', () => {
   const defaultProps = {

superset-frontend/spec/javascripts/components/MetricOption_spec.jsx

@@ -1,85 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import React from 'react';
-import { shallow } from 'enzyme';
-import { InfoTooltipWithTrigger } from '@superset-ui/control-utils';
-
-import MetricOption from 'src/components/MetricOption';
-import ColumnTypeLabel from 'src/components/ColumnTypeLabel';
-
-describe('MetricOption', () => {
-  const defaultProps = {
-    metric: {
-      metric_name: 'foo',
-      verbose_name: 'Foo',
-      expression: 'SUM(foo)',
-      description: 'Foo is the greatest metric of all',
-      warning_text: 'Be careful when using foo',
-    },
-    showType: false,
-  };
-
-  let wrapper;
-  let props;
-  const factory = o => <MetricOption {...o} />;
-  beforeEach(() => {
-    wrapper = shallow(factory(defaultProps));
-    props = { ...defaultProps };
-  });
-  it('is a valid element', () => {
-    expect(React.isValidElement(<MetricOption {...defaultProps} />)).toBe(true);
-  });
-  it('shows a label with verbose_name', () => {
-    const lbl = wrapper.find('.option-label');
-    expect(lbl).toHaveLength(1);
-    expect(lbl.first().text()).toBe('Foo');
-  });
-  it('shows 3 InfoTooltipWithTrigger', () => {
-    expect(wrapper.find(InfoTooltipWithTrigger)).toHaveLength(3);
-  });
-  it('shows only 2 InfoTooltipWithTrigger when no descr', () => {
-    props.metric.description = null;
-    wrapper = shallow(factory(props));
-    expect(wrapper.find(InfoTooltipWithTrigger)).toHaveLength(2);
-  });
-  it('shows a label with metric_name when no verbose_name', () => {
-    props.metric.verbose_name = null;
-    wrapper = shallow(factory(props));
-    expect(wrapper.find('.option-label').first().text()).toBe('foo');
-  });
-  it('shows only 1 InfoTooltipWithTrigger when no descr and no warning', () => {
-    props.metric.warning_text = null;
-    wrapper = shallow(factory(props));
-    expect(wrapper.find(InfoTooltipWithTrigger)).toHaveLength(1);
-  });
-  it('sets target="_blank" when openInNewWindow is true', () => {
-    props.url = 'https://github.com/apache/incubator-superset';
-    wrapper = shallow(factory(props));
-    expect(wrapper.find('a').prop('target')).toBeNull();
-
-    props.openInNewWindow = true;
-    wrapper = shallow(factory(props));
-    expect(wrapper.find('a').prop('target')).toBe('_blank');
-  });
-  it('shows a metric type label when showType is true', () => {
-    props.showType = true;
-    wrapper = shallow(factory(props));
-    expect(wrapper.find(ColumnTypeLabel)).toHaveLength(1);
-  });
-});