From 0364933e8b2921ab206bbc6657962c7da8043720 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Thu, 2 Oct 2025 19:08:31 +0200 Subject: [PATCH] fix(explore): Remove query autotrigger (#35418) --- .../src/utilities/Shared_DeckGL.tsx | 1 + .../components/ExploreViewContainer/index.jsx | 28 +------------------ 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx b/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx index be06ecaa15b..f1a49107de8 100644 --- a/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx +++ b/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx @@ -505,6 +505,7 @@ export const tooltipTemplate = { config: { type: TooltipTemplateControl, label: t('Customize tooltips template'), + renderTrigger: true, debounceDelay: 30, default: '', description: '', diff --git a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx index c65f14916fc..42aea646238 100644 --- a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx +++ b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx @@ -371,15 +371,6 @@ function ExploreViewContainer(props) { props.form_data, ]); - // Simple debounced auto-query for non-renderTrigger controls - const debouncedAutoQuery = useMemo( - () => - debounce(() => { - onQuery(); - }, 1000), // 1 second delay - [onQuery], - ); - const handleKeydown = useCallback( event => { const controlOrCommand = event.ctrlKey || event.metaKey; @@ -573,25 +564,8 @@ function ExploreViewContainer(props) { if (displayControlsChanged.length > 0) { reRenderChart(displayControlsChanged); } - - // Auto-update for non-renderTrigger controls - const queryControlsChanged = changedControlKeys.filter( - key => - !props.controls[key].renderTrigger && - !props.controls[key].dontRefreshOnChange, - ); - if (queryControlsChanged.length > 0) { - // Check if there are no validation errors before auto-updating - const hasErrors = Object.values(props.controls).some( - control => - control.validationErrors && control.validationErrors.length > 0, - ); - if (!hasErrors) { - debouncedAutoQuery(); - } - } } - }, [props.controls, props.ownState, debouncedAutoQuery]); + }, [props.controls, props.ownState]); const chartIsStale = useMemo(() => { if (lastQueriedControls) {