QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(mcp): change save_chart default to False for preview-first workflow (#36935)

Browse Source 
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Amin Ghadersohi
2026-01-08 14:30:01 -05:00
committed by GitHub
parent 337eb3baf5
commit 047360641a
3 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit_tests/mcp_service/chart/tool/test_generate_chart.py
View File

@@ -182,24 +182,35 @@ class TestGenerateChart:
@pytest.mark.asyncio
async def test_save_chart_flag(self):
"""Test save_chart flag behavior."""
# Default should be True (save chart)
# Default should be False (preview only, not saved)
request1 = GenerateChartRequest(
dataset_id="1",
config=TableChartConfig(
chart_type="table", columns=[ColumnRef(name="col1")]
),
)
assert request1.save_chart is True
assert request1.save_chart is False
# Explicit False (preview only)
# Explicit True (save chart permanently)
request2 = GenerateChartRequest(
dataset_id="1",
config=TableChartConfig(
chart_type="table", columns=[ColumnRef(name="col1")]
),
save_chart=False,
save_chart=True,
)
assert request2.save_chart is False
assert request2.save_chart is True
# Both False should raise validation error (no-op request)
with pytest.raises(ValueError, match="At least one of"):
GenerateChartRequest(
dataset_id="1",
config=TableChartConfig(
chart_type="table", columns=[ColumnRef(name="col1")]
),
save_chart=False,
generate_preview=False,
)
@pytest.mark.asyncio
async def test_preview_formats(self):