QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 22:29:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Removes the UX_BETA feature flag (#23651)

Browse Source
This commit is contained in:
Michael S. Molina
2023-04-13 10:32:34 -03:00
committed by GitHub
parent 0974fa1172
commit 04bd528bed
9 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx
View File

@@ -372,7 +372,7 @@ const DndFilterSelect = (props: DndFilterSelectProps) => {
const config: Partial<AdhocFilter> = {
subject: (droppedItem as ColumnMeta)?.column_name,
};
if (config.subject && isFeatureEnabled(FeatureFlag.UX_BETA)) {
if (config.subject) {
config.operator = OPERATOR_ENUM_TO_OPERATOR_TYPE[Operators.IN].operation;
config.operatorId = Operators.IN;
}

18
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
View File

@@ -315,16 +315,14 @@ const DndMetricSelect = (props: any) => {
const config: Partial<AdhocMetric> = {
column: itemValue,
};
if (isFeatureEnabled(FeatureFlag.UX_BETA)) {
if (itemValue.type_generic === GenericDataType.NUMERIC) {
config.aggregate = AGGREGATES.SUM;
} else if (
itemValue.type_generic === GenericDataType.STRING ||
itemValue.type_generic === GenericDataType.BOOLEAN ||
itemValue.type_generic === GenericDataType.TEMPORAL
) {
config.aggregate = AGGREGATES.COUNT_DISTINCT;
}
if (itemValue.type_generic === GenericDataType.NUMERIC) {
config.aggregate = AGGREGATES.SUM;
} else if (
itemValue.type_generic === GenericDataType.STRING ||
itemValue.type_generic === GenericDataType.BOOLEAN ||
itemValue.type_generic === GenericDataType.TEMPORAL
) {
config.aggregate = AGGREGATES.COUNT_DISTINCT;
}
return new AdhocMetric(config);
}