QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: filter with created_by for charts and dashboards (#21199)

Browse Source 
* feat: filter with created_by for charts and dashboards

* add tests

* update tests

* update tests
This commit is contained in:
Lily Kuang
2022-08-30 12:27:38 -07:00
committed by GitHub
parent 1aa1864d13
commit 05354a96bf
7 changed files with 102 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/integration_tests/dashboards/api_tests.py
View File

@@ -1836,3 +1836,39 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin, InsertChartMixi
# get returns 404
resp = self.get_assert_metric(uri, "get_embedded")
self.assertEqual(resp.status_code, 404)
@pytest.mark.usefixtures("create_created_by_admin_dashboards")
def test_gets_created_by_user_dashboards_filter(self):
arguments = {
"filters": [
{"col": "id", "opr": "dashboard_has_created_by", "value": True}
],
"keys": ["none"],
"columns": ["dashboard_title"],
}
self.login(username="admin")
uri = f"api/v1/dashboard/?q={prison.dumps(arguments)}"
rv = self.get_assert_metric(uri, "get_list")
self.assertEqual(rv.status_code, 200)
data = json.loads(rv.data.decode("utf-8"))
self.assertEqual(data["count"], 7)
def test_gets_not_created_by_user_dashboards_filter(self):
arguments = {
"filters": [
{"col": "id", "opr": "dashboard_has_created_by", "value": False}
],
"keys": ["none"],
"columns": ["dashboard_title"],
}
dashboard = self.insert_dashboard(f"title", f"slug", [])
self.login(username="admin")
uri = f"api/v1/dashboard/?q={prison.dumps(arguments)}"
rv = self.get_assert_metric(uri, "get_list")
self.assertEqual(rv.status_code, 200)
data = json.loads(rv.data.decode("utf-8"))
self.assertEqual(data["count"], 6)
db.session.delete(dashboard)
db.session.commit()