QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-06 16:19:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Chart cache-warmup task fails on Superset 4.0 (#28706)

Browse Source
This commit is contained in:
Ross Masters
2024-09-07 01:56:14 +01:00
committed by GitHub
parent d7547fc4ef
commit 0744abe87b
4 changed files with 126 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/integration_tests/tasks/test_cache.py
View File

@@ -29,9 +29,10 @@ from tests.integration_tests.test_app import app
],
ids=["Without trailing slash", "With trailing slash"],
)
@mock.patch("superset.tasks.cache.fetch_csrf_token")
@mock.patch("superset.tasks.cache.request.Request")
@mock.patch("superset.tasks.cache.request.urlopen")
def test_fetch_url(mock_urlopen, mock_request_cls, base_url):
def test_fetch_url(mock_urlopen, mock_request_cls, mock_fetch_csrf_token, base_url):
from superset.tasks.cache import fetch_url
mock_request = mock.MagicMock()
@@ -40,18 +41,22 @@ def test_fetch_url(mock_urlopen, mock_request_cls, base_url):
mock_urlopen.return_value = mock.MagicMock()
mock_urlopen.return_value.code = 200
initial_headers = {"Cookie": "cookie", "key": "value"}
csrf_headers = initial_headers | {"X-CSRF-Token": "csrf_token"}
mock_fetch_csrf_token.return_value = csrf_headers
app.config["WEBDRIVER_BASEURL"] = base_url
headers = {"key": "value"}
data = "data"
data_encoded = b"data"
result = fetch_url(data, headers)
result = fetch_url(data, initial_headers)
assert data == result["success"]
mock_fetch_csrf_token.assert_called_once_with(initial_headers)
mock_request_cls.assert_called_once_with(
"http://base-url/superset/warm_up_cache/",
"http://base-url/api/v1/chart/warm_up_cache",
data=data_encoded,
headers=headers,
headers=csrf_headers,
method="PUT",
)
# assert the same Request object is used