QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(dao): Remove redundant convenience methods (#24967)

Browse Source
This commit is contained in:
John Bodley
2023-08-14 12:07:04 -07:00
committed by GitHub
parent 12f2b0f8e7
commit 0879b9215c
3 changed files with 4 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset/datasets/columns/commands/delete.py
View File

@@ -20,7 +20,7 @@ from typing import Optional
from superset import security_manager
from superset.commands.base import BaseCommand
from superset.connectors.sqla.models import TableColumn
from superset.daos.dataset import DatasetDAO
from superset.daos.dataset import DatasetColumnDAO, DatasetDAO
from superset.daos.exceptions import DAODeleteFailedError
from superset.datasets.columns.commands.exceptions import (
DatasetColumnDeleteFailedError,
@@ -43,7 +43,7 @@ class DeleteDatasetColumnCommand(BaseCommand):
assert self._model
try:
DatasetDAO.delete_column(self._model)
DatasetColumnDAO.delete(self._model)
except DAODeleteFailedError as ex:
logger.exception(ex.exception)
raise DatasetColumnDeleteFailedError() from ex