QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 01:24:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enable G logging rules and comprehensive ruff improvements (#35081)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2025-09-15 12:42:49 -07:00
committed by GitHub
parent e1a2e4843a
commit 088ecdd0bf
47 changed files with 340 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
superset/extensions/discovery.py
View File

@@ -40,7 +40,9 @@ def discover_and_load_extensions(
LoadedExtension instances for each valid .supx file found
"""
if not extensions_path or not os.path.exists(extensions_path):
logger.warning(f"Extensions path does not exist or is empty: {extensions_path}")
logger.warning(
"Extensions path does not exist or is empty: %s", extensions_path
)
return
extensions_dir = Path(extensions_path)
@@ -50,7 +52,8 @@ def discover_and_load_extensions(
for supx_file in extensions_dir.glob("*.supx"):
if not is_zipfile(supx_file):
logger.warning(
f"File has .supx extension but is not a valid zip file: {supx_file}"
"File has .supx extension but is not a valid zip file: %s",
supx_file,
)
continue
@@ -59,11 +62,13 @@ def discover_and_load_extensions(
files = get_bundle_files_from_zip(zip_file)
extension = get_loaded_extension(files)
extension_id = extension.manifest["id"]
logger.info(f"Loaded extension '{extension_id}' from {supx_file}")
logger.info(
"Loaded extension '%s' from %s", extension_id, supx_file
)
yield extension
except Exception as e:
logger.error(f"Failed to load extension from {supx_file}: {e}")
logger.error("Failed to load extension from %s: %s", supx_file, e)
continue
except Exception as e:
logger.error(f"Error discovering extensions in {extensions_path}: {e}")
logger.error("Error discovering extensions in %s: %s", extensions_path, e)