QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enable G logging rules and comprehensive ruff improvements (#35081)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2025-09-15 12:42:49 -07:00
committed by GitHub
parent e1a2e4843a
commit 088ecdd0bf
47 changed files with 340 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset/migrations/shared/migrate_viz/base.py
View File

@@ -180,7 +180,7 @@ class MigrateViz:
slc.params = json.dumps({**clz.data, **backup})
except Exception as e:
logger.warning(f"Failed to migrate slice {slc.id}: {e}")
logger.warning("Failed to migrate slice %s: %s", slc.id, e)
@classmethod
def downgrade_slice(cls, slc: Slice) -> None:
@@ -202,14 +202,14 @@ class MigrateViz:
slc.query_context = None
except Exception as e:
logger.warning(f"Failed to downgrade slice {slc.id}: {e}")
logger.warning("Failed to downgrade slice %s: %s", slc.id, e)
@classmethod
def upgrade(cls, session: Session) -> None:
slices = session.query(Slice).filter(Slice.viz_type == cls.source_viz_type)
for slc in paginated_update(
slices,
lambda current, total: logger.info(f"Upgraded {current}/{total} charts"),
lambda current, total: logger.info("Upgraded %s/%s charts", current, total),
):
cls.upgrade_slice(slc)
@@ -223,7 +223,9 @@ class MigrateViz:
)
for slc in paginated_update(
slices,
lambda current, total: logger.info(f"Downgraded {current}/{total} charts"),
lambda current, total: logger.info(
"Downgraded %s/%s charts", current, total
),
):
cls.downgrade_slice(slc)