chore: enable no-unused-vars and prefer-template eslint rules (#10350)

superset-frontend/src/SqlLab/components/HighlightedSql.jsx

@@ -60,7 +60,7 @@ class HighlightedSql extends React.Component {
     return lines
       .map(line => {
         if (line.length > this.props.maxWidth) {
-          return line.slice(0, this.props.maxWidth) + '{...}';
+          return `${line.slice(0, this.props.maxWidth)}{...}`;
         }
         return line;
       })

superset-frontend/src/SqlLab/components/QuerySearch.jsx

@@ -136,7 +136,7 @@ class QuerySearch extends React.PureComponent {
     const validParams = params.filter(function (p) {
       return p !== '';
     });
-    return baseUrl + '?' + validParams.join('&');
+    return `${baseUrl}?${validParams.join('&')}`;
   }
 
   changeStatus(status) {
@@ -150,7 +150,7 @@ class QuerySearch extends React.PureComponent {
 
   userLabel(user) {
     if (user.first_name && user.last_name) {
-      return user.first_name + ' ' + user.last_name;
+      return `${user.first_name} ${user.last_name}`;
     }
     return user.username;
   }

superset-frontend/src/SqlLab/components/ResultSet.tsx

@@ -167,7 +167,7 @@ export default class ResultSet extends React.PureComponent<
             {this.props.csv && (
               <Button
                 bsSize="small"
-                href={'/superset/csv/' + this.props.query.id}
+                href={`/superset/csv/${this.props.query.id}`}
               >
                 <i className="fa fa-file-text-o" /> {t('.CSV')}
               </Button>

superset-frontend/src/SqlLab/components/ShareSqlLabQuery.jsx

@@ -77,10 +77,9 @@ class ShareSqlLabQuery extends React.Component {
     let savedQueryToastContent;
 
     if (this.props.queryEditor.remoteId) {
-      savedQueryToastContent =
-        window.location.origin +
-        window.location.pathname +
-        `?savedQueryId=${this.props.queryEditor.remoteId}`;
+      savedQueryToastContent = `${
+        window.location.origin + window.location.pathname
+      }?savedQueryId=${this.props.queryEditor.remoteId}`;
       this.setState({ shortUrl: savedQueryToastContent });
     } else {
       savedQueryToastContent = t('Please save the query to enable sharing');

superset-frontend/src/SqlLab/components/TabStatusIcon.jsx

@@ -20,7 +20,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 export default function TabStatusIcon(props) {
-  return <div className={'circle ' + props.tabState} />;
+  return <div className={`circle ${props.tabState}`} />;
 }
 
 TabStatusIcon.propTypes = {

superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx

@@ -304,7 +304,7 @@ class TabbedSqlEditors extends React.PureComponent {
           {isSelected && (
             <DropdownButton
               bsSize="small"
-              id={'ddbtn-tab-' + i}
+              id={`ddbtn-tab-${i}`}
               title={' '}
               noCaret
             >