QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(chart-data): add rowcount, timegrain and column result types (#13271)

Browse Source 
* feat(chart-data): add rowcount, timegrain and column result types

* break out actions from query_context

* rename module
This commit is contained in:
Ville Brofeldt
2021-02-24 07:43:47 +02:00
committed by GitHub
parent 6954114f84
commit 0a00153375
12 changed files with 339 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
tests/charts/api_tests.py
View File

@@ -1102,7 +1102,7 @@ class TestChartApi(SupersetTestCase, ApiOwnersTestCaseMixin, InsertChartMixin):
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
@mock.patch(
"superset.common.query_context.config", {**app.config, "SAMPLES_ROW_LIMIT": 5},
"superset.common.query_actions.config", {**app.config, "SAMPLES_ROW_LIMIT": 5},
)
def test_chart_data_default_sample_limit(self):
"""
@@ -1698,3 +1698,44 @@ class TestChartApi(SupersetTestCase, ApiOwnersTestCaseMixin, InsertChartMixin):
name
)
return name
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_chart_data_rowcount(self):
"""
Chart data API: Query total rows
"""
self.login(username="admin")
request_payload = get_query_context("birth_names")
request_payload["queries"][0]["is_rowcount"] = True
request_payload["queries"][0]["groupby"] = ["name"]
rv = self.post_assert_metric(CHART_DATA_URI, request_payload, "data")
response_payload = json.loads(rv.data.decode("utf-8"))
result = response_payload["result"][0]
expected_row_count = self.get_expected_row_count("client_id_4")
self.assertEqual(result["data"][0]["rowcount"], expected_row_count)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_chart_data_timegrains(self):
"""
Chart data API: Query timegrains and columns
"""
self.login(username="admin")
request_payload = get_query_context("birth_names")
request_payload["queries"] = [
{"result_type": utils.ChartDataResultType.TIMEGRAINS},
{"result_type": utils.ChartDataResultType.COLUMNS},
]
rv = self.post_assert_metric(CHART_DATA_URI, request_payload, "data")
response_payload = json.loads(rv.data.decode("utf-8"))
timegrain_result = response_payload["result"][0]
column_result = response_payload["result"][1]
assert list(timegrain_result["data"][0].keys()) == [
"name",
"function",
"duration",
]
assert list(column_result["data"][0].keys()) == [
"column_name",
"verbose_name",
"dtype",
]