QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-25 02:55:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't reformat generated queries (#30350)

Browse Source
This commit is contained in:
Beto Dealmeida
2024-10-04 11:09:37 -04:00
committed by GitHub
parent b627011463
commit 0b34197815
11 changed files with 29 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/integration_tests/query_context_tests.py
View File

@@ -367,7 +367,7 @@ class TestQueryContext(SupersetTestCase):
sql_text = get_sql_text(payload)
assert "SELECT" in sql_text
assert re.search(r'NOT [`"\[]?num[`"\]]? IS NULL', sql_text)
assert re.search(r'[`"\[]?num[`"\]]? IS NOT NULL', sql_text)
assert re.search(
r"""NOT \([\s\n]*[`"\[]?name[`"\]]? IS NULL[\s\n]* """
r"""OR [`"\[]?name[`"\]]? IN \('"abc"'\)[\s\n]*\)""",
@@ -1161,16 +1161,19 @@ LIMIT 10000
OFFSET 0
"""
assert (
re.search(r"WHERE\n col6 >= .*2002-01-01", sqls[0])
re.search(r"WHERE col6 >= .*2002-01-01", sqls[0])
and re.search(r"AND col6 < .*2003-01-01", sqls[0])
) is not None
assert (
re.search(r"WHERE\n col6 >= .*2001-10-01", sqls[1])
re.search(r"WHERE col6 >= .*2001-10-01", sqls[1])
and re.search(r"AND col6 < .*2002-10-01", sqls[1])
) is not None
def test_virtual_dataset_with_comments(app_context, virtual_dataset_with_comments):
if backend() == "mysql":
return
qc = QueryContextFactory().create(
datasource={
"type": virtual_dataset_with_comments.type,