QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add comments to SQL clause validation (#39167)

Browse Source
This commit is contained in:
Luiz Otavio
2026-04-16 09:19:39 -03:00
committed by GitHub
parent 0b51e9cd5e
commit 0b419a07f5
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit_tests/sql/parse_tests.py
View File

@@ -2693,9 +2693,19 @@ def test_is_valid_cvas(sql: str, engine: str, expected: bool) -> None:
), # Compact format
(
"col = 'abc' -- comment",
"col = 'abc'",
"col = 'abc' /* comment */",
"base",
), # Comments removed for compact format
), # Line comments converted to block comments
(
"TRUE /* precise_count_distinct=true */",
"TRUE /* precise_count_distinct=true */",
"base",
), # Block comments preserved
(
"col > 1 /* hint=value */",
"col > 1 /* hint=value */",
"base",
), # Block comments preserved
("col = 'col1 = 1) AND (col2 = 2'", "col = 'col1 = 1) AND (col2 = 2'", "base"),
("col = 'select 1; select 2'", "col = 'select 1; select 2'", "base"),
("col = 'abc -- comment'", "col = 'abc -- comment'", "base"),