QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Improves the native filters bar layout (#15115)

Browse Source
This commit is contained in:
Michael S. Molina
2021-06-16 08:17:14 -03:00
committed by GitHub
parent 83602923f5
commit 0c22266041
13 changed files with 308 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
View File

@@ -23,7 +23,6 @@ import sinon from 'sinon';
import fetchMock from 'fetch-mock';
import { ParentSize } from '@vx/responsive';
import { supersetTheme, ThemeProvider } from '@superset-ui/core';
import { Sticky, StickyContainer } from 'react-sticky';
import Tabs from 'src/components/Tabs';
import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend';
@@ -90,14 +89,14 @@ describe('DashboardBuilder', () => {
it('should render a StickyContainer with class "dashboard"', () => {
const wrapper = setup();
const stickyContainer = wrapper.find(StickyContainer);
const stickyContainer = wrapper.find('[data-test="dashboard-content"]');
expect(stickyContainer).toHaveLength(1);
expect(stickyContainer.prop('className')).toBe('dashboard');
});
it('should add the "dashboard--editing" class if editMode=true', () => {
const wrapper = setup({ dashboardState: { editMode: true } });
const stickyContainer = wrapper.find(StickyContainer).first();
const stickyContainer = wrapper.find('[data-test="dashboard-content"]');
expect(stickyContainer.prop('className')).toBe(
'dashboard dashboard--editing',
);
@@ -113,12 +112,12 @@ describe('DashboardBuilder', () => {
{ dashboardLayout: undoableDashboardLayoutWithTabs },
mockStoreWithTabs,
);
const sticky = wrapper.find(Sticky);
const sticky = wrapper.find('[data-test="top-level-tabs"]');
const dashboardComponent = sticky.find(DashboardComponent);
const tabChildren =
undoableDashboardLayoutWithTabs.present.TABS_ID.children;
expect(sticky).toHaveLength(1);
expect(dashboardComponent).toHaveLength(1 + tabChildren.length); // tab + tabs
expect(dashboardComponent.at(0).prop('id')).toBe('TABS_ID');
tabChildren.forEach((tabId, i) => {