QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 23:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

move metric parsing to state instantiation (#15069)

Browse Source
This commit is contained in:
Elizabeth Thompson
2021-06-09 14:54:25 -07:00
committed by GitHub
parent 821519fcfa
commit 0c470feaef
2 changed files with 33 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
View File

@@ -233,4 +233,21 @@ describe('DatasourceEditor RTL', () => {
);
expect(warningMarkdown.value).toEqual('someone');
});
it('properly updates the metric information', async () => {
render(<DatasourceEditor {...props} />, {
useRedux: true,
});
const metricButton = screen.getByTestId('collection-tab-Metrics');
userEvent.click(metricButton);
const expandToggle = await screen.findAllByLabelText(/toggle expand/i);
userEvent.click(expandToggle[1]);
const certifiedBy = await screen.findByPlaceholderText(/certified by/i);
userEvent.type(certifiedBy, 'I am typing a new name');
const certificationDetails = await screen.findByPlaceholderText(
/certification details/i,
);
expect(certifiedBy.value).toEqual('I am typing a new name');
userEvent.type(certificationDetails, 'I am typing something new');
expect(certificationDetails.value).toEqual('I am typing something new');
});
});