QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow (#24266)

Browse Source
This commit is contained in:
John Bodley
2023-06-09 18:54:31 -07:00
committed by GitHub
parent 4e47771df1
commit 0e3f1f638c
23 changed files with 62 additions and 1061 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/integration_tests/security_tests.py
View File

@@ -45,7 +45,6 @@ from superset.utils.core import (
)
from superset.utils.database import get_example_database
from superset.utils.urls import get_url_host
from superset.views.access_requests import AccessRequestsModelView
from .base_tests import SupersetTestCase
from tests.integration_tests.fixtures.public_role import (
@@ -1386,9 +1385,6 @@ class TestRolePermission(SupersetTestCase):
self.assertIn(("all_datasource_access", "all_datasource_access"), perm_set)
def assert_cannot_alpha(self, perm_set):
if app.config["ENABLE_ACCESS_REQUEST"]:
self.assert_cannot_write("AccessRequestsModelView", perm_set)
self.assert_can_all("AccessRequestsModelView", perm_set)
self.assert_cannot_write("Queries", perm_set)
self.assert_cannot_write("RoleModelView", perm_set)
self.assert_cannot_write("UserDBModelView", perm_set)
@@ -1398,12 +1394,7 @@ class TestRolePermission(SupersetTestCase):
self.assert_can_all("Database", perm_set)
self.assert_can_all("RoleModelView", perm_set)
self.assert_can_all("UserDBModelView", perm_set)
self.assertIn(("all_database_access", "all_database_access"), perm_set)
self.assertIn(("can_override_role_permissions", "Superset"), perm_set)
self.assertIn(("can_override_role_permissions", "Superset"), perm_set)
self.assertIn(("can_approve", "Superset"), perm_set)
self.assert_can_menu("Security", perm_set)
self.assert_can_menu("List Users", perm_set)
self.assert_can_menu("List Roles", perm_set)
@@ -1430,14 +1421,6 @@ class TestRolePermission(SupersetTestCase):
)
)
if app.config["ENABLE_ACCESS_REQUEST"]:
self.assertTrue(
security_manager._is_admin_only(
security_manager.find_permission_view_menu(
"can_list", "AccessRequestsModelView"
)
)
)
self.assertTrue(
security_manager._is_admin_only(
security_manager.find_permission_view_menu(
@@ -1445,11 +1428,6 @@ class TestRolePermission(SupersetTestCase):
)
)
)
self.assertTrue(
security_manager._is_admin_only(
security_manager.find_permission_view_menu("can_approve", "Superset")
)
)
@unittest.skipUnless(
SupersetTestCase.is_module_installed("pydruid"), "pydruid not installed"
@@ -1534,13 +1512,6 @@ class TestRolePermission(SupersetTestCase):
self.assert_cannot_alpha(sql_lab_set)
def test_granter_permissions(self):
granter_set = get_perm_tuples("granter")
self.assertIn(("can_override_role_permissions", "Superset"), granter_set)
self.assertIn(("can_approve", "Superset"), granter_set)
self.assert_cannot_alpha(granter_set)
def test_gamma_permissions(self):
gamma_perm_set = set()
for perm in security_manager.find_role("Gamma").permissions:
@@ -1752,22 +1723,6 @@ class TestSecurityManager(SupersetTestCase):
self.assertEqual([security_manager.get_public_role()], roles)
class TestAccessRequestEndpoints(SupersetTestCase):
def test_access_request_disabled(self):
with patch.object(AccessRequestsModelView, "is_enabled", return_value=False):
self.login("admin")
uri = "/accessrequestsmodelview/list/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
def test_access_request_enabled(self):
with patch.object(AccessRequestsModelView, "is_enabled", return_value=True):
self.login("admin")
uri = "/accessrequestsmodelview/list/"
rv = self.client.get(uri)
self.assertLess(rv.status_code, 400)
class TestDatasources(SupersetTestCase):
@patch("superset.security.manager.g")
@patch("superset.security.SupersetSecurityManager.can_access_database")