fix: Implement SIP-40 error styles for GAQ (#36596)

tests/unit_tests/tasks/test_async_queries.py

@@ -20,6 +20,8 @@ import pytest
 from flask_babel import lazy_gettext as _
 
 from superset.commands.chart.exceptions import ChartDataQueryFailedError
+from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
+from superset.exceptions import SupersetErrorException, SupersetErrorsException
 
 
 @mock.patch("superset.tasks.async_queries.security_manager")
@@ -53,3 +55,97 @@ def test_load_chart_data_into_cache_with_error(
     mock_async_query_manager.update_job.assert_called_once_with(
         job_metadata, "error", errors=expected_errors
     )
+
+
+@mock.patch("superset.tasks.async_queries.security_manager")
+@mock.patch("superset.tasks.async_queries.async_query_manager")
+@mock.patch("superset.tasks.async_queries.ChartDataQueryContextSchema")
+def test_load_chart_data_into_cache_with_superset_error_exception(
+    mock_query_context_schema_cls, mock_async_query_manager, mock_security_manager
+):
+    """Test that SupersetErrorException extracts SIP-40 style errors"""
+    from superset.tasks.async_queries import load_chart_data_into_cache
+
+    job_metadata = {"user_id": 1}
+    form_data = {}
+
+    superset_error = SupersetError(
+        message="Access denied to datasource",
+        error_type=SupersetErrorType.DATASOURCE_SECURITY_ACCESS_ERROR,
+        level=ErrorLevel.ERROR,
+        extra={"datasource": "my_table"},
+    )
+    err = SupersetErrorException(superset_error)
+
+    mock_user = mock.MagicMock()
+    mock_query_context_schema = mock.MagicMock()
+
+    mock_security_manager.get_user_by_id.return_value = mock_user
+    mock_async_query_manager.STATUS_ERROR = "error"
+    mock_query_context_schema_cls.return_value = mock_query_context_schema
+
+    mock_query_context_schema.load.side_effect = err
+
+    with pytest.raises(SupersetErrorException):
+        load_chart_data_into_cache(job_metadata, form_data)
+
+    # Verify the full SIP-40 error structure is preserved
+    call_args = mock_async_query_manager.update_job.call_args
+    assert call_args[0] == (job_metadata, "error")
+    errors = call_args[1]["errors"]
+    assert len(errors) == 1
+    assert errors[0]["message"] == "Access denied to datasource"
+    assert errors[0]["error_type"] == SupersetErrorType.DATASOURCE_SECURITY_ACCESS_ERROR
+    assert errors[0]["level"] == ErrorLevel.ERROR
+    assert errors[0]["extra"]["datasource"] == "my_table"
+
+
+@mock.patch("superset.tasks.async_queries.security_manager")
+@mock.patch("superset.tasks.async_queries.async_query_manager")
+@mock.patch("superset.tasks.async_queries.ChartDataQueryContextSchema")
+def test_load_chart_data_into_cache_with_superset_errors_exception(
+    mock_query_context_schema_cls, mock_async_query_manager, mock_security_manager
+):
+    """Test that SupersetErrorsException extracts multiple SIP-40 style errors"""
+    from superset.tasks.async_queries import load_chart_data_into_cache
+
+    job_metadata = {"user_id": 1}
+    form_data = {}
+
+    superset_errors = [
+        SupersetError(
+            message="Column not found",
+            error_type=SupersetErrorType.COLUMN_DOES_NOT_EXIST_ERROR,
+            level=ErrorLevel.ERROR,
+        ),
+        SupersetError(
+            message="Table not found",
+            error_type=SupersetErrorType.TABLE_DOES_NOT_EXIST_ERROR,
+            level=ErrorLevel.WARNING,
+        ),
+    ]
+    err = SupersetErrorsException(superset_errors)
+
+    mock_user = mock.MagicMock()
+    mock_query_context_schema = mock.MagicMock()
+
+    mock_security_manager.get_user_by_id.return_value = mock_user
+    mock_async_query_manager.STATUS_ERROR = "error"
+    mock_query_context_schema_cls.return_value = mock_query_context_schema
+
+    mock_query_context_schema.load.side_effect = err
+
+    with pytest.raises(SupersetErrorsException):
+        load_chart_data_into_cache(job_metadata, form_data)
+
+    # Verify all SIP-40 errors are preserved
+    call_args = mock_async_query_manager.update_job.call_args
+    assert call_args[0] == (job_metadata, "error")
+    errors = call_args[1]["errors"]
+    assert len(errors) == 2
+    assert errors[0]["message"] == "Column not found"
+    assert errors[0]["error_type"] == SupersetErrorType.COLUMN_DOES_NOT_EXIST_ERROR
+    assert errors[0]["level"] == ErrorLevel.ERROR
+    assert errors[1]["message"] == "Table not found"
+    assert errors[1]["error_type"] == SupersetErrorType.TABLE_DOES_NOT_EXIST_ERROR
+    assert errors[1]["level"] == ErrorLevel.WARNING