QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-07-20 21:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bigquery): ensure BigQuery client uses project from engine URI (#41975)

Browse Source
This commit is contained in:
Abhishek Kumbhar
2026-07-18 08:35:34 +05:30
committed by GitHub
parent b432f8c917
commit 0f61d9a3fb
2 changed files with 76 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
tests/unit_tests/db_engine_specs/test_bigquery.py
View File

@@ -430,6 +430,78 @@ def test_get_default_catalog(mocker: MockerFixture) -> None:
assert BigQueryEngineSpec.get_default_catalog(database) == "project"
@pytest.mark.parametrize(
("sqlalchemy_uri", "schema", "expected_project"),
[
("bigquery://uri-project", None, "uri-project"),
("bigquery:///uri-project", None, "uri-project"),
("bigquery://", "dataset_name", None),
],
)
def test_get_client_resolves_uri_project_with_service_account_credentials(
mocker: MockerFixture,
sqlalchemy_uri: str,
schema: str | None,
expected_project: str | None,
) -> None:
"""Test that service-account clients use the project from the engine URI."""
from superset.db_engine_specs.bigquery import BigQueryEngineSpec
credentials_info = {"project_id": "credential-project"}
credentials = mock.Mock()
engine = mock.MagicMock()
engine.url = BigQueryEngineSpec.adjust_engine_params(
make_url(sqlalchemy_uri), {}, schema=schema
)[0]
engine.dialect.credentials_info = credentials_info
create_credentials = mocker.patch(
"superset.db_engine_specs.bigquery.service_account.Credentials."
"from_service_account_info",
return_value=credentials,
)
client = mocker.patch("superset.db_engine_specs.bigquery.bigquery.Client")
BigQueryEngineSpec._get_client(engine, mock.Mock())
create_credentials.assert_called_once_with(credentials_info)
client.assert_called_once_with(credentials=credentials, project=expected_project)
@pytest.mark.parametrize(
("sqlalchemy_uri", "schema", "expected_project"),
[
("bigquery://uri-project", None, "uri-project"),
("bigquery:///uri-project", None, "uri-project"),
("bigquery://", "dataset_name", None),
],
)
def test_get_client_resolves_uri_project_with_application_default_credentials(
mocker: MockerFixture,
sqlalchemy_uri: str,
schema: str | None,
expected_project: str | None,
) -> None:
"""Test that ADC clients use the project from the engine URI."""
from superset.db_engine_specs.bigquery import BigQueryEngineSpec
credentials = mock.Mock()
engine = mock.MagicMock()
engine.url = BigQueryEngineSpec.adjust_engine_params(
make_url(sqlalchemy_uri), {}, schema=schema
)[0]
engine.dialect.credentials_info = None
get_default_credentials = mocker.patch(
"superset.db_engine_specs.bigquery.google.auth.default",
return_value=(credentials, "credential-project"),
)
client = mocker.patch("superset.db_engine_specs.bigquery.bigquery.Client")
BigQueryEngineSpec._get_client(engine, mock.Mock())
get_default_credentials.assert_called_once_with()
client.assert_called_once_with(credentials=credentials, project=expected_project)
def test_get_time_partition_column_uses_catalog_in_table_reference(
mocker: MockerFixture,
) -> None: