QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(plugin-chart-table): Add memoization to avoid rerenders (#19976)

Browse Source 
* perf(plugin-chart-table): Add memoization to avoid rerenders

* Fix typing
This commit is contained in:
Kamil Gabryjelski
2022-05-13 18:10:48 +02:00
committed by GitHub
parent 35e6e2709c
commit 0f68deedf1
8 changed files with 81 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
View File

@@ -36,6 +36,7 @@ import {
Row,
} from 'react-table';
import { matchSorter, rankings } from 'match-sorter';
import { typedMemo } from '@superset-ui/core';
import GlobalFilter, { GlobalFilterProps } from './components/GlobalFilter';
import SelectPageSize, {
SelectPageSizeProps,
@@ -74,7 +75,7 @@ const sortTypes = {
};
// Be sure to pass our updateMyData and the skipReset option
export default function DataTable<D extends object>({
export default typedMemo(function DataTable<D extends object>({
tableClassName,
columns,
data,
@@ -124,7 +125,7 @@ export default function DataTable<D extends object>({
const defaultGetTableSize = useCallback(() => {
if (wrapperRef.current) {
// `initialWidth` and `initialHeight` could be also parameters like `100%`
// `Number` reaturns `NaN` on them, then we fallback to computed size
// `Number` returns `NaN` on them, then we fallback to computed size
const width = Number(initialWidth) || wrapperRef.current.clientWidth;
const height =
(Number(initialHeight) || wrapperRef.current.clientHeight) -
@@ -287,7 +288,7 @@ export default function DataTable<D extends object>({
let resultCurrentPage = pageIndex;
let resultOnPageChange: (page: number) => void = gotoPage;
if (serverPagination) {
const serverPageSize = serverPaginationData.pageSize ?? initialPageSize;
const serverPageSize = serverPaginationData?.pageSize ?? initialPageSize;
resultPageCount = Math.ceil(rowCount / serverPageSize);
if (!Number.isFinite(resultPageCount)) {
resultPageCount = 0;
@@ -299,7 +300,7 @@ export default function DataTable<D extends object>({
if (foundPageSizeIndex === -1) {
resultCurrentPageSize = 0;
}
resultCurrentPage = serverPaginationData.currentPage ?? 0;
resultCurrentPage = serverPaginationData?.currentPage ?? 0;
resultOnPageChange = (pageNumber: number) =>
onServerPaginationChange(pageNumber, serverPageSize);
}
@@ -354,4 +355,4 @@ export default function DataTable<D extends object>({
) : null}
</div>
);
}
});