QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: add stack trace to all calls of logger.error (#14382)

Browse Source
This commit is contained in:
Sam Faber-Manning
2021-04-30 09:22:05 -07:00
committed by GitHub
parent 13cfc421d5
commit 11260b3117
26 changed files with 133 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset/db_engine_specs/base.py
View File

@@ -836,7 +836,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
# It's expected that some dialects don't implement the comment method
pass
except Exception as ex: # pylint: disable=broad-except
logger.error("Unexpected error while fetching table comment")
logger.error("Unexpected error while fetching table comment", exc_info=True)
logger.exception(ex)
return comment
@@ -1218,7 +1218,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
try:
extra = json.loads(database.extra)
except json.JSONDecodeError as ex:
logger.error(ex)
logger.error(ex, exc_info=True)
raise ex
return extra