QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-09 09:39:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(chart-controls): improve typing for mapStateToProps (#1171)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2021-07-24 11:06:27 +02:00
committed by Yongjie Zhao
parent 72ac9ab0ef
commit 11a52ea0fc
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts
View File

@@ -190,7 +190,7 @@ export interface BaseControlConfig<
*/
mapStateToProps?: (
state: ControlPanelState,
controlState: this & ExtraControlProps,
controlState: ControlState,
// TODO: add strict `chartState` typing (see superset-frontend/src/explore/types)
chartState?: AnyDict,
) => ExtraControlProps;

1
superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/controlPanel.tsx
View File

@@ -184,7 +184,6 @@ const config: ControlPanelConfig = {
mapStateToProps: (state: ControlPanelState, controlState: ControlState) => {
const { controls } = state;
const originalMapStateToProps = sharedControls?.groupby?.mapStateToProps;
// @ts-ignore
const newState = originalMapStateToProps?.(state, controlState) ?? {};
newState.externalValidationErrors = validateAggControlValues(controls, [
controls.metrics?.value,