QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: improve engine spec discoverability (#14204)

Browse Source 
* feat: improve engine spec discoverability

* Address comments

* Fix tests
This commit is contained in:
Beto Dealmeida
2021-04-19 17:24:22 -07:00
committed by GitHub
parent c2d11ac53e
commit 13bf023100
5 changed files with 57 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/db_engine_specs/postgres_tests.py
View File

@@ -20,7 +20,7 @@ from unittest import mock
from sqlalchemy import column, literal_column
from sqlalchemy.dialects import postgresql
from superset.db_engine_specs import engines
from superset.db_engine_specs import get_engine_specs
from superset.db_engine_specs.postgres import PostgresEngineSpec
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from tests.db_engine_specs.base_tests import TestDbEngineSpec
@@ -132,7 +132,7 @@ class TestPostgresDbEngineSpec(TestDbEngineSpec):
"""
DB Eng Specs (postgres): Test "postgres" in engine spec
"""
self.assertIn("postgres", engines)
self.assertIn("postgres", get_engine_specs())
def test_extras_without_ssl(self):
db = mock.Mock()