QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: front end CI tests and test runner (#10897)

Browse Source
This commit is contained in:
Elizabeth Thompson
2020-09-16 11:35:18 -07:00
committed by GitHub
parent c3f1720456
commit 13cc1a3d2d
4 changed files with 26 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/explore/components/controls/BoundsControl.jsx
View File

@@ -67,10 +67,10 @@ export default class BoundsControl extends React.Component {
onChange() {
const mm = this.state.minMax;
const errors = [];
if (mm[0] && Number.isNaN(mm[0])) {
if (mm[0] && Number.isNaN(Number(mm[0]))) {
errors.push(t('`Min` value should be numeric or empty'));
}
if (mm[1] && Number.isNaN(mm[1])) {
if (mm[1] && Number.isNaN(Number(mm[1]))) {
errors.push(t('`Max` value should be numeric or empty'));
}
if (errors.length === 0) {

4
superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
View File

@@ -116,9 +116,9 @@ export default class FilterBoxItemControl extends React.Component {
if (type === 'BOOLEAN') {
typedValue = value === 'true';
} else if (INTEGRAL_TYPES.has(type)) {
typedValue = Number.isNaN(value) ? null : parseInt(value, 10);
typedValue = Number.isNaN(Number(value)) ? null : parseInt(value, 10);
} else if (DECIMAL_TYPES.has(type)) {
typedValue = Number.isNaN(value) ? null : parseFloat(value);
typedValue = Number.isNaN(Number(value)) ? null : parseFloat(value);
}
}
}