QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for week_start_sunday and week_ending_saturday (#4911)

Browse Source 
* Handle locked weeks

* Fix spelling

* Fix druid

* Clean unit tests
This commit is contained in:
Beto Dealmeida
2018-05-01 13:27:56 -07:00
committed by Maxime Beauchemin
parent 9c53323c93
commit 13da5a8742
4 changed files with 94 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
superset/assets/spec/javascripts/modules/time_spec.js Normal file
View File

@@ -0,0 +1,58 @@
import { it, describe } from 'mocha';
import { expect } from 'chai';
import { getPlaySliderParams } from '../../../src/modules/time';
describe('getPlaySliderParams', () => {
it('is a function', () => {
assert.isFunction(getPlaySliderParams);
});
it('handles durations', () => {
const timestamps = [
new Date('2018-01-01'),
new Date('2018-01-02'),
new Date('2018-01-03'),
new Date('2018-01-04'),
new Date('2018-01-05'),
new Date('2018-01-06'),
new Date('2018-01-07'),
new Date('2018-01-08'),
new Date('2018-01-09'),
new Date('2018-01-10'),
].map(d => d.getTime());
const { start, end, step, values, disabled } = getPlaySliderParams(timestamps, 'P2D');
expect(new Date(start)).to.eql(new Date('2018-01-01'));
expect(new Date(end)).to.eql(new Date('2018-01-11'));
expect(step).to.equal(2 * 24 * 60 * 60 * 1000);
expect(values.map(v => new Date(v))).to.eql([
new Date('2018-01-01'),
new Date('2018-01-03'),
]);
expect(disabled).to.equal(false);
});
it('handles intervals', () => {
const timestamps = [
new Date('2018-01-01'),
new Date('2018-01-02'),
new Date('2018-01-03'),
new Date('2018-01-04'),
new Date('2018-01-05'),
new Date('2018-01-06'),
new Date('2018-01-07'),
new Date('2018-01-08'),
new Date('2018-01-09'),
new Date('2018-01-10'),
].map(d => d.getTime());
// 1970-01-03 was a Saturday
const { start, end, step, values, disabled } = getPlaySliderParams(timestamps, 'P1W/1970-01-03T00:00:00Z');
expect(new Date(start)).to.eql(new Date('2017-12-30')); // Saturday
expect(new Date(end)).to.eql(new Date('2018-01-13')); // Saturday
expect(step).to.equal(7 * 24 * 60 * 60 * 1000);
expect(values.map(v => new Date(v))).to.eql([
new Date('2017-12-30'),
new Date('2018-01-06'),
]);
expect(disabled).to.equal(false);
});
});