QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-12 12:47:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing the build (#3445)

Browse Source 
* Bumping npm

* Fixing the build

This addresses long standing issues and hacks around react-map-gl
that have been creating all sorts of build issues over time.

It appears that recent changes broke things further.

This PR upgrades to the latest `react-map-gl` and removes related hacks.
This commit is contained in:
Maxime Beauchemin
2017-09-11 16:30:39 -07:00
committed by GitHub
parent 3dfdde130a
commit 147c12dddf
5 changed files with 65 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/javascripts/explore/components/ChartContainer.jsx
View File

@@ -178,8 +178,8 @@ class ChartContainer extends React.PureComponent {
this.props.actions.renderTriggered();
const mockSlice = this.getMockedSliceObject();
this.setState({ mockSlice });
const viz = visMap[this.props.viz_type];
try {
const viz = visMap[this.props.viz_type];
viz(mockSlice, this.props.queryResponse, this.props.actions.setControlValue);
} catch (e) {
this.props.actions.chartRenderingFailed(e);