QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-12 12:47:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: revert #17654 to fix subselect table name parsing (#18017)

Browse Source
This commit is contained in:
Erik Ritter
2022-01-12 21:28:23 -08:00
committed by GitHub
parent 51090c3f1b
commit 14b9298ef7
2 changed files with 5 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/unit_tests/sql_parse_tests.py
View File

@@ -45,11 +45,11 @@ def test_table() -> None:
Special characters in the table, schema, or catalog name should be escaped correctly.
"""
assert str(Table("table_name")) == "table_name"
assert str(Table("table_name", "schema_name")) == "schema_name.table_name"
assert str(Table("tbname")) == "tbname"
assert str(Table("tbname", "schemaname")) == "schemaname.tbname"
assert (
str(Table("table_name", "schema_name", "catalog_name"))
== "catalog_name.schema_name.table_name"
str(Table("tbname", "schemaname", "catalogname"))
== "catalogname.schemaname.tbname"
)
assert (
str(Table("table.name", "schema/name", "catalog\nname"))
@@ -537,22 +537,6 @@ def test_extract_tables_multistatement() -> None:
}
def test_extract_tables_keyword() -> None:
"""
Test that table names that are keywords work as expected.
If the table name is a ``sqlparse`` reserved keyword (eg, "table_name") the parser
needs extra logic to identify it.
"""
assert extract_tables("SELECT * FROM table_name") == {Table("table_name")}
assert extract_tables("SELECT * FROM table_name AS foo") == {Table("table_name")}
# these 3 are considered keywords
assert extract_tables("SELECT * FROM catalog_name.schema_name.table_name") == {
Table("table_name", "schema_name", "catalog_name")
}
def test_extract_tables_complex() -> None:
"""
Test a few complex queries.