QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: failed samples should throw exception (#20228)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-06-01 18:24:01 +08:00
committed by GitHub
parent 9432c62ec1
commit 1530c34792
5 changed files with 85 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx
View File

@@ -17,7 +17,7 @@
* under the License.
*/
import React, { useState, useEffect, useMemo } from 'react';
import { GenericDataType, styled, t } from '@superset-ui/core';
import { ensureIsArray, GenericDataType, styled, t } from '@superset-ui/core';
import Loading from 'src/components/Loading';
import { EmptyStateMedium } from 'src/components/EmptyState';
import TableView, { EmptyWrapperType } from 'src/components/TableView';
@@ -63,9 +63,9 @@ export const SamplesPane = ({
setIsLoading(true);
getDatasetSamples(datasource.id, queryForce)
.then(response => {
setData(response.data);
setColnames(response.colnames);
setColtypes(response.coltypes);
setData(ensureIsArray(response.data));
setColnames(ensureIsArray(response.colnames));
setColtypes(ensureIsArray(response.coltypes));
setResponseError('');
cache.add(datasource);
if (queryForce && actions) {
@@ -73,6 +73,9 @@ export const SamplesPane = ({
}
})
.catch(error => {
setData([]);
setColnames([]);
setColtypes([]);
setResponseError(`${error.name}: ${error.message}`);
})
.finally(() => {