fix: SQL label missing for non-group-by queries (#29420)

This commit is contained in:
Hex Café
2024-07-01 16:59:25 +08:00
committed by GitHub
parent ba405bacbf
commit 179cf269c6
2 changed files with 26 additions and 1 deletions

View File

@@ -556,6 +556,29 @@ class TestSqlaTableModel(SupersetTestCase):
self.assertTrue("Metric 'invalid' does not exist", context.exception)
def test_query_label_without_group_by(self):
tbl = self.get_table(name="birth_names")
query_obj = dict(
groupby=[],
columns=[
"gender",
{
"label": "Given Name",
"sqlExpression": "name",
"expressionType": "SQL",
},
],
filter=[],
is_timeseries=False,
granularity=None,
from_dttm=None,
to_dttm=None,
extras={},
)
sql = tbl.get_query_str(query_obj)
self.assertRegex(sql, r'name AS ["`]?Given Name["`]?')
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_data_for_slices_with_no_query_context(self):
tbl = self.get_table(name="birth_names")