QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[line] fix verbose names in time shift (#4765)

Browse Source 
* [line] fix verbose names in time shift

* Addressing comments
This commit is contained in:
Maxime Beauchemin
2018-04-07 15:19:58 -07:00
committed by GitHub
parent ee15fc8aa8
commit 17e673ec87
4 changed files with 56 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
superset/assets/spec/javascripts/visualizations/nvd3_viz_spec.jsx Normal file
View File

@@ -0,0 +1,28 @@
import { describe, it } from 'mocha';
import { expect } from 'chai';
import { formatLabel } from '../../../visualizations/nvd3_vis';
describe('nvd3 viz', () => {
const verboseMap = {
foo: 'Foo',
bar: 'Bar',
};
describe('formatLabel', () => {
it('formats simple labels', () => {
expect(formatLabel('foo')).to.equal('foo');
expect(formatLabel(['foo'])).to.equal('foo');
expect(formatLabel(['foo', 'bar'])).to.equal('foo, bar');
});
it('formats simple labels with lookups', () => {
expect(formatLabel('foo', verboseMap)).to.equal('Foo');
expect(formatLabel('baz', verboseMap)).to.equal('baz');
expect(formatLabel(['foo'], verboseMap)).to.equal('Foo');
expect(formatLabel(['foo', 'bar', 'baz'], verboseMap)).to.equal('Foo, Bar, baz');
});
it('deals with --- properly', () => {
expect(formatLabel(['foo', '---'], verboseMap)).to.equal('Foo ---');
expect(formatLabel(['foo', 'bar', 'baz', '---'], verboseMap)).to.equal('Foo, Bar, baz ---');
});
});
});