QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(trino): handle missing db in migration (#29997)

Browse Source
This commit is contained in:
Ville Brofeldt
2024-08-22 15:52:56 -07:00
committed by GitHub
parent 5906890b78
commit 17eecb1981
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/unit_tests/db_engine_specs/test_trino.py
View File

@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
# pylint: disable=unused-argument, import-outside-toplevel, protected-access
from __future__ import annotations
import copy
from collections import namedtuple
from datetime import datetime
@@ -719,7 +721,15 @@ def test_adjust_engine_params_catalog_only() -> None:
assert str(uri) == "trino://user:pass@localhost:8080/new_catalog/new_schema"
def test_get_default_catalog() -> None:
@pytest.mark.parametrize(
"sqlalchemy_uri,result",
[
("trino://user:pass@localhost:8080/system", "system"),
("trino://user:pass@localhost:8080/system/default", "system"),
("trino://trino@localhost:8081", None),
],
)
def test_get_default_catalog(sqlalchemy_uri: str, result: str | None) -> None:
"""
Test the ``get_default_catalog`` method.
"""
@@ -728,15 +738,9 @@ def test_get_default_catalog() -> None:
database = Database(
database_name="my_db",
sqlalchemy_uri="trino://user:pass@localhost:8080/system",
sqlalchemy_uri=sqlalchemy_uri,
)
assert TrinoEngineSpec.get_default_catalog(database) == "system"
database = Database(
database_name="my_db",
sqlalchemy_uri="trino://user:pass@localhost:8080/system/default",
)
assert TrinoEngineSpec.get_default_catalog(database) == "system"
assert TrinoEngineSpec.get_default_catalog(database) == result
@patch("superset.db_engine_specs.trino.TrinoEngineSpec.latest_partition")