QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-13 13:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): update overwrite button on perm change (#16437)

Browse Source 
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
This commit is contained in:
Ville Brofeldt
2021-08-26 06:24:33 +03:00
committed by GitHub
parent db11c3e6c8
commit 18be181946
9 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx
View File

@@ -42,14 +42,16 @@ describe('SaveModal', () => {
dashboards: [],
},
explore: {
can_overwrite: true,
user_id: '1',
datasource: {},
slice: {
slice_id: 1,
slice_name: 'title',
owners: [1],
},
alert: null,
user: {
userId: 1,
},
},
};
const store = mockStore(initialState);
@@ -104,7 +106,7 @@ describe('SaveModal', () => {
it('disable overwrite option for non-owner', () => {
const wrapperForNonOwner = getWrapper();
wrapperForNonOwner.setProps({ can_overwrite: false });
wrapperForNonOwner.setProps({ userId: 2 });
const overwriteRadio = wrapperForNonOwner.find('#overwrite-radio');
expect(overwriteRadio).toHaveLength(1);
expect(overwriteRadio.prop('disabled')).toBe(true);